GitLab

Review URL: https://codereview.chromium.org/356953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282429 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282428 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=177845:177866&mode=html
TBR=yutak@chromium.org,junov@chromium.org
BUG=

Review URL: https://codereview.chromium.org/388543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282427 0039d316-1c4b-4281-b951-d872f2087c98

Introduced static initializers into chrome binary:
preload_supplier.cc _GLOBAL__sub_I_preload_supplier.cc+0xa
preload_supplier.cc i18n::addressinput::StringCompare::StringCompare()
preload_supplier.cc __cxa_atexit@plt [registers a dtor to run at exit]

Run ./tools/linux/dump-static-initializers.py before re-landing to
verify they're no longer present.

> Use upstream libaddressinput in Chrome.
> 
> Most of the changes are mechanical switches from chromium/ to src/
> directory in third_party/libadressinput/.
> 
> To simplify the switch, autofill::AddressValidator is a shim between
> Chromium and i18n::addressinput::AddressValidator. The shim behaves the
> same way as Chromium's version of libaddressinput. The goal is to
> gradually remove the shim and make Chromium work directly with
> libaddressinupt.
> 
> Upstream libaddressinput does not include suggestions, which now can be
> found in third_party/libadressinput/chromium/input_suggester.{h,cc}.
> 
> A follow up patch will remove Chromium's version of libaddressinput.
> 
> BUG=327046
> 
> Review URL: https://codereview.chromium.org/298863012

TBR=rouslan@chromium.org

Review URL: https://codereview.chromium.org/388613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282426 0039d316-1c4b-4281-b951-d872f2087c98

It's no longer needed as of r282376.

BUG=370634
R=rileya@chromium.org

Review URL: https://codereview.chromium.org/380893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282424 0039d316-1c4b-4281-b951-d872f2087c98

These are not null everywhere now, including android webview.
Remove obsolete conditionals and comments, and add asserts.

BUG=

Review URL: https://codereview.chromium.org/385643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282421 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Signedness mismatch

The problem here is that using enums to declare bitmasks results in the enum values being signed, when all consumers want to use the values in an unsigned context.  Declaring them as consts allows using the more appropriate uint32 type.

In C++11 we could use "enum class" for this, but C++11 isn't legal yet.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/385443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282419 0039d316-1c4b-4281-b951-d872f2087c98

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/380023005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282418 0039d316-1c4b-4281-b951-d872f2087c98

from the message pipes.

This includes the following:-
1. Number of bytes in the message.
2. Number of fields in the message.
3. The message id.
4. The request id of the message.
5. Whether the message expects a response message.
6. Whether the message is a response message.
7. The URL of the service.

We also intercept the first message pipe which is used for
vending services in the debugger.

Support for tracing additional information will be added as needed.

BUG=360188
TBR=viettrungluu

Review URL: https://codereview.chromium.org/354043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282417 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/382773006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282416 0039d316-1c4b-4281-b951-d872f2087c98

Many functions in Python's logging module grab a lock internally. Some
appear to do so before converting the provided message to a string via
its __str__ method.

Calling an object's __str__ method before calling a logging funciton
allows anything called by the __str__ method to log without the risk of
hitting a deadlock.

BUG=392869

Review URL: https://codereview.chromium.org/385653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282412 0039d316-1c4b-4281-b951-d872f2087c98

Extracted UserSessionManager::Delegate as UserSessionManagerDelegate.

Added UserSessionStateDelegate which will for now coexist with UserManager::UserSessionStateDelegate till latter will be deprecated and merged with the former.

BUG=387614

Review URL: https://codereview.chromium.org/385633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282411 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/371003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282410 0039d316-1c4b-4281-b951-d872f2087c98

Use new sync backup DB if settings are reset to avoid undoing reset from backup data, e.g. reinstall removed extensions, etc.


BUG=389690

Review URL: https://codereview.chromium.org/367063005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282409 0039d316-1c4b-4281-b951-d872f2087c98

Most of the changes are mechanical switches from chromium/ to src/
directory in third_party/libadressinput/.

To simplify the switch, autofill::AddressValidator is a shim between
Chromium and i18n::addressinput::AddressValidator. The shim behaves the
same way as Chromium's version of libaddressinput. The goal is to
gradually remove the shim and make Chromium work directly with
libaddressinupt.

Upstream libaddressinput does not include suggestions, which now can be
found in third_party/libadressinput/chromium/input_suggester.{h,cc}.

A follow up patch will remove Chromium's version of libaddressinput.

BUG=327046

Review URL: https://codereview.chromium.org/298863012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282408 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/381153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282407 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386982
TEST=VISUAL

Review URL: https://codereview.chromium.org/379253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282406 0039d316-1c4b-4281-b951-d872f2087c98

In this test, index 0 is set as separator and TextComboboxModel::GetItemAt
asserts that separator items are not reached.
However, the combobox's selected index is 0 (default value) and on the Mac
OnPaint() will be triggered to cause the NOTREACHED to trigger.
TestComboboxModel is now initialized with the separators instead of being 
mutated after, and GetDefaultIndex is implemented to return the first
non-separator index.

BUG=378134

Review URL: https://codereview.chromium.org/376703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282405 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/383763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282403 0039d316-1c4b-4281-b951-d872f2087c98

Broke gpu_unittests FramebufferInfoTest.DrawBuffers:
[ RUN      ] FramebufferInfoTest.DrawBuffers
../../gpu/command_buffer/service/framebuffer_manager_unittest.cc:653: Failure
Actual function call count doesn't match EXPECT_CALL(*gl_, DrawBuffersARB(kMaxDrawBuffers, _))...
         Expected: to be called once
           Actual: never called - unsatisfied and active
../../gpu/command_buffer/service/framebuffer_manager_unittest.cc:657: Failure
Actual function call count doesn't match EXPECT_CALL(*gl_, DrawBuffersARB(kMaxDrawBuffers, _))...
         Expected: to be called once
           Actual: never called - unsatisfied and active
[  FAILED  ] FramebufferInfoTest.DrawBuffers (1 ms)

> Do not call glDrawBuffersARB when the extension is absent
> 
> The function Framebuffer::ChangeDrawBuffersHelper was assuming
> that binding of an FBO with no GL_COLOR_ATTACHMENT0 was
> accompanied by setting the first draw buffer to GL_NONE with
> glDrawBuffersARB in the fix introduced in:
> https://codereview.chromium.org/315283002
> 
> When the extension is not present, it can be assumed that the
> glDrawBuffersARB state need not be set and restored.
> 
> BUG=(wrangling)
> NOTRY=True
> 
> Review URL: https://codereview.chromium.org/375413003

TBR=ccameron@chromium.org

Review URL: https://codereview.chromium.org/382003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282402 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375333

Review URL: https://codereview.chromium.org/372683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282400 0039d316-1c4b-4281-b951-d872f2087c98

in chromeos_unittests

TBR=stevenjb@chromium.org
BUG=392936
TEST=waterfall.sh

Review URL: https://codereview.chromium.org/387663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282399 0039d316-1c4b-4281-b951-d872f2087c98

This only added conversion functions to/from PP_Bool. We have those
in pp_bool.h, so we don't need it.

BUG=

Review URL: https://codereview.chromium.org/384793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282398 0039d316-1c4b-4281-b951-d872f2087c98

This is a relanded https://codereview.chromium.org/307673002. It was reverted due to concerns that non-Chrome passwords may suffer (which is untrue). After https://codereview.chromium.org/360343002 is landed the only affected passwords are those created by Chrome within the current profile.

BUG=343891

Review URL: https://codereview.chromium.org/363013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282397 0039d316-1c4b-4281-b951-d872f2087c98

This change just exposes information about what tabs are selected
and fires proper notifications when tab selection changes. This will
allow screen readers to announce when switching tabs even if the
web content doesn't have focus. It's also a good first step towards
making the tab strip fully accessible too (e.g. making it possible to
perform operations on multiple tabs with just the keyboard).

As part of this change I renamed the "selection changed" event to
"text selection changed" so that there's no confusion between the
text-selection-related events, and tab/list selection events.

BUG=100412

Review URL: https://codereview.chromium.org/349033010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282396 0039d316-1c4b-4281-b951-d872f2087c98

Define the hit test mask for MicButton by implementing
MaskedTargeterDelegate instead of overriding
View::HasHitTestMask() and View::GetHitTestMaskDeprecated().

BUG=388838
TEST=SpeechViewTest.ClickMicButton

Review URL: https://codereview.chromium.org/365753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282395 0039d316-1c4b-4281-b951-d872f2087c98

Reason: My TODO was wrong. export.h should stay in athena/.

> athena: Move athena_export.h into common/ directory.
> 
> Fix a TODO in athena.gyp.
> 
> BUG=None
> TEST=None
> R=oshima@chromium.org
> 
> Review URL: https://codereview.chromium.org/371573002

TBR=tfarina@chromium.org

Review URL: https://codereview.chromium.org/382913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282394 0039d316-1c4b-4281-b951-d872f2087c98

The function Framebuffer::ChangeDrawBuffersHelper was assuming
that binding of an FBO with no GL_COLOR_ATTACHMENT0 was
accompanied by setting the first draw buffer to GL_NONE with
glDrawBuffersARB in the fix introduced in:
https://codereview.chromium.org/315283002

When the extension is not present, it can be assumed that the
glDrawBuffersARB state need not be set and restored.

BUG=(wrangling)
NOTRY=True

Review URL: https://codereview.chromium.org/375413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282393 0039d316-1c4b-4281-b951-d872f2087c98

This is part #2 of https://codereview.chromium.org/354343002/

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/345133005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282392 0039d316-1c4b-4281-b951-d872f2087c98

This implementation is similar to that in ui/cocoa/autofill/autofill_sign_in_container.mm.

BUG=364644
TEST=Start Chrome with --new-profile-management turned on. From the avatar
menu, select "Not <name>". The User Manager should show up. Cmd+W should
close it, but other accelerators (eg. Cmd+t) should not work.

Review URL: https://codereview.chromium.org/378693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282390 0039d316-1c4b-4281-b951-d872f2087c98

Follow-up to https://codereview.chromium.org/386543002 , probably fixed by
https://codereview.chromium.org/381883002/

BUG=392768
TBR=hamaji@chromium.org

Review URL: https://codereview.chromium.org/382013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282389 0039d316-1c4b-4281-b951-d872f2087c98

Disable animations to get TextfieldTest.DragToSelect to pass.
AuraTestHelper disables animations, so they were already disabled on non-Mac.
This change creates ViewsTestHelperMac that disables animation the same way
as ViewsTestHelperAura does.

BUG=378134

Review URL: https://codereview.chromium.org/378663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282385 0039d316-1c4b-4281-b951-d872f2087c98

TBR=robertphillips@chromium.org
BUG=392912
TEST=waterfall.sh

Review URL: https://codereview.chromium.org/388563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282384 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282383 0039d316-1c4b-4281-b951-d872f2087c98

webrtc bug 3211.

R=ronghuawu@chromium.org
BUG=

Review URL: https://codereview.chromium.org/376053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282382 0039d316-1c4b-4281-b951-d872f2087c98

This is how there were supposed to be before someone accidentally
renumbered the match types.

BUG=390597

Review URL: https://codereview.chromium.org/362033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282381 0039d316-1c4b-4281-b951-d872f2087c98

BUG=360311
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/381123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282380 0039d316-1c4b-4281-b951-d872f2087c98

Split linux library expectations for debian into 32 and 64 bit, remove libgcc1 from 64 after clang switch

BUG=360311
NOTRY=true

Review URL: https://codereview.chromium.org/385693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282379 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Experimental app list: Added a current page indicator to the launcher. (https://codereview.chromium.org/380613002/)

Reason for revert:
Caused a static initializer, see http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/67534

Original issue's description:
> Experimental app list: Added a current page indicator to the launcher.
> 
> Adds a current page indicator to the launcher when the experimental app launcher is enabled.
> 
> BUG=391642
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282335

TBR=calamity@chromium.org,mgiuca@chromium.org,kcarattini@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=391642

Review URL: https://codereview.chromium.org/384803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282378 0039d316-1c4b-4281-b951-d872f2087c98

A better fix is to set clang further up, so that gcc_version is set to
0 when clang is on automatically
( https://codereview.chromium.org/384633005 ). This is however blocked
on nacl also using the "clang" symbol, so that needs to be fixed first
( https://codereview.chromium.org/384793002 ). To make the build go for
people in the meantime, land this hack. I'll revert it once the nacl change has
landed in nacl and then rolled into chromium, and the better fix has landed.

BUG=360311
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/379693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282377 0039d316-1c4b-4281-b951-d872f2087c98