- 08 May, 2019 40 commits
-
-
Nico Weber authored
The motivation is that some projects (e.g. v8) deps in a git mirror of the build/ directory but don't have tools/win available. This makes the build/ directory not depend on tools/win again. Bug: 960658 Change-Id: Ibaa9a81862e89ea049299149a5d9aa7e7c4b5850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600776 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#657688}
-
Donn Denman authored
Speculative fix for histogram recording - int values are not registering in UMA. Maybe avoiding the converstion to long will fix. BUG=960613 Change-Id: Ia639c3a4b16091af6c82c007bfde97ae7653e5d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600640 Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#657687}
-
Michael Lippautz authored
This reverts commit dc16c8dc. Reason for revert: Fails on regular ASAN builds because all unreachable objects are poisoned directly after marking. Original change's description: > timer: Specialize TaskRunnerTimer for GCed classes > > This allows us getting rid of WillObjectBeLazilySwept which peeks into > garbage collection internal state. > > Change-Id: I82b38def090c33f1b6e6727ab4b685abb0409ea1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598826 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#657650} TBR=haraken@chromium.org,mlippautz@chromium.org Change-Id: I38047dc29ca14158aa891d99c15e218c1fdb7570 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 960775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599623Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#657686}
-
Daniel McArdle authored
This reverts commit b4d80c99. Reason for revert: Pursuing alternate strategy of preserving base::MD5 interface, but replacing its implementation with boringssl. Original change's description: > Replace base MD5 impl with boringssl in //net > > This CL also makes several IWYU changes outside of //net. After making the > changes in //net, these missing includes became compilation errors. > > Bug: 755368 > > Change-Id: Ieb18e0ab0dd4478f9ce8285f45ecee21a9c84e0c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570525 > Commit-Queue: Daniel McArdle <dmcardle@chromium.org> > Reviewed-by: Nathan Parker <nparker@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Olivier Robin <olivierrobin@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> > Auto-Submit: Daniel McArdle <dmcardle@chromium.org> > Cr-Commit-Position: refs/heads/master@{#656167} TBR=rsleevi@chromium.org,thakis@chromium.org,peter@chromium.org,sammc@chromium.org,nparker@chromium.org,olivierrobin@chromium.org,dmcardle@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 755368 Change-Id: I1486c246381b67052e85c1fbb2d81309b919526c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601193Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Daniel McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#657685}
-
Miguel Casas authored
This CL makes VASurface's ReleaseCB |release_cb_| a OnceCallback, since it doesn't make any sense that a release callback can be called repeatedly. Callsites use BindOnce() to bind to a RepeatingCallback for conveniency, since |va_surface_release_cb_| is bound once on the main thread with a WeakPtr. Test: chrome plays video on nocturne, v_d_a_unittests on the same. Bug: 822346 Change-Id: I7f0bb1658981f89b5b3a7d2bae388cec4b99efd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598496Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#657684}
-
Peter Kasting authored
Since users can type arbitrary strings, these lines are reachable and must be handled. For now, handle as they were already, e.g. by returning zero. We may later decide to do something else, e.g. return nullopt. This also adds better range-checking, so that e.g. "257" entered for an int8_t does not become "1". Bug: none Change-Id: I4a0185f921c3f40f38439798c52de0ce92f3be30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600650 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#657683}
-
Dan Sinclair authored
TBR: thestig@chromium.org Change-Id: I678bae3ca64bde9c8628a44997e507f506a5a140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601295 Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#657682}
-
Anders Hartvoll Ruud authored
The current approach is quite confusing and inconsistent. The value nullptr means too many different things, depending on the situation. This CL introduces a new, hopefully clearer model, where nullptr always means invalid at computed-value-time, and base::nullopt means "no entry found". This means that, if a ComputedStyle has a present entry of 'nullptr' for a given custom property, we do not e.g. fall back to values from StyleInitialData. However, if there is no entry (base::nullopt), we look up values from the root-bucket (see StyleInheritedVariables), and/or StyleInitialData. A consequence of this approach, is that explicitly applied initial and inherited values must actually be present on the ComputedStyle; we can not return to a state of base::nullopt. This is because of the root-bucket optimization of StyleInheritedVariables, which makes it impossible to actually erase a value in all cases. (We actually don't have the same restriction for StyleNonInheritedVariables, but the behavior is the same, for simplicity). Another change in this CL, is that StyleInitialData now has the initial "data" as well as the initial "values". This is again to avoid that nullptr has different meanings. If we didn't store the initial data, we could end up with a nullptr for registered properties with an implicitly initial value. This is incompatible with the "nullptr means nullptr" idea. Note that CSSInvalidVariableValue isn't technically needed anymore after this CL, but since it's going to be useful for the Cascade project (during the application phase only, not as a persistently stored object), I'd like to keep it. It has a unit tests, so it's not completely unused. BUG=947004 R=futhark@chromium.org Change-Id: I4922f0d36f3d3d4fde6a25e56ef5c14c0c9890f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601135Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#657681}
-
Roger Tawa authored
Bug: None Change-Id: Ie7b3b5a4c7c2649d7bd0c4916ce2696abc0cc70d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595452 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#657680}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c2849eabed44..254a80307c6e git log c2849eabed44..254a80307c6e --date=short --no-merges --format='%ad %ae %s' 2019-05-08 lalitm@google.com metrics: fix reading uninitialized memory in metrics platform 2019-05-08 lalitm@google.com Merge "trace_processor: add metrics test infra" Created with: gclient setdep -r src/third_party/perfetto@254a80307c6e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I63360d9a0206bd50db93d962c7cf44a9c69e05ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601181Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657679}
-
Manuel Rego Casasnovas authored
We were always sizing grid containers with "contain: size" as 0x0. However this is wrong as discussed on the following GitHub issue: https://github.com/w3c/csswg-drafts/issues/2804 To do this we add a new method to GridTrackSizingAlgorithmStrategy called IsComputingSizeContainment() to determine the cases in which we're computing the size containment dimensions. That way we can run only the initialization step instead of the full algorithm to get the expected track sizes for size containment. For widths the change is pretty simple in LayoutGrid::ComputeIntrinsicLogicalWidths(). For heights we don't have a phase to compute the intrinsic size so apart from the changes in LayoutGrid::UpdateBlockLayout() we need some extra checks in LayoutBox too. There is a minor change in test contain-size-grid-002.html, because after this patch it was not passing yet due to some overflow that is unrelated to the purpose of the test. BUG=855261 TEST=external/wpt/css/css-contain/contain-size-grid-002.html TEST=external/wpt/css/css-contain/contain-size-grid-003.html Change-Id: I4d0fd417183068518070721afde84efdbfe1fcb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1355923 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#657678}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f90bfd72174b..15c91422339a git log f90bfd72174b..15c91422339a --date=short --no-merges --format='%ad %ae %s' 2019-05-08 robertphillips@google.com Repro Chrome bug and add Skia-side fix Created with: gclient setdep -r src/third_party/skia@15c91422339a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:958055 TBR=robertphillips@chromium.org Change-Id: I0ccbd4e049b68becfaddcdf41efd7c853aa26e8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601180Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0cb2d605cc4a..5f21a6e5b1ab Created with: gclient setdep -r src-internal@5f21a6e5b1ab The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=dvadym@chromium.org,noel@chromium.org,jbroman@chromium.org,xialinyan@chromium.org Change-Id: I0209e6f00184270d09cf35513b52c15e0c62598d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601179Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657676}
-
Vasilii Sukhanov authored
This is a follow up to r649499. The Update method now matches Save() method. The replacement logic is now in UpdateReplace(). Bug: 936011,831123 Change-Id: I59d65fe77ef3b386e80ba890e140370d190555c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596456 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#657675}
-
Allen Bauer authored
Bug: 938501 Change-Id: Ic04556279c23eb5db8e4435a2f339c98de97b27f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597470Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#657674}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 698fa94d. With Chromium commits locally applied on WPT: e28269b6 "[LayoutNG/PE] Clear visual overflow for LayoutText before setting." aff3c8fe "Add tests for crbug.com/363609 and crbug.com/954591" c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." a554ea37 "Reland "[EventTiming] Round instead of ceil the |duration|"" a06bcc90 "WebXR: Rename requestSession parameter variables to match use" eeafcaee "[sms] Introduce testing infrastructure and handle some corner cases." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" 08cc019f "[XHR] Use response tainting to calculate CORS-exposed header-name list" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ieb183edd8a7c109f2808e1b37611244e288d74b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600731Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657673}
-
Elly Fong-Jones authored
This reverts commit a521561e. Reason for revert: very likely cause for https://crbug.com/960763 Original change's description: > macOS V2 GPU Sandbox: Diagnose mach service hang. > > This is a temporary CL to locate and diagnose a mach service acccess > that is hanging. > > Bug: 871280 > Change-Id: I8ef068baa2f6f4b6eb3dd7a15671dffc399db2dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599251 > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Auto-Submit: Greg Kerr <kerrnel@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#657377} TBR=kerrnel@chromium.org,rsesek@chromium.org Change-Id: Ie2351b19805c898a2809aad094bc8345f17abc0b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 871280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600835Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#657672}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9e4ae309..bde98f63 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I009d08b8cfa5dc4e109314d91b8fdc745d93b6e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600955Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657671}
-
Rune Lillesveen authored
Change-Id: Ic63c722103e24d0fff3a612ec1b626b882ed74a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599602Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#657670}
-
Wez authored
Remove the all-in-one CreateSysInfo() targets. Bug: b/130731732 Change-Id: I83bd36bd625a4a736ff1e25b1bc09555ed34cff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583422 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#657669}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ibe1ed18d8f97dd4830d286d8787782e0f450805a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601115Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5f3a01805f61..c2849eabed44 git log 5f3a01805f61..c2849eabed44 --date=short --no-merges --format='%ad %ae %s' 2019-05-08 hjd@google.com Add example camera config Created with: gclient setdep -r src/third_party/perfetto@c2849eabed44 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ieaf467fb99801b34d38fc41319312186b352490b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601174Reviewed-by:
-
Miyoung Shin authored
Replace the use of std::map of std container with WTF::HashMap in image.cc/h and use FloatSize instead of std::pair as HashMap's key. Bug: 952716 Change-Id: I8476fd4710f71469806c6118e0dcfe37602bfe30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599813Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#657666}
-
Jinho Bang authored
In current implementation, retry() ignores |error| member. So, before this patch, nothing was displayed on the payment sheet UI even if retry() is invoked with custom error message. After this patch, JS authors can display a custom message on the payment sheet UI via |error| member when invoking retry(). If the |error| member is empty, UA displays default error message. This feature is behind a flag: chrome://flags/#enable-experimental-web-platform-features Manual Test: wpt/payment-request/payment-response/retry-method-manual.https.html wpt/payment-request/PaymentValidationErrors/retry-shows-error-member-manual.https.html Bug: 861704, 942204 Change-Id: Id23a2924ca1d5c2f32416c7de6210357bf4e6296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575307 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#657665}
-
Wez authored
These definitions were modified down-stream, so apply the same changes to Chromium to keep things consistent. Bug: b/130731732, b/132044525 Change-Id: I6afb70bafa48250faf4c5b5931dd949d838fd758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598873Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f88e5824d2cf..e291f7a09f67 git log f88e5824d2cf..e291f7a09f67 --date=short --no-merges --format='%ad %ae %s' 2019-05-08 johnkslang@users.noreply.github.com Merge pull request #1739 from jeffbolznv/buffer_reference2 Created with: gclient setdep -r src/third_party/glslang/src@e291f7a09f67 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org,jonahr@chromium.org Change-Id: I0c27654decfa07ac62c1d5f7fe410891d9c7459c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601172Reviewed-by:
-
Ryo Hashimoto authored
ArcCameraBridge handles mojo method calls from Camera HAL and forwards it to arc-camera D-Bus daemon.` BUG=b:124946090 TEST=Camera works on eve Change-Id: Id85b10e76b55e43d0f636da9c3583e62ea722000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541548 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#657662}
-
Jit Yao Yap authored
This reverts commit dcb36f6f. Reason for revert: Maximum description length was increased in https://chromium-review.googlesource.com/c/chromium/src/+/1598801 Original change's description: > Shorten ExtensionInstallForcelist description > > The description length was exceeding 3100 characters after recent > changes and was failing the pre-submit checks. This change shortens the > description back to under 3100 characters. > > Bug: 958784 > Change-Id: I514e6722f239e495d39ae11c7ef44ecc7871b665 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596750 > Reviewed-by: Alexander Hendrich <hendrich@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Commit-Queue: Jit Yao Yap <jityao@google.com> > Cr-Commit-Position: refs/heads/master@{#657159} TBR=pastarmovj@chromium.org,hendrich@chromium.org,jityao@google.com Change-Id: I5dcfb6a0df1169eccebbd251650d621c055c5fb8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599171Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#657661}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/04840ca8..9e4ae309 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1f4d152c8bc2d732283afff71f325d6507ed330a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600709Reviewed-by:
-
Alexander Timin authored
At the moment we stop iterating when we encounter a task queue without this trait, which makes us miss disabling or enabling a lot of queues. R=alexclarke@chromium.org CC=yuzus@chromium.org Change-Id: I9e5f12b802a02292c9c3804a1cb5cabe9871123d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599394Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#657659}
-
Hans Wennborg authored
I think at some point the ToT bots didn't actually build the plugins, so we had to disable them in the build. But these days the plugins are available, and we want the test coverage. Bug: 960153 Change-Id: Id23c0af65ed7dce15cbb2e07fcb9ae91298644f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599453 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 873623cf. With Chromium commits locally applied on WPT: e28269b6 "[LayoutNG/PE] Clear visual overflow for LayoutText before setting." aff3c8fe "Add tests for crbug.com/363609 and crbug.com/954591" c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." a554ea37 "Reland "[EventTiming] Round instead of ceil the |duration|"" a06bcc90 "WebXR: Rename requestSession parameter variables to match use" eeafcaee "[sms] Introduce testing infrastructure and handle some corner cases." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" 08cc019f "[XHR] Use response tainting to calculate CORS-exposed header-name list" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Id69e870ede6b87079cdb5cd51c028d24c1c02c03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600323Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/68e29b7bbefc..0cb2d605cc4a Created with: gclient setdep -r src-internal@0cb2d605cc4a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=dvadym@chromium.org,noel@chromium.org,jbroman@chromium.org,xialinyan@chromium.org Change-Id: I62051c97a2272d0e96a905918d1913d142134f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600711Reviewed-by:
-
Wei Lee authored
This is a reland of f28fecb3 Original change's description: > Move CrOS JEA/MJDA to components/chromeos_camera > > This CL moves CrOS specific JEA/MJDA to components/chromeos_camera. > > Bug: 946366 > Test: Manually > Change-Id: I666f658955892bc750fdce0626f4979597462c5a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587678 > Commit-Queue: Wei Lee <wtlee@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#657110} Bug: 946366 Change-Id: I76ed93d18073fef048a68e2b08332122590139af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597514 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#657655}
-
Hans Wennborg authored
I introduced spaces around CLANG_SUB_REVISION in crrev.com/656007 This updates upload_revision.py to match. Bug: 884608 Change-Id: I6781bdf86386e8f3b4d3e68776673af249c74926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599598 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Bruce Dawson authored
Autoninja now has a better option for diagnosing slow builds. This change updates the documentation for the new option. Bug: 787983 Change-Id: I69f3ba901d3c98bd9c996b03421260559004edd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596854 Commit-Queue: Peter Boström <pbos@chromium.org> Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#657653}
-
Daniel Cheng authored
Bug: 705169 Change-Id: I0f232f96e545de8fef2ed3386f08cc949ecf2512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595650 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#657652}
-
Jeevan Shikaram authored
Updated the app view UI for PWAs, ARC and Chrome Apps to match the new mock. The link to "more settings" has shifted down to below the permissions section. Bug: 948936 Change-Id: I7add60f5e5792de4eded4021b65a868e5b0c4ab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589480 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#657651}
-
Michael Lippautz authored
This allows us getting rid of WillObjectBeLazilySwept which peeks into garbage collection internal state. Change-Id: I82b38def090c33f1b6e6727ab4b685abb0409ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598826 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/208ed40a2afb..eddad7e7669c git log 208ed40a2afb..eddad7e7669c --date=short --no-merges --format='%ad %ae %s' 2019-05-08 swiftshader.regress@gmail.com Regres: Update test lists @ 208ed40a Created with: gclient setdep -r src/third_party/swiftshader@eddad7e7669c The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I4663ed27d064be527639e255334c385c92a5f16a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600706Reviewed-by:
-
