- 21 May, 2020 40 commits
-
-
Jinsong Fan authored
The NetLog is now an internal detail of the network service. And this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1695293 still left dead codes about NetLog. The CL removes it for code health. Bug: 963875 Change-Id: I01c246b95a961b219bb4c93fd4b40743f9ba5e20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2192536 Auto-Submit: Jinsong Fan <jinsong.van@gmail.com> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#770992}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590019092-d032408a4c7d66eb8e8eaad56f5f62575a89e2db.profdata to chrome-win32-master-1590047700-a706b1a99569faae4b31ea10afb5af7a8db8e3e7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I31ef5b5680f1f16e83a9057e750b290ae33581fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211888Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770991}
-
Gabriel Charette authored
R=grt@chromium.org Change-Id: Ibcc042cddf089adb42aafb5d98fcb71888306ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210022Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#770990}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 84-4129.0-1589191546-benchmark-84.0.4142.0-r1 to 84-4136.1-1589797128-benchmark-84.0.4147.10-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I65b580882f7906aaf602ce3234a2f5fa5ef287c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211884Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 84-4136.1-1589194235-benchmark-84.0.4142.0-r1 to 84-4136.1-1589794882-benchmark-84.0.4147.10-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ieb9265dc978c69e7fc4b1a034d25ed69c6420089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211883Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590033536-e720add817899a0a9587c78e7de615e881dda3e9.profdata to chrome-mac-master-1590047700-f78bd2d622c61ab01f15ac85a9b78063006149d8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I3baa469e2587ddb2fd4e30fcdfc80ec8f96f33f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211881Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d0ecac7c1172..e5d042ae732b 2020-05-21 abennetts@google.com Aggressively defer imports in sheriff_config_client. 2020-05-21 abennetts@google.com Update bq_rows export job for updated schema. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1082639 Tbr: sadrul@google.com Change-Id: I5469de1c381d72d42480b27e0669de525d42d0fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211617Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ie5e87ddca7426bf08231bb3368341ab196a78ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211721Reviewed-by:
-
Johann authored
Use HeapMojoRemote wrapper for authenticator_, credential_manager_, and sms_receiver_. This puts the objects on the heap so that Oilpan will manage/GC them. Bug: chromium:1049056 Change-Id: I7d8d281780c667cfd9feeded592587d74572c90b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144805Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#770984}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2e0f0a0517e4..6f723ebbe3b0 2020-05-21 mbechard@users.noreply.github.com fix incorrect error when multiple compilation units don't declare layouts (#2238) 2020-05-21 shuizhuyuanluo@126.com Add an option to make Exceptions enabled (#2239) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I4c0833f4c1681d673c21419c331148a17c601350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211616Reviewed-by:
-
Hitoshi Yoshida authored
"unspecified" is not a member of IDL enum 'CookieSameSite'. Before this CL, the code set the invalid value on CookieListItem. sameSite. This CL fixes it, and leaves the dictionary member unset if UNSPECIFIED was passed. Bug: 839389 Change-Id: I61c01c6cd20990f9dd48456c7e50d06f7c93d385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210293 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#770982}
-
Giovanni Ortuño Urquidi authored
This CL helps fix two issues: 1. For default apps, `add_to_applications` is set based on `create_shortcuts`, which according to its documentation controls whether the app is pinned to the shelf. Currently, no default app sets `create_shortcuts` to true, so `add_to_applications_menu` is always false. This wasn't an issue with Extensions because the field was ignored, but it is an issue with BMO where we use that field to decide whether the app should show in the app launcher or not. To address this issue, we could simply set `add_to_applications_menu` to true, but that would be a problem for default apps that don't want to be shown in the launcher. 2. Some default apps don't want to be shown in the launcher, but currently there is no way for them to specify this. To address both issues, we introduce a new `hide_from_user` field for default apps. The value defaults to false, so it fixes issue 1. above, and can be set to true by apps that don't want to appear to users, which addresses issue 2. Also fixes some test files that were missing the user_type field. Bug: 1084887 Change-Id: Id77a4f50eae3fb4517bca26b76aeb737161df431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210179 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#770981}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 84-4136.1-1589189756-benchmark-84.0.4142.0-r1 to 84-4136.1-1589799722-benchmark-84.0.4147.10-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I8344a095e42ac9a215a52e57720af5344774b02f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211522Reviewed-by:
-
Takashi Toyoshima authored
Suppress the test for Blink CORS as if fails with Blink CORS. TBR=kinuko@chromium.org NOTRY=true Bug: 911952 Change-Id: I5eb2d1fb0e60b7fb53e290413718711512ebf640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210046Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#770979}
-
Julie Jeongeun Kim authored
This CL moves printing::PageSizeMargins to print.mojom to pass it to Mojo interfaces. This is a precursor CL to mojofy PrintHostMsg_DidGetDefaultPageLayout. Bug: 1008939 Change-Id: I013fb5e1cc8d7ba6988c299c603effc4813805c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203565 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#770978}
-
Vasilii Sukhanov authored
This reverts commit bbbb1fad. Reason for revert: broke WebTests on WebKit Mac10.13 (retina) https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20%28retina%29/28885 Original change's description: > Let both minimum font-size settings apply to CSS px units. > > Applying the minimum font-size to the device pixels would not give the > expected result, either for using zoom for DSF, or applying page zoom. > > I added the documentation for the settings based on what I found on > stackoverflow: > > https://stackoverflow.com/questions/52943595/cannot-understand-android-webview-documentation > > The behavior changes for both the non-"logical" setting in that we will > still apply a minimum font-size even if the zoomed font-size would have > become larger than the minimum font-size in device-pixels. That is, if > we have a minimum font-size of 20px and two elements, one with a 10px > font-size and the other with a 20px font-size, they will both be > rendered at 40 device pixel size at 200% zoom. > > This changes the behavior for the logical setting when we have a page > zoom factor which is lower than 100%, where we also now just adjust the > CSS px font-size before zooming is applied. > > The logical setting is only exposed via the Android WebView API or via > a hand-edited config file. The minimum font-size setting the > chrome://settings is the non-"logical" one. > > If the settings object is null, return the font-size without minimum > sizes applied instead of the not-so-useful 1px return we had. > > Bug: 1082127 > Change-Id: Idc03bf37fb7d39206ad4d4dc50eef01b56a69ddb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199134 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Commit-Queue: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770661} TBR=pdr@chromium.org,chrishtr@chromium.org,drott@chromium.org,pdr@google.com,futhark@chromium.org Change-Id: I70d34b6df1b42075781d4c29b753b7ae8ebe767c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1082127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210359Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/14a83aec5603..c9eb1c3712fa 2020-05-21 orodley@chromium.org Update lucicfg version. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I720ec0131179d66fbf9f7e445ddaaa0d9643569a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211477Reviewed-by:
-
Julie Jeongeun Kim authored
This CL fixes the crash caused by calling mojom::PrintPreviewUI on the unbounded |preview_ui_|. PrepareFrameAndViewForPrint::DidStopLoading() is an implementation of a blink::WebViewClient method and it's called when the loading is stopped. At that time, the preview dialog could be closed already and |preview_ui_| is unbound. When the preview UI used legacy IPC messages, it searched the preview UI first and then passed the messages. So, this CL adds also checking if |preview_ui_| is bound. Bug: 1084641,1008939 Change-Id: Ifcb80306e485c8796456512777ebc67b62e9842d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208847Reviewed-by:
-
Vasilii Sukhanov authored
This reverts commit 1938691f. Reason for revert: Broke AutoclickE2ETest on CrOS https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/18769?blamelist=1#blamelist-tab Original change's description: > Move Autoclick manifest to shared accessibility directory > > The ChromeVox, Select-to-speak, and Switch Access manifests are > generated in the shared accessibility/ directory. This change moves the > autoclick manifest to behave in the same manner. > > AX-Relnotes: n/a. > Bug: 978200 > Change-Id: I2470b505cf379ed512be32e52a432941d4009564 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209304 > Commit-Queue: Anastasia Helfinstein <anastasi@google.com> > Reviewed-by: Katie Dektar <katie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770674} TBR=katie@chromium.org,anastasi@google.com Change-Id: I47f1a29983937a003cb2195b78c21e1976a86963 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 978200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208143Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a6b59e58b6b5..ce0a830cd582 2020-05-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7ff16622afe7f1f9e8bac9b802bb8c2ee160e02a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211478Reviewed-by:
-
Yoshifumi Inoue authored
This reverts commit 87e1425b. Reason for revert: Causes MSAN failure https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/23989 ==2820==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x559b20545044 in cc::PaintOpBuffer::NeedsAdditionalInvalidationForLCDText(cc::PaintOpBuffer const&) const ./../../cc/paint/paint_op_buffer.cc:2766:28 #1 0x559b2205e216 in NeedsAdditionalInvalidationForLCDText ./../../cc/paint/display_item_list.h:189:29 Original change's description: > Reland "Preserve LCD-text in SaveLayerAlphaOp when possible" > > This reverts commit 0bd440c5. > > Fixed (mostly invisible) raster invalidation issue with > PaintOpBuffer::NeedsAdditionalInvalidationForLCDText() to invalidate > the whole layer when LCD Text under SaveLayerAlpha may change. > > Original change's description: > > Revert "Preserve LCD-text in SaveLayerAlphaOp when possible" > > > > This reverts commit 0c258cbd. > > > > Reason for revert: Flakiness of raster result. crbug.com/1082804. > > > > Original change's description: > > > Preserve LCD-text in SaveLayerAlphaOp when possible > > > > > > This achieves LCD-text under non-composited opacity when possible. Pass > > > two flags to SkCanvas::SaveLayer() for SaveLayerAlphaOp: > > > kPreserveLCDText_SaveLayerFlag to preserve LCD text, and > > > kInitWithPrevious_SaveLayerFlag to to ensure an opaque background. > > > > > > This doesn't apply when there any SaveLayer modes which would break > > > LCD text or be broken by kInitWithPrevious_SaveLayerFlag. So we disable > > > the feature for the whole layer when there is any of such effects in > > > the layer. The new operation is also a bit more expensive, so only do > > > it when there is text. For now these two conditions are applied on the > > > whole layer for simplicity. Otherwise we would need to track them in > > > SaveLayerAlpha/Restore hierarchy which would be complex and error-prone. > > > > > > Bug: 942051 > > > Change-Id: I3ab2e8051e26c5714fd72830a7921099b9170d0d > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189260 > > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#768367} > > > > TBR=wangxianzhu@chromium.org,pdr@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 942051, 1082804 > > Change-Id: I36f281df4940588d5c2b1b4da415f5d22b0aa9e3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203495 > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#769425} > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 942051, 1082804 > Change-Id: Ic4bccc769a044061238469a38edf0822a6ed16c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206213 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770920} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: I10691b9a0ee5c9e8e45846f6ad02c2a101e53310 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 942051, 1082804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210603Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770972}
-
Roman Sorokin authored
Refactor test to newer standards. Also fixed a race condition in the Welcome screen. In the flow UpdateLanguageList calls before SetApplicationLocale. But sometimes results are returned in a different order. That leads to a wrong language selection (and test flakiness). This CL cancel UpdateLanguageList request if SetApplicationLocale is called. Fixed: 990819 Change-Id: I9117b19ec22e63befb0f904fb91f4fc8e1354c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209069Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770971}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/98dedb300ca7..d0ecac7c1172 2020-05-21 fancl@chromium.org auto-triage: Split workflow and data model in AlertGroup 2020-05-21 dberris@chromium.org operations: Update capacity for upload processing If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: sadrul@google.com Change-Id: I4cfe0241b52259035a2d6f805ec02c6cd20fe903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211473Reviewed-by:
-
Vasilii Sukhanov authored
This reverts commit 8a905049. Reason for revert: consistent failure on CrOS https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/38104?blamelist=1#blamelist-tab Original change's description: > Reuse upload browsertests for corresponding Enterprise Connectors > > This reuses tests by having the policy setters of > DeepScanningBrowserTestBase set either legacy or Connector policies, and > then making every upload browsertest parametrized with a bool so both > policy sets get tested. > > The DeepScanningDialogViews test also change a bit, the ScanType test > parameter is removed since this dialog doesn't depend on the type of > scanning being done. This avoids having a very large number of > combinations for that test that don't cover different code paths. > > Bug: 1076083 > Change-Id: I419b21de0095add8b5b214993be010d022941202 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210782 > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770745} TBR=rogerta@chromium.org,domfc@chromium.org Change-Id: Ifbd58dd8403a58b48b2d4911387b2ecbbd5bf70a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1076083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209222Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bb633c91606e..fe49ce29c3e1 2020-05-21 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-05-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from d45b30b5a554 to e8b8b8164520 (6 revisions) 2020-05-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 179a84ca to 16e86c0b (485 revisions) 2020-05-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b6e8c3f0f483 to cc5cda0f997d (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I797792ba85893048e5b3815cb5f8f66f769eb39e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211475Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 2299 2303 2304 2328 2330 2341 19 lines were removed and 2 lines were deflaked by consecutive results since 2220. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Ib381327ac9c44a998f3184b2fa3fca2280aa29d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193352Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#770967}
-
Wei-Yin Chen (陳威尹) authored
Bug: 1082664 Change-Id: I11df4fcd668a517d160c9bbe29656f92e312cfaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205001 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#770966}
-
Wei-Yin Chen (陳威尹) authored
After simplifying the tests, there's no need to use EmbeddedTestServer in StartSurfaceTest anymore. Bug: None Change-Id: Id9898777ba8a423439bfb2168293d8fe2a980a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206335 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#770965}
-
Noel Gordon authored
Rewrite the toaster in terms of <cr-toast> which supports animating the toast on and off the screen using CSS transitions effects, has in-built ARIA support, and provides <slot>s for inserting the toast text element <div> and action <cr-button>. Styling this component for ChromeOS files-ng: <cr-toast> mostly does it for us with little extra work. We only need to control toast min-height and number of lines shown (at most 2), a few margins and one background color. Delete all our CSS that <cr-toast> now does for us. Elevation +2 shadows are the <cr-toast> default internal style and flex display too. Users must add justify-content: space-between to keep text pinned to the left and the action button pinned to the right. The default <cr-toast> position is 24px,24px from the lower-left corner so CSS move it to the lower-right corner in LTR per FilesApp usage. The toast duration is controlled by that <cr-toast> attribute: add that attribute in markup and use the same value as before: 5000 ms. Update the externs file definition (it was out-of-date) and add TODO to fix <cr-toast> iron-a11y-announcer BUILD.gn deps issue. Remove ES6 lint exceptions, add comments, add closure markup. Fix UI test sharing tests: <cr-toast> fails to work in that system. Add <files-toast> mock to workaround that failure. Test: browser_tests --gtest_filter="FilemanagerJsTest*FilesToast" Bug: 1002391, 1033660 Change-Id: I06113a6bcdc564bc374df559a3830a2a9df031f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208166 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#770964}
-
Yao Xiao authored
Previously we added this field to the "visits" table. This CL adds the field to URLResult and fills in this field inside HistoryBackend::QueryHistoryBasic and HistoryBackend::QueryHistoryText. Bug: 1062736 Change-Id: I8e0690a43f1c5648dc5b2bd611a06ae92c62afba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211051 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#770963}
-
Hitoshi Yoshida authored
We used to use an empty ScriptValue as a default null value, and we will distinguish them in the new code generator. Then we found the default value expressions need to know what they depend on, such as a null value for ScriptValue type needs v8::Isolate. This CL makes DefaultValueExpr dataset to have dependency information to work for the case. Bug: 839389, 1070964 Change-Id: I19dd7a109bb1752df6c53a502ea2fd815fd3c348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198764Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#770962}
-
François Beaufort authored
Change-Id: I8c30b541360493298675bad413c3e999220f3a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209212 Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#770961}
-
Sara Kato authored
Mainly in ARC++ we often see that focus going into containers with clickable parents. This is evident in lists (as described in bugs), where the containing children will also receive focus. This CL adds a condition, which considers focusable nodes that have children with the same name should be considered as a leaf (thus preventing further focus propagation). announced twice. AX-Relnotes: Ensure that nodes with static text with same name don't get Bug: b:156426961 Bug: b:154875936 Test: ChromeVoxBackgroundTest.FocusableNamedDivIsNotContainer Test: manual (open FamilylinkApp, Hangouts app), navigate using search+arrow and note that items are read once. Change-Id: I569b9059c2a8eb458f9e8684bd4d645b0260b93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198047 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#770960}
-
Takashi Toyoshima authored
* virtual/omt-worker-fetch/external/wpt/resource-timing/redirects.sub.html * virtual/omt-worker-fetch/external/wpt/resource-timing/resource_connection_reuse_mixed_content_redirect.html NOTRY=true TBR=kinuko@chromium.org Bug: 1085332 Change-Id: I7da0d3f0549655a55fa768e558e61b20fbfc63e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211582Reviewed-by:
-
Alexey Baskakov authored
Return runtime error if finalizer is not started. Unfortunately, WebAppInstallFinalizer::FinalizeInstall is used directly by PendingAppManager (for now). This is a speculative fix for the crash in the bug: Do not even initiate the writing operation if web app provider is not yet ready. In next CLs: Add more started/shutdown checks in WebAppInstallManager, ManifestUpdateManager. We should return WebAppProviderNotReady error as early as possible (in WebAppInstallManager API). Bug: 1084939 Change-Id: I3f7a27f587da4d2c8676f9863f94650f7357d5ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208889 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#770958}
-
Takashi Toyoshima authored
* external/wpt/resource-timing/redirects.sub.html * external/wpt/resource-timing/resource_connection_reuse_mixed_content_redirect.html * http/tests/misc/resource-timing-sizes-redirect-worker.html * http/tests/misc/resource-timing-sizes-redirect.html NOTRY=true TBR=kinuko@chromium.org Bug: 1085332 Change-Id: I6c74264b0cc8e931680f1e26c8ea686a1902ed60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210182Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4c0578632217..bb633c91606e 2020-05-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 78f7e8640f14 to 8a3cc5c4dfd8 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I502c742785014d731821b8990f2c05de53d40b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211468Reviewed-by:
-
Rob Buis authored
MathML Core support the script level functionality both using a font-size extension and as an attribute on MathML elements. The scriptlevel attributes simply maps to the font-size extension [1]. The font-size extension follows the algorithm stated in [2]. In order to keep track of the internal scriptlevel [3] an internal property MathScriptLevel is added to the computed style. Finally various stylesheet rules related to script level are taken as-is from the specification stylesheet [4]. [1] https://mathml-refresh.github.io/mathml-core/#the-displaystyle-and-scriptlevel-attributes [2] https://mathml-refresh.github.io/mathml-core/#the-math-script-level-property [3] https://mathml-refresh.github.io/mathml-core/#dfn-internal-scriptlevel [4] https://mathml-refresh.github.io/mathml-core/#user-agent-stylesheet Bug: 1023292 Change-Id: I47ed250a63049b15daff53f9c0942cf676b21acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2184131Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#770955}
-
Karandeep Bhatia authored
Types which are only referenced once are inlined by the Docserver by default. This causes excessive nesting in documentation for declarativeNetRequest. Prevent this by explicitly disallowing inlining for these types. BUG=1085326 Change-Id: I2d2a938832fdfd26915b8956b14f1d41e3b0a646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209966 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770954}
-
Shik Chen authored
This CL removes the renaming behavior for video recording to simplify the logic, and mitigate thumbnail regeneration timeout issue in Files app for long video. Bug: 1058325, 1080869 Test: Verify the file name manually, and pass CCAUIRecordVideo and CCAUIIntent Change-Id: I074885d95e8cf41d85cf46ef866c47500726708b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210201 Commit-Queue: Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#770953}
-
