- 17 Jul, 2020 40 commits
-
-
Mike West authored
This reverts commit b5bdc990. Reason for revert: `MediaRouterViewsUITest.RouteCreationTimeoutForDesktop` started failing after this CL in https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests/2446?blamelist=1#blamelist-tab. The error message in the related test is https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8874579294717582880/+/steps/unit_tests_on_Mac-10.15/0/logs/Deterministic_failure:_MediaRouterViewsUITest.RouteCreationTimeoutForDesktop__status_CRASH_/0: ``` Actual function call count doesn't match EXPECT_CALL(*mock_router_, CreateRouteInternal( _, _, _, _, _, base::TimeDelta::FromSeconds(timeout_seconds), false))... Expected: to be called once Actual: never called - unsatisfied and active Stack trace: 0 unit_tests 0x000000010fcfba8c testing::internal::GoogleTestFailureReporter::ReportFailure(testing::internal::FailureReporterInterface::FailureType, char const*, int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 92 1 unit_tests 0x000000010fcffc05 testing::internal::UntypedFunctionMockerBase::VerifyAndClearExpectationsLocked() + 597 2 unit_tests 0x000000010fd00521 testing::Mock::VerifyAndClearExpectationsLocked(void*) + 401 3 unit_tests 0x000000010fd00371 testing::Mock::VerifyAndClearExpectations(void*) + 33 4 unit_tests 0x000000010f26566b media_router::MediaRouterViewsUITest::StartCastingAndExpectTimeout(media_router::MediaCastMode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) + 2491 5 unit_tests 0x000000010f2659a4 media_router::MediaRouterViewsUITest_RouteCreationTimeoutForDesktop_Test::TestBody() + 52 Received signal 11 SEGV_MAPERR 000000000008 [0x000114431eb9] [0x000114377dc3] [0x000114431dd1] [0x7fff70e295fd] [0x7fff70de9297] [0x00010f2659a4] [0x00010fd1860d] [0x00010fd193cf] [0x00010fd19d47] [0x00010fd283a7] [0x00010fd27e1f] [0x00011384b7fb] [0x0001138623b3] [0x00011386225f] [0x000113835f25] [0x7fff70c30cc9] [end of stack trace] ``` Bug: 1106647 Original change's description: > [MediaRouter] Add warning for invalid permissions > > This patch adds a new check to the media router views UI that, on Mac OS > X 10.15+ (Catalina), checks if the screen capture permission has been > granted, and shows a warning message and fails to cast if so. > > Bug: 1087236 > Change-Id: I3afdfdb06a011fee3e6fd5f199d375d0ab6eef88 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298479 > Commit-Queue: Jordan Bayles <jophba@chromium.org> > Reviewed-by: Takumi Fujimoto <takumif@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789194} TBR=mfoltz@chromium.org,takumif@chromium.org,jophba@chromium.org Change-Id: I64651c90503bf90a2f9cfca99f7929efd35b4c23 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1087236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302613Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#789391}
-
Corentin Wallez authored
Use the concept of "permissions" and "allowed paths" that make the code clearer as well as more inclusive. Bug: chromium:1101491 Change-Id: I374bc95250a97efbd3190d22c82261a6c31a03af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302195Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#789390}
-
Adam Rice authored
The transferable streams implementation assumed that two kPull messages couldn't be sent without an intervening chunk. This wasn't true in the case of a compromised renderer, and since https://chromium-review.googlesource.com/c/chromium/src/+/2291180 hasn't been true in general. This change aligns the implementation with the proposed standard at https://chromium-review.googlesource.com/c/chromium/src/+/2291180. This fixes flakiness in the http/tests/streams/transferable/worker.html test. BUG=1106239,1106239 Change-Id: I12c9d011c4a42c8178fcaffa4ddd23e38fb82d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303329Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#789389}
-
Zufeng Wang authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/vqT-WqhwS504vwcLdBC9Y998VXTrAydEbVVHCjdZSPMC Release notes: http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202007160800_RC00.html Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Iaa9b1d2fae90f6118a7c79ba45192441ea066f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303335Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Zufeng Wang <zufeng@google.com> Cr-Commit-Position: refs/heads/master@{#789388}
-
Joanmarie Diggs authored
This is a reland of a6bb85c6, which had been reverted due to a unit test failure. The new failure turned out to be a side effect of how the test runner bundles tests and addressed via 0144ebea. This reland includes additional improvements: Treating all style changes on containers with selectable children the same as we do for kListBox, and adding a sanity check for style changes coming from detached objects. Bug: 904977, 1062063, 1085481 AX-Relnotes: Windows and Linux assistive technologies are now notified when text attributes have been changed. This allows them to update any cached information they may have so as not to present stale/inaccurate data about text appearance. In addition, because a notification is emitted when a newly-typed word has a spelling or grammar error, the Orca screen reader now announces when the error indicator appears. Original change's description: > Emit accessible text-attribute-changed events > > * Add TEXT_ATTRIBUTE_CHANGED event so platforms can distinguish this > event from the more generic OTHER_ATTRIBUTE_CHANGED event that was > being fired. > > * Fire TEXT_ATTRIBUTE_CHANGED from the AXEventGenerator for: > - kBackgroundColor > - kColor > - kFontFamily > - kFontSize > - kFontWeight > - kMarkerTypes (e.g. for spelling and grammar errors) > - kTextDirection > - kTextPosition > - kTextStyle > - kTextOverlineStyle > - kTextStrikethroughStyle > - kTextUnderlineStyle > > * Fire state-change event for ATK when ATK_STATE_ENABLED changes. > (Detected as a side effect of debugging an issue with the above) > > * Eliminate some extraneous accessibility events resulting from the > ignored state being changed on an element. > > Bug: 904977, 1062063, 1085481 > > AX-Relnotes: > > Windows and Linux assistive technologies are now notified when text > attributes have been changed. This allows them to update any cached > information they may have so as not to present stale/inaccurate data > about text appearance. > > In addition, because a notification is emitted when a newly-typed word > has a spelling or grammar error, the Orca screen reader now announces > when the error indicator appears. > > Change-Id: I6a070154304f185dcd6343baadb728b0a4beec35 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211224 > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com> > Reviewed-by: Javier Fernandez <jfernandez@igalia.com> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> > Cr-Commit-Position: refs/heads/master@{#778437} Change-Id: I776b86bbb7b691f42d0d2be01f6bd6877009c4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279799Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#789387}
-
Mike West authored
This reverts commit 3d677a19. Reason for revert: `linux-chromeos-dbg` began failing in https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/19625, with errors along the lines of https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8874588910239798816/+/steps/browser_tests/0/logs/Deterministic_failure:_CrElementsFingerprintProgressArcV3Test.Fingerprint__status_CRASH_/0: ``` [9471:9471:0716/140802.869423:FATAL:dedicated_worker_host_factory.mojom.cc(574)] Check failed: !connected. DedicatedWorkerHostFactory::CreateWorkerHostCallback was destroyed without first either being run or its corresponding binding being closed. It is an error to drop response callbacks which still correspond to an open interface pipe. #0 0x7f0d6306d98f base::debug::CollectStackTrace() #1 0x7f0d62e1600d base::debug::StackTrace::StackTrace() #2 0x7f0d62e15fc8 base::debug::StackTrace::StackTrace() #3 0x7f0d62e5751b logging::LogMessage::~LogMessage() #4 0x7f0d62e57dfc logging::LogMessage::~LogMessage() #5 0x7f0d62dddf4e logging::CheckError::~CheckError() #6 0x7f0d5b24076d blink::mojom::DedicatedWorkerHostFactory_CreateWorkerHost_ProxyToResponder::OnIsConnectedComplete() ... ``` This CL is the most suspicious in the range. Reverting to see if the bot recovers. Original change's description: > Introduce DedicatedWorkerToken. > > Subsequent CLs will migrate Shared and Service workers to use similar > tokens. This is in support of the performance.measureMemory API, endowing > workers with tokens that can be used as an identifier when communicating > information regarding V8 memory usage. > > BUG=1085129, 1096617 > > Change-Id: I184eabcd1a421ffcfb561f388f620eaf9471d9f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297702 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Commit-Queue: Chris Hamilton <chrisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789141} TBR=falken@chromium.org,chrisha@chromium.org,dtapuska@chromium.org,afakhry@chromium.org,wfh@chromium.org Change-Id: I420aba017ab4a7ac28d94f296355fb434d24cb96 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085129 Bug: 1096617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302693Reviewed-by:
-
zengqiang authored
If an android application registers the PROCESS_TEXT intent but the exported value of Activity is false, the Chrome android or android webView still displays this menu item. If you click these menu items to start the external activity, the 'java.lang.SecurityException: Permission Denial: start Intent' crash occurs. Bug: 1105292 Change-Id: Ie4a033de25e43d67ec76284e3c21a7c3548b3045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291567 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Auto-Submit: Qiang Zeng <zengqiang1@huawei.com> Cr-Commit-Position: refs/heads/master@{#789385}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/65a88eb4bed0..9acf5844cae6 2020-07-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 6fe87f4a226d to cc5513855cc5 (14 revisions) 2020-07-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 0a8f44c514ce to 0e82586297a8 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Test: Test: Test: CQ Change-Id: I62add8d316697184b4f8ed2f21605b8316017196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304350Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789384}
-
Leo Lai authored
The introduced new class is meant to replace the current fake objects used in various browser tests. BUG=b:158955123 Change-Id: I743bd605321e7f384eb22a9ecac4fb40ae93e980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297062 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#789383}
-
François Degros authored
BUG=chromium:912236 TEST=browser_tests --gtest_filter="*/FilesApp*" Change-Id: I0ea62bb92376ab0ee68aef2a76ab9594c45cf341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303932Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#789382}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I589b5758f6a674c07decd4475504b814e7aefd5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303466Reviewed-by:
-
Sven Zheng authored
Previously tryjob failed with: MBErr: Builder name "linux-lacros-rel" not found under masters[tryserver.chromium.linux] in "/b/s/w/ir/cache/builder/src/tools/mb/mb_config.pyl" Bug: 1104291 Change-Id: I1a4b1cb2a306a0d1562da1a0d4e712adfd852cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304311 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#789380}
-
Karel Král authored
Refactor function ValueToString from the class base::trace_event::TracedValue into namespace base::trace_event. This is a follow-up of http://crrev.com/c/2299722 Bug: 1103623 Change-Id: Ied92ce36da432d84fef4b186f902c8ac581b416b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302029Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Karel Král <karelkral@google.com> Cr-Commit-Position: refs/heads/master@{#789379}
-
Guillaume Jenkins authored
Moves the ReportGenerator class from chrome/browser to components/enterprise so it can be reused by iOS code. As part of this move, the ReportGenerator constructor now also uses the base ReportingDelegateFactory instead of the desktop-specific one. Bug: 1092425 Change-Id: I634f898486bcec349d81425b3b5714f7a2c34328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298229 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789378}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I73d4b14fbcc444a0042ac8d21e52b6ea219cc584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304195Reviewed-by:
-
Rob Buis authored
When setting host, empty/incorrect port strings should not change the existing port [1, 2]. This CL also applies the new behavior to setting URL port with empty/incorrect value, since the code paths for setting port and host+port are shared. Behavior matches Firefox. [1] https://url.spec.whatwg.org/#host-state Step 2.4 [2] https://url.spec.whatwg.org/#port-state Step 2.2 Change-Id: I2aa62c1acaa4bc9c0f17dbd2e82c2f2bad1ccedc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300103Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#789376}
-
Eliot Courtney authored
The current implementation only allows two buffers in flight at a time. This is because a new buffer may only be submitted when an old one is released, and initially clients of WBMH only submit the initial buffer plus one more (because of the immediate ack of the initial buffer). Further, only submitting a new buffer when an old buffer is released means that latency variation in receiving release messages directly translates into increased latency in submitting the next buffer. Under load when running linux Chrome on ChromeOS, IPC shunting release messages back from viz=>exo=>ozone can have latencies in the low tens of milliseconds. If buffers are shown in a separate DRM plane (i.e. not copied) they must be held onto for the duration of scanout. This plus the IPC release latency causes visible performance degredation. Currently this latency cannot be absorbed by the buffer queue in linux Chrome. This change introduces an output queue in WBMH. Note that this does not change the semantics of OnSubmission and OnPresentation (acking). For this change to be useful, clients (e.g. GbmSurfacelessWayland) also need to have an output queue, which I will add in a follow-up CL. In order to provide the guarantees swap ack expects this CL also adds some logic for destroyed buffers and out of order releases. For linux Chrome on ChromeOS, surface sync logic in Viz (in ChromeOS chrome) can cause buffer releases to be re-ordered - the new logic handles this case. Bug: 1062529 Test: added unit tests Test: Run linux chrome on chromeos Test: Run ozone linux chrome on Weston, software and hw accel Change-Id: I3574248c92a8cf12207154052194c0e021d2984f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287334 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#789375}
-
Meilin Wang authored
Bug: b/149246117 Test: unittest. Change-Id: I660ebe59f003b004dca13e19e60f51092528d961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275361 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#789374}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d72cb4c076b7..65a88eb4bed0 2020-07-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 1b9b53a39576 to cb2938a1afd7 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I33b357ec6127493532bc93de4a5ccef4090e8c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304370Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I21855838e72a69c32857e09d67e754267e571e4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304369Reviewed-by:
-
Patti authored
This reverts commit cbf18954. Reason for revert: Suspecting this roll to be causing compile failures seen in https://bugs.chromium.org/p/chromium/issues/detail?id=1106623, will revert. Original change's description: > Roll SwiftShader from e8dd233c7a85 to 0e82586297a8 (4 revisions) > > https://swiftshader.googlesource.com/SwiftShader.git/+log/e8dd233c7a85..0e82586297a8 > > 2020-07-17 amaiorano@google.com Fix MacOS Chromium build (source_set dupe) > 2020-07-16 amaiorano@google.com Fix MacOS (darwin) Chromium build on LLVM 10 > 2020-07-16 amaiorano@google.com Added Fuchsia support to LLVM 10 update script and updated configs > 2020-07-16 amaiorano@google.com Use LLVM 10 instead of 7 for GN builds > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/swiftshader-chromium-autoroll > Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 > Bug: None > Tbr: swiftshader-team+autoroll@google.com > Change-Id: I74abe18089392ee45812ce6f2a66537aac6db4bd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304169 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#789366} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,swiftshader-team+autoroll@google.com Change-Id: I30ccd584ef929ccfd353f208fed4537d1d13f443 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302980Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#789371}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie0ed5ccb637c1e3f17ed54ef1face49db93ae974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304331Reviewed-by:
-
Daniel Libby authored
Get rid of some cpplint warnings in these files. R=bokan@chromium.org Change-Id: I49793a90c4341e728dcde65c9509727597a4d582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302713 Auto-Submit: Daniel Libby <dlibby@microsoft.com> Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#789369}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b15083559691..587380c5809d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC patricialor@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1025990,chromium:1092528,chromium:1101179,chromium:1101820,chromium:812428 Tbr: patricialor@google.com Change-Id: If875208936d3c27ae7c4fc2033fc2b0c02b9c77e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304141Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789368}
-
Noel Gordon authored
Patch 3 / 3: menu and submenu margin-top in files-ng is handled by menu JS files. These files-ng specific CSS rules are now unused: ditch them. Bug: 1066727 Change-Id: I1f64f5df9b5d336bfb5edc94acf7ac58a042a8cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301715 Commit-Queue: Alex Danilo <adanilo@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#789367}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e8dd233c7a85..0e82586297a8 2020-07-17 amaiorano@google.com Fix MacOS Chromium build (source_set dupe) 2020-07-16 amaiorano@google.com Fix MacOS (darwin) Chromium build on LLVM 10 2020-07-16 amaiorano@google.com Added Fuchsia support to LLVM 10 update script and updated configs 2020-07-16 amaiorano@google.com Use LLVM 10 instead of 7 for GN builds If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I74abe18089392ee45812ce6f2a66537aac6db4bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304169Reviewed-by:
-
Takashi Sakamoto authored
Bug: 1092288 Change-Id: Ib0102bd587f2947f591babe9e1deee4e50c8e6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298786 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
When we paint selected text in vertical mode, we need to rotate the selection rect because we are under a rotation transform. Bug: 1106205 Change-Id: I148e2bf7a7b8e2e90a8d48f483d16a73d16200c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303878Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#789364}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I647e3bf28628e03138dad0419358d47bd81a76d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304329Reviewed-by:
-
Mansi Awasthi authored
This CL removes the creation of span of page objects for AddRemainingAnnotations() method in PdfAccessibilityTreeBuilder class. Change-Id: I6a70fa70c40503a92be26857cc88bbd7ecd0b7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279424 Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by: -
Noel Gordon authored
Patch 2 / 3: next in the code flow that shows a menu, we must position the menu using a getComputedStyle done internally by cu.ui positioning code. Just before that style recalc, set the menu's margin-top: 8px in inline style. The inline style overrides all CSS and all action-bar menu's of files- app have 8px margin-top as a result (to provide tap-target gap). Bug: 1066727 Change-Id: Ie6e7a651d8bb974dc71581d460e04debb60892c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301713 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Maggie Cai authored
To support sharing, we added action condition in the intent filter. However this will be inconsistent with the stored preferred apps (contains intent filters). This will cause filter matching issues when we try to modify or delete preferred apps entry. This CL adds the support to upgrade the preferred apps if the flag is on. BUG=1092784 AppServiceImplTest.PreferredAppsUpgrade. Test: Unit test PreferredAppsConverterTest.UpgradePreferredApp and Change-Id: Ib6fb3e4d6128b7c2f83a63cac73d800993a4b440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301549Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#789360}
-
Mingjing Zhang authored
This CL adds CompositorLatency.TotalLatency to replace the pipeline:* breakdowns that are to be removed in the benchmark report. Bug: 1078160 Change-Id: I22241a5903d3b122c3e92cc80a1a019e697444e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211918Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789359}
-
Mohsen Izadi authored
In order to be able to compare new EventLatency metrics with existing LatencyInfo-based metrics (Event.Latency.*) for scroll events, we need to measure latency from when the event is created until when gpu-swap has started. Instead, we were incorrectly measuring that latency up to when gpu-swap has ended which is not what existing scroll latency metrics report. This CL deprecates incorrect metrics and replaces them with correct one. This CL changes both UMA and UKM metrics for this. The UKM privacy doc is updated: https://docs.google.com/document/d/1SDxdua997Gm7ihJFVjinHz9qTdBzTJrEzC7GEeQHs-8/edit# Bug: 1079116 Change-Id: I7900e3eca397f863fdba975a2ff7df66f5e08460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280423Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789358}
-
Ben Mason authored
This is a noop since UseDownloadOfflineContentProvider is set as enabled in fieldtrial_testing_config.json, so useDownloadOfflineContentProvider() always returns true and exits the test immediately. Disabling the test to prevent test failure on release testers, where fieldtrial_testing_config.json is not used and causes this test to fail. If this test is needed, can it be fixed up and re-enabled. Bug: 1106460 Change-Id: I0986131275f490ec9e75b26790e9aaaa07f172ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303787Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#789357}
-
Mike Wasserman authored
This single bit exposes whether the device has multiple screens. It informs the value of permission prompts to request more information. This CL adds the IDL, IPC, implementation, and testing. Add a mojo struct for GetDisplays results; reject on failure. Test with the DevTools console (and multiple screens) with: chrome://flags#enable-experimental-web-platform-features Bug: 1098861, 1080710 Test: window.isMultiScreen() works as expected Change-Id: I5d5d86716f1910bfc4ddc5dc70faef252b831a31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278529Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Auto-Submit: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#789356}
-
Aleks Totic authored
Does not fix the layout, but it prevents the DCHECK. Prcentage padding can cause negative widths in Legacy table layout. With TablesNG shipping soon, it is not worth investigating root cause. This clamp just prevents the DCHECK, and is not going to make anything look worse. Bug: 1105900 Change-Id: Id68369dbb906fa62238c71f83b7b87ac3743917a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303564Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#789355}
-
Dylan Cutler authored
This allows us to instrument navigator.languages using this annotation for the identifiability study on which Chromium APIs leak information about users' cross-origin identity. Bug: 973801 Change-Id: I6d3fcf3b193ce34b799e2312172ee4c9e3908e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297683 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#789354}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3164b4494fba..d72cb4c076b7 2020-07-17 csmartdalton@google.com Mixed samples/conservative raster cleanups for tessellation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I1b043867b13add22d5a1df3dbbb3f047dcc07694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304192Reviewed-by:
-
chrome://media-appTrent Apted authored
Previously it used a return value, but that caused increased coupling. Just move the updated file properties into the AbstractFile which can already represent what's needed. Bug: b/161108779 Change-Id: I6dc4d2e889b8c6d3247af00fa613a8c768f27171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300901Reviewed-by:
-
