- 03 Oct, 2020 25 commits
-
-
Wei Li authored
Allow ToolbarButton to have metadata and builder support. Also add support for gfx::Insets in type conversions. Bug: 1130078 Change-Id: Ib98aede08866dc0bf88ddab1a3c0a70de3959685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436514 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#813458}
-
Reilly Grant authored
The DCHECK in serial_port_manager_impl.cc:97 is reachable if the kEnableBluetoothSerialPortProfileInSerialApi flag is disabled or GetDevices() is not called first and an unrecognized token is passed to GetPort(). This change adds a check for the flag and initializes the Bluetooth enumerator as necessary. Bug: 1043300 Change-Id: Ib38e297f61cbc86bb9ab567084919a9e268196e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446846 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#813457}
-
Josh Simmons authored
These tests were failing on networkless phones in lab. We should probably figure out how to mock out the translate service for these, but for now this is a step in the right direction. Bug: 1130712 Bug: 1127786 Change-Id: Ifd7cb1176ae9beb89c1f44268af9c0add9f29a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446894 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#813456}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a6ca9757d3a6..09b9eade20d3 2020-10-02 johnstiles@google.com Rename BlendOverlap to BlendOverlay. 2020-10-02 brianosman@google.com Revert "moved SkSL Field data into IRNode" 2020-10-02 ethannicholas@google.com moved SkSL Field data into IRNode 2020-10-02 ethannicholas@google.com fix SkSL dehydration 2020-10-02 johnstiles@google.com Fix indenting on InlineCandidateAnalyzer. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: brianosman@google.com Change-Id: I326c38267062d9fd8ef4b1d4a28c7f9f30d5402a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445573Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813455}
-
Yuly Novikov authored
No longer needed. TBR=bsheedy Bug: 1132963 Change-Id: Ic71eaf030bff5e7b821e6ce24a511d6cce4d2c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446354Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#813454}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3048829bb6b8..2c28e29e9c92 2020-10-02 jalyn@microsoft.com Sources: Don't scroll to top of threads on click If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1128826 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia10e50dc11608411fc88aea67d39af1714bd598e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447070Reviewed-by:
-
Andrey Kosyakov authored
Bug: 1090988 Change-Id: I59d49a006d61c948a507633cbb4ed965ec2d11b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447092Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#813452}
-
Wei Li authored
Other than BaseScrollBarButton, other subclasses of Button class in views/ should follow Button's default focus behavior. BaseScrollBarButton should not be focusable, nor accessible for accessibility. Set these default values explicitly so changing Button class's default won't affect them. Bug: 1001103 Change-Id: If32d8dadf69a5ba5f8d23738678e31d285d3e5ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429435 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#813451}
-
Jesse Schettler authored
The progress_callback is already nullable, so it doesn't need to be wrapped with base::Optional. Bug: None Change-Id: Ifb43c88ab59b2ec0208225359b11070407fc5912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442571Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#813450}
-
Xiaoling Bao authored
Original algorithm: choose the active policy provider with the highest priority and apply all policies from it. Updated algorithm: for each policy, find the highest priority provider that has defined value, and returns that policy. Bug: 1134303 Change-Id: I3461f476e5404f97a08a6a83f57346804e84e678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443541Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org> Cr-Commit-Position: refs/heads/master@{#813449}
-
Peter Boström authored
This lets dialogs that don't need to store state inside a DialogModel avoid instantiating (and subclassing) a DialogModelDelegate. DialogModel::Builder::model() is added to permit accessing a pointer to the model before it's been built so that it can be bound to callbacks. This change removes DialogModelDelegate use from WindowNamePrompt and OutdatedUpgradeBubbleView. Bug: 1106422 Change-Id: I66119536ae30e8d7a6a3232bea265b57cb8c9346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442500Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#813448}
-
James Vecore authored
We don't support caching share targets so this code removes an attempt to keep cached targets around which causes duplicates to show up in the ui. Fixed: 1133824 Change-Id: I3162cfffae59ca638b2b21e5f9adf6d4a2cc21a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446845 Commit-Queue: James Vecore <vecore@google.com> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: James Vecore <vecore@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#813447}
-
George Burgess IV authored
These existed in the ebuild before for no particular reason. Having them sitting in Chrome seems more theoretically good, and fixes a small bug with some of our simplechrome builders (they weren't picking up the =20 or =30 limits properly, so they were doing =100...) Bug: 937821 Change-Id: I3f89354d377de2e4db7c1b11b644b07867d3b66c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446818 Commit-Queue: George Burgess <gbiv@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#813446}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/16636f480f81..b3c1e71eb1cb 2020-10-02 nicolascapens@google.com Regres: List regressions before summary If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I4e28912a9d5510bbc5d35060f7077b3c0d0e38e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445811Reviewed-by:
-
Haiyang Pan authored
the device usage looks in a good shape and should be able to run at 100%. See the capacity graph http://shortn/_mMR3m6J0Dr Also have weblayer_instrumentation_test_apk running on sailfish since the grash shows walleye capacity could be tight during peak time, while sailfish still has plenty room to hold more test. Bug: 1111436 Change-Id: I7fb68d6a6710a3d2c68fef3f6e54e23af433d2b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446513Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#813444}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: If2c7e6aa62ced283dc88b1ed79f24d74ea8a8439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446921Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9b8970cc0198..3b50b7c41123 2020-10-02 treehugger-gerrit@google.com Merge "Optimize the scroll_jank_cause_queuing_delay metric." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If61bf5f9f0e2c1f5b2c7c4263b730901ec844b15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446911Reviewed-by:
-
Leonid Baraz authored
Fixes were in https://chromium-review.googlesource.com/c/chromium/src/+/2444409 and https://chromium-review.googlesource.com/c/chromium/src/+/2446451 Bug: 1133962 Bug: b:169427520 Change-Id: I1586c801721a3d8f04035b01ce9ab95000454296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446835 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#813441}
-
Kevin Babbitt authored
This CL uses the parameter introduced in crrev.com/c/2438010 to serialize system colors either as keywords or as rgb values depending on whether computed or used value was requested. Bug: 1112362 Change-Id: I5dfca764f944789930c42c5d80338fca1437ea12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436515Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#813440}
-
Bettina Dea authored
This CL creates the actual controller for the Enhanced Protection promo on the NTP on Android and hooks it up to the Feed Surface. Also added metrics to track impressions and dismissal of the promo. This also creates a max impressions for SigninPromoController which will be controlled by an experiment. The first part was: https://chromium-review.googlesource.com/c/chromium/src/+/2423165 Bug: 1130739,1130735,1130745 Change-Id: I080e9c93f2f3b9e38dc397d97fee92525c2a0291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430263 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813439}
-
Bruce Dawson authored
The Windows build instructions for Chromium leads many people to assume that the --ide command is required. This change makes it clearer that it is optional, and also expands on how to use the alternatives. This also changes the recommend invocation of "gclient sync" to add "-D". Tested with https://markdownlivepreview.com/ Change-Id: Ia341f3021c320a4cf7a7071fb96f0464078baf3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444450 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#813438}
-
Stephen Chenney authored
TBR: ikilpatrick@chromium.org Bug: 1045599 Change-Id: I35c8a5ac4e824816c9c16e252955d106bead5cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446777 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#813437}
-
Peter Kotwicz authored
Rename font-related Chrome resources to avoid resource name clash with internal Chrome library which duplicates the font resources BUG=1129255 Change-Id: I027e2295f5cbc173c9a0de235bcee30cd5b9b8ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415533 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#813436}
-
Leonid Baraz authored
Bug: 1133962 Bug: b:169427520 Change-Id: I899a35654fbbc91763b46e54350a447d17834581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446451 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
-
Zentaro Kavanagh authored
- Test each observer firing twice with the second explicitly triggered from the first. Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I9c62c05710adb96ac912270bd08265fd9cd8b6b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440218 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#813434}
-
- 02 Oct, 2020 15 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e4b0c039a1f1..e0d95b608dab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kelvinjiang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1128599,chromium:1131982 Tbr: kelvinjiang@google.com Change-Id: I327416c0a00424d28afe03633feab3beab5780ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445464Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813433}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a2d9abef043b..c488f0c909e2 2020-10-02 jmadill@chromium.org Suppress flaky test on Win/Intel/GL. 2020-10-02 vantablack@google.com First pass at increasing inclusivity 2020-10-02 j.vigil@samsung.com Implement GL_OES_texture_stencil8 2020-10-02 jmadill@chromium.org Disable AMD OpenGL testing on Windows ANGLE tests. 2020-10-02 cclao@google.com Vulkan: Add a test and fix the bug with draw/invalidate/clear 2020-10-02 jmadill@chromium.org Skip ResizeWindowWithDraw test on all Linux. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1097198 Tbr: jonahr@google.com Test: Test: angle_deqp_egl_tests Change-Id: Ifc582e7ac5d4b95be03d4637bac147332970f54c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446917Reviewed-by:
-
Natalie Chouinard authored
These render tests had breaking UI changes introduced in https://crrev.com/c/2424506 and should have been re-baselined by incrementing the revision number (see https://crbug.com/skia/10795). Bug: 1131073 Change-Id: Idf9df5d43a6da8c80ae0c7ac5d1dcc0e88b59b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443400Reviewed-by:
-
Etienne Bergeron authored
This CL is adding unittests for the Pause(...) and Resume(...) API. Fix potential bugs while calling pause/resume multiple times. The underlying platform implementations may not accept double pause or double resume. The related code pause/resume was not covered by previous unittests. Bug: 1133813 Change-Id: I396bed4e2356a3b4bcb8363f0f82d005436022bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446190 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#813430}
-
Peter Kvitek authored
Adding this flag prevents sandbox_type.cc complaining about valid sandbox configuration missing in a command line. Change-Id: I076aaf51411c187e36f3b08f6eb5e50199b2b804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446656 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Auto-Submit: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#813429}
-
Meilin Wang authored
This CL fixes the issue where the bubble size doesn't get updated after switching to another content view possibly with a different size. Screenshot before this CL: https://screenshot.googleplex.com/4GN26KQ6QC6jyo4.png BUG=1106937,1126208 Change-Id: Ie6dda62d93f4d1e5c09212426e8b55bfc5d30cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446773Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Meilin Wang <meilinw@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#813428}
-
James Hawkins authored
This is necessary because Polymer 3 infra does not support flattenhtml. R=khorimoto@chromium.org Bug: none Test: OS Settings -> Networks -> Add Network -> See add wifi icon Change-Id: I8957b3d60aad33e13a785d2fef15922c10218abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446522Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#813427}
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /components/data_reduction_proxy This CL was uploaded by git cl split. R=tbansal@chromium.org Change-Id: Idf2ab419bf07cd41493076a887390d93c1f8266a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435582 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#813426}
-
Aaron Colwell authored
Moving logic from SiteInstanceImpl::ShouldLockProcess() and SiteInstanceImpl::DoesSiteInfoRequireDedicatedProcess() into SiteInfo, because these functions derive most of their behavior from information in the SiteInfo. These functions also represent what the process model should to with specific SiteInfos so it feels like these should be more closely associated with SiteInfo instead of SiteInstanceImpl. This change does not change any behaviour. - Moved SiteInstanceImpl::ShouldLockProcess() to SiteInfo and renamed it to ShouldLockProcessToSite() to make it a little more clear that this method indicates which SiteInfos should cause "is_locked_to_site" ProcessLocks to be used. - Moved SiteInstanceImpl::DoesSiteInfoRequireDedicatedProcess() to SiteInfo and renamed it to RequiresDedicatedProcess(). - Renamed ContentBrowserClient::ShouldLockProcess() to ShouldLockProcessToSite() and updated overrides so that naming is consistent. Bug: 1085275 Change-Id: Iaf9c036c3fe6d274640ee08377ce2e2fcca3d96c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427864 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#813425}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/77107392837f..8e5f2c0fe3e8 2020-10-02 jophba@chromium.org Speed up YABV tests by using smaller array of sizes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Idf73bbf68a4e8ad48d590c6ea4e00359170537df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446913Reviewed-by:
-
Dave Tapuska authored
This moves the creation of the LayerTreeFrameSink into WidgetBase while minimally exposing some APIs on the blink platform. This allows us to move the android synchronous compositor frame sink also to be inside blink. BUG=1097816 TBR=tommycli@chromium.org Change-Id: Ie86b6923cb7cae2505d32ee922c5d03bb8198dc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429224 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#813423}
-
Siyu An authored
Bug: 1112095 Change-Id: I614ec70d4ba183850cd19412c963bd344b7c318c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444800 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#813422}
-
Orin Jaworski authored
This CL includes data fixes for several languages to improve Pedal triggering. Issues resolved include: Stray capitalization, duplicate synonyms, synonyms consisting entirely of a single dash, separators consisting only of a single dash, empty cell gaps, and synonyms consisting entirely of ignore group synonyms. Bug: 11347706 Change-Id: Iabc8099db437e518ef2deea34fd41329985e5b8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446823Reviewed-by:
-
Jimmy Gong authored
Fully implements the DoNotDisturbController. This class is responsible sending and receiving states in regards to the DoNotDisturb feature of the user's phone. Bug: 1106937 Test: chromeos_components_unittests Change-Id: I6a4fa96de5920711a7534ae7eff8bb33b9bb35b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439777 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
-
Yi Gu authored
Currently when an SmsService has unhandled request upon destruction, e.g navigating away, we record "Timeout" as an outcome. This is misleading because "Timeout" should refer to the user consent prompt being timeout. This patch renames Timeout to UnhandledRequest and the follow up patch crrev.com/c/2427560 records the right Outcome.Timeout. Bug: 1127397 Change-Id: I151d5f087c416136bc042d12086df3185dbf2b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424894Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Sam Goto <goto@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813419}
-
