GitLab

The other changes follow from that.

BUG=82098
TBR=haruki@chromium.org (for chrome/browser/chromeos/drive/drive_file_system_util.h)
TBR=hidehiko@chromium.org (for chrome/browser/chromeos/drive/webkit_file_stream_writer_impl.h)
TBR=noamsml@chromium.org (for chrome/browser/local_discovery/storage/privet_filesystem_attribute_cache_unittest.cc)
TBR=rvargas@chromium.org (for device/hid/hid_connection_linux.cc)
TBR=clamy@chromium.org (for net/disk_cache/simple/simple_test_util.cc)

Review URL: https://codereview.chromium.org/184583008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255841 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140315
Test=None, this bindings is not exposed yet.

Review URL: https://codereview.chromium.org/189923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255840 0039d316-1c4b-4281-b951-d872f2087c98

If the natural size is not set, the <video> tag will set its properties videoHeight and videoWidth to the original, uncropped width and height.If that is used for deciding the <video> render size- the aspect ratio will be wrong.

This cl allow setting the natural_size as well as the visible_rect when calling media::VideoFrame::WrapVideoFrame.

BUG=349450
R=fischman@chromium.org, tommi@chromium.org

Review URL: https://codereview.chromium.org/189513004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255839 0039d316-1c4b-4281-b951-d872f2087c98

Right now the param is always cast to int.

BUG=348810
TEST=ToT webgl conformance conformance/extensions/ext-texture-filter-anisotropic.html
R=kbr@chromium.org,bajones@chromium.org

Review URL: https://codereview.chromium.org/189133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255836 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255835 0039d316-1c4b-4281-b951-d872f2087c98

The fact that each Get methods can be used with a NULL out-value simply to check that a value exists (and has the desired type) under a given key is used all over chrome, but isn't actually documented so this simply makes it official by documenting and testing this fact.

Also document the fact that GetDouble will succeed for TYPE_INTEGER as well as TYPE_DOUBLE (which was a surprise to me when I wrote the tests for this CL).

Review URL: https://codereview.chromium.org/191983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255834 0039d316-1c4b-4281-b951-d872f2087c98

Tested with NVIDIA, AMD, Intel HD 3000/4000

Actually I also tested with 10.8.5, but at this point I don't
think it's worth making any changes on 10.8.5.

BUG=349137
TEST=
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/189263017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255833 0039d316-1c4b-4281-b951-d872f2087c98

Randomize order in which ready component updates are applied. On demand updates still take precedence.

BUG=343686

Review URL: https://codereview.chromium.org/144523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255832 0039d316-1c4b-4281-b951-d872f2087c98

Now app::ShellMainDelegate initializes with chrome_100_percent.pak
by default. This patch is to remove this dependancy by add all
chrome-specific resources to app_shell.pak.

BUG=348484

Review URL: https://codereview.chromium.org/176873016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255830 0039d316-1c4b-4281-b951-d872f2087c98

Check --utility-enable-mdns before local_discovery::ServiceDiscoveryMessageHandler::PreSandboxStartup call.

BUG=350518

Review URL: https://codereview.chromium.org/191513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255829 0039d316-1c4b-4281-b951-d872f2087c98

Nothing in the spec - or Blink implementation - precludes empty names
for databases. Remove this bogus DCHECK.

Will add Blink-side layout tests once this lands.

BUG=350133
R=cmumford

Review URL: https://codereview.chromium.org/189413007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255828 0039d316-1c4b-4281-b951-d872f2087c98

Add UMA histograms for register promos.

BUG=350228

Review URL: https://codereview.chromium.org/189623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255827 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338297

Review URL: https://codereview.chromium.org/180983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255826 0039d316-1c4b-4281-b951-d872f2087c98

Build URL for sending client-to-server cacheinvalidation messages.

BUG=325020
R=rlarocque@chromium.org

Review URL: https://codereview.chromium.org/182333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255825 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/189503004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255823 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255820 0039d316-1c4b-4281-b951-d872f2087c98

This CL brings the tracing information into the resulting JSon.

As tracing needs administrator rights, we assume that Chrome is launched
as administrator.

To be able to view events, the traceviewer part must land first.
see: https://codereview.appspot.com/51300043/

BUG=

Review URL: https://codereview.chromium.org/171143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255818 0039d316-1c4b-4281-b951-d872f2087c98

Since the volumes are not used, and moreover some of them are shared between profiles, they volumes should not be mounted, and observers shouldn't be added.

TEST=Tested manually on a enterprise enrolled device.
BUG=349298

Review URL: https://codereview.chromium.org/190403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255817 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255816 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350540

Review URL: https://codereview.chromium.org/191883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255815 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347900

Review URL: https://codereview.chromium.org/190203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255814 0039d316-1c4b-4281-b951-d872f2087c98

The EventRewriter itself is a MessagePumpObserver now, so it does not have
to depend on XInputHierarchyChangedEventListener to know what device a key
event came from. Remove the relevant method from DeviceHierarchyObserver
interface.

BUG=none
R=derat@chromium.org

Review URL: https://codereview.chromium.org/192123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255813 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements a different animation for the experimental app list.
The change will allow more views to be added with a default animation
when switching the contents view.

BUG=349727

Review URL: https://codereview.chromium.org/187083004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255812 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347900

Review URL: https://codereview.chromium.org/190423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255811 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds an ImageView that displays the icon to the
BookmarkAppBubbleView. It also moves the "Open as tab" checkbox to the
same line as the buttons to save on vertical space which was consumed
by the square icon.

BUG=318607

Review URL: https://codereview.chromium.org/184213006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255810 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes all remaining references to the deprecated
device::BluetoothAdapter::StartDiscovering and
device::BluetoothAdapter::StopDiscovering methods. This CL also does
a minor refactor, so that BluetoothAdapter now only tracks active
discovery sessions.

BUG=346985
TEST=Compile chrome; run device_unittests.

Review URL: https://codereview.chromium.org/188473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255809 0039d316-1c4b-4281-b951-d872f2087c98

They DCHECK during telemetry unittests which run with dchecks enabled.

BUG=350684
NOTRY=True
TBR=ernstm@chromium.org

Review URL: https://codereview.chromium.org/192173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255808 0039d316-1c4b-4281-b951-d872f2087c98

(*) A "for irt" library, that will get linked into the IRT.
That library just has the auto-generated pnacl_shim.c file.
Also modify ppapi_proxy to include a "irt_shim_ppapi.c",
which makes use of the pnacl_shim.c file to define a private
hook, parallel to the hook provided by irt_ppapi.c.

(*) A "for the browser" library, that the browser-tester
and the PNaCl packager will include for PNaCl-in-the-browser.
This is still called "libpnacl_irt_shim.a" so that we don't
need to change the in-browser linker's commandline. However,
it will be placed in a different directory so that the
Chrome PNaCl packager can pick it up separately from
the AOT library. This for-browser library uses the new hook.

(*) A "AOT" library, that will go into the SDK for offline
pexe -> nexe translation. Still called "libpnacl_irt_shim.a"
as well, confusingly enough, so that we don't need to change
the pnacl-nativeld.py commandlines. Placed in a different
directory from the for-browser library. Does not use the
new hook, so that it only depends on stable interfaces.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3783
R=binji@chromium.org, dmichael@chromium.org, mseaborn@chromium.org

Review URL: https://codereview.chromium.org/164373010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255807 0039d316-1c4b-4281-b951-d872f2087c98

It fails consistently there.

BUG=350692
NOTRY=True
TBR=alancutter@chromium.org

Review URL: https://codereview.chromium.org/190543007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255806 0039d316-1c4b-4281-b951-d872f2087c98

Similar to the TabCaptureApi.EndToEnd test: An extension is run that generates a rotating cycle of colors and audio tones, and the result is captured and streamed to an in-process Cast receiver.  In addition:

1. Refactored existing code out of the cast_receiver_app into a shared InProcessReceiver class.
2. Added a convenient StandaloneCastEnvironment for test apps.
3. Got rid of the cast_receiver_app prompts since the defaults are used >99% of the time.  Using the --enable-prompts command line arg will show them again.
4. Minor clean-ups in files touched.

NOTE: The new EndToEnd test is being submitted as disabled while outstanding bugs are worked by the team.  Will re-enable once the implementation is sufficiently stable for the bots.

R=hubbe@chromium.org, kalman@chromium.org

Review URL: https://codereview.chromium.org/184813009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255805 0039d316-1c4b-4281-b951-d872f2087c98

(It was only ever given a "true" value once, and even that seemed dubious.)

R=phajdan.jr@chromium.org
TBR=darin@chromium.org, jeremy@chromium.org

Review URL: https://codereview.chromium.org/191483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255801 0039d316-1c4b-4281-b951-d872f2087c98

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/190973008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255800 0039d316-1c4b-4281-b951-d872f2087c98

Disabling various IRT interfaces under PNaCl is now done in the NaCl
repo by irt_interfaces.c, as long as pnacl_mode is set to true in
nacl_listener.cc.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3803
TEST=PnaclExceptionHandlingDisabled, PnaclDyncodeSyscallDisabled
R=jvoung@chromium.org

Review URL: https://codereview.chromium.org/191503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255799 0039d316-1c4b-4281-b951-d872f2087c98

Because inheritance sucks.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/190943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255798 0039d316-1c4b-4281-b951-d872f2087c98

According to `purge; sample -wait Chromium` and launching
out/Release/Chromium.app/Contents/MacOS with 30 wikipedia tabs, this reduces
time spent creating the TaskManagerModel (which happens on the IO thread, in
response to raw bytes arriving from the network) from ~100 samples to ~1 sample.
The icon looks slightly different from the icon that Activity Monitor displays,
but a) it looks arguably nicer now (sharp) and b) most people never open the
task manager.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/190533009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255797 0039d316-1c4b-4281-b951-d872f2087c98

Don't force people who want to write multiprocess tests to derive their
test fixture from MultiProcessTest.

TBR=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/189373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255796 0039d316-1c4b-4281-b951-d872f2087c98

We will now use the domAutomationController rather than looking at the
page title. This will confer the following advantages:

- Tests will fail right away when the js detects an error, rather than
  timing out.
- We will get a lot better stack traces when errors do occur.
- The communication path to the tests becomes more flexible with
  possibility for custom return values (for instance if we need to
  verify something in the C++ code or have a multi-stage test).

BUG=None
NOTRY=True

(doing notry since CQ gets stuck on telemetry test on mac_rel)

Review URL: https://codereview.chromium.org/190563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255795 0039d316-1c4b-4281-b951-d872f2087c98

This fixed the Mac non-component build.

BUG=346766
TEST=Mojo tests (non-component build) work on Mac
R=thakis@chromium.org, viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/188693006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255791 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350517
TBR=ben@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/191863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255790 0039d316-1c4b-4281-b951-d872f2087c98

Closer inspection of MotionEventAndroid usage revealed that several uncached
properties were being accessed on average 2x or more times per event, incurring
significant JNI costs.  Address this by caching these properties (pointer id,
touch size and touch position) for the most common touch scenarios (scroll and
pinch).  This reduces the time spent processing touch events in the browser by
~20% (.1ms) during scrolling, and ~40% (.2ms) during pinching on a typical
Android device.

BUG=341613
NOTRY=true

Review URL: https://codereview.chromium.org/189693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255789 0039d316-1c4b-4281-b951-d872f2087c98