- 05 Sep, 2019 40 commits
-
-
Ian Clelland authored
Bug: 856601 Change-Id: I91a13f97a5c038e1a570f83ace203f9a52cc2a62 TBR: robertma@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786933Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#693760}
-
Alison Maher authored
This change adds a paint phase for backplates in forced colors mode. The backplate paint phase goes before the float and foreground paint phases and after the background paint phase. The new paint phase has been added for both the backplate implementation for LayoutNG and non-LayoutNG. Bug: 970285 Change-Id: I51badafa9564b6e477ab794fed9b8e2caee4b441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757271Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#693759}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /services/preferences. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=jonross@chromium.org Bug: 891670 Change-Id: I2267eede47df2efb13f39d8be4500a24f82d2de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787112 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#693758}
-
Nick Diego Yamane authored
UpdateX11EventForChangedButtonFlags function is not used anywhere and UpdateX11EventForFlags is used in one unittest but with no effect (native_event() returns null) so remove both. Bug: 965991 Change-Id: Ida9b30be22a13cc8cdb2cac424b1968754aa3021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785182Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#693757}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ui/events/blink. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=bokan@chromium.org Bug: 891670 Change-Id: I626ba137031b1d510206f119075f23024408141a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786940 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#693756}
-
Finnur Thorarinsson authored
Bug: 988275, 860467 Change-Id: I9b4d02e5dd8eb449ba7b0c98e36964fcd8eb31bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781429Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#693755}
-
Lowell Manners authored
NavigationControllerBrowserTest.HistoryBackTwiceFromRendererWithUserGesture SitePerProcessBrowserTest.TwoCrossSitePendingNavigationsAndMainFrameWins It looks like these were fixed. Probably either by javascript freezing or not caching pages that are currently loading. Bug: 999848 Change-Id: I69eb7ffb19651e796d9f94dee96f797036bffb6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787380Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#693754}
-
Rakina Zata Amni authored
Because the rendersubtree attribute is also cloned. Bug: 998030 Change-Id: I7bdf0c94578203feaf418d05dd150b4b6ad5c71a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787619Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#693753}
-
Rakina Zata Amni authored
After the move from presentational hints to direct style adjustment, rendersubtree containment addition & locking works with SVG elements. Bug: 998030 Change-Id: Ibf10f2614b1562fd58b67fafbf25051b8608d75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787481Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#693752}
-
Friedrich Horschig authored
This CL fixes the spacing below title texts (which were mistakenly treated as UserInfo instances since both stem from LinearLayouts). Additionally it sets the correct color to the slash used as divider in credit card sheets. Bug: None Change-Id: I03a3bd11a991d848960f3301a0f315cdb362f910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787542Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#693751}
-
Jimmy Gong authored
- The fix is for the SavedPrinters test suite to wait for getCupsPrintersList to be called before querying for the SavedPrintersElement. GetCupsPrintersList is responsible for querying and populating saved printers. Original commit message below: - The header for saved printers will be hidden when the saved printers list is empty. - Adds a browsertest to reflect this change. Bug: 993819, 999072 Test: browser tests, end to end manual Change-Id: I22d8c383812595c5a83587d4fc1d06f91df87b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775203 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#693750}
-
Aga Wronska authored
Update submit button color in parent access view. Bug: 999389 Change-Id: I0db11ec38ec29ab418e12bc126ccf7be3fa8e696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785999Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#693749}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/web_resource. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=rsesek@chromium.org Bug: 891670 Change-Id: I289ecffa9181d7090d1e052f942529a0d672b727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786841 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#693748}
-
Owen Min authored
Add Greg and remove Georges. Change-Id: Ia1d75e45a5083d32ea7198394c34f274dc765a9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787864Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#693747}
-
Eric Orth authored
Changed DNS configuration (especially changes to use of the soon-to-be-enabled DNS-over-HTTPS) can have significant effect on redirect detection. Bug: 971411 Change-Id: Ia0ab92a18495d305a3f16dae1b5ee73357aa45da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781775 Auto-Submit: Eric Orth <ericorth@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#693746}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /services/data_decoder. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=rsesek@chromium.org Bug: 891670 Change-Id: I661e8c04cf53a354ead7ff808eb2636f8a2248ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786970 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#693745}
-
Geoff Lang authored
These failures only appear on Win/AMD/Vulkan and are not reproducable locally yet. BUG=angleproject:2898 TBR=kbr@chromium.org NOTRY=true Change-Id: Ic5024c0de700470ae55e6e17d051322dbc968f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787586Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#693744}
-
Alex Clarke authored
We want to prioritize loading and compositing task until first contentful paint. This causes snav-search-outside-of-focused-scroller.html to flake because the test can sometimes run before all the resources have have loaded. Adding an onload handler fixes this. Bug: 971191 Change-Id: I1b0565a2e07177b19549852f35ba7114b12d38d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787280Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#693743}
-
Emily Stark authored
This adds a histogram that records whenever a user interacts with a Safety Tip (dismisses it or leaves the site). The histogram records the user interaction as well as the type of Safety Tip showing. Bug: 987754 Change-Id: If1a99506a6d92ac37b4025297552c38fdeb6652b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783710Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#693742}
-
Yusuf Sengul authored
Bug: 1001036 Change-Id: I44338b1fae6cdb85631b8178d3cfd2a5eb465193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787737Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#693741}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /content/browser/gpu. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=backer@chromium.org Bug: 891670 Change-Id: I219837178a228d5a0ce2fd45145666ff17ad118c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786802 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#693740}
-
Jesse Schettler authored
When print preview is closed, notify the PrintSessionImpl so it can close the ARC Custom Tab used for printing. Bug: b:139551164 Test: Close print preview in ARC Custom Tab and verify the tab is closed Change-Id: I5ed70a26eef781b9e8224bfa88617d93d7709a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782010 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#693739}
-
Jinfeng Ma authored
Custom scroll corners and resizers are LayoutScrollbarPart objects, they will set scrollable container box as parent by calling SetDangerousOneWayParent. By now, this one way parent is just used for getting the writing mode style. Bug: 999062 Change-Id: I7a31fe23e6558e70fb3de83519a473633c4303fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778899Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#693738}
-
Gabriel Charette authored
Backport some tests in /content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=rsesek@chromium.org Bug: 891670 Change-Id: I21d55afc3729de3571d2c15215992656753cae7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786747 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#693737}
-
Kevin Bailey authored
Just adds a field-trial test config to exercise the higher suggestions, URL limit logic. Desktop only. (Also removes mention of OmniboxTailSuggestions.) Bug: 964049 Change-Id: Iad68a65c59a1033887ea41a3f6f4efb444052a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778361 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#693736}
-
Rafał Godlewski authored
Bug: 986322 Change-Id: Icacf75505712412ebfa6afffac4b46afab4adfaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787637 Commit-Queue: Rafał Godlewski <rgod@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#693735}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chrome/browser/safe_browsing/chrome_cleaner. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=joenotcharles@google.com Bug: 891670 Change-Id: I16c7853ec95cc1aa12416234ec09778b5e1bd840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787057 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@google.com> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#693734}
-
Andrew Grieve authored
Reverting whole CL has merge conflicts, so quickly reverting this one more known bad file. NOTRY=true NOPRESUBMIT=true TBR=estevenson Bug: 1000471 Change-Id: Ica8158d081cb4e7c833787e8196e2cbf792093bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786671Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#693733}
-
Peter Beverloo authored
Bug: 891339 Change-Id: I5e144d89715e067469a01ae4b23a4ffb599ceab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784610Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#693732}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /content/browser/compositor. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=danakj@chromium.org Bug: 891670 Change-Id: Ifb26dd922e4c13b81182127448e399677505989b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786821 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#693731}
-
Michael Ludwig authored
Bug: 1001093 Change-Id: I93ff0c9929221fa7b9c2d14a1ff2a3013256004c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787243 Auto-Submit: Michael Ludwig <michaelludwig@google.com> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#693730}
-
Peter Kasting authored
This is now effectively the guidance of the public Google C++ styleguide, and thus unnecessary. Bug: none Change-Id: I5896ec95822cc586d8f30427083108c34ac1206c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785747 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#693729}
-
danakj authored
The WebWidget in a frame-based RenderWidget is always a WebFrameWidget now. The TextInputClientObserver checks if the WebWidget is a WebFrameWidget when it is not null, but for a frame-based RenderWidget is always a WebFrameWidget now when not null, and becomes null instead of a non- WebFrameWidget when the main local frame is detached. So we can just check (and return directly) the nullptr instead. R=dcheng@chromium.org Bug: 419087 Change-Id: If0c3eea72a468d5d1b63cc8a5427c7a17880c59a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783919Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#693728}
-
Nicolas Ouellet-payeur authored
This CL was submitted without updating annotations.xml due to an issue with the presubmit bot: https://chromium-review.googlesource.com/c/chromium/src/+/1783879 TBR=rhalavati@chromium.org Bug: 1001108 Change-Id: Ib5e0b6d51e843e0b48c79d9fecae9ecf27bc823c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787862 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#693727}
-
Ian Clelland authored
This reverts commit a5c0d47c. Reason for revert: Breaks Android build: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/4323 Original change's description: > Remove deprecated methods in CallbackHelper.java > > Bug: 1000510 > Change-Id: I6d26647c389b75bbc37dcc0fbafc18d25e84285b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785102 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693693} TBR=boliu@chromium.org,agrieve@chromium.org Change-Id: I332fe630da34560893ccc1ca470624f067db3428 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1000510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787353Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#693726}
-
Nico Weber authored
This reverts commit 0bf621ef. Reason for revert: This breaks the iOS build, see e.g. https://ci.chromium.org/p/chrome/builders/try/ipad-device/113 Original change's description: > base: Remove temporary "WithTraits" task API wrappers > > Now that everyone has been migrated to the renamed > PostTask/CreateTaskRunner APIs, we can remove these temporary wrappers. > > TBR=gab@chromium.org > (to apply side-effects of mechanical change in //base) > > Bug: 968047 > Change-Id: I69c53abd899f37586f23ec295ffcc9bf12042c4a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752787 > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> > Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693695} TBR=gab@chromium.org,skyostil@chromium.org Change-Id: If1229c8390dc657b7525e58994a94b51f598e880 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 968047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786836Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#693725}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /gin. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=jbroman@chromium.org Bug: 891670 Change-Id: Idc0de22233bb1dfa72b0111d2dc5d24ba32208a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786942 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#693724}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/3fa35aa420ee..3de1b8d0b098 git log 3fa35aa420ee..3de1b8d0b098 --date=short --no-merges --format='%ad %ae %s' 2019-09-05 wl@gnu.org [cmake] Add brotli support. 2019-09-05 wl@gnu.org FindHarfBuzz.cmake: Change indentation to two spaces; shorten lines. 2019-09-05 wl@gnu.org Fix handling of `AF_CONFIG_OPTION_INDIC'. 2019-09-05 wl@gnu.org CMakeLists.txt: Fix generation of DLL related stuff (#56852). Created with: gclient setdep -r src/third_party/freetype/src@3de1b8d0b098 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: I6061bbaf2b0997c47c9d3833babb052c11f9ef02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787840Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#693723}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/79401df82ffb..5c3c41d20e9c Created with: gclient setdep -r src-internal@5c3c41d20e9c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Iaac3011090b024fefee8a600a4548433993794b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786926Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693722}
-
John Budorick authored
This is a partial revert of crrev.com/c/1780982. Bug: 950413,1001063e Change-Id: Ie76a8ad85aaa58b68d5bb11539dd36756a5f36ae Tbr: sque@chromium.org,hypan@google.com No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787917Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#693721}
-