GitLab

There's no longer anything to do here.

Bug: 729808
Change-Id: Ic0cf93abdcbdfdbfc2392df1a46e1c129a5166fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752286
Commit-Queue: James Cook <jamescook@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686485}

This cl removes stale reference to
components/supervised_user_error_page/OWNERS which has been moved.

NOPRESUBMIT=true

Bug: 969748
Change-Id: I5b82b8ff2e18415e1b191c1a3fbb04383482f03d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751969Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686484}

This CL aims at removing rest of the code to use gmscore isUVPAA.

This CL is the third of 3 CLs to add isUVPAA implemenration on clank
and remove the flow to call isUVPAA that gmscore supports.
First CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1739973
Second CL:
https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/1587528

Bug: n/a
Change-Id: I8f045738e3b3213184e7109bb42f1924ad8c55b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750406
Commit-Queue: Suzy Li <suzyli@google.com>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686483}

Some features need to know if the screen is on and unlocked (e.g. the
ClickToCall feature will use this to open the dialer immediately instead
of displaying a notification). This adds this information to
DeviceConditions and updates all dependencies.

Bug: None
Change-Id: If67dc2d736b20284c0e79a0244753f594bfdba74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751730Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686482}

The goal of this CL is to fix WebApkIntegrationTests flakiness
on touchless bots.

The WebApkIntegrationTests with the exception of
testWebApkLaunchesByLauncherActivity test WebApkActivity not the
WebappLauncherActivity/WebApkActivity launch flow. This CL moves those
tests to WebApkActivityTest.
The differences between WebApkIntegrationTest and WebApkActivityTest
are:
WebApkActivityTest builds WebApkInfo directly instead of reading the
AndroidManifest
WebApkActivityTest does not use --host-resolver-rules weirdness

BUG=983769

Change-Id: I0273a34c27f4d07e38ea67fdb9dac7b2b900e6ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747164
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686481}

Environment variable "CHROMIUM_TEST_LAUNCHER_BOT_MODE"
will set retry limit to 3.
This causes RunMockTests test to retry failing and crashed tests.

Bug: 993323
Change-Id: If2ba3baa52a356b732bdc317171a3dc73ce306df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752169
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686480}

For Captured Sites test automation, we now log what is in the cache,
and we log the key that was looked for on a miss, but we don't log
what key was requested when there is a hit. This line fixes that.

Change-Id: I01561dd39d7152f87b66bb9d1a993dbe2d94b33f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748604Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Ian Struiksma <ianstruiksma@google.com>
Cr-Commit-Position: refs/heads/master@{#686479}

- Adds a fullScreenBadge property to BadgeViewController beside the
displayedBadge that is shown regardless if fullscreen is enabled or
disabled.
- Creates BadgeIncognitoItem as a model representation of the incognito
badge.
- Checks if new WebState is OffTheRecord in BadgeMediator to add
an incognito badge.

Screenshot: https://drive.google.com/open?id=1_GyW4tQ2iNIJmv-5yBH4fEGRf8i2GOxf

Bug: 976901, 976815
Change-Id: Ic1a3580c51ca2f5ee0d33f326e069d32c0b72ea2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746464
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686478}

... the window has an un-identity transform in place.

This is to fix the animation when snapping an overview window in clamshell mode.

Bug: 890029
TEST: Manually
Change-Id: I5d05eee296b16a5b84da10bfbad848c78969c8a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731697
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima (OOO 8/12,13) <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686477}

This is to fix the issue mentioned in crbug.com/993363

NOTRY=true
TBR=jbudorick

Bug: 993363
Change-Id: I58f3cd8ebc0761124d51be5328852a493b487eea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751906
Commit-Queue: Haiyang Pan <hypan@google.com>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Auto-Submit: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#686476}

After non-sync users are able to migrate local cards, the
primary account email will no longer be correct.

Bug: 897998
Change-Id: I932b38ed2d6bf0ffdd238ab73a76998a31ed898c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747076
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#686475}

This CL makes AutocompleteMatch::duplicate_matches sorted from
best-to-worst.

It refactors the deduplication process by splitting the duplicate
preference sorting code into a comparator, and puts the relevance
upgrading logic into its own method in:
AutocompleteMatch::UpgradeMatchWithPropertiesFrom().

This CL is needed, because almost any re-duplication logic used for
Entity Suggest "plain" match (see bug) will need to sort the duplicates
from second-best to worst.

But this should also be a pretty beneficial change on its own for code
clarity.

Bug: 989232
Change-Id: I71f093fe69714ee491328a54e3e2238a3ecadbbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730598
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686474}

CQ-DEPEND=chromium:1698490

Change-Id: I15d3ee4e0e5425c34fbbbccff63c937af2e1e4ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733712
Commit-Queue: Shaojiang Zhong <sjzhong@google.com>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686473}

|update_network_isolation_key_on_redirect| should only be set on
navigation requests, and renderers are not trusted to set it.

This CL introduces ResourceRequest::TrustedParams, which contains fields
only the browser process is trusted to set, and an |is_trusted| bit that
can be set when creating URLLoaderFactories. If TrustedParams are sent
to a URLLoaderFactory without that bit set, the request will fail.

Bug: 991736
TBR: alexilin@chromium.org
Change-Id: Id3263e03e663b330ee9c21682a4d0de753c5331a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744926
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686472}

Users from browswer side can call AddDataRestoreKey() in cryptohome_client
so that the client will send D-Bus call to chromeOS cryptohome. The
reply sent from chromeOS will contain the raw bytes of generated
data_restore_key.

CQ-DEPEND=chromium:1698490
BUG=chromium:969916

Change-Id: I671f826ac6795de021f9c93e093a7f04b7738730
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736817Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Shaojiang Zhong <sjzhong@google.com>
Cr-Commit-Position: refs/heads/master@{#686471}

The stuck-child timeout tests were using a 5ms timeout, which on some
systems caused CoordinatorImplTest.TimeOutStuckChildMultiProcess to fail
due to no "browser" dump being received within those 5ms.

Remove the dependency on the speed of the system on which the test is
running by using MOCK_TIME instead.

Bug: 970819
Change-Id: I48fc6c8b8b6e7bc5c19179a01cd9e80ee40e8555
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750405Reviewed-by: Hector Dearman <hjd@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686470}

This adds a global CHECK that ensures we hopefully won't miss new processes as
they are added.

This enables all processes to initialize system tracing as early as possible.

Bug: 979576
Change-Id: Id9d841dad5980cf82e46586238fe682722558cea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748886
Commit-Queue: Stephen Nusko <nuskos@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Auto-Submit: Stephen Nusko <nuskos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686469}

chrome_cleaner is built into a separate executable from chrome, so many
of chrome's include_rules shouldn't apply to it.

Also moves several common dirs to chrome_cleaner's main DEPS file so they're
allowed in the whole chrome_cleaner project. The remaining includes that are
only allowed in some subdirs are:

* components/crx_file (only used in the component that unpacks CRX's)
* mojo/core/embedder (only used in IPC setup, and by some tests - mojo/public is allowed everywhere)
* net/traffic_annotation (only used in networking code)
* third_party/crashpad (only used in the crash reporter)
* third_party/zlib (only used in the unpacker component and zip_archiver)

R=proberge

Bug: 967728
Change-Id: I96dc59014ebb9be0e0483a190e000f42902b49da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749249Reviewed-by: proberge <proberge@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@google.com>
Cr-Commit-Position: refs/heads/master@{#686468}

This class now requires an anchor view (which in practice it always has) and
does not support having an anchor point.

Bug: 989080
Change-Id: I7c0b24e5cbe9794ef87c97ce5e6d174938192170
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749308
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686467}

This helps to see what happened around DCHECK failure.

Bug: 993249
Change-Id: I2f7dd76c63899599140f15149da761ac33b2d7f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750539
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686466}

  ../../chromeos/services/secure_channel/ble_scanner_impl_unittest.cc:231:12:
  error: address of stack memory associated with local variable
  'fake_bluetooth_device' returned [-Werror,-Wreturn-stack-address]
      return fake_bluetooth_device.get();
             ^~~~~~~~~~~~~~~~~~~~~

I guess the test worked before because it didn't actually dereference the
pointer.

Bug: 992458
Change-Id: I82f189588644a63de1a9f16dbf158dfcdca5e5a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751789Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686465}

Bug: 992355
Change-Id: I9a61e2f21d7d0492763d444d228c13090d0d4262
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751982Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686464}

Test: added test
Bug: 992223
Change-Id: I717921ba2a0cc428b934b57e247f54395691b907
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750155Reviewed-by: Avery Musbach <amusbach@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686463}

Bug: 966386
Change-Id: Ic3c7e2e5cc6848fabdb7f35a753024e75bfdd783
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750090
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686462}

This is a follow up change of CL:1667787, which introduced
AutofillPopupControllerImpl::FireControlsChangedEvent for autofill
popup accessibility.

On Mac and potentially other platforms, when accessibility is
enabled, upon invoking autofill popup and FireControlsChangedEvent
we end up dereferencing a nullptr of AxPlatformNode due to
Mac does not have a complete implementation of AxPlatformNode yet.

This CL fixes the above by adding a check for AxPlatformNode in
FireControlsChangedEvent.

Changes:
 1. Introduced a check for invalid AxPlatformNode in
    AutofillPopupControllerImpl::FireControlsChangedEvent to return
    early from firing event.
 2. Added associated unit tests for FireControlsChangedEvent.
 3. Exposed GetWebContentsPopupControllerAxId virtual to
    AutofillPopupDelegate..

Bug: 986587
Change-Id: I9a6ed49330a9ea9d7d4e5483c3ee06d5675919ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714297
Commit-Queue: Victor Fei <vicfei@microsoft.com>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ian Prest <iapres@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686461}

It is enabled, but does not have a feature_configurations or
finch configuration. I.e. it's really the same as disabled.

Discussed with ghendel@. We have collected data for this Reading List
promo which did increased usage, but not something that we want to run
permanently. It's OK to leave this as disabled but keep the code
in case we want to run it in the future.

Bug: None
Change-Id: Ie6ee6c8227985bda08af36964fe83f51a6bc77f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745401
Commit-Queue: Peter Lee <pkl@chromium.org>
Auto-Submit: Peter Lee <pkl@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686460}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Ieb48da1f5ceea08f8b6f12ab283ae4fca193e849
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751763Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#686459}

Adds tests to the Visual Viewport ScrollIntoView for
fixed-position elements.

BUG=986390

Change-Id: Id6a6838b948ce95efa2eee228303cd0325d2af50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746079
Commit-Queue: Donn Denman <donnd@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686458}

Turns out we don't really want to use the TabDelegate that
WebAppActivity uses, as it does asynchronous tab loading, and fires an
intent in order to launch the NTP, instead of just opening it in a tab.

This is slightly complicated by some weird initialization ordering
issues (why does CTA initialize the TabModels in initializeCompositor??)
and that we still want new tab link clicks to open in CCT (to avoid
breaking things that need multiple tabs alive at once, like oauth).

Bug: 984019
Change-Id: Iea98cdc0936b374eb985643af8dbb040feeef946
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742927Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686457}

Fix ServicificationBackgroundServiceTest::testHistogramsPersistedWithServiceManagerOnlyStart fails on official bot.

The test fails on the official bot due to the active field trial group size is
0. In this CL, we force a field trial "Foo/Bar" in the test. Thus, it guarantees
at least there is one active field trial.

Bug: 965482
Change-Id: Icdd84dd2e4ff22a17da3d7a7c9dd048529ac9ae0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752245Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686456}

Move it under generic location so this can be reused in other places.


Bug: 991464
Change-Id: I7cf9b227a04400ccf6dc92bffc72f2f493ac83ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725312
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686455}

Bug: 992556
Change-Id: I6db46d4606948821a4faf30861e16180fff226c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752164Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686454}

This reverts commit 858d35cc.

Reason for revert: Still seems to be causing issues:
https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak

Original change's description:
> Fix sending scrollend on main thread snap
> 
> This CL sends scrollend event if GSE is being
> handled on the main thread after the snap (if
> the snap has started after GSE). It also takes
> care of sending scrollend event for snap after
> fling.
> 
> This CL is exactly the same as previous CL that got reverted:
> https://chromium-review.googlesource.com/c/chromium/src/+/1743253
> 
> with some modification to the test and input injection instrumentation
> to solve the leak bots.
> 
> TBR=bokan@chromium.org
> 
> Bug: 907601
> Change-Id: I02f501573cb2021473df0b36f4c512b82e617fb2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749790
> Auto-Submit: Navid Zolghadr <nzolghadr@chromium.org>
> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#686424}

TBR=bokan@chromium.org,nzolghadr@chromium.org

Change-Id: I96aa049c04530fa392c79415fc6c2bb3b99af341
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 907601
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752247Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686453}

In W3C mode for ChromeDriver, the response format changed. Code
was modified to extract sessionId from the new response format.

Bug: chromedriver:3076
Change-Id: Iaf749fa480fcbe541d8b520357c4344c79241dc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746787Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tricia Crichton <triciac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686452}

This class is using base::flat_map, which seems to be added by this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1728056

Notice that the flat_map.h is not included. It works fine for now, but
can be a potential problem. For example, when I am working on my own CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1614120

There is a compilation error if flat_map is not included in this file.

Bug: None
Change-Id: I8d9be82945a322afba3d0a07bd8d79d7a9910495
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746293Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686451}

UX wants to show the GAIA avatar instead of the device account image.

Bug: 990528
Test: added to browser_tests
Change-Id: If56b065154b0690b7ce4ff9b3d520250575395cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750100Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686450}

This CL removes code paths of unused bubble view modes in
ProfileMenuView and refactors related code.

Bug: 966388
Change-Id: Icece4828989c61d8be9ac85de27874d934fa92ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751788Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686449}

Update the color palettes so that Incognito and Dark mode share some
same colors, including toolbars, text and icons.

Bug: 985064
Change-Id: I512cfecf6774883bba935a20d56b03df8d2143a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742517Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Lijin Shen <lazzzis@google.com>
Cr-Commit-Position: refs/heads/master@{#686448}

https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/c267899484ba..7e90794dfac8

$ git log c26789948..7e90794df --date=short --no-merges --format='%ad %ae %s'
2019-06-24 alanlxl power_manager: Remove kScreenDimImminentSignal and kDeferScreenDimMethod
2019-07-15 zuan cryptohome: Add calls for obtaining RSUDeviceID to UserDataAuth and proxy
2019-08-02 victorhsieh system_api: rename BOOTLOCKBOX_ERROR_CANNOT_READ
2019-07-11 sjzhong system_api: Add AddDataRestoreKey and MassRemoveKeys in dbus-constants.h.

Created with:
  roll-dep src/third_party/cros_system_api

Bug: 977321
Change-Id: Id32afe66517a243302b90f7b1b182709e22b7562
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750930Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Commit-Queue: Shaojiang Zhong <sjzhong@google.com>
Cr-Commit-Position: refs/heads/master@{#686447}

Use dynamic colors instead of static ones.

Bug: 976675, 991209
Change-Id: I5750a55eb00de7ae510c9561c7bace2f1fac63c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749089
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686446}