GitLab

This reverts commit 09eafe73.

TBR=tommycli@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/790123003

Cr-Commit-Position: refs/heads/master@{#309573}

BUG=

Review URL: https://codereview.chromium.org/812133003

Cr-Commit-Position: refs/heads/master@{#309572}

validate the sanity of the WebContentsObserver invocations, but which hopefully
will grow to include other too-heavy-for-production-code bug detection logic.

The currently supported check, WebContentsObserverSanityChecker, is a fleshed-
out version of the FrameLifetimeConsistencyChecker previously used in
RenderFrameHost unittests.

This sanity check managed to identify the root cause for bug 438951, so it's
already proved itself useful. Enabling it on all tests should prevent future
regressions of that kind.

To install this on all WebContentses, we need to un-deprecate the
WebContentsImpl::AddCreatedCallback/RemoveCreatedCallback mechanism. To make
that safer, the dangerous methods are moved to the FriendZone (get it?) which is
what I call what Dr. Dobbs calls, stodgily, the "C++ attorney/client idiom"
http://goo.gl/13oS7e. They also now have, cleverly, ForTesting in their names.

Lastly, we change the invocation time of the g_created_callbacks to be at the
end of WebContents::Init, instead of at the end of the ctor, so we're not
inviting tests to muck around with a half-inflated WebContents.

BUG=438951, 444722, 444717
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/803873004

Cr-Commit-Position: refs/heads/master@{#309571}

Fix forward declarations in cc/animation/

R=vollick@chromium.org

Review URL: https://codereview.chromium.org/826453002

Cr-Commit-Position: refs/heads/master@{#309570}

If a connection is not going to succeed, the user shouldn't be prompted to allow it.

BUG=442497

Review URL: https://codereview.chromium.org/800853006

Cr-Commit-Position: refs/heads/master@{#309569}

Tests are flaky as setMediaKeys() was not completing before the
"encrypted" event was generated. Change delays setting the video
source until setMediaKeys() completes.

BUG=444683
TEST=Failing tests run fine locally

Review URL: https://codereview.chromium.org/823743002

Cr-Commit-Position: refs/heads/master@{#309568}

This reverts commit 5abc69b1.

Reason for revert:

The Linux GN bot failed compile:
http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20GN&number=19568

Due to error running grit:
KeyError: 'Duplicate keys: [18500]'

We have seen this error before, and it should have already been fixed
in grit's resource_ids....

I expect the problem is with GN since this failure isn't happening on
any other bot, however reverting in the meantime to make the tree green
until this is sorted out.

TBR=tommycli@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/825753002

Cr-Commit-Position: refs/heads/master@{#309567}

TBR=dgozman@chromium.org
NOTRY=true
BUG=444827

Review URL: https://codereview.chromium.org/821263002

Cr-Commit-Position: refs/heads/master@{#309566}

Tested with:
out/GN/mojo_shell
http://<host>/LayoutTests/media/encrypted-media/encrypted-media-playback-setmediakeys-before-src.html
--args-for='mojo://html_viewer --v=3 --enable-encrypted-media'

TBR=jamesr@chromium.org
BUG=444205
TEST=See above.

Review URL: https://codereview.chromium.org/815293002

Cr-Commit-Position: refs/heads/master@{#309565}

This needs to be set in order to build properly from the bisect script.

BUG=

Review URL: https://codereview.chromium.org/815083004

Cr-Commit-Position: refs/heads/master@{#309564}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f11ba2b..73483d9

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/820073002

Cr-Commit-Position: refs/heads/master@{#309563}

BUG=441446

Review URL: https://codereview.chromium.org/818053003

Cr-Commit-Position: refs/heads/master@{#309562}

This is a partial fix for 41, but this part can be merged to 39 and 40.
This should be merged to 39 and 40.

BUG=444524

Review URL: https://codereview.chromium.org/822823002

Cr-Commit-Position: refs/heads/master@{#309561}

r302898 made FontRenderParams avoid calling FcFontMatch()
for empty queries, instead just sticking to the default
pattern. Many users don't have sane default patterns,
though, so instead call FcConfigSubstituteWithPat() to load
settings that aren't tied to particular font families.

Also use scoped_ptr to simplify FcPattern management and add
myself as an owner for font_render_params*.

BUG=442443,435277,423056

Review URL: https://codereview.chromium.org/811123002

Cr-Commit-Position: refs/heads/master@{#309560}

BUG=418375

Review URL: https://codereview.chromium.org/820063003

Cr-Commit-Position: refs/heads/master@{#309559}

In the fill on account select password manager experiment, the enabled
setting still highlights the fields that can be autofilled. This adds an
experimental group where the fields will not be highlighted even if they
can be autofilled until after a choice has been selected.

R=gcasto@chromium.org
TBR=isherman@chromium.org

BUG=410963

Review URL: https://codereview.chromium.org/788183004

Cr-Commit-Position: refs/heads/master@{#309558}

Cr-Commit-Position: refs/heads/master@{#309557}

Cr-Commit-Position: refs/heads/master@{#309556}

BUG=405361

Review URL: https://codereview.chromium.org/783663003

Cr-Commit-Position: refs/heads/master@{#309555}

BUG=444827
TBR=eroman
NOTRY=true

Review URL: https://codereview.chromium.org/821093006

Cr-Commit-Position: refs/heads/master@{#309554}

BUG=419373
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/822913002

Cr-Commit-Position: refs/heads/master@{#309553}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/825663002

Cr-Commit-Position: refs/heads/master@{#309552}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2db2f35..ce0377c

TBR=gavinp@chromium.org,johnme@chromium.org

Review URL: https://codereview.chromium.org/819283002

Cr-Commit-Position: refs/heads/master@{#309551}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/812323004

Cr-Commit-Position: refs/heads/master@{#309550}

This reverts these three changes - the original one, plus two fixes that landed on top of it.
It's too late to try to fix bug 393665. Let's revert, merge the revert to M40, then try again
when we have a proper fix for bug 393665.

4f8a4bca #301810 https://codereview.chromium.org/387353004
ffd2bdde #307160 https://codereview.chromium.org/771353004
5a1a4d91 #307167 https://codereview.chromium.org/784553002

BUG=437701,393665
TBR=ananta

Review URL: https://codereview.chromium.org/796333009

Cr-Commit-Position: refs/heads/master@{#309549}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/65e09ff..2db2f35

TBR=gavinp@chromium.org,johnme@chromium.org

Review URL: https://codereview.chromium.org/813323003

Cr-Commit-Position: refs/heads/master@{#309548}

BUG=442514

Review URL: https://codereview.chromium.org/815363002

Cr-Commit-Position: refs/heads/master@{#309547}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b1c6843..f11ba2b

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/824853002

Cr-Commit-Position: refs/heads/master@{#309546}

Cr-Commit-Position: refs/heads/master@{#309545}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/933540f..65e09ff

TBR=haraken@chromium.org,gavinp@chromium.org

Review URL: https://codereview.chromium.org/789333003

Cr-Commit-Position: refs/heads/master@{#309544}

BUG=444713
TEST=Add tests to cover this case.
R=jrummell@chromium.org

Review URL: https://codereview.chromium.org/798583003

Cr-Commit-Position: refs/heads/master@{#309543}

BUG=427418

Review URL: https://codereview.chromium.org/802343002

Cr-Commit-Position: refs/heads/master@{#309542}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/68cf7f6..933540f

TBR=haraken@chromium.org,gavinp@chromium.org

Review URL: https://codereview.chromium.org/803603005

Cr-Commit-Position: refs/heads/master@{#309541}

Revert of Revert of Clean up Smart Lock cryptohome keys logic: (patchset #1 id:1 of https://codereview.chromium.org/789793005/)

Reason for revert:
This didn't fix the problem, so reverting the revert.

Original issue's description:
> Revert of Clean up Smart Lock cryptohome keys logic: (patchset #5 id:80001 of https://codereview.chromium.org/808563004/)
>
> Reason for revert:
> Once this change landed chromeos file manager tests started failing across the MSAN bots.
>
> This is the most likely culprit, so reverting speculatively. If this does not help will reland this change.
>
> See http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Browser%20%282%29/builds/139
>
> Original issue's description:
> > Clean up Smart Lock cryptohome keys logic:
> >
> > 1. Queue all cryptohome keys operations.
> > 2. Roll ClearRemoteDevices as a specific case of SetRemoteDevices
> > 3. Introduce new RefreshKeys operation using the existing add and remove keys
> >    operations to replace the current cryptohome keys with new keys.
> > 4. After reauthenticating for setup, remove the old cryptohome keys.
> >
> > BUG=432996
> >
> > Committed: https://crrev.com/275152c34d8edc5346757288cfffe63444650faa
> > Cr-Commit-Position: refs/heads/master@{#309094}
>
> TBR=tbarzic@chromium.org,xiyuan@chromium.org,tengs@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=432996
>
> Committed: https://crrev.com/8ffa00af2d4e322e91859c502aa02e0c9b0e1f2a
> Cr-Commit-Position: refs/heads/master@{#309519}

TBR=tbarzic@chromium.org,xiyuan@chromium.org,tengs@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=432996

Review URL: https://codereview.chromium.org/814153003

Cr-Commit-Position: refs/heads/master@{#309540}

BUG=none

Review URL: https://codereview.chromium.org/818873002

Cr-Commit-Position: refs/heads/master@{#309539}

Covers testing/, tools/, ui/, and win8/.

BUG=422426
TEST=none
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/819223002

Cr-Commit-Position: refs/heads/master@{#309538}

This ensures that compiler optimizations are restored to the state as it was before ReduceLarge function. Previous CL https://codereview.chromium.org/814273004 could have a possible side effect of enabling "tree-vectorize" optimizations for the rest of the file even when they were disabled in build settings.

BUG=439566

Review URL: https://codereview.chromium.org/819893002

Cr-Commit-Position: refs/heads/master@{#309537}

This is timing out pretty consistently now.

TBR=thakis@chromium.org
NOTRY=true
BUG=400490

Review URL: https://codereview.chromium.org/810953006

Cr-Commit-Position: refs/heads/master@{#309536}

R=erickung@chromium.org
TBR=lcwu@chromium.org
BUG=408189

Review URL: https://codereview.chromium.org/794253004

Cr-Commit-Position: refs/heads/master@{#309535}

Currently if postMessage messages are sent to a MimeHandlerView guest before
it has loaded, they will just be dropped. It also isn't possible to know
when the guest has fully loaded. This CL queues messages until the guest
has fully loaded and then dispatches them to the guest so that none are lost.

BUG=415858

Review URL: https://codereview.chromium.org/811263002

Cr-Commit-Position: refs/heads/master@{#309534}