- 01 Mar, 2019 13 commits
-
-
Juanmi Huertas authored
These functions receive parameters of type long, and those were not being checked in case they were receiving infinity or other not-long values. Added EnforceRange in the idl to ensure those functions are receiving valid longs. Removing the expected on the WPT tests to stop ignoring these failures. Changing a fast test that was testing the original throw behavior. Bug: 934841, 934839, 934837 Change-Id: Iaa95d3c5ed9ac545472ff72e9ef4b535d22cbedf Reviewed-on: https://chromium-review.googlesource.com/c/1494798 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#636626}
-
Morten Stenshorne authored
This saves 192 bytes [*] of stack space per in-flow layout recursion. [*] Linux 64bit release. Bug: 930637 Change-Id: Ib4531d031312d97023c5e14ef40b8f25684ae29c Reviewed-on: https://chromium-review.googlesource.com/c/1489421Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#636625}
-
Staphany Park authored
AppCache will also need to share the same key used to pad CacheStorage. This CL also updates the singleton key's implementation from base::LazyInstance to base::NoDestructor. Bug: 918293 Change-Id: I792d700a445dc1bfa408564401288e6bd56918b2 Reviewed-on: https://chromium-review.googlesource.com/c/1490951Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#636624}
-
Kevin Strohbehn authored
Bug: 936504 Change-Id: I98436eb82c64fe5b3b6ba1a9d39176317883026a Reviewed-on: https://chromium-review.googlesource.com/c/1496239 Commit-Queue: Kevin Strohbehn <ginko@google.com> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Kevin Strohbehn <ginko@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#636623}
-
Ian Kilpatrick authored
Since we started painting floating objects directly (instead of using the FloatingObjects data-structure), we were only using this for overflow calculation. This change removes the copy back, and modifies the visual&layout overflow calculations to use the correct object. (non-LayoutNG object uses the FloatingObjects data-structure still, LayoutNG object uses the object directly). This change breaks some LayoutNGBlockFragmentation tests. Bug: 635619 Change-Id: Ie0422b4b9071eb75f293c8c5510af87e0dac21b1 Reviewed-on: https://chromium-review.googlesource.com/c/1474677Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#636622}
-
Roman Aleksandrov authored
Change messages of the warning for both cases: 1) Non-risky configuration 2) Risky configuration Bug: 936955 Change-Id: I32c863decab87e8ea11183039edeceeadab66475 Reviewed-on: https://chromium-review.googlesource.com/c/1495535Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#636621}
-
Ben Pastene authored
R=jbudorick, martiniss Bug: 815387, 731982, 800178, 731980, 731976, 731966 Change-Id: If2b3c143766e0738be985f7c7542efc4569afc52 Reviewed-on: https://chromium-review.googlesource.com/c/1496250 Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#636620}
-
John Delaney authored
This test is flaking due to not waiting for resources to finish loading. Currently "AddMinimumAdResourceExpectation" only checks for resources reported as ads to be identified, rather than waiting for the resources to complete. This modifies the method to wait for complete ad resources. This change modifies the EvalJS call that plays the video to not have a user gesture so it is clear that the frame doesn't receive user activation. This is purely to provide clarity in the code and does not change the testing path. Flake analysis: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNGMxNmRkZDA1NmY4ZTE3NGMzOGQ1Zjg2Y2FiMGJkYjBjNzM5MzRmMww Change-Id: Ide73b6696610a134c4d0c5990d3a92685f1fc5b9 Reviewed-on: https://chromium-review.googlesource.com/c/1495674 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#636619}
-
Piotr Pawliczek authored
A list of enterpise printers is not ready immediately after creation of CupsPrintersManager. It caused a problem for testing procedure since from the level of autotest_private_api we do not know if the final list is ready or there are still some ongoing calculations. A new method called OnEnterprisePrintersInitialized() was added to the observer of CupsPrintersManager to solve this issue. Also whole code related to enterprise printers were refactored, large part of functionality was moved from SyncedPrintersManager to new class EnterprisePrintersProvider. Classes ExternalPrintersPrefBridge and DeviceExternalPrintersSettingsBridge have been merged into one class called CalculatorsPoliciesBinder. This is reland of CL:1220547, it fixes the problem detected by the test AutotestPrivateApiTest.AutotestPrivate (method execution after destruction of CupsPrintersManager object). BUG=chromium:816996 TEST=Tested on cave with the use of CL:1451591 TBR=achuith@chromium.org Change-Id: I70958421aadd9fab9a2401555bef0dbb28ad5a6a Reviewed-on: https://chromium-review.googlesource.com/c/1491909 Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#636618}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fe83cfa6b43a..5117888302cf git log fe83cfa6b43a..5117888302cf --date=short --no-merges --format='%ad %ae %s' 2019-02-28 iannucci@chromium.org [led] Roll back to cc015d8903532826f4430b87501a3c542ef468ce. Created with: gclient setdep -r src/third_party/depot_tools@5117888302cf The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:936254 TBR=agable@chromium.org Change-Id: I6939abe7d0d1b247145dbda437177f52ca468e19 Reviewed-on: https://chromium-review.googlesource.com/c/1496157Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636617}
-
Ken Rockot authored
Introduces new bindings types described by https://docs.google.com/document/d/18pOsJOTuLVH-V7s9xwR-em9t-R4icyPjk7i8I8bfjjg/edit In summary: - Remote will replace InterfacePtr - PendingRemote will replace InterfacePtrInfo - PendingReceiver will replace InterfaceRequest - Receiver will replace Binding - mojom IDL will use pending_remote<T> and pending_receiver<T> to replace T and T& syntax. See the lone unittest.cc and .test-mojom files in this patch for working example usage. Bug: 875030 Change-Id: Id4b76599d4d6973661c80fa438b37b14d4b1e93a Reviewed-on: https://chromium-review.googlesource.com/c/1474844 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#636616}
-
Aran Gilman authored
Currently it only looks at the background color and does not check whether high contrast mode is enabled overall. Future CLs will add the ability to process and correctly classify background images. This code is not under platform/graphics with the existing high contrast code because it needs access to ComputedStyle and LayoutObject, and code in platform cannot depend on core. Follow-up CLs are planned to modify GraphicsContext::SetHighContrast() to take the return value of this function as a parameter. Bug: 925949 Change-Id: I79376205d5ee5d0b20a1138ffcf1568ac7bf0ae7 Reviewed-on: https://chromium-review.googlesource.com/c/1448988 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#636615}
-
Gyuyoung Kim authored
As a step to annotate the macros of Allocator for the Onion Soup, this CL annotates some classes of //third_party/blink/renderer/platform/font with the macros of Allocator. After some analyzes, it was concluded that for the case of FontFallbackList, FontGlobalContext, FontSelectionValue, FontUniqueNameLookup, OpenTypeVerticalData, ShapeResult, and UnicodeRangeSet classes, they make sense to use USING_FAST_MALLOC because they have been used with smart pointers. In HarfBuzzShaper class, it makes sense to use DISALLOW_NEW because it's used as a member variable with a reference type. Bug: 919389 Change-Id: Ia03ab46b86af39f6cb5a2d5161a7cb0809ddebb7 Reviewed-on: https://chromium-review.googlesource.com/c/1491879Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#636614}
-
- 28 Feb, 2019 27 commits
-
-
Aaron Krajeski authored
From: https://html.spec.whatwg.org/multipage/canvas.html: """ When the ImageData() constructor is invoked with its first argument being an Uint8ClampedArray source and its second and optional third arguments being numeric arguments sw and sh, it must run these steps: 1. Let length be the number of bytes in source. 2. If length is not a nonzero integral multiple of four, then throw an "InvalidStateError" DOMException. """ Previously we were throwing an IndexSizeError. Change the error type to match the spec. Bug: 934838 Change-Id: Id122dcbae49426c3c10bf690f8bf940bbf481fc7 Reviewed-on: https://chromium-review.googlesource.com/c/1495195 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
-
Harley Li authored
This is a reland of 3dc09a0d Original change's description: > [DevTools] Application>Clear Site Data: stop service worker when unregistering it > > We should stop the service worker before unregistering it. > > Originally, clicking "Clear site data" will unregister the service worker. In > Application>Service Workers, the service worker's tab title is marked as > "deleted", but its "status" says it's still running. > > Bug: 894783 > Change-Id: Ib1550cfab8274a27495bb795501f54e9a19f6a36 > Reviewed-on: https://chromium-review.googlesource.com/c/1480725 > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635263} Bug: 894783 Change-Id: I4b1b9a2f3764391846e47f8752cab6e223adbb1d Reviewed-on: https://chromium-review.googlesource.com/c/1490432Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Cr-Commit-Position: refs/heads/master@{#636612}
-
Kenichi Ishibashi authored
This seems flaky. Update TestExpectations. Tbr: nhiroki@chromium.org,falken@chromium.org Bug: 937048 Change-Id: Ibf0b0145af5eb891fa06a3759225cf8cd3ab2a6e Reviewed-on: https://chromium-review.googlesource.com/c/1496254Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#636611}
-
Gayane Petrosyan authored
This reverts commit dbf62e53. Reason for revert: Crash following ProfileResetter::ResetNtpCustomizations() call. Original change's description: > Reset NTP customizations when all settings are reset. > > Bug: 931806 > Change-Id: I89db8c24edfb9a7e1c4c6bf3ac3d0faa68d70ca1 > Reviewed-on: https://chromium-review.googlesource.com/c/1472450 > Commit-Queue: Gayane Petrosyan <gayane@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Ramya Nagarajan <ramyan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636087} TBR=engedy@chromium.org,gayane@chromium.org,ramyan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 936830 Change-Id: Ib81b7839c10f6bd7e75b438c2f98b015e866d4a5 Reviewed-on: https://chromium-review.googlesource.com/c/1495749Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#636610}
-
Richard Knoll authored
This is now fixed after crrev.com/c/1489297. Bug: 910524 Change-Id: Ie04d3e299d99ace61d7e7832661648231dc7797f Reviewed-on: https://chromium-review.googlesource.com/c/1491554Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#636609}
-
Michael Martis authored
This CL switches out our usage of base::JSONReader for the data decoder service (in another process on desktop Chrome), which is safer for parsing JSON returned from an external server. Bug: 916420 Change-Id: I3cb9b20af19064cfa877d88f06baeb417322f0a0 Reviewed-on: https://chromium-review.googlesource.com/c/1491068Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#636608}
-
Manu Cornet authored
Bug: 933044 Change-Id: Ibeb706b1ea2aa91a4ddd6dd83bff35cb05139f4c Reviewed-on: https://chromium-review.googlesource.com/c/1492039Reviewed-by:
-
Jonathan Backer authored
DirectContextProvider shares a GL context with SkiaRenderer. Both of these have GL state trackers that don't know anything about each other. ScopedUseContextProvider is responsible for keeping the state trackers consistent. These changes were necessary to make my reuse of GLRenderer color conversion work. I believe that GLRendererCopier has similar requirements, but that we got lucky with timing and bugs did not manifest. Change-Id: I9ac64f51498df0518aeac296ef2bea8fd156d635 Reviewed-on: https://chromium-review.googlesource.com/c/1495196Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#636606}
-
Jeffrey Cohen authored
Bug: 910390 Change-Id: I04bb4593152a3b7fd418fe836d755f176a19533b Reviewed-on: https://chromium-review.googlesource.com/c/1481583 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#636605}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/67e3f02c..96fc7ac1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I266b7442de64e5224f8afe3d3c56c924b150e84b Reviewed-on: https://chromium-review.googlesource.com/c/1495794Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636604}
-
Steven Bennetts authored
NetworkHandler uses Shill service paths to identify network services, but the forthcoming mojo API and the rest of the UI code uses GUID so this code needs to switch to GUID to support the mojo API. Bug: 923444 Change-Id: I739b36762b6f380ae70e054eba9284bad2773ba9 Reviewed-on: https://chromium-review.googlesource.com/c/1470939 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#636603}
-
Jon Kunkee authored
Specific tools need to run on the test-initiating machines instead of the build host or the build target. Since GN does not provide a third toolchain designation for this, it needs to be calculated in the exceptional cases that need it. This CL adds this logic for imagediff. Bug: 893460 Change-Id: I07f7a39971f47517550fc4edc0922f4b15eb87e5 Reviewed-on: https://chromium-review.googlesource.com/c/1489484 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#636602}
-
Ryan Sturm authored
This is being launched to 100% of stable after this CL lands. Bug: 914029 Change-Id: Iecaeaa54fa404c9f25ae2d8172a3a620ff4533a9 Reviewed-on: https://chromium-review.googlesource.com/c/1490732Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#636601}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/72565d358a64..a365aff3ed0b Created with: gclient setdep -r src-internal@a365aff3ed0b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:790200,chromium:790185,chromium:790192,chromium:790194,chromium:790196,chromium:790229 TBR=mmoss@chromium.org Change-Id: I88faf5b2a64cf39fb8140c67dc7f7d6f589401f4 Reviewed-on: https://chromium-review.googlesource.com/c/1494830Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636600}
-
Lukasz Anforowicz authored
Bug: 935094, 936887 Change-Id: Ie1df72cc3638f3bfd3ce22f1af26ab40bd1fa2ca Reviewed-on: https://chromium-review.googlesource.com/c/1495795 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#636599}
-
Matt Falkenhagen authored
Heavily based on an original CL by Charles Vazac <cvazac@akamai.com> at https://chromium-review.googlesource.com/c/chromium/src/+/1396938 Service worker navigation preload[1] is a web platform feature that involves sending a request to network at the same time as starting up the service worker for a navigation. This network request was not visible to extensions. This CL: - Modifies the network service path for service worker navigation preload requests so that the embedder is aware of them. - In web_request_permissions.cc, if a request is not considered a browser side navigation, it becomes opaque to extensions. This CL makes it so that service worker navigation preload requests[1] are exempted from that. This CL deletes the unit test for navigation preload in ServiceWorkerNavigationLoaderTest. It was too much hassle getting that to work with a TestWebContents because the infrastructure for enabling NetworkService in content_unittests is not set up yet so unittest_test_suite.cc typically disables NetworkService (issue 901092). We have sufficient navigation preload test coverage in browser tests and web tests. [1] https://w3c.github.io/ServiceWorker/#navigationpreloadmanager Bug: 914062 Change-Id: I4c91521e55c1103a1a67d973e595094b78357c34 Reviewed-on: https://chromium-review.googlesource.com/c/1491168Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#636598}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/25fb765367e1..b8a4d688f907 git log 25fb765367e1..b8a4d688f907 --date=short --no-merges --format='%ad %ae %s' 2019-02-28 srte@webrtc.org Allow injection of task queue factory in RtcEventLog. 2019-02-28 crodbro@webrtc.org Add bandwidth floor for RTT based backoff. 2019-02-28 Peter) Slatala Fix: Ignore empty frames in Media Transport 2019-02-28 jakobi@webrtc.org Fix jitter buffer delay reporting. 2019-02-28 titovartem@google.com Add construtor from required fields for VideoConfig in PC E2E framework 2019-02-28 titovartem@google.com Add stream label to audio streams in PC E2E framework 2019-02-28 mbonadei@webrtc.org [clang-tidy] Apply bugprone-argument-comment fixes. 2019-02-28 jakobi@webrtc.org Cleanup NetEqPostponeDecodingAfterExpand field trial. 2019-02-28 tzik@chromium.org Add a presubmit check for absl/memory/memory.h inclusion for WrapUnique 2019-02-28 phensman@webrtc.org Only draw frames with height and width >0 2019-02-28 hbos@webrtc.org Reland "Fix getStats() freeze bug affecting Chromium but not WebRTC standalone." Created with: gclient setdep -r src/third_party/webrtc@b8a4d688f907 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:752720,chromium:850907 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8c1452c4d47a55a1108abd1fd485111ade528aca Reviewed-on: https://chromium-review.googlesource.com/c/1495298Reviewed-by:
-
Aaron Krajeski authored
Bug: 851810 Change-Id: I92b6b76d47c1fed6e10721737e09fcc6277093a8 Reviewed-on: https://chromium-review.googlesource.com/c/1496001 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f6d776ff4a4a..00b1f1e2a50e git log f6d776ff4a4a..00b1f1e2a50e --date=short --no-merges --format='%ad %ae %s' 2019-02-28 saklein@chromium.org Build API: Recommend services when unrecognized value provided 2019-02-28 fqj@chromium.org cros deploy: set selinux to permissive. 2019-02-28 athilenius@google.com Upgrade chromite/third_party/httplib2 to 0.10.3 2019-02-28 dgarrett@google.com test_builders: chromite-pre-cq re-enable CidbIntrationTest. 2019-02-28 dhanyaganesh@chromium.org scripts/summarize_build_status: Delete the unused script 2019-02-28 dhanyaganesh@chromium.org CommitQueueSyncStage: Cleanup Git folder before fetch --all. 2019-02-28 xianuowang@chromium.org paygen: Double timeout of paygen suites. 2019-02-28 nednguyen@google.com chromite: update chromite OWNERS 2019-02-28 seanabraham@chromium.org test_reqs: Removing target test reqs from chromite. 2019-02-28 seanabraham@chromium.org testingconfig: Make a single "requirements" field rather than having 5 Created with: gclient setdep -r src/third_party/chromite@00b1f1e2a50e The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I5b769f5c2087fa01057b8cd42b96d2ff6340e580 Reviewed-on: https://chromium-review.googlesource.com/c/1496035Reviewed-by:
-
Matt Mueller authored
DnsProbeService becomes a BrowserContextKeyedService instead of an IOThread global. Bug: 874660 Change-Id: I18f03205b215f67b65efc6cbc3c5068bcf674058 Reviewed-on: https://chromium-review.googlesource.com/c/1471256Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
-
Darwin Huang authored
- Chromium doesn't need compat/ and fossil/. - Use variable to avoid hardcoded version. - The year is now 2019 (only used once so this should be ok). Bug: 936694 Change-Id: If01ba58755bc692d6104f525cbc496ad628901d1 Reviewed-on: https://chromium-review.googlesource.com/c/1493263 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#636593}
-
Lowell Manners authored
Change-Id: I66dec126821fe0b3e16563241bc3432671a18486 Reviewed-on: https://chromium-review.googlesource.com/c/1477065 Commit-Queue: Sam McNally <sammc@chromium.org> Auto-Submit: Lowell Manners <lowell@chromium.org> Reviewed-by:
-
David Bertoni authored
Change-Id: I93d9fb18100b46ba84aad03303129bd28409fba8 Reviewed-on: https://chromium-review.googlesource.com/c/1473838 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#636591}
-
Evan Stade authored
These tests would often fail when run in parallel, but would always pass in isolation. This change fixes the tests via proper use of SetUp and TearDown, and moves some initialization of EasyUnlockServiceRegular from the ctor to InitializeInternal(). This also removes some virtual method calls from the ctor, as per the style guide: "Constructors should never call virtual functions" Bug: none Change-Id: Ibdb8628778105ed242c137ffa5ee12ffa018b06e Reviewed-on: https://chromium-review.googlesource.com/c/1493072 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#636590}
-
David Bienvenu authored
Use GetSystemMetrics(SM_X/Y/CV/CYVIRTUALSCREEN) to get rect of virtual screen and clip app window rect by virtual screen rect to handle occlusion of windows partly off screen. Bug: 532128, 813093 Change-Id: I23e96ceb17deea6a16ade5780203112c218e640c Reviewed-on: https://chromium-review.googlesource.com/c/1484492Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#636589}
-
Adrienne Walker authored
This is a followup to: https://chromium-review.googlesource.com/c/1444234 That previous patch worked, but only if --enable-oop-rasterization was passed on the command line. For finch and field trials, it's decided much later in gpu_util.cc that oop raster should be turned on and so the passthrough raster decoder needs to be enabled earlier. Bug: 627621 Change-Id: Ibe32cf715bca65faabc76954c46765ba3c18418d Reviewed-on: https://chromium-review.googlesource.com/c/1487143 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#636588}
-
Paul Dyson authored
When choosing the apps to send as negative examples, prefer to send data from apps that have already been clicked on. These will have data more useful for training. Bug: 899123 Change-Id: I79973f0ca67fe8f6104dae5850125726bae0567d Reviewed-on: https://chromium-review.googlesource.com/c/1491151Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Paul Dyson <pdyson@chromium.org> Cr-Commit-Position: refs/heads/master@{#636587}
-
