- 23 Sep, 2019 40 commits
-
-
Dan Beam authored
Relevant style guidance: https://bit.ly/cr-cpp-do-dont#use-and-instead-of-bare Noticed while investigating https://crbug.com/1006619 but not really related. R=dpapad@chromium.org BUG=none Change-Id: Ia13d8fa63bed5d4958ce0de57811be5b92dae915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818464 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#699085}
-
Richard Knoll authored
This adds UMA to track the actual display delay of notifications with show triggers. Bug: 891339 Change-Id: I8263b9b50df06eabb38079641069863d74d26327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801758Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#699084}
-
Alex Turner authored
Currently the owner of NavigationPredictorAnchorElementMetrics and NavigationPredictorPageLinkMetrics is a chromium.*com* not chromium.org email address and there is no listed owner of NavigationPredictorPageLinkClick. Bug: 1005467 Change-Id: I904a148b94e232d243369c27292e3ba8a5964b5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811838Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b3542d95da65..4dd7c01ca87e git log b3542d95da65..4dd7c01ca87e --date=short --no-merges --format='%ad %ae %s' 2019-09-23 jvanverth@google.com Use safe computation for adding up YUVASizeInfo total bytes Created with: gclient setdep -r src/third_party/skia@4dd7c01ca87e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: If5bebc91e7b41a6c0a9dddc2959477d6de187614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819899Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699082}
-
George Steel authored
Fix filenames of manual tests in external/wpt/css/css-transitions to include the proper -manual.html suffix instead of the legcy meta tag. Move their TextExpectations entries to NeverFixTests with the other manual tests. Bug: 626703 Change-Id: I93ad061f8b88dfc3abc7837c93d347b63de7bc61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795631 Commit-Queue: George Steel <gtsteel@chromium.org> Auto-Submit: George Steel <gtsteel@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#699081}
-
Andrew Grieve authored
Change-Id: Ib441c5bd3ce3dec875e3403d8bf7eb1512dfdbbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819349Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#699080}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fdb59f0d9088..6f18e68719fc git log fdb59f0d9088..6f18e68719fc --date=short --no-merges --format='%ad %ae %s' 2019-09-23 ehmaldonado@chromium.org gclient: Execute python hooks using vpython. Created with: gclient setdep -r src/third_party/depot_tools@6f18e68719fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I98535285f4fb1fe1a01b56f5b54e414896ccb410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819900Reviewed-by:
-
David Black authored
Hover changed events may be propagated during the widget close sequence. Previously, this could cause us to schedule a timer to auto- close the proactive suggestions view which would crash when firing due to the widget no longer existing. Bug: b:141386438 Change-Id: Ia2a2cf8ba11c9f1209df857edccbd160e1be45c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817762Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#699078}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/4edb70c11cc5..c5b0621faea0 git log 4edb70c11cc5..c5b0621faea0 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 rharrison@google.com Add --update_known_failures to spvc test script (#813) Created with: gclient setdep -r src/third_party/shaderc/src@c5b0621faea0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I0072a163189c6a3a72b134c1f3cd325de4ce2a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817775Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/112a550769c4..cbf54891be66 Created with: gclient setdep -r src-internal@cbf54891be66 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: If5995481d935803c1a2390a28682e868416ffa3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817768Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699076}
-
Maksym Onufriienko authored
Example of test run on iOS 13.0 real device https://ci.chromium.org/p/chrome/builders/try/iphone-device/166 This cl depends on http://crrev/c/1802023 that enables test output in console. Bug: 1001667 Change-Id: I95ae522be3ba573d6c2d5c7d74956e315cb8be8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793126 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#699075}
-
Emily Stark authored
When an HTTP auth prompt is cancelled, we close the prompt and refresh the page to retrieve the 401 error body from the server. There is some logic in LoginNavigationThrottle/LoginTabHelper that tracks/detects these refreshes to handle them specially, i.e. not re-show an auth prompt when the refresh commits. This logic was looking at NavigationController:GetVisibleEntry() to determine when an observed navigation was one of these refresh navigations -- but a visible entry is not always guaranteed to exist, leading to crashes. One correct fix would be to check for a null visible entry, but instead we now look at the pending entry. This is more specific because the pending entry is the one that would be for the refresh. Note: this fix relies on the assumption that GetPendingEntry() will always be non-null during a main-frame WillProcessResponse(). I think this condition is guaranteed, but if I'm wrong, it will show up as crashes when dereferencing GetPendingEntry(). In that case we'll need to add a check for a null GetPendingEntry(). Bug: 1005096 Change-Id: If4a72ca903e14da588c0ee515648e8d2694f8612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819331 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#699074}
-
Rakib M. Hasan authored
These operations don't depend on the reference files, therefore we don't need to look for these args for each reference file. Bug: chromium:982208 Change-Id: Ie3ffe4491d3ff5f23ccc087b60e6bb969c02bfa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817774Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#699073}
-
Brian Sheedy authored
Adds the necessary data dependencies for Telemetry ChromeOS stack symbolization to work on the bots and re-enables the stack symbolization tests on ChromeOS. Also adds support for ChromeOS to generage_breakpad_symbols.py, which is the same as Android. This is necessary because Android and ChromeOS need to use readelf instead of ldd due to potentially different architectures between the host and device. Bug: 978952 Change-Id: Ic143d8a9d233c324a1e4fd20463c9ce2ffeec40a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790330 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#699072}
-
dpapad authored
Replacing with 'on-cilck' and click() respectively. Bug: 812035 Change-Id: Iaa2a1dc8a6b528b2cdfdb410601ea742c374757d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819109 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#699071}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1f89f58faeb8..e3a5983705da git log 1f89f58faeb8..e3a5983705da --date=short --no-merges --format='%ad %ae %s' 2019-09-23 swiftshader.regress@gmail.com Regres: Update test lists @ 1f89f58f Created with: gclient setdep -r src/third_party/swiftshader@e3a5983705da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: Id366060c5330d71bb69eaaeb8883bc82ed13298f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817773Reviewed-by:
-
Junyi Xiao authored
Issue: Default focus is not seen when select a tab from dropdown menu Fix: focus to the tab view after select a tab from dropdown Bug: 1004171 Change-Id: If63e10d7b3cadcc50fb69fa7f775f478aa258987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807703Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Junyi Xiao <juxiao@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699069}
-
Renjie Tang authored
Change-Id: Id3f3e3ff411b313fd9c7db14a485a746818d8a6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815979Reviewed-by:
Renjie Tang <renjietang@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#699068}
-
Steven Bennetts authored
This is developer debugging UI only, and a subtle use cases that I only noticed when investigating a bug where a Cellular device property is not getting set by Shill. (The information is still available in chrome://system and in feedback reports). Bug: none Change-Id: I6435435c0ccf7cfd1608635631c0f6311c30fc34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815547 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#699067}
-
David Schinazi authored
Change-Id: I7f802b043365e99e69a02385d3ecace4d4116a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819634 Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/c094391e954a..b8d86733e9d9 $ git log c094391e9..b8d86733e --date=short --no-merges --format='%ad %ae %s' 2019-09-20 marpan vp9-svc: Fix to forced key frame for spatial layers 2019-09-18 angiebird Remove redundant comment 2019-09-17 angiebird Move vp9_alloc_motion_field_info 2019-09-13 jianj Fix msan on svc tests. 2019-09-10 jzern vp9_quantize_sse2: quiet clang-7 integer sanitizer warning Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: Ibb8d76c787e652df8646253b2ebc48ab0ffcb2c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819328Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#699065}
-
Lei Zhang authored
It is only ever used within popup_blocker.cc. Change-Id: I514eac14d05c8b844242ed93693841c291af4966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817661Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#699064}
-
dpapad authored
Specifically: - Replace MockInteractions.tap() with a click() call. - Replace Polymer.Base.create() with document.createElement(). This is in preparation of migrating to Polymer3, where every dependency needs to be imported as a module. Bug: 1005029 Change-Id: I87b07d59b69df69258b2d7a1492cea014e053768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819678Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#699063}
-
Tommy Steimel authored
This CL modifies the MediaToolbarButtonView to check for a Widget before updating its icons. This prevents a crash where the button would try to read theme data from the Widget after it was gone. In addition, this CL changes the logic for updating the icon on enable/disable to only happen on Mac, since Mac is the only OS where the icon can change from enabling/disabling. Bug: 1006359 Change-Id: I009d5e5e921982be2628ce51f0488c463985dd58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815904Reviewed-by:
Jazz Xu <jazzhsu@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#699062}
-
Xiaohan Wang authored
This tests the case where MojoRenderer::SetCdm() is called with a CDM ID where the CDM has already been released. Bug: 1004730 Test: Add a unittest. Change-Id: Ia400ccdfac74fb6153c46ba3b216c325b8ea2327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819624Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#699061}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d46cabd73fb4..27a35eb2a938 git log d46cabd73fb4..27a35eb2a938 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 rharrison@chromium.org Rolling 3 dependencies Created with: gclient setdep -r src/third_party/dawn@27a35eb2a938 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I094b03cf175f4478ae59fd45c3d130123b6f64db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817771Reviewed-by:
-
Peter Kasting authored
This reverts commit 1a82123e. Reason for revert: Breaks tooltips: http://crbug.com/1006751 Original change's description: > Fix the |accept_events| InitParam to work on Windows. > > WS_EX_TRANSPARENT only seems to mean "pass events to the underlying window" when > the windows in question is also WS_EX_LAYERED. > > Bug: 1004721 > Change-Id: Ia2618ddfa9c16a49fd8eb156ab0c7793736bce0d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816745 > Auto-Submit: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698569} TBR=pkasting@chromium.org,robliao@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1004721,1006751 Change-Id: I41b3b9776cc53e926831d98babd669a189e447ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819937Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#699059}
-
Jiawei Li authored
This reverts commit d08541bb. Reason for revert: In favor of focusing on supporting Linux build for now. Original change's description: > [chromecast] Add bindings_manager_cast target for Android build > > Previously, bindings_manager_cast target was guarded by is_linux. This > should be available for all non-fuchsia builds. > > Bug: internal b/141398875 > Test: CQ > Change-Id: I21d95c65040956dd4446eff61dbd50acbb3f4e20 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815949 > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Yuchen Liu <yucliu@chromium.org> > Commit-Queue: Jiawei Li <lijiawei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699041} TBR=kmarshall@chromium.org,yucliu@chromium.org,lijiawei@chromium.org Change-Id: I6d42eb1f3bfa79904cc5c0b39576e47c409ff30f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: internal b/141398875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818465 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Auto-Submit: Jiawei Li <lijiawei@chromium.org> Cr-Commit-Position: refs/heads/master@{#699058}
-
Akihiro Ota authored
This change adds a hotkey in ChromeVox that allows the user to get the phonetic disambiguation for the current word in the node's name. If the user is on a node, then we speak the first word in the node's name. Upon activation, ChromeVox speaks each character in the word, followed by its phonetic disambiguation. Change-Id: I1a88c3256cf1084a971f6fc7fc47d5bfe847ab11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811988Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#699057}
-
Tarun Bansal authored
Add a navigation predictor keyed service that is notified of the new predictions about the next navigations. The keyed service exposes Observer interface which allows other observers to subscribe to the notifications from the keyed service. The next CL would add observers that would listen to the notifications and take actions. Change-Id: I8ded320cdf15c1d0120a64c2434f7b0d5d7b7da9 Bug: 1004465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816905Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#699056}
-
Robert Ogden authored
Functionality is now subsumed by the original feature Bug: 1005295 Change-Id: Ia9894cbdcc33d37e1f9de53952443e53afe9f83a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819819Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#699055}
-
Alex Moshchuk authored
Bug: 1004371 Change-Id: I62c91186f046b6701c8fdd1fded90f38d45188c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817286Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#699054}
-
Anastasia Helfinstein authored
This addresses a bug in Switch Access (go/cros-switch) where users got stuck in editable text fields. The root cause was that the physical key events were perceived to be virtual key events by the Switch Access event handler. The solution is to more precisely identify which key events come from physical devices. Bug: 996893 Change-Id: Id39130ce7edc7f933c1be43f434b5a08f909f19f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804395 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#699053}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d239d4d3493a..55783c1d0403 git log d239d4d3493a..55783c1d0403 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 chiur@google.com Merge "Add gpu_track_tracker to prevent repeated GPU tracks" Created with: gclient setdep -r src/third_party/perfetto@55783c1d0403 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I851bfc054b0b8c88d2ff53de887fd7c0c0e116ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817766Reviewed-by:
-
Matt Mueller authored
Provides a more concise method for creating an X509Certificate with the necessary intermediate(s). Change-Id: I20d1cedbc7ee177b27871e460b1db56aec8f4e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815994 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#699051}
-
Kurt Catti-Schmidt authored
The following CL set up a pipeline to send a map of the system colors from the browser process to the render process: https://chromium-review.googlesource.com/c/chromium/src/+/1728056 This change takes those system colors and uses them in LayoutThemeWin::SystemColor(). This replaces the old logic of making API calls to get the system colors. LayoutThemeWin accesses the system colors stored in NativeTheme through WebThemeEngineDefault. Unit tests were added for conversions between Blink and NativeTheme types. This required pulling the static conversion methods into their own header. Bug: 970285 Change-Id: I842e5224aa3a97852eda13c3d86f90396262fde9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793742 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699050}
-
Alexei Filippov authored
There's no change to semantics. - got rid of ref-counted MostVisitedThreadSafe - made extensive use of movable vectors BUG=1006830 Change-Id: Iba70c2955f01ceaeac8771ca93af2258829f02a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819037Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#699049}
-
Yuly Novikov authored
deqp/functional/gles3/shaderstruct.html Flaky on Linux NVIDIA GL passthrough as well. TBR=kbr Bug: 965648 Change-Id: I6baa0c314a4aa2839cd9c9ae59470720cc7c5c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819519Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#699048}
-
Esmael El-Moslimany authored
In this CL: - changed cr-icon-button to use -webkit-mask-image instead of background-image to make it easy to change the color of image icons - added an attribute 'a11y-enhanced' to <html> for settings, bookmarks, history, extensions, print preview and downloads when the WebUIA11yEnhancements flag is enabled - removed the style that hides 'subpage-arrow' and 'icon-external' since it is not really used and causes issues with the cr-icon-button (it sets the display to block instead of inline-flex) - fixed cr-link-row where it was using that no longer available 'iconClass' property - moved the background image icon inside of cr-icon-button because when it is used as a mask on the :host, the ripple would also be masked - when 'a11y-enhanced' attribute is set on <html>, make the cr-icon-button ripple opaque and change the color of the icon to the background color when a ripple is shown Bug: 1001742 Change-Id: Ia6d7f7c951003e440e7bca1cccf81ab849d98732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769586Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Michael Thiessen authored
Note that this is a speculative fix as I was unable to repro, but see the bug for context - I'm pretty certain this will fix the crash. This introduces NavigationController::RemoveForwardEntries which will attempt to remove any forward navigation entries (without crashing :)). Bug: 963783 Change-Id: Ic375e0e4fd89d4ded3a5229bf82ccb932e10ab5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775070 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#699046}
-
