- 21 Apr, 2016 30 commits
-
-
danakj authored
Replace the GLInProcessContextSharedMemoryLimits class with our new SharedMemoryLimits class, so we can share implementations and defaults. R=boliu@chromium.org, piman@chromium.org BUG=584497 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1898033005 Cr-Commit-Position: refs/heads/master@{#388633}
-
xhwang authored
Review URL: https://codereview.chromium.org/1905473002 Cr-Commit-Position: refs/heads/master@{#388632}
-
hcarmona authored
BUG=546836 Review URL: https://codereview.chromium.org/1900233005 Cr-Commit-Position: refs/heads/master@{#388631}
-
danakj authored
The android browser compositor doesn't have a raster worker context so there's no other context in the group to share with. R=piman, sievers BUG=584497 Review URL: https://codereview.chromium.org/1900713006 Cr-Commit-Position: refs/heads/master@{#388630}
-
dbeam authored
This code was originally written for the New Tab Page[1], which should always be clobbered by a link click. The NTP no longer shows promos (which is why it used parseHtmlSubset()), and other WebUI pages like settings use target="_blank", so allow target="_blank" globally. R=tommycli@chromium.org BUG=605226 [1] https://codereview.chromium.org/1759007, https://crbug.com/29084 Review URL: https://codereview.chromium.org/1907653002 Cr-Commit-Position: refs/heads/master@{#388629}
-
danakj authored
This context is used by canvas and video, which speak to the compositor through mailboxes. R=piman, sievers BUG=584497 Review URL: https://codereview.chromium.org/1903863003 Cr-Commit-Position: refs/heads/master@{#388628}
-
victorhsieh authored
Not sure this is correct behavior, but this should make the build green. BUG=b/27779397,574241 TEST=ninja Review URL: https://codereview.chromium.org/1907593003 Cr-Commit-Position: refs/heads/master@{#388627}
-
dmurph authored
This helps us get to the bottom of where the invalid blob refcount and url calls are. It's unclear whether these are new or if they've always occurred, as we used to ignore these messages. R=kinuko@chromium.org, mpearson@chromium.org BUG=602443 Review URL: https://codereview.chromium.org/1893293006 Cr-Commit-Position: refs/heads/master@{#388626}
-
dcheng authored
BUG=554298 R=erg@chromium.org Review URL: https://codereview.chromium.org/1906623003 Cr-Commit-Position: refs/heads/master@{#388625}
-
danakj authored
R=jbroman, thakis@chromium.org BUG=604860 Review URL: https://codereview.chromium.org/1897863006 Cr-Commit-Position: refs/heads/master@{#388624}
-
dcheng authored
BUG=554298 R=isherman@chromium.org Review URL: https://codereview.chromium.org/1912433002 Cr-Commit-Position: refs/heads/master@{#388623}
-
kinuko authored
BUG=n/a Review URL: https://codereview.chromium.org/1901473007 Cr-Commit-Position: refs/heads/master@{#388622}
-
eroman authored
Review URL: https://codereview.chromium.org/1907643002 Cr-Commit-Position: refs/heads/master@{#388621}
-
jrummell authored
Add some needed dependencies. BUG=599578 Review URL: https://codereview.chromium.org/1902493002 Cr-Commit-Position: refs/heads/master@{#388620}
-
bokan authored
These layout tests were skipped on Mac since it used to be impossible to enable scroll animations on a per-test basis in Mac. This was fixed in r376025 so these tests should be able to run now. BUG=364614 Review URL: https://codereview.chromium.org/1897973006 Cr-Commit-Position: refs/heads/master@{#388619}
-
danakj authored
Everything goes through mailboxes when used with this context. R=piman@chromium.org BUG=584497 Review URL: https://codereview.chromium.org/1898423005 Cr-Commit-Position: refs/heads/master@{#388618}
-
rdevlin.cronin authored
BUG=None Review URL: https://codereview.chromium.org/1905783002 Cr-Commit-Position: refs/heads/master@{#388617}
-
dcheng authored
BUG=554298 Review URL: https://codereview.chromium.org/1902873002 Cr-Commit-Position: refs/heads/master@{#388616}
-
dskiba authored
The original CL (1891543003) was reverted because it broke Windows x64 build: heap_profiler_allocation_context.cc(58): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data This CL adds necessary cast to avoid the warning. Original issue's description: > [tracing] Turn StackFrame into struct. > > This change turns StackFrame (aka const char*) into a struct and > introduces 'type' field which controls how stack frame is formatted > when it's written to trace file. As an example, thread name, which > previously was just a string like any other function name, is now > formatted as '[Thread: %s]'. > > More stack frame types will be added in the future, for example > native allocation tracing will add 'program counter' type. > BUG=602701 TBR=primiano@chromium.org Review URL: https://codereview.chromium.org/1904823002 Cr-Commit-Position: refs/heads/master@{#388615}
-
dtu authored
Sometimes, a machine goes down, but the waterfall stays green. We want the perfbot health sheriffs to watch out for these kinds of failures. Review URL: https://codereview.chromium.org/1903913002 Cr-Commit-Position: refs/heads/master@{#388614}
-
pilgrim authored
There was one reference to Document::layoutView() (hitTest() method) which is deprecated by the new layout API. I converted it to use layoutViewItem() instead. No new API methods were required. There are no functional changes. BUG=499321 Review URL: https://codereview.chromium.org/1908573003 Cr-Commit-Position: refs/heads/master@{#388613}
-
leilei authored
BUG= Review URL: https://codereview.chromium.org/1896363003 Cr-Commit-Position: refs/heads/master@{#388612}
-
emircan authored
Additional to the original, this CL checks for >=OSX10.9 in content/common/gpu/media/vt_video_encode_accelerator_mac.cc since VideoToolbox HW features are introduced there. The original CL got reverted because of a failure on a bot running 10.8.5. https://developer.apple.com/library/mac/releasenotes/General/APIDiffsMacOSX10_9/VideoToolbox.html Original CL description: https://codereview.chromium.org/1852523002/ This CL enables using VideoToolbox encoder when kWebRtcH264WithOpenH264FFmpeg flag is on. BUG=597334 TBR=mcasas@chromium.org, hbos@chromium.org Review URL: https://codereview.chromium.org/1886363002 Cr-Commit-Position: refs/heads/master@{#388611}
-
dcheng authored
BUG=554298 R=ben@chromium.org,jam@chromium.org Review URL: https://codereview.chromium.org/1910673002 Cr-Commit-Position: refs/heads/master@{#388610}
-
pmonette authored
On Windows 8, now make sure the required registry key exist so that Chrome is always given as an option when poping the intent picker. On Windows 10, now shows the system settings to the user to set the default handler for a given protocol. Also fixed a small UI issue. BUG=562671 Review URL: https://codereview.chromium.org/1896513002 Cr-Commit-Position: refs/heads/master@{#388609}
-
gogerald authored
This CL adds Google Activity Controls preference in setting sign in account management screen and an icon for sync preference. BUG=595349 Review URL: https://codereview.chromium.org/1880203002 Cr-Commit-Position: refs/heads/master@{#388608}
-
zmo authored
The first step to emulate ES3 BindBufferRange semantics on Desktop GL 4.1 or lower. BUG=604436 TEST=gpu_unittests R=piman@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review URL: https://codereview.chromium.org/1905743002 Cr-Commit-Position: refs/heads/master@{#388607}
-
sky authored
If someone adds a resource then it should be in the ResourceBundle. BUG=none TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/1905553003 Cr-Commit-Position: refs/heads/master@{#388606}
-
danakj authored
This function is not called. R=piman, sievers Review URL: https://codereview.chromium.org/1906693002 Cr-Commit-Position: refs/heads/master@{#388605}
-
rkc authored
Currently we have only one type of BluetoothGattService, BluetoothGattCharacterstic and BluetoothGattDescriptor. Each of these objects have significantly divergent functionality depending on whether they are objects representing a remote or local version. For example, ReadRemoteValue or WriteRemoteValue makes no sense on a local characteristic. Similarly, delegates for receiving read/write requests for characteristics and descriptors doesn't make any sense for a remote service. Trying to accomodate this led to very ugly code with lots of NOTIMPLEMENTED()s, varying implementations of the same code and a lot of repeated but unused code. Seperating these out into remote and local interfaces allows us to have platform specific implementations which only contain code relevant to remote and local objects (with common implementation deriving the common interface). This is just a refactor with no actual code change. To keep reviewing easier, any fixes to the code that is being moved around is being reserved for other CLs. This CL also moves all BlueZ specific code into its own directory. We should do the same for other platforms too so the //device/bluetooth directory isn't as crowded. Reviews requested, OWNERS (should most probably be rubberstamps), chrome/browser/extensions/api/* - rockot components/arc/bluetooth/* - elijahtaylor,lhchavez components/proximity_auth/* - tbarzic scheib/ortuno for the general review. R=elijahtaylor@chromium.org, lhchavez@chromium.org, ortuno@chromium.org, rockot@chromium.org, scheib@chromium.org, tbarzic@chromium.org BUG=601935 Review URL: https://codereview.chromium.org/1898643002 Cr-Commit-Position: refs/heads/master@{#388604}
-
- 20 Apr, 2016 10 commits
-
-
dcheng authored
BUG=554298 R=tnagel@chromium.org Review URL: https://codereview.chromium.org/1902633006 Cr-Commit-Position: refs/heads/master@{#388603}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2a883daa..d48fa2bb Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1901103005 Cr-Commit-Position: refs/heads/master@{#388602}
-
thestig authored
Also fix some typos. Review URL: https://codereview.chromium.org/1900033005 Cr-Commit-Position: refs/heads/master@{#388601}
-
lambroslambrou authored
The swarming/isolate system copies the built remoting_me2me_host executable, preserving the filename, so make sure this script can still find it in tests. Review URL: https://codereview.chromium.org/1903503006 Cr-Commit-Position: refs/heads/master@{#388600}
-
dtseng authored
1. Some sites result in an accessibility tree as follows: link name=foo children=(heading, paragraph) We end up reading the link's name when reading the children (e.g. bar heading 1, foo link This becomes noisy across multiple instances of this structure across a page. The nameFromNode attribute only adds the name if it isn't computed based on the contents of the node. 2. Content editables containing spaces come through as non-breaking spaces. In particular, this is seen in Google Docs. Add the literal string for the space so we read it when navigating by character. TEST=navigate to sites containing links with complex children. Ensure we don't read the link's name. Navigate by character in Google Docs with braille mode on in chromeVox Next. Ensure we read the space. Review URL: https://codereview.chromium.org/1866043004 Cr-Commit-Position: refs/heads/master@{#388599}
-
skyostil authored
ContentLayerDelegate::paintContents() is being used as an alternate painting path by the rasterize and record microbenchmark. This benchmark can crash if any frame on the page is being throttled, because this way of painting doesn't enable throttling. This patch fixes that by enabling throttling, which also makes the benchmark more realistic since the real painting path also uses throttling. BUG=600377 TEST=tools/perf/run_benchmark rasterize_and_record_micro.top_25_smooth --browser=debug --story-filter=Blogger Review URL: https://codereview.chromium.org/1898813002 Cr-Commit-Position: refs/heads/master@{#388598}
-
estade authored
BUG=585312 Review URL: https://codereview.chromium.org/1894173002 Cr-Commit-Position: refs/heads/master@{#388597}
-
xyzzyz authored
For context, see https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/zJZPkxEFVxY For the things to look out for while reviewing this, see the doc https://docs.google.com/document/d/1qjSBV2ioi0mykAT1eSXuMaNqO0BIS-j1PeYfxT-TbW4/edit?usp=sharing BUG=597321 Review URL: https://codereview.chromium.org/1842653006 Cr-Commit-Position: refs/heads/master@{#388596}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/9134686fd9ce..650f9e9a2630 $ git log 9134686fd..650f9e9a2 --date=short --no-merges --format='%ad %ae %s' 2016-04-20 mtklein SkOnce: 2 bytes -> 1 byte CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=fmalita@google.com Review URL: https://codereview.chromium.org/1910483003 Cr-Commit-Position: refs/heads/master@{#388595}
-
stanisc authored
This test is for detecting an error caused by a compiler bug on Windows (which is now worked around by crrev.com/1878963005). I've verified that the test is failing without the workaround by temporarily undoing it (by switching the optimization from speed to size). BUG=599427 Review URL: https://codereview.chromium.org/1897383004 Cr-Commit-Position: refs/heads/master@{#388594}
-