- 19 Nov, 2020 40 commits
-
-
shivanigithub authored
This CL adds metrics to see the number of cache hits if the blink memory cache was per-document. Bug: 1129860 Change-Id: I8d9b969c0540b5e72b7b3343cbbfb5daeefe88b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543684Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#829222}
-
Wei Lee authored
This reverts commit c946338b. Reason for revert: Reland after fixing browser tests Original change's description: > Revert "Reland "[CCA] Run CCA as SWA by default"" > > This reverts commit 074c395f. > > Reason for revert: > > This patch landed in https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/21376, where three ~related `browser_test` items began failing consistently: > > * SystemFeaturesPolicyTest.DisableCameraAfterInstall > * SystemFeaturesPolicyTest.DisableCameraBeforeInstall > * ExtensionPolicyTest.ExtensionInstallBlocklistComponentApps > > These failures are really verbose, but it looks like the core is: > > ``` > ../../chrome/browser/policy/extension_policy_browsertest.cc:401: Failure > Value of: registry->enabled_extensions().GetByID(extension_misc::kCameraAppId) > Actual: false > Expected: true > ``` > > > > Original change's description: > > Reland "[CCA] Run CCA as SWA by default" > > > > This reverts commit 5dec0310. > > > > Reason for revert: LKGM update: crbug.com/1148527 > > > > Original change's description: > > > Revert "[CCA] Run CCA as SWA by default" > > > > > > This reverts commit 46b6fd15. > > > > > > Reason for revert: > > > > > > camera.CCAUISmoke.fake is failing on chromeos-eve-chrome and camera.CCAUI* is listed as test coverage for this CL, so I am speculating that it is the cause. See: > > > https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/11136 > > > > > > Original change's description: > > > > [CCA] Run CCA as SWA by default > > > > > > > > Bug: b/172345161 > > > > Test: tast run [DUT] camera.CCAUI* > > > > Change-Id: I10484c9263f3e4c560028aef272cd3db88c47b31 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509834 > > > > Commit-Queue: Wei Lee <wtlee@chromium.org> > > > > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > > > Auto-Submit: Wei Lee <wtlee@chromium.org> > > > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#825657} > > > > > > TBR=ortuno@chromium.org,wtlee@chromium.org > > > > > > Change-Id: I5464fbcd7f1a03cd157122ad66c6ee13ad111630 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: b/172345161 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529360 > > > Reviewed-by: Henrik Boström <hbos@chromium.org> > > > Commit-Queue: Henrik Boström <hbos@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#825818} > > > > TBR=hbos@chromium.org,ortuno@chromium.org,wtlee@chromium.org > > > > Bug: b/172345161 > > Change-Id: Ie6d18656a2b247d8eec260319594e7355337c5af > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547645 > > Reviewed-by: Wei Lee <wtlee@chromium.org> > > Reviewed-by: Shik Chen <shik@chromium.org> > > Commit-Queue: Wei Lee <wtlee@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#829079} > > TBR=shik@chromium.org,hbos@chromium.org,ortuno@chromium.org,wtlee@chromium.org > > Change-Id: I31ad4e34332a5c54a0a4bd2c2f98dfe7e6544016 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: b/172345161 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549842 > Reviewed-by: Mike West <mkwst@chromium.org> > Commit-Queue: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829154} TBR=shik@chromium.org,hbos@chromium.org,ortuno@chromium.org,mkwst@chromium.org,wtlee@chromium.org # Not skipping CQ checks because this is a reland. Bug: b/172345161 Change-Id: I752d3919a2e7de9a43c2e8271b7f8e83509db84f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549203Reviewed-by:
Wei Lee <wtlee@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#829221}
-
Vasiliy Telezhnikov authored
The histagram is expiring and we didn't use it as UMA for quite a while. This CL makes it LOCAL_HISTOGRAM instead of UMA_HISTOGRAM to be able to use in telemetry runs. Bug: 1140046f Change-Id: Ic15517035ca11fd6626632d38cf202b5e0600d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486115Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#829220}
-
Morten Stenshorne authored
Missing part of https://chromium-review.googlesource.com/c/chromium/src/+/2538266 I wish that linux_layout_tests_layout_ng_disabled were triggered a bit more often, but since it isn't, things like this are bound to happen. TBR=atotic@chromium.org Bug: 958381 Change-Id: I0570151bf2081d4b0e14d42036e340f3ab2e5af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549945Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#829219}
-
Michael Lippautz authored
Instead of relying on a non-GCed type for Oilpan, use a different type in the garabge-collected world and split the traits based on the allocator. All PA relevant types are provided in list_hash_set.h, whereas the garbage collected specializations are provided by heap_allocator.h. Switching to a regular GCed type for Oilpan allows for removing special handling in various traits. The following are removed: - HeapAllocator::Malloc; - Custom support for TraceListHashSetValue; - Custom support for trace traits; Bug: 1056170 Change-Id: I74e913a2b63e60e62018bb1303dd3345058b1ddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547240 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#829218}
-
Morten Stenshorne authored
TBR=ikilpatrick@chromium.org Change-Id: I52af661d52fbdb2a02a6dbc289c107a4a8619258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550201Reviewed-by:
-
Nick Diego Yamane authored
BUG=1148021 R=msisov@igalia.com Change-Id: Id3d0a8c9ea41c421cd4ae633709372e12a77c2b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546980 Auto-Submit: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Maksim Sisov (GMT+2) <msisov@igalia.com> Reviewed-by:
Maksim Sisov (GMT+2) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#829216}
-
Alice Wang authored
This CL breaks the dependency link between the signin package and incognito_interstitial package so that signin package will only depend on account_picker package and account_picker handles everything with incognito_interstitial for the web sign-in flow. Bug: 1149852 Change-Id: Ia4633989d9f66f35770249ddc96bd22183043f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544886Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#829215}
-
Tanmoy Mollik authored
Use AccountManagerTestRule to add accounts on the device to check that Signin Promos for that account is shown. Currently the tests just check generic promo. Bug: 1100895 Change-Id: Iea2f61943ca0c3545a02d95b812cac1a28ecbca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519456 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#829214}
-
Viktor Semeniuk authored
This change adds Password Edit feature for iOS to testing config. Bug: 1137475 Change-Id: I73e8f5daa44cdda5fc4c24bc37b57767f698e9e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545927Reviewed-by:
-
Fredrik Söderqvist authored
The RespectImageOrientationEnum and ImageClampingMode arguments are not used, so there's no need to pass them to this function. Drop them at the callsites and simplify. Also fix the Draw() declaration to mirror the definition for the names of some arguments. Ditto for DrawInternal(). Change-Id: Ie705162d9b984e2a9cc32628a109a7e1dc091bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549922 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#829212}
-
Saurabh Nijhara authored
The browser tests related to download directory policy are moved to a separated file. Bug: 1002483 Change-Id: I52ecbbc65bdc43b62c1ad4d13149084f0382bed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547443 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#829211}
-
Hiroki Nakagawa authored
Bug: 1149226 Change-Id: I48391f13e88a5cd772cb2bb79db01dcd54ea6285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549021Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#829210}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605743960-03e8e3c00d664b0272fc9bec8fbd6eb12ca9ed48.profdata to chrome-win64-master-1605765502-3ccba7e07e5cf94b5756f4641a727d60a578a62b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I87eccf43297863457c8e96790f5bdd6111985291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549281Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829209}
-
Benoit Lize authored
The thread cache has a hard limit on how many objects are cached per bucket. Previously, every cache fill above the limit would go back to the central allocator, so the following scenario: 1. 1000 malloc(10) calls 2. 1000 free(ptr) calls (of the previously allocated memory) Woould acquire the lock 1000 - kMaxCountPerBucket times on the deallocation path. By batching deallocations, the lock is only acquired (1000 - kMaxCountPerBucket) / (kMaxCountPerBucket / 2) = 2000 / kMaxCountPerBucket - 2 times. It may also reduce cache footprint for these scenarios, since the bucket is rarely full. Note that the allocation patth is not affected, batching on this side may be investigated as well, but not without data showing that empty buckets are frequent. Bug: 998048 Change-Id: I626205e28d7a082a12303a493ca504e9581fc43a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546599 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#829208}
-
Denis Kuznetsov authored
Bug: None Change-Id: Ie4329a1a00ad35316f22340a2ce42832427243c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549962 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ieda249b47c753697db3de49d482af1f8ec1d1591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549145Reviewed-by:
-
Maksim Sisov authored
In the first take, I thought buffer formats could be determined from the browser process side as early as possible, but several problems were identified in the end - 1) glx's bindings' initialization is required. And it's done on the gpu process side 2) gl implementation can be determined after gl is set (it's temporarily required before angle + gmb support is added, though). I also thought to make fetching gmb formats asynchronous, but it would require rewriting some important clients, which is non-trivial, unfortunately. Thus, that approach didn't work well and I had to reuse the existing approach to pass support buffer formats for gmb via gpu extra info. Now, OzonePlatform has fetch_buffer_formats_for_gmb_on_gpu variable that clients can use to determine the way that they are able to fetch supported buffer formats. All the previous logic that non-Ozone/X11 had stayed the same except that it's also used by OzonePlatform that has fetch_buffer_formats_for_gmb_on_gpu set to true. In this case, CollectGpuExtraInfo collects supported buffer formats. Bug: 1099183 Change-Id: I56c1323af54ae5bec4a5f9152aca47a21035d6b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540286Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov (GMT+2) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#829205}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d40c6d7f3bef..745ab6e3c09a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mkwst@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mkwst@google.com Change-Id: If781c93efa24c71f3be9c1d61845e74e46dc80e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549162Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829204}
-
Viktor Semeniuk authored
Bug: 1096986 Change-Id: Ic3f4b69c0762afd09386d42a3639a207da24aa9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546007Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#829203}
-
Danila Kuzmin authored
Screens with loaded webview parts need focus adjustment after returning focus from the system tray. But it breaks logic when tab is returned in reverse order and we need to focus other parts of the screen. This CL fixes such tab transitions. Bug: 1133249 Change-Id: I6b565411687e654547935e425272e8f14f1ebaa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532576Reviewed-by:
-
Greg Thompson authored
They indicate that the initial trivial move succeeds ~2/3 of the time, and that the fallback then moves its contents nearly every time. BUG=1149458 R=ydago@chromium.org Change-Id: Ib107b8c7d59d595c3f22aed697c1a22ded9ba9bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544123 Commit-Queue: Greg Thompson <grt@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#829201}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/145e22d4d49f..876a780b5210 2020-11-19 tsepez@chromium.org Save some zero bytes in struct XFA_FMHtmlReserveCode 2020-11-18 tsepez@chromium.org Better bounds-checking in CFDE_TextOut::ReloadLinePiece(). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1147125 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I27748bf37a68aaf8ff7e81836819b12982ab6091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549825Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1f8ea587c2e2..1a5d5109644a 2020-11-19 aerotwist@chromium.org Tweak metrics pane styles 2020-11-19 aerotwist@chromium.org TypeScriptify focus-changed.js 2020-11-19 wolfi@chromium.org [TS] Port HeapProfilePanel.js to TypeScript 2020-11-19 alexrudenko@chromium.org Enable TypeScript for TopDownProfileDataGridNode 2020-11-19 mathias@chromium.org TypeScriptify profiler/HeapProfileView.js, part 1 2020-11-19 szuend@chromium.org TypeScript-ify ui/SearchableView.js 2020-11-19 szuend@chromium.org TypeScript-ify ui/InspectorView.js 2020-11-19 jacktfranklin@chromium.org [DataGrid]: enforce cell values are primitive 2020-11-19 petermarshall@chromium.org [typescript] TypeScript-ify profiler/CPUProfileFlameChart.js 1/N 2020-11-19 aerotwist@chromium.org TypeScriptify TimelineFlameChartView.js 2020-11-19 kimanh@chromium.org [ts] Typescript-ify TracingLayerTree.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1125968 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2b16db37b0e239942722885932bf5a956980d759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549829Reviewed-by:
-
Elad Alon authored
Change-Id: Ifa001fff187c3f1ec7348693e5ba32fb6eb64dcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549081Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#829198}
-
Owen Min authored
With partial reporting also using this field, the old name becomes misleading. Renaming it to is_available. This matches server side renaming: 343096864 Bug: 1137964 Change-Id: Icf606a22c9b8efaa7c962b5d49b54e52432bb204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547571 Auto-Submit: Owen Min <zmin@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605732977-09df8fbd862d08eaa283942ed13244c34d12f091.profdata to chrome-win32-master-1605754194-4e76916f5340c97913d651fe425b3570e2df369d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I425688f81a27c983a00ef988e85f0026b223aa97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549183Reviewed-by:
-
Rushan Suleymanov authored
Bug: None Change-Id: Ie7b1a0a016d1b63a71ca313f6e7054246e056c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547022 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
-
Monica Basta authored
This CL adds the generic colored avatar to the avatar icons shown on 'chrome://settings/manageProfile' that is only shown for local profile (No GAIA account). It also fixes the bug where no selected is shown when the user is using the GAIA avatar as the chrome avatar. In a future CL, |kProfileUsingDefaultAvatar, kProfileUsingGAIAAvatar| prefs will be deleted. The |ManageProfileHandler| should not rely on these prefs. Fixed: 1149539 Change-Id: I9cbce03e62efb20a6c466eac9c7e32d1cbc93f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542062 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#829194}
-
Findit authored
This reverts commit e13a069e. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 829053 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZTEzYTA2OWUyZmNmZmU3OWM4MmRlNTAzMmEwMzVhMDRjNDIwMmZkMgw Sample Failed Build: https://ci.chromium.org/b/8863210065181297712 Sample Failed Step: services_unittests on (none) GPU on Mac on Mac-10.13.6 Sample Flaky Test: CoreLocationProviderTest.ShouldUseCallbackTest Original change's description: > fallback to Network Provider if wifi is turned off > > If Wifi is disabled Core Location does not work. In this case we will > fallback to the Network Location Provider which can use the IP address > to get an much less precise location. > > Bug: 1135766 > Change-Id: I3f5fa8e78fbb34bcec36dbd6eeb0e6adc06c64c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453437 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: James Hollyer <jameshollyer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829053} Change-Id: Iecd1cf5b4e3a36fdac2b11d5c52754fab8772c31 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1135766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549832 Cr-Commit-Position: refs/heads/master@{#829193}
-
Swapnil authored
There are many browsertest related to search related polices such as DefaultSearchProvider related policy and ForceGoogleSafeSearch policy. This CL splits them to new files. Bug: 1148743 Change-Id: Iba18f2e1ce08fbded6b112ee07d683405ca0a653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545522 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
-
Greg Thompson authored
The histogram had the wrong type, making its interpretation non-obvious. BUG=1149463 R=ydago@chromium.org Change-Id: I394db672d96da3c9f32e4434ae7b57016aabe5c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543385 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
-
Shik Chen authored
The i18n json files are now generated in subdirectories for platform app and SWA. Bug: b/172879638 Test: cca deploy Change-Id: I404b42b2afdca4eb4a628bb49c44365dc7b21741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549381 Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8d63a7fc4924..c151f873e4ab 2020-11-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 45b78e7b to 62214500 (493 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I6c359a9e7e44367f40aa521f8fa2f52442482aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549282Reviewed-by:
-
Benoit Lize authored
Always enable thread cache statistics. Bug: 998048 Change-Id: I6cc5ac2e248baf19582c7170537a94e6292daf5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544570Reviewed-by:
-
Roman Sorokin authored
During Kiosk app launch we might need to configure network. This is guarded by the owner authentication (in case of consumer kiosk). Before this CL it used WebUI AccountPicker screen. This CL moves it to the current User pod screen implementation Bug: 1071779 Change-Id: Iaa1665e8d588d4df0beb5459365159a8292c08f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540983 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#829187}
-
Maria Kazinova authored
This is needed to properly record PasswordManager.SuccessfulSubmissionIndicatorEvent metric for this type of submission. Bug: 1146373, 1150780 Change-Id: I426746ed0fabadf553cc04cf7143b0c370015ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541764 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#829186}
-
Bret Sepulveda authored
As a prerequisite to landing cr/339683181. Bug: 1134294 Change-Id: I95a0774957c5ba1cae28faad5916865f50e5a8d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510054 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#829185}
-
arthursonzogni authored
It was previous reset once per navigations, including the same-document ones. This moves it toward DidCommitNewDocument(); Bug: 1113294 Change-Id: I7a947d9b693fd1380da54996e60431642f4cdde1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538212 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#829184}
-
chrome://flags#disable-idle-sockets-close-on-memory-pressurePavol Marko authored
This adds a chromeos-specific flag for the feature added in CL:TODO. When the feature is enabled, idle connections will not be closed on memory pressure. Bug: 1150526 Change-Id: If9d2063c30c7ede5039941f1764e5b769a0facab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547295 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#829183}
-
