- 11 Jul, 2019 40 commits
-
-
Karan Bhatia authored
Code to set the policy host restrictions is duplicated in Dispatcher::OnUpdatePermissions. Fix it. BUG=None Change-Id: I3cfc5cbe6b7565c2093204690bd88333a23f683a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695758 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#676614}
-
Yuly Novikov authored
Add gpu-fyi-try-win-xr-builder as an alternative. Drive-by remove non-existent buildbot/chromium.gpu/Android Release (Nexus 5X) Bug: 982086, 977735 Change-Id: I30effd28b414ce46df230c9b24305921c8cdb423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696691Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#676613}
-
Tamir Duberstein authored
We can do our masking later, avoiding violating FDIO's assumptions. Change-Id: Ia28b74b9d7fadae6512af51df18e39935e3e90d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697140Reviewed-by:
James Robinson <jamesr@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#676612}
-
chrome://flagsAndrii Sagaidak authored
If there is an edit field for a flag (e.g "Insecure origins treated as secure"), it should get focus when tabing through that flag, not after tabing through all the flags. This PR fixes this focus order issue. Bug: 982888 Change-Id: I7fd62b4ea60b15f0e1a1abdd48f27e1b08fa1c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696772Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Andrii Sagaidak <ansagaid@microsoft.com> Cr-Commit-Position: refs/heads/master@{#676611}
-
Anatoliy Potapchuk authored
Bug: 939674 Change-Id: I54e7eb79a9321ee205c27cbb23b9370ee5a1e1ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665939Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#676610}
-
Omer Katz authored
The comment on EAGERLY_FINALIZE metions m_extraData that does not exist Bug: 981043 Change-Id: I3112e41de68dcf764643bcab802dafa05372e7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697187 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#676609}
-
Stefan Zager authored
Intent to implement and ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/MzXscv7fT0w/ygq7qc6sBQAJ The implementation landed behind a flag here: https://chromium-review.googlesource.com/c/chromium/src/+/1686824 It has been in a few Canary versions without issue, and appears to work as advertised in manual testing. BUG=603193 Change-Id: I6e8737ef6de4444f887e986566c154f331869a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695965Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#676608}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7825d4983f90..f6da14697e15 git log 7825d4983f90..f6da14697e15 --date=short --no-merges --format='%ad %ae %s' 2019-07-11 bsalomon@google.com Move compatible stencil tracking from GrGLCaps::fConfigTable to ::fFormatTable. 2019-07-11 jvanverth@google.com New approach to fixing Vulkan MSAA. 2019-07-11 rmistry@google.com [perf_skottiewasm_lottieweb] Do 2 loops with 25 points each and then pick 25 from the middle 2019-07-11 jvanverth@google.com Remove deprecated discard method and GrCaps support 2019-07-11 mtklein@google.com instructions for JIT tail support on ARM Created with: gclient setdep -r src/third_party/skia@f6da14697e15 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@google.com Change-Id: I6d313c6f2191858b1da9fcfe8c5ffb8b6a8e43e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698784Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676607}
-
Dale Curtis authored
It's possible for a renderer to trigger ended while a demuxer hits an error which has not yet propagated to WMPI (where Stop() would be invoked). BUG=982747 R=sandersd Change-Id: Ibf225c85ef3d07f342dabf3e60bc835166f4c3da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697435Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#676606}
-
Karan Bhatia authored
This CL adds support for handling of unsafe-eval in isolated worlds. Since the IsolatedWorldCSP feature is disabled by default, no behavior changes are expected. BUG=896041 Change-Id: I41b5ddc905b2193e29e4fbe56b4c28c350b298b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670352Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
CSSPrimitiveValue::TypeWithCalcResolved() is an ambiguous function that mixes numeric literal unit types and math function result categories. It also leads to misuse, as many callers may assume that the returned type is the unit type of GetDoubleValue(), which is incorrect. Hence, this patch removes some callers of TypeWithCalcResolved(). It might have also revealed some existing bugs, which are marked by TODOs. Bug: 979895 Change-Id: I4051b940d8b67ab22868cd803ee21422a4c5d587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696274Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
-
Maggie Chen authored
The Direct Composition Visual tree should be rebuilt after switching between overlay and underlay. Because the old code didn't do this, the swap chain is still in underlay mode after switching from underlay to overlay. Thus, the video controls from the last underlay frame still shows on the later overlay frames. Bug: 978203, 974344 Change-Id: If179fc07de6a2a9580234310e25f90221a06fc12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697312Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#676603}
-
Rouslan Solomakhin authored
Before this patch, a failure to download a payment manifest would be printed in developer console, but would not be returned back to the merchant. This made debugging production problems difficult, because real world users have different configurations that can be hard to predict and replicate in a local development environment. This patch forwards the errors from the downloader to the merchant when rejecting the promise returned from PaymentRequest.show(). If multiple errors occur, only the first one is forwarded. If PaymentRequest.show() is not being rejected, then the downloader error is still printed in the developer console, but not forwarded to the merchant. After this patch, the first failure to download a payment manifest is forwarded to the merchant in the rejection of the promise returned from PaymentRequest.show(). Bug: 977145 Change-Id: Ide9021293099a9c1488ac3d1bd2c96ce9afe2e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685429 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#676602}
-
A Olsen authored
Depends on CL 1692987 Bug: 930109 Change-Id: I02093da36b69e50753e8bda2859f9af09a3f5406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695270 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#676601}
-
Brian White authored
Bug: 975852 Change-Id: I965ef8d27e382f8af65a0e031537e979dc309e59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697289 Commit-Queue: Brian White <bcwhite@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Brian White <bcwhite@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#676600}
-
Danan S authored
Also, removed Parental Controls from Settings Menu. Bug: 927957 Change-Id: Ie3a25e223cc84f63669fa9a61d29e29b5c83a115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692979 Commit-Queue: Danan S <danan@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#676599}
-
Alberto Herrera authored
Class that retrieves a GATT connection to read the standardized GATT Battery Service. Using a callback, returns the obtained value or nullopt if an error occurred in the process. An instance of this class will be created every time GattBatteryPoller (to be implemented in a separate CL) needs to read the battery level. Design doc at go/cros-bt-battery. Bug: 785758 Change-Id: I5115c39e7208c9d22c0ed1f073c174faed42f1fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685329 Commit-Queue: Alberto Herrera <ahrfgb@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#676598}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/944f7dee7dc1..da391939c524 git log 944f7dee7dc1..da391939c524 --date=short --no-merges --format='%ad %ae %s' 2019-07-11 oysteine@google.com Merge "Include profiling protos in the Chrome public deps" Created with: gclient setdep -r src/third_party/perfetto@da391939c524 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I951210297fbe3bf0945ccfa2d8c4f835a764517b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697080Reviewed-by:
-
Mounir Lamouri authored
Bug: 975915 Change-Id: I94378d89139bc57bd755820e074fb3f110862049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691326Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#676596}
-
Jordy Greenblatt authored
This CL changes the name of the 'Downloads' Settings section to 'Files' in CrOS settings and reflects the change in the code by renaming the corresponding files in chrome/browser/resources/settings/chromeos/os_downloads_page/ to follow the use the name 'file' rather than 'download'. It also factors out the string provision into a CrOS specific AddFilesStrings function in chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc. New text screenshot: http://screen/HzEdJpRp80Q Bug: 978648 Change-Id: I71ea9102190ef0c45e2b578f721147e94b3a6e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696180 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#676595}
-
Matt Wolenetz authored
Deprecates histograms and removes reporting code for the following which expire in M77 (also updates their owners and updates the expiration for the video metric): Media.MSE.NumberOfTracks Media.MSE.DetectedTrackCount.Audio Media.MSE.DetectedTrackCount.Text Media.MSE.DetectedTrackCount.Video The NumberOfTracks metric has confirmed expectation that the vast majority of SourceBuffers use just one track (multiple SourceBuffers are the common way audio+video are used in MSE playbacks). The DetectedTrackCount metrics similarly confirmed expectations of very insignificant presence of text tracks in SourceBuffers, and rare occurrences of anything other than one audio track plus one video track across all SourceBuffers used in an MSE playback. UKM MSE data has similar information about audio+video versus audio-only or video-only, making these MSE track count metrics unnecessary/redundant assuming usage doesn't radically increase the number of tracks in MSE playbacks. This change retains the parsers' track type/count accounting that is used to verify expectations in at least their unit tests (via the StreamParser::InitParameters struct). Later changes could leverage the information reported in the configuration callback, instead of the initialization callback, to allow removal of those fields from InitParameters and not lose coverage. This change also notes that the MSE Audio and Video codec histogram recording is currently overlogging at least in codec switching scenarios (changeType), and references https://crbug.com/535738 which is reworking related code. This change addresses parts of 975898 and 975090, and references 535738 BUG=975898,975090,535738 Change-Id: Ia7d37b2f4ccacdb924a46098054b4deb72cc295a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693905Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Michael Thiessen authored
If the native WebContentsState returns null for some reason, we shouldn't consider there to be a saved tab that we try to restore. Bug: 982356 Change-Id: Ic7960faec2a90b534714ff4ba91b60cf89a01336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693601Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#676593}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/c538b5d796fb..71892a5eda90 git log c538b5d796fb..71892a5eda90 --date=short --no-merges --format='%ad %ae %s' 2019-07-11 johnkslang@users.noreply.github.com Merge pull request #1833 from AaronHaganAMD/master Created with: gclient setdep -r src/third_party/glslang/src@71892a5eda90 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,cwallez@chromium.org Change-Id: I74b0842718ecf9cbf0d8d37032222a80f9b52376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698781Reviewed-by:
-
James MacLean authored
This reverts commit 64a399de. Reason for revert: suspect cause of layout test failures: Unexpected Failures: * virtual/cache-storage-sequence/external/wpt/service-workers/service-worker/fetch-canvas-tainting-video.https.html * virtual/gpu/fast/canvas/canvas-composite-alpha.html * virtual/gpu/fast/canvas/canvas-composite-text-alpha.html * virtual/gpu/fast/canvas/color-space/canvas-createImageBitmap-e_srgb.html https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/81717 Original change's description: > Fixing ShouldAccelerate to preserve acceleration > > If the canvas has a mode fixed (acceleration or not acceleration), > ShouldAccelerate should not change it even though the hint is set > to the other side. > This CR fixes that when the canvas is accelerated will stay > accelerated. > Changing unittest and fixing a series of tests that were affected > as a side effect of blurriness. > For the browsertests I'm making some test to activate pixels (as now > these test are using accelerated canvas and we need to generate the > pixels). > > Bug: 947532, 973448, 977179 > Change-Id: I8814794e774f78aa3ad8147ff5dd6cc249c8b272 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617636 > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Fernando Serboncini <fserb@chromium.org> > Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#676488} TBR=aboxhall@chromium.org,rdevlin.cronin@chromium.org,fserb@chromium.org,aaronhk@chromium.org,juanmihd@chromium.org Change-Id: I62d304c4f5559a64302773767b12e8c689132b1a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 947532, 973448, 977179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699244Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#676591}
-
Alex Khouderchah authored
Bug: 969941, 975116 Change-Id: I837a4081625ecd3a64a7912869d87281570d1993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697129 Auto-Submit: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#676590}
-
Omer Katz authored
Bug: 981043 Change-Id: I405ec5da96e34a5bf5665ea338130976614d8237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697188 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Malay Keshav authored
Render surface textures have the surface content scale already applied to them when they are generated. Because of this, the surface content scale component of the target draw transform needs to be removed. In the case of a mirror layer, a RenderPassDrawQuad (RPDQ) is used that points to the render surface texture of the mirrored layer. Similar to the RPDQ of the mirrored layer, the RPDQ of the mirror layer also has to have its surface content scale component removed from its target draw transform. However, since this RPDQ points to the render surface texture of the mirrored layer, the inverse surface scale content of the mirrored layer must be applied rather than that of the mirror layer. This patch makes this change. Change-Id: I2696d7af8f62872c623ea6516485671a9341484d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696581Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#676588}
-
Patrick To authored
XRCompositorCommon::MaybeCompositeAndSubmit calls ExitPresent() when SubmitCompositedFrame() fails, which clears pending_frame_. pending_frame_ is accessed below, causing a nullptr exception. Bug: 974406 Change-Id: Iea89aee7c4eb5cb7e1fba57d1f79901de52efb4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698669Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Patrick To <patrto@microsoft.com> Cr-Commit-Position: refs/heads/master@{#676587}
-
Lei Zhang authored
Change-Id: I5aaf82e84c9429bbbbf142f532db03325c026a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696175 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#676586}
-
Toni Barzic authored
BUG=975460, 974995, 975862, 975448, 975722 Change-Id: I9ffb4e6cca9954ac9435f09d8f800e96eaaea3c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698561 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#676585}
-
Anastasia Helfinstein authored
This reverts commit 53c528aa. BUG=983246 TBR=dpapad@chromium.org Change-Id: Id590280240a32ada77d452abedd3478d102be7ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697763Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#676584}
-
Fredrik Söderquist authored
Remove some unused conversion helpers that would otherwise need similar treatment. In the case of ToFloatSize(const DoubleSize&) it was used in one instance but erroneously so, promoting to DoubleSize just so that it could convert back to FloatSize/ScrollOffset again. Bug: 983032 Change-Id: I416f24fc125b447c881edbdebf5d1796483bec85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698507Reviewed-by:
-
Xiaohui Chen authored
Remove Keyboard.Shortcuts.CrosSearchKeyDelay metrics. It is used for search key related shortcut analysis a while ago. Bug: 975475 Test: locally build and CQ TBR=nikunjb@chromium.org Change-Id: I32e9afc2a556fbc58b45029a3f2d24b5b00ced16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685327 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#676582}
-
Jacques Chen authored
Change-Id: I138af52f02c412448708fda7e535cbb0bd61fff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696999Reviewed-by:
-
Lei Zhang authored
Having GetScreenRect() as a standalone function, separate from PDFiumEngine, makes it easy to test. Add unit tests for GetScreenRect(), and update comments to reflect reality, since the tests show the function does not return empty rectangles. Change-Id: Ibe807c0edd957c61bd4907ed87c3708f7cd21b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696174 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
yilkal authored
Bug: 977019 Change-Id: Ieb42dab51dc15ce636363e6969311762588bcf91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684812 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#676579}
-
Evan Stade authored
Replace with an observer interface on FindTabHelper. This CL also moves some enum types to their own file in order to prevent circular includes. Bug: 268984 Change-Id: I92e8cf64d87d2b45cb421ee8aaa24a55bf360316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691369 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#676578}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4e5a41a08674..66b3860fc95c git log 4e5a41a08674..66b3860fc95c --date=short --no-merges --format='%ad %ae %s' 2019-07-11 orphis@webrtc.org Remove WebRTC-SimulcastScreenshare and enable it by default 2019-07-11 sukhanov@webrtc.org Integrate datagram feedback loop 2019-07-11 yvesg@webrtc.org Let git-hyper-blame ignore new format cleanup. Created with: gclient setdep -r src/third_party/webrtc@66b3860fc95c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I38faf2f89c60aa95c4ca1621554979dda488f644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696912Reviewed-by:
-
Matt Wolenetz authored
Deprecates histograms and removes reporting code for the following which expire in M77 (also updates their owners and updates the expiration for the video metric): Media.DetectedTrackCount.Audio Media.DetectedTrackCount.Text Media.DetectedTrackCount.Video The text metric was added to see if in-band text demuxing for SRC (or MSE) might be motivated based on usage of SRC= media playback; it never showed significant counts. The audio/video track counts were typically as expected (vast majority either 0 or 1 track of each of audio, video). If we wish to later add media element audio mixing (based on dynamically enabled audio tracks at runtime), we may wish to add some audio track mixing metrics, though UKM may be better suited for that purpose. BUG=975315 Change-Id: I7cc208c7860a588d7013ec04d8b46a7d4dea8e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693582Reviewed-by:
-
Evan Stade authored
Bug: 268984 Change-Id: I0d1a5f3fc18643055fb7f78f44996c93a493132c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698671 Commit-Queue: Evan Stade <estade@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#676575}
-
