GitLab

Currently |migration_pending_| is mixing three invariants together:
- connection migration is triggered but no alternate network is available for migration.
- connection migration on write error posted, but other direct migration completes, prevent the posted task from being executed.
- connection migration on write error is in progress, read error should be ignored.

This change explicitly separate out those three invariants:
- |wait_for_new_network_| tracks if a migration is triggered and no alternate network is available
- MigrateSessionOnWriteError(posted task to handle write error) takes the writer which encountered the write error, and compares with the active writer in use to determine if the migration should be aborted.
- |ignore_read_error_| tracks if read error should be ignored.

Bug: 818050
Change-Id: Ic6d1c4c95f9da2207901ba985fb662ab0d4abc3c
Reviewed-on: https://chromium-review.googlesource.com/1129549
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574056}

Bug: 860677
Change-Id: I1eddedd3f751380236854156033bb324ec365581
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/1127845
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574055}

The service manager thread and (TODO) ServiceManager might be created
before the full browser starts, and we want to reuse them when starting
the full browser. Therefore, we add a pointer of BrowserStartupData in
MainFunctionParams.

Particularly, in this CL, ContentMainRunnerImpl creates and owns a
BrowserStartupData object. It passes a pointer of the BrowserStartupData
through the main function parameter to BrowserMainLoop.

The BrowserStartupData interface was introduced in:
https://crrev.com/c/1117471.

Bug: 846846, 853308
Change-Id: Ie11063227a670cd8d72935131e854ee2b5c46e4e
Reviewed-on: https://chromium-review.googlesource.com/1108178
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574054}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: I5a16cdd72ed714a8eca9b68b5cd919583d54c3f5
Reviewed-on: https://chromium-review.googlesource.com/1132703Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574053}

Removes the tool from third_party, as well as gni references to it.

This does not remove the logic from the "stack" script, since that may
still be useful for running on stacks from older chrome binaries.

Bug: 861887
Change-Id: Ifc5372846d41f0e8b013524dd463eb023af1ec00
Reviewed-on: https://chromium-review.googlesource.com/1130005
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574052}

This CL creates a NetworkService implementation of the PreconnectionStreams
function for use in the predictor.

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I5d9ca41e47d96b0a044cb82ca8e07e91a090cbb6
Reviewed-on: https://chromium-review.googlesource.com/1097627
Commit-Queue: Lily Houghton <lilyhoughton@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574051}

This CL replaces detailed view header icons in UnifiedSystemTray by
new ones. Help icon is still not ready on UX side.

TEST=manual
BUG=842079

Change-Id: Ib8418c2c3ee31d58f1636a01f8a338d4d6a4fa1d
Reviewed-on: https://chromium-review.googlesource.com/1127505Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574050}

The top-level win8 directory does not exist anymore.

Change-Id: Iab412299a10e72aa786c789b281f4625baca1ffa
Reviewed-on: https://chromium-review.googlesource.com/1132535Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574049}

This was extracted from
https://chromium-review.googlesource.com/c/chromium/src/+/1088762/17
in an attempt to simplify it (and is now a precursor to it).
(MessageLoop::Controller was IncomingTaskQueue::MessageLoopController
there but after grokking the resulting CL it's simpler under MessageLoop
as done in this CL)

This CL splits the logic in IncomingTaskQueue which took care of
scheduling the MessageLoop into a dedicated class. In that follow-up CL:
MessageLoopTaskRunner will interact directly with the task Observer and
take IncomingTaskQueue completely out of the picture (merely a data
structure holding various task queues at that point).

IncomingTaskQueue also took care of detaching on MessageLoop shutdown
which was moved to the new Controller class as well.

message_loop.cc is the best place for this extracted logic as it all
pertains precisely to MessageLoop's implementation detail (how
ScheduleWork should be invoked).

This CL simplifies locking as well by having a clear separation between
the two locks instead of two locks in the same class used
interchangibly. |incoming_queue_lock_| is now strictly for incoming
tasks. |message_loop_lock_| is now strictly for
ScheduleWork()/DisconnectFromParent().

Note: |message_loop_scheduled_| was dropped as it was redundant (always
equal to |!was_empty|).

Performance wise, the perf tests show that this change is a noop :
 * While BasicPostTaskPerfTest became simpler (executed less code) with
   this CL :
     The new BasicPostTaskPerfTest w/ MockObserverSimulatingOverhead
     reintroduces that overhead to show that it's still the same (or
     slightly in favor of this CL).
 * And the IntegratedPostTaskPerfTest are the same.
 * Augmented perf tests to 30 seconds which yields more reliable results.
   (and ran old ones under 30s mode too when comparing)
 * Results :
     https://docs.google.com/spreadsheets/d/100wYvbCI_dJ7gRnQiSsYaTb5OJnbF_muL6LyQWJLXSU/edit

Bug: 860252
Change-Id: I22de2409d52414524cc125b0e2fe08e2c516fcbe
Reviewed-on: https://chromium-review.googlesource.com/1127262
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574048}

Add both icons for My Files active and inactive.

Bug: 846593, 846587
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I718f3374868686ed0aa9480deb83ebf96e9717e4
Reviewed-on: https://chromium-review.googlesource.com/1130557Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574047}

During tree update, DirectoryTree expects the NavigationModelItem to be
the same instance to be able to find the item in the tree, so this CL
changes NavigationListModel to not create a new model instance on
|orderAndNestItems_|.

Add unittest to VolumeEntry for rootEntry null and resolveDisplayRoot.

Add unittest to NavigationListModel to check that MyFiles model is the
same across multiple calls to |orderAndNestItems_|.

Add integration_test to cover the tree update when an USB volume is
mounted.

Fix |isDescendantyEntry| to use const instead of let and to work with
VolumeEntry with non-resolved rootEntry.

Bug: 861978
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I92f76749dd56a134c4b33517dfa3333ed4f01cca
Reviewed-on: https://chromium-review.googlesource.com/1130957Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574046}

It's quite flaky.

TBR=martiniss@chromium.org
BUG=861730

Change-Id: Id1ec406b75c54451244976108fd44fc1937a1419
Reviewed-on: https://chromium-review.googlesource.com/1132600Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574045}

This CL will swap the two rows of an answer/entity if the
answers are excepted.  It is a duplicate of change at
crrev.com/c/1112730 but with merge conflict resolved and
owner changed.

Bug: 855783
Change-Id: I17950c6daa489d7b42c0954195f4bf823383e31b
Reviewed-on: https://chromium-review.googlesource.com/1132550Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574044}

https://pdfium.googlesource.com/pdfium.git/+log/144107d3ca6d..cbed949bee84


git log 144107d3ca6d..cbed949bee84 --date=short --no-merges --format='%ad %ae %s'
2018-07-10 hnakashima@chromium.org Add test for reading marked content with an indirect dict.


Created with:
  gclient setdep -r src/third_party/pdfium@cbed949bee84

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Idd130f58c12c3b6652bec27de47fa5178786d183
Reviewed-on: https://chromium-review.googlesource.com/1132437Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574043}

This CL replaces base::Timer with its subclasses.
As base::Timer changes its behavior subject to its construction time
flags, that makes hard to see the actual timer behavior, especially
it's unclear when a timer is injected from other components.
Also, that OnceCallback support of base::Timer is hard to implement on
the dynamically determined invocation pattern.

Bug: 850247
Change-Id: I699518b6d70fe9f41a6516e11b68997ae7e6fda9
Reviewed-on: https://chromium-review.googlesource.com/1125718Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574042}

Add ScriptingPermissionsModifier::RemoveAllGrantedHostPermissions() to
revoke all host permissions that were granted to an extension with the
runtime host permissions feature. This includes hosts granted through
the runtime host permissions feature (using ScriptingPermissionsModifier
methods) and hosts granted through optional permissions using the
permissions API.

This will be used when adjusting extension host permissions in the
chrome://extensions page.

Bug: 844128

Change-Id: If45bf0024cb31946cba72e1abf06c27b3ed857b5
Reviewed-on: https://chromium-review.googlesource.com/1128381
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574041}

https://crrev.com/c/1112950 didn't quite fix one of the reported bugs
https://crbug.com/854499 about webview not getting key input. This CL
aims to address it by replacing WebContentsView::RenderFrameSwappedIn
with WCV::RenderViewHostChanged, and letting WebContentsImpl call it
upon NotifyViewSwapped.

Verified, with the change above, that updating focus/native view tree
takes effect as expected:
 - Build/install webview apk: ninja -C out/Default webview_system_apk
 - Open Gmail or Amazon app
 - Go to account creation page
 - Verify that click on input form brings up keyboard, and letters
   can be typed in

Bug: 860173, 860235
Change-Id: Iaf2013bcb2990b70ba8197eee86f0ababca54088
Reviewed-on: https://chromium-review.googlesource.com/1126580Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574040}

https://chromium.googlesource.com/angle/angle.git/+log/c0bb36cbe7be..a2f043d847dd


git log c0bb36cbe7be..a2f043d847dd --date=short --no-merges --format='%ad %ae %s'
2018-07-10 jmadill@chromium.org dEQP: Implement platform error handling.
2018-07-10 fjhenigman@chromium.org Fix run_code_generation.py hash calculation.
2018-07-10 theoking@google.com Enabled Vulkan backend on as many tests as possible
2018-07-10 geofflang@chromium.org Vulkan: Support RGB/BGR backbuffers emulated on RGBA/BGRA.
2018-07-10 jmadill@chromium.org Vulkan: Apply driver uniforms descriptor set.


Created with:
  gclient setdep -r src/third_party/angle@a2f043d847dd

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: I318fcb6f58646bff7295eb436e11d9c46a3705c4
Reviewed-on: https://chromium-review.googlesource.com/1132439Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574039}

Practically speaking, we weren't drawing single-tab mode in this case anyway;
but because it wasn't marked disabled, we were calculating things like the New
Tab Button color incorrectly.

Bug: none
Change-Id: If07fed8d0c98956444bf24e5f2e2adccc6c9ea5c
Reviewed-on: https://chromium-review.googlesource.com/1132594
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574038}

There is a case on Android where we'll update the fallback surface without
updating the primary surface ID as well when surface synchronization is off.

This might be the cause of the occasional deadlines triggering when surface
sync is off.

Bug: 672962
Change-Id: I87133cc11b369a2097adc3b2a2bcd7f2781e1b30
Reviewed-on: https://chromium-review.googlesource.com/1131816Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574037}

- TouchExplorationController is managing its internal state by watching
  events as an event rewriter. If MagnificationController (which is also
  an event rewriter) rewrites an event, next event rewriter won't get
  the event. This makes TouchExplorationController confused.

      touch explorer works with full screen magnifier with touch.

Bug: 856558, 856554
Test: Enable spoken feedback and full screen magnifier. Confirm that
Change-Id: I3fd250c3ecf893a41a55af7b3286355aef2fe76e
Reviewed-on: https://chromium-review.googlesource.com/1119605
Commit-Queue: Yuki Awano <yawano@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574036}

TBR: kvitekp
Change-Id: Ib8fec97ff936788c9e783686531a98929c4b801f
Reviewed-on: https://chromium-review.googlesource.com/1132621Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574035}

This reverts commit 6562517f.

Reason for revert: I think this has an invalid cast and is causing CFI failures, see https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/9012 .

Original change's description:
> Use retargeted start point when starting composited transitions.
> 
> When starting transitions we check if they are interpolable, and don't
> start a TransitionInterpolation if not. When retargeting, the start
> keyframe from the previously active interpolation may cause an
> incompatible interpolation so we must take this into account.
> 
> Bug: 853698
> Change-Id: Iaeeba35c64c659818c68d30e8f999e704b382926
> Reviewed-on: https://chromium-review.googlesource.com/1126519
> Commit-Queue: Robert Flack <flackr@chromium.org>
> Reviewed-by: Majid Valipour <majidvp@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#573980}

TBR=flackr@chromium.org,majidvp@chromium.org

Change-Id: I4de74036835b09da2fe4751280bea9d9b0e205a0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 853698
Reviewed-on: https://chromium-review.googlesource.com/1132016Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574034}

https://skia.googlesource.com/skia.git/+log/c69c4410be7d..e8d674dd7cef


git log c69c4410be7d..e8d674dd7cef --date=short --no-merges --format='%ad %ae %s'
2018-07-11 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 d8b1c5c5bba2..569b9cb983b1 (16 commits)
2018-07-10 bungeman@google.com Move SkRefSet / pipe code to smart pointer.
2018-07-10 herb@google.com Revert "Use new SkGlyphIDSet"
2018-07-10 herb@google.com Use new SkGlyphIDSet
2018-07-10 bungeman@google.com Move SkWriteBuffer to smart pointers.
2018-07-10 brianosman@google.com Revert "transform paint color to dst colorspace"
2018-07-10 jcgregorio@google.com Revert "added skeletal animation support to GPU backend"
2018-07-10 bsalomon@google.com Revert "Remove interpolants are inaccurate workaround for Adreno 3xx."
2018-07-10 ruiqimao@google.com added skeletal animation support to GPU backend


Created with:
  gclient setdep -r src/third_party/skia@e8d674dd7cef

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:847984
TBR=robertphillips@chromium.org

Change-Id: Ibd19c78f436bc166f9eed2742bfb01c416a9d029
Reviewed-on: https://chromium-review.googlesource.com/1132440Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574033}

This reverts commit 52601a56.

Reason for revert: Speculatively reverting to see if this is confusing crashpad on the Mac somehow. See crbug.com/862466.

Original change's description:
> [sampling heap profiler] Support stack collection on Android
> 
> BUG=803276
> 
> Change-Id: I60d7925104b8614aa68c135d52f6089a76675d22
> Reviewed-on: https://chromium-review.googlesource.com/1128630
> Reviewed-by: Siddhartha S <ssid@chromium.org>
> Commit-Queue: Alexei Filippov <alph@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#573880}

TBR=alph@chromium.org,ssid@chromium.org

Change-Id: Ie7b4f8b20cd5526420ef836d3a21dda27d4090bb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 803276
Reviewed-on: https://chromium-review.googlesource.com/1132357Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574032}

Bug: 792774
Change-Id: I81bc4c1d032a775319c68ee17f8e1322839d8fd7
Reviewed-on: https://chromium-review.googlesource.com/991155Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574031}

This bug has been around since WebKit. When AXNodeObject::ChildrenChanged() is
called, it invalidates the list of children of the current node (correct), but it
also does so for all ancestors. This is wasteful and I've recently discovered
that this is a significant performance bottleneck on sites like the new Gmail
when composing a message; every character typed ends up forcing us to explore
nearly the whole tree, rather than only the part that changed.

However, just invalidating the current node isn't quite enough if that node is
ignored. When an AXObject computes its children, if any child is marked as
"ignored" it recursively adds the children of that ignored child. Thus if an
ignored node's children are invalidated, we need to walk up to an unignored
ancestor and ensure that it recomputes its children, too.

It's likely that this reason (handling ignored nodes properly) is why
the bug persisted in WebKit. Also the way WebKit is architected,
the performance impact is not as large there.

This is well-covered by existing tests. Dozens of tests fail if we
fail to invalidate nodes whose children have changed (whereas
invalidating too much just silently wastes resources).

Bug: 861567
Change-Id: Ib9688615027ea5f7d4a01f74c830d2ae381fcf63
Reviewed-on: https://chromium-review.googlesource.com/1130996
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574030}

This is a reland of 53ed5722

But only reland the change for copy_ex.py
Reverting aar.py fixes the build failure in Android builder.

Original change's description:
> Keep timestamp in aar.py and copy_ex.py when file is not changed
>
> This removes unnecessary build steps in incremental build.
>
> Also this mitigates crbug.com/860251 a bit.
>
> Bug: 810298, 860251
> Change-Id: Ia6aedfea692611a08b1f9a6a2c3963bb69cf32bc
> Reviewed-on: https://chromium-review.googlesource.com/1127565
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Reviewed-by: Eric Stevenson <estevenson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#573145}

Bug: 810298, 860251
Change-Id: Ibd30991d65153553a8c36d1af82552461c85966f
Reviewed-on: https://chromium-review.googlesource.com/1132494Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574029}

Cherry picked from eureka/1.32j

Bug: b/110034090

Test: Test on AT devices.
Change-Id: If6e5ac71b64f85a9828ea058fdc09fd45a13a109
Reviewed-on: https://chromium-review.googlesource.com/1132525Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com>
Cr-Commit-Position: refs/heads/master@{#574028}

Bug: 861628
Change-Id: Id7a6f8acef2c1226a95bf38d6d35ac01ce9fff67
Reviewed-on: https://chromium-review.googlesource.com/1130471Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574027}

Bug: 856530
Change-Id: I21c938052ca9493408947b2e5d50b43806f05104
Reviewed-on: https://chromium-review.googlesource.com/1131047
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574026}

A previous CL addressed the inconsistency in how throttleable
outstanding requests were counted when transistioning between life cycle
states. This caused memory perf tests to regress because more low/medium
requests were throttled due to high priority requests being counted.

While the change made the counting scheme more consistent, it likely
should be reverted and re-landed behind a field trial of some sort.

Bug: 862365
Change-Id: I525058198ccf5b65aa8c754aca776c74295351e6
Reviewed-on: https://chromium-review.googlesource.com/1132471Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574025}

Bug: 856530
Change-Id: I8da043903712003379603b443ad2c584ebc1c244
Reviewed-on: https://chromium-review.googlesource.com/1131022Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574024}

This benchmark is no longer necessary now that we are no longer using
ground-truth power in our integration testing.

Bug: 859514
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I9d9fd8d5a629d903e38a9ad5d5e03a2fda58c650
Reviewed-on: https://chromium-review.googlesource.com/1130008
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574023}

This migrates SyncEngine from using

net::NetworkChangeNotifier to content::NetworkConnectionTracker, which

works with the network service enabled.

Bug: 859139
Change-Id: I8ec4d755c0a6ec854403f66d89ad22a6be47f467
Reviewed-on: https://chromium-review.googlesource.com/1123712
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574022}

Fixes two broken WebXR tests that verify the Daydream controller's app
button behavior. The condition that they checked after pressing the
button was not changed as part of the AR test patch, so they always
failed.

TBR=mthiesse@chromium.org

Change-Id: Ibbee773352e18ea65018101057be08adc6ba190a
Reviewed-on: https://chromium-review.googlesource.com/1132563Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574021}

Change-Id: I53f92d7b6f9b7dfc7f698018896c6a28703e10b1
Reviewed-on: https://chromium-review.googlesource.com/1132481
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574020}

The reported bug uncovered an issue about non-full-width overlay panel
having a wrong, full width when toggling (or resizing while in)
multi-window mode. The new panel width calculated from the new size
should have been used, but the raw, full width value was passed to
resizing logic of the content layer. This is a new corner case where
non-full-width overlay panel is preserved across size change.

This CL fixes it to ensure that the right values from
|OverlayPanelBase.getContentView{Width|Height}Px()| are used.
Also did a cleanup removing some dup'ed codes and combined WebContents/
native backing size updates as they are always done together.


Bug: 855386
Change-Id: I0a982dd21a083bbec7b9e0d5838a866ebcce31cb
Reviewed-on: https://chromium-review.googlesource.com/1127918Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574019}

Aligns with other service_worker directories.

Change-Id: I19396e65af847d38acf82f6a29ea4a302d12dd7a
Reviewed-on: https://chromium-review.googlesource.com/1131042
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574018}

This is the subpage for the multidevice settings UI. It will contain a
toggle for each individual feature in addition to some feature-specific
infrastructure (e.g. setup button, learn more link, password protection
of features). I will also have a toggle to disable all multidevice
features and a button to forget phone already set up on the account
(the subpage is only reached if there is a phone set).

Note that if the phone is not yet verified for multidevice features,
then individual feature toggles will not be shown.

Bug: 824568
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I29e8f9aa3d2801fb898eabf02adc2e79bd43ef5e
Reviewed-on: https://chromium-review.googlesource.com/1128334
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574017}