- 24 Sep, 2019 40 commits
-
-
Raul Tambre authored
Initial conversion performed using '2to3 -f print .'. Imports added and duplicate parentheses removed manually. Manually converted files, comments and inline code that 2to3 missed. Presubmit disabled due to an unrelated error in find_runtime_symbols/find_runtime_symbols.py. Afterwards ran "git cl format --python" and cherry-picked the formatting changes. There are no intended behavioural changes. NOPRESUBMIT=true Bug: 941669 Change-Id: I3174ed0eb7005d493c6bc44751353b8fae18a1f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818478 Commit-Queue: Raul Tambre <raul@tambre.ee> Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#699202}
-
Kenichi Ishibashi authored
We should terminate a service worker thread when the top-level script fetch fails. Otherwise the thread would stay running and leak a V8 isolate. WorkerGlobalScope::close() schedules thread termination. I manually confirmed that this CL fixes the leak. I'll add a test for this fix in a follow-up CL. Bug: 1005650 Change-Id: If3fd2f7f0f746c4e240b9fdebd4cf242d87a0943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819282 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#699201}
-
Wei Lee authored
This CL changes the behavior to let CCA open back camera as the default one when the device is under tablet mode. Bug: b/140273786 Test: Tested on Soraka and it open front camera as default under clamshell mode and open back camera as default under tablet mode. Change-Id: I1fa8f16265e9021ab0093cba506e0b652cb27af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815927Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#699200}
-
Alexis Savery authored
Since the host is reading/writing in power of 2 units to the device, and lifetime_writes is originally reported in KiB, the amount of writes reported in the histogram should be in GiB. Implementation CL: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1779603 Bug: None Test: ran validate_format.py Change-Id: I481c31730e66fe1f677ff52280fa8bfef97ca7c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818607Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#699199}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3da5033009ec..e712395b0e52 Created with: gclient setdep -r src-internal@e712395b0e52 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I4bd645f7b2ab42668d6044b70d3d41b1af57b21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819846Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699198}
-
Alan Cutter authored
This test is failing on just Windows 7 after getting deflaked. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Fthreaded%2Fexternal%2Fwpt%2Fcss%2Fcss-scroll-snap%2Fscroll-margin.html TBR=alsan@google.com Bug: 964239 Change-Id: I9e63ab319955f70138f529585ac8ce51efd58bf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820399Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#699197}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b9650d22d16e..984536bb45f4 git log b9650d22d16e..984536bb45f4 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 ntfschr@chromium.org Docs: add devil to navbar.md Created with: gclient setdep -r src/third_party/catapult@984536bb45f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: None Change-Id: I1e16eb8a35d1289fa26bb0f262f8369ffe71c834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820294Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699196}
-
Jay Harris authored
Bug: 1007063 Change-Id: Ife944e1e1784037c442e260df7d02e65454606cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818890 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
-
Maggie Cai authored
This CL updates the App Service intent filter condition value to an array and create a intent_filter_util file to handle the creation of the condition values. Bug: 853604 Change-Id: Ib43f1efd4cde468379f25d6aaf9dd3ae54a6a142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816000 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#699194}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d0581808..017e8357 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7d91dde62095dffb25df97bd6a6b656a36ebbb64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820307Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699193}
-
jongdeok.kim authored
This CL adds a link to Korean version for how_cc_works.md. Change-Id: Iaf09c30d2c43304a85bd4416def6a5c742787c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819278Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#699192}
-
Alan Cutter authored
This reverts commit de35a097. Reason for revert: Failing on all platforms. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=WelcomeA11y.WelcomeFlow_color_contrast https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/27248 [18374:18374:0923/204432.097393:ERROR:CONSOLE(49)] "Mocha test failed: WelcomeFlow_color_contrast Landing Page Error: the string "Found 1 accessibility violations." was thrown, throw an Error :) ", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (49) [18374:18374:0923/204432.101101:ERROR:web_ui_test_handler.cc(72)] Test Errors: 1/1 tests had failed assertions. [18374:18374:0923/204432.101355:ERROR:web_ui_browser_test.cc(546)] CONDITION FAILURE: encountered javascript console error(s): [18374:18374:0923/204432.101376:ERROR:web_ui_browser_test.cc(548)] JS ERROR: '[18374:18374:0923/204432.097393:ERROR:CONSOLE(49)] "Mocha test failed: WelcomeFlow_color_contrast Landing Page Error: the string "Found 1 accessibility violations." was thrown, throw an Error :) ", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (49) ' [18374:18374:0923/204432.101390:ERROR:web_ui_browser_test.cc(550)] JS call assumed failed, because JS console error(s) found. gen/chrome/test/data/webui/welcome/a11y_tests-gen.cc:285: Failure Value of: RunJavascriptTestF( true, "WelcomeA11y", "WelcomeFlow_color_contrast") Actual: false Expected: true Stack trace: #0 0x55ebe3920b5f StackTraceGetter::CurrentStackTrace() #1 0x55ebe392955c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #2 0x55ebe3928ea9 testing::internal::AssertHelper::operator=() #3 0x55ebe36c24dd WelcomeA11y_WelcomeFlow_color_contrast_Test::RunTestOnMainThread() #4 0x55ebe60b131e content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #5 0x55ebe5cae39c ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #6 0x55ebe5cad1ad ChromeBrowserMainParts::PreMainMessageLoopRun() #7 0x55ebe438318f content::BrowserMainLoop::PreMainMessageLoopRun() #8 0x55ebe4779607 content::StartupTaskRunner::RunAllTasksNow() #9 0x55ebe4381e42 content::BrowserMainLoop::CreateStartupTasks() #10 0x55ebe4384bf2 content::BrowserMainRunnerImpl::Initialize() #11 0x55ebe438041f content::BrowserMain() #12 0x55ebe5873245 content::ContentMainRunnerImpl::RunServiceManager() #13 0x55ebe5872d76 content::ContentMainRunnerImpl::Run() #14 0x55ebe7a2e8dd service_manager::Main() #15 0x55ebe4c9c511 content::ContentMain() #16 0x55ebe60b0dc6 content::BrowserTestBase::SetUp() Original change's description: > Reland Update axe-core to v3.3.2 > > This change updates the version of axe-core to the latest released > version. As part of picking up the latest version, the following > additional changes were made: > > 1) axe-core removed the 'href-no-hash' rule, so that been removed > from the test list. > > 2) Several 'link-in-text-block' tests started failing with > axe-core v3.0.2 (and later). These tests do pass in v3.0.1, but > are disabled as part of this change. > - CrManagementA11yTest.SimpleTest_link_in_text_block > - CrManagementA11yTestWithExtension. > ExtensionSection_link_in_text_block > - CrostiniAccessibilityTest.CROSTINI_link_in_text_block > - CrExtensionsA11yTest.NoExtensions_link_in_text_block > - MultideviceA11yTest.MULTIDEVICE_link_in_text_block > - MultideviceFeaturesA11yTest. > MULTIDEVICE_FEATURES_ACCESSIBILITY_link_in_text_block > > 3) One 'heading-order' test started failing in v3.0.0 (and later). > This tests does pass in V2.4.2, but is disabled as part of this > change. > - CrExtensionsA11yTestWithMultipleExensions. > WithExtensions_heading_order > > 4) Several DevTools a11y tests were failing. This change either > updates the baseline or excludes the rule depending upon the > test/rule itself. > - http/tests/devtools/a11y-axe-core/basic-a11y-test.js > - http/tests/devtools/a11y-axe-core/console-a11y-test.js > - http/tests/devtools/a11y-axe-core/memory/heap-profiler-a11y-test.js > - http/tests/devtools/a11y-axe-core/sources/dom-breakpoints-pane-a11y-test.js > > I spent some time investigating the test failures, and it looks > like axe-core is highlighting legitimate product issues. > > Change-Id: I0ef08cdace91250936f83705fb3cd0fbb35bed4b > Bug: 984817 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809407 > Commit-Queue: Mike Jackson <mjackson@microsoft.com> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699166} TBR=aboxhall@chromium.org,hcarmona@chromium.org,yangguo@chromium.org,mjackson@microsoft.com,tvanderlippe@chromium.org Change-Id: I6e74d1ddeec80407fc057dd07c95c492d7e6679f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 984817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819284Reviewed-by:
-
Manu Cornet authored
Add some tests. Bug: 982512 Change-Id: Ifcf6574fae9dc258c60ce4990109c6c5d2c3a12d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820092Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#699190}
-
Alexey Baskakov authored
TestWebAppRegistryController contains TestWebAppDatabaseFactory (the input and the output for tests), WebAppRegistrar, WebAppSyncBridge and ChangeProcessor. Bug: 860583 Change-Id: I1e0ed5e75fb5effd8f69bd2a7d9f819b56df0be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818893 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
Raul Tambre authored
Converted other regex strings to raw strings to prevent this being reintroduced in the future. ../../build/toolchain/win/midl.py:56: SyntaxWarning: invalid escape sequence \. 'Created by MIDL version 8\.\d\d\.\d{4} at ... Jan 1. ..:..:.. 2038\n', ../../build/toolchain/win/midl.py:72: SyntaxWarning: invalid escape sequence \. 'File created by MIDL compiler version 8\.\d\d\.\d{4} \*/\r\n' ../../build/toolchain/win/midl.py:73: SyntaxWarning: invalid escape sequence \* '/\* at ... Jan 1. ..:..:.. 2038', ../../build/toolchain/win/midl.py:78: SyntaxWarning: invalid escape sequence \( ' Oicf, W1, Zp8, env=(.....) \(32b run\), ' ../../build/toolchain/win/midl.py:79: SyntaxWarning: invalid escape sequence \. 'target_arch=(AMD64|X86) 8\.\d\d\.\d{4}', ../../build/toolchain/win/midl.py:97: SyntaxWarning: invalid escape sequence \( contents = re.sub('class DECLSPEC_UUID\("[^"]*"\)', ../../build/toolchain/win/midl.py:231: SyntaxWarning: invalid escape sequence \* print(' copy /y %s\* %s' % (tmp_dir, source)) Bug: 958138 Change-Id: I171f8d30540aa5ef15126b568d313a928b89c3e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816412Reviewed-by:Dirk Pranke <dpranke@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Auto-Submit: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#699188}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Idc52d4fe3180ea595870b9965ca743838de94632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819849Reviewed-by:
-
Alan Cutter authored
Flaking on all platforms. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fintersection-observer%2Fv2%2Fdelay-test.html TBR=szager@chromium.org Bug: 1007134 Change-Id: Iff33f55d6fea6ea94a1ff8398de3208100c6dc65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818009Reviewed-by:
-
Dan Beam authored
R=rbpotter@chromium.org Bug: 1003508 Change-Id: Ibad7ce62a2aeee2e40a911e6ebdff853a87cbfbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818466 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#699185}
-
Dan Beam authored
R=rbpotter@chromium.org BUG=1003508 Change-Id: I08bebc1d333086b36a7470a4c9043f87f9e209eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818469 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/672bcaf02c9a..b4b1005d485f git log 672bcaf02c9a..b4b1005d485f --date=short --no-merges --format='%ad %ae %s' 2019-09-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@b4b1005d485f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: Idc0f956d5fdbf9b1f3efa421f7af63da4618d7b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819916Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/988e63eb06c0..bc646eee208f git log 988e63eb06c0..bc646eee208f --date=short --no-merges --format='%ad %ae %s' 2019-09-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 09b71d30..1d4ed9e2 (698937:699120) 2019-09-23 mellem@webrtc.org Delete the deprecated GetTransportParametersOffer(). Created with: gclient setdep -r src/third_party/webrtc@bc646eee208f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I16107f49229137b4ee176971e3a50acad05b4cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819847Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8669b37aa2b0..b9650d22d16e git log 8669b37aa2b0..b9650d22d16e --date=short --no-merges --format='%ad %ae %s' 2019-09-24 abennetts@google.com Whitelist name 'maxDiff' in pylintrc; it's a commonly used attr of unittest.TestCase. Created with: gclient setdep -r src/third_party/catapult@b9650d22d16e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: None Change-Id: I349c6d24b023bcbd227c3f3147aab68fc6c110ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819844Reviewed-by:
-
Julian Watson authored
BUG=999950 Change-Id: Ia2e6e313824badc43ffb2eb68688c60171806cdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816003 Commit-Queue: Julian Watson <juwa@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#699180}
-
Michael Matena authored
Bug: b:139752841 Change-Id: Ibaeed64fa47adde6e6b374e2771bd697a9715bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793252Reviewed-by:
Shao-Chuan Lee <shaochuan@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Shao-Chuan Lee <shaochuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#699179}
-
Wei Lee authored
This issue is introduced by this CL: https://crrev.com/c/1722167 Since it makes camera_app.mojom depends on camera_intent.mojom but did not add camera_intent.mojom into the CCA's dependency, CCA will complain when launching. Bug: 980812, 967611, b/131809655, b/134635999 Test: Tested on Soraka and CCA could launch successfully with this CL Change-Id: Icb43a6e83ec13e391dd82fa281a52d99244de618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817872Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Yun Liu authored
Bug: 1005003 Change-Id: I888e625183fcde0bb1cf2ac529374f8334f3dd58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809745 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#699177}
-
Alan Cutter authored
As of CL https://chromium-review.googlesource.com/c/chromium/src/+/1803018 The OmniboxPageActionIconContainerView supports a superset of the icons supported by ToolbarPageActionIconContainerView. This CL dedupes the PageActionIconView handling between the two container classes as a single PageActionIconContainerView. Effective renaming: OmniboxPageActionIconContainerView -> PageActionIconContainerView ToolbarPageActionIconContainerView -> ToolbarAccountIconContainerView ToolbarAccountIconContainerView now uses a PageActionIconContainerView for its PageActionIconViews. Incidentally this CL fixes crbug.com/1005031 where the "save card" dialog would not show due to Layout() not being called when the icons updated inside the account icon container. With this dedupe they now Layout() as needed. Bug: 1005031, 788051 Change-Id: Icd5746a8c44221826e11246662f2251840c5d7f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816244 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#699176}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/c5b0621faea0..e849e6783d9f git log c5b0621faea0..e849e6783d9f --date=short --no-merges --format='%ad %ae %s' 2019-09-24 rharrison@google.com Add logging missing failures to spvc test script (#815) Created with: gclient setdep -r src/third_party/shaderc/src@e849e6783d9f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: Iaf5eb41309842e67747a43fadb7bb4df0e7d7b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819845Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I0da04baa78c2399b603cd87d54003af86b615d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820199Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699174}
-
Miyoung Shin authored
This CL converts SensorProvider{Ptr, PtrInfo, Request} in device, services, content and blink to the new Mojo types. SensorProviderPtr -> Remote<SensorProvider> SensorProviderPtrInfo -> PendingRemote<SensorProvider> SensorProviderRequest -> PendingReceiver<SensorProvider> Binding<SensorProvider> -> Receiver<SensorProvider> BindingSet<SensorProvider> -> ReceiverSet<SensorProvider> Bug: 955171, 978694 Change-Id: I318a2b0651b6dac993acf1ba29ed53c86f864048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809046 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#699173}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/27a35eb2a938..41f8aa550b43 git log 27a35eb2a938..41f8aa550b43 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 bryan.bernhart@intel.com Return Dawn result upon submit. Created with: gclient setdep -r src/third_party/dawn@41f8aa550b43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: If52a300e3b7ef4deffa8f392e45a0aa336730662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820095Reviewed-by:
-
Peter Kotwicz authored
This CL removes unused: - WebContents#reloadLoFiImages() - WebContentsObserver::DidReloadLoFiImages() BUG=1004173 Change-Id: If561b0ce731b1eb4a12063159f804ff53cfd3a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805717Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#699171}
-
Ian Struiksma authored
Two sites had mixed content (http & https) when recorded by wpr: cdbaby bed_bath_and_beyond Looks like the sites have fixed this, and thus live sites don't reflect these issues. Re-recorded the sites and updated the CIPD version to the new version which has the updated files. Bug: 1006377 Change-Id: If7900716b203a72ef8e660bcc7adeaa4d855d46a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819570 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#699170}
-
Donn Denman authored
Limits the sheet height to 95% of a tab's full height. Updates the touch highlight area of the Bar to limit height under the new layout. BUG=1005558 Change-Id: I57f4bfb6cca53096e93e00679098ef6b3933671b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812245Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#699169}
-
Julie Jeongeun Kim authored
This CL converts CallStackProfileCollectorPtr and CallStackProfileCollectorRequest to new Mojo types. It uses Remote, PendingReceiver, and Receiver instead of CallStackProfileCollectorPtr, CallStackProfileCollectorRequest, and binding. Bug: 955171 Change-Id: Iafc17945a133946713e11359ee806e0bfb184ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810174Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#699168}
-
John Z Wu authored
- Make it work with python3's bytestring semantics. - Not sure why, but looks like libcpp is compiled as big endian now? Change-Id: Ia73fd960472606b0f72970674b80200a1ae467d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816642 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#699167}
-
Mike Jackson authored
This change updates the version of axe-core to the latest released version. As part of picking up the latest version, the following additional changes were made: 1) axe-core removed the 'href-no-hash' rule, so that been removed from the test list. 2) Several 'link-in-text-block' tests started failing with axe-core v3.0.2 (and later). These tests do pass in v3.0.1, but are disabled as part of this change. - CrManagementA11yTest.SimpleTest_link_in_text_block - CrManagementA11yTestWithExtension. ExtensionSection_link_in_text_block - CrostiniAccessibilityTest.CROSTINI_link_in_text_block - CrExtensionsA11yTest.NoExtensions_link_in_text_block - MultideviceA11yTest.MULTIDEVICE_link_in_text_block - MultideviceFeaturesA11yTest. MULTIDEVICE_FEATURES_ACCESSIBILITY_link_in_text_block 3) One 'heading-order' test started failing in v3.0.0 (and later). This tests does pass in V2.4.2, but is disabled as part of this change. - CrExtensionsA11yTestWithMultipleExensions. WithExtensions_heading_order 4) Several DevTools a11y tests were failing. This change either updates the baseline or excludes the rule depending upon the test/rule itself. - http/tests/devtools/a11y-axe-core/basic-a11y-test.js - http/tests/devtools/a11y-axe-core/console-a11y-test.js - http/tests/devtools/a11y-axe-core/memory/heap-profiler-a11y-test.js - http/tests/devtools/a11y-axe-core/sources/dom-breakpoints-pane-a11y-test.js I spent some time investigating the test failures, and it looks like axe-core is highlighting legitimate product issues. Change-Id: I0ef08cdace91250936f83705fb3cd0fbb35bed4b Bug: 984817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809407 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:Yang Guo <yangguo@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#699166}
-
Nate Fischer authored
Miscellaneous edits to the netlog documentation: * Don't refer to chromium scripts in the manual section; the user may not have a chromium checkout * Fix the script output (the line of output requires --verbose) * Explain how to clean up the flags file * Cross-link to the commandline-flags page * Link to the online netlog viewer, rather than its README file Bug: 918221 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: Ib2d0027b58266fa39d2c0400567adb3d113cada6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820090Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#699165}
-
Fabrice de Gans-Riberi authored
This is a reland of bbd8d150, now that the peer-component's implementation of the UrlRequestRewriteRulesProvider really actually works correctly! Original change's description: > [fuchsia] Handle UrlRequestRewriteRulesProvider in CastRunner. > > * Implement handling of the > chromium.cast.UrlRequestRewriteRulesProvider API in CastRunner. > * Remove handling of the fuchsia.web.AdditionalHeadersProvider API in > CastRunner as it is deprecated. > * Adapt the integration test to use the new API. > > Bug: 976975 > Change-Id: If1e97c474f79a4b6f3f0c03428b85557e3e73460 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770434 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695766} TBR=fdegans Bug: 976975, b/141305604 Change-Id: I5e96abb44c167e64c2dbb32b596a6ce4550f61b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820198Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#699164}
-
Kinuko Yasuda authored
TBR=jam@chromium.org Change-Id: Ifeebeeb58cef6cf10a18dd6ea3a398553c977aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784260Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#699163}
-
