- 06 Nov, 2020 40 commits
-
-
Wez authored
Allow WebEngine to be configured to report an Android-like UserAgent via the system-provided config-data, to allow it to be fetch the right form of content for the device form-factor. This will likely be replaced with options to configure the Client Hints reported, on a per-instance basis, once those are standardized. Bug: b/171582703, 1010256 Change-Id: I9db408be09ec9b9a78facc7b078d635b96c3637b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522071 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#825042}
-
Rob Schonberger authored
Model desc: 1. Trained with Kohaku, Kohaku-Prev and Basking data. Combined AUC is 0.982 2. Feature Vector Unchanged 3. Model Radius changed in Kohaku for new fw. 4. Eval on held out Kohaku data is 0.988, held out basking 0.976. Bug: 1095874 Test: Deployed and tested on a kohaku device. Change-Id: Ia76a6c740dd7f85b8f64b87f0ff170a83196a8f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521880 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/master@{#825041}
-
Pavel Yatsuk authored
Native interface includes MessageWrapper and MessageDispatcherBridge. MessageWrapper represents a message for native feature code and allows feature code to set message properties before enqueueing it. Java side of MessageWrapper constructs PropertyModel that maintains property values. MessageDispatcherBridge enables feature code to interact with Java MessageDispatcher to enqueue/dismiss message. BUG=1123947 R=lazzzis@chromium.org Change-Id: I28b58ed080dd63045f2e18f13e3875fabd9764e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472599Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#825040}
-
Charlie Hu authored
As |chrome::ShowWarningMessageBoxWithCheckbox| accepts |base::OnceCallback| as its last parameter, the call site should use |base::BindOnce|. Bug: 1007635 Change-Id: I5e437d37ba1573cf552a2a51916a2e34831ffe32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522212Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#825039}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/639610df4433..df58b821059d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tinazwang@google.com,xiaochengh@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tinazwang@google.com,xiaochengh@google.com Change-Id: Ib7219a1d2bd371c21ce70a24ee04372be50e177d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522609Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825038}
-
Guido Urdaneta authored
This CL adds an UnderlyingSinkBase implementation that takes VideoFrames and sends them to a PushableMediaStreamVideoSource. This is intended to be used by Raw Access Insertable Streams (a.k.a. BreakoutBox) Bug: 1142955 Change-Id: I0da46c1867e1ce745f69da7ea10be4d9a00a8606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514400 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#825037}
-
Moe Ahmadi authored
Provides repeatable query suggestions to be shown in the NTP MV tiles when Google is the default search provider. The repeatable queries are requested from the server for signed-in users and extracted from the URL database for unauthenticated users. Fixed: 1106396, 1110077 Change-Id: I749739cb4382d83f21256430428a60c5f1d563bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518773 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#825036}
-
Andrew Xu authored
As demonstrated by the specs, there should be an 8-pixel gap between the text and the delete button. Bug: 1131731 Change-Id: Iedcc98ba4253d10ec3acdf828f6d5eab21d6ee47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523370 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Commit-Queue: David Black <dmblack@google.com> Auto-Submit: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#825035}
-
Nick Burris authored
These switches are no longer used by internal testing so they can be removed. This also removes ExternalAuthUtils' dependency on chrome. Bug: 1145663 Change-Id: I5ee1468bd78bd9bd7b3b0bf041aed214bb5e6016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518803Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#825034}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/49d9785e4224..156c227d6cf2 2020-11-06 geofflang@google.com Remove the amend commit from roll_aosp.sh 2020-11-06 cnorthrop@google.com Capture/Replay: Restore buffer bindings during Reset 2020-11-06 geofflang@google.com Always use the -f flag with rm in roll_aosp.sh 2020-11-06 jmadill@chromium.org Update DevSetup. 2020-11-06 amaiorano@google.com Re-enable GLES31 test that is no longer flaky 2020-11-06 jmadill@chromium.org Perf Tests: Add --max-steps-performed argument. 2020-11-06 geofflang@google.com Fix wrong working directory for roll_aosp.sh 2020-11-06 jmadill@chromium.org Symbol Table: Error on duplicate group keys. 2020-11-06 geofflang@google.com Check out depot_tools in roll_aosp.sh 2020-11-06 syoussefi@chromium.org Vulkan: Remove vertex attribute aliasing suppressions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Test: Test: Capture Clash of Clans Change-Id: I23efe90faa66cf782987b2d3e6785943fb7154ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523434Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825033}
-
Gordon Seto authored
Add ability for users to switch between cameras when scanning for QR codes on the Activation Code Page. Screenshot: https://screenshot.googleplex.com/jacMJUL3HhZAAr2.png Bug: 1093185 Change-Id: I32282cd62e0b98c72d4a76c5257b3e6f02f111c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510740 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#825032}
-
David Tseng authored
R=dmazzoni@chromium.org Test: compiles, passes existing tests. Change-Id: I543899d7cc231df8b1748b1d614e36d482acf789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520802Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#825031}
-
Jimmy Gong authored
- Phonehub will now be hidden in lockscreen, preventing notifications and controls from appearing in the lockscreen. - A followup CL will handle the suspend state of the Chrome OS device. Bug: 1139415, 1106937 Test: chromeos_components_unittest, ash_unittests Change-Id: Ie06dc84e22db98032e4f1479f4db5e4df0c1290d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516248Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
-
Natalie Chouinard authored
Add feature flag for enabling ChromeStartupDelegate, to be used downstream. Bug: 1143402 Change-Id: I12a56e7927d204efd4f1f487e3256b30d487f5f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523359Reviewed-by:
-
Xiaocheng Hu authored
Bug: 1146560 Change-Id: Icbbb104dafc57e1abdc1aa540265896ac96357f2 NoTry: True Tbr: fserb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521949Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#825028}
-
Mei Liang authored
Change-Id: I3becc899943b0e3aeb2eb06a3f9d3fc84f738e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522006Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#825027}
-
Robert Sesek authored
Use base::TimeDelta instead. Change-Id: I8065fbb31e0360180ed2d201fd3a1c31c20b8144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522237Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#825026}
-
Tina Wang authored
This reverts commit 683608bf. Reason for revert: The newly added test UNSCHEDULED_tab_search keeps failing the build: https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome Please take a look and help fixing. Original change's description: > Tab Search: Implement performance benchmark > > Doc: > https://docs.google.com/document/d/1-1ijT7wt05hlBZmSKjX_DaTCzVqpxbfTM1y-j7kYHlc > Usage: > tools/perf/run_benchmark run UNSCHEDULED_tab_search --browser-executable=out/Default/chrome --story-filter=tab_search:top10:2020 > tools/perf/run_benchmark run UNSCHEDULED_tab_search --browser-executable=out/Default/chrome --story-filter=tab_search:top50:2020 > tools/perf/run_benchmark run UNSCHEDULED_tab_search --browser-executable=out/Default/chrome --story-filter=tab_search:top100:2020 > > Change-Id: I684024f9cf3264ac2ed4feca15c6059342a493c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461224 > Commit-Queue: Yuheng Huang <yuhengh@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824599} TBR=johnchen@chromium.org,tluk@chromium.org,yuhengh@chromium.org Change-Id: If919a1e96f43a661f72e3f33f59f590922790644 No-Presubmit: true No-Tree-Checks: true No-Try: true bug: 1146335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523416Reviewed-by:
Tina Wang <tinazwang@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#825025}
-
Matt Jones authored
Change-Id: I4f229ae0932f031a9083761a2fd0b09932f6c5a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523487 Commit-Queue: Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Gang Wu authored
This is follow up CL for https://chromium-review.googlesource.com/c/chromium/src/+/2500274 Since ViewHighlighter provide 3 type of IPH now, we rename turnOnHighlight to turnOnCircularHighlight(View) turnOnRectangularHighlight(View) turnOnRectangularHighlight(View, int) Bug:1146243 Change-Id: Id36dab8992f848fa33569ebba23a377ffd0f0fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521782Reviewed-by:
-
Eric Lawrence authored
To mitigate "tab-napping" attacks, in which a new tab/window opened by a victim context may navigate that opener context, the HTML standard changed to specify that anchors that target _blank should behave as if |rel="noopener"| is set. A page wishing to opt out of this behavior may set |rel="opener"|. Bug: 898942 Change-Id: Id34bbc480e96cb2cc8e922388a9a5bc4161b03b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630010Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#825022}
-
Kevin McNee authored
Bug: None Change-Id: I5308a19ad12f3b0ba59c33bef603f2ff5a0882a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523439 Commit-Queue: Kevin McNee <mcnee@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#825021}
-
Torne (Richard Coles) authored
The DEVELOPMENT_TOOLS permission group was removed from the framework many releases ago, and it's recently become an error to define a permission in a nonexistent group. Just remove the permission group from the declaration; it only ever affected how permissions were shown in the device permissions UI and since the group was deleted has been a no-op. Fixed: 1143827 Change-Id: I636aa0d5f9d6f27e51aa5b5fa15b2e5a6339dda7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522983 Commit-Queue: Richard Coles <torne@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#825020}
-
Jeff Yoon authored
This reverts commit f19f9e01. Reason for revert: crbug/1144638 The changes have worked for webrtc, but is causing failures for iOS official bots. We'll wait for the autoroll and ensure that CL is in place before re-landing this if that's okay. Original change's description: > Reland "[DEPS] update luci-go" > > This reverts commit 94863f6a. > > Reason for revert: > https://crrev.com/c/2518615 fixed the previous issue. > > Original change's description: > > Revert "[DEPS] update luci-go" > > > > This reverts commit 1585878b. > > > > Reason for revert: > > https://crbug.com/1144638 > > https://crbug.com/webrtc/12126 > > > > Original change's description: > > > [DEPS] update luci-go > > > > > > Bug: 1142713 > > > Change-Id: Id330d0c9a0e225e5fbf8ae12abeb6b8d55f46262 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507246 > > > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> > > > Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> > > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#822547} > > > > TBR=yyanagisawa@google.com,tikuta@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 1142713, 1144638, webrtc:12126 > > Change-Id: Ie06d7c40065630f28ac44fe6f2dac82f91e64da1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517405 > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#823859} > > TBR=yyanagisawa@google.com,tikuta@chromium.org,mbonadei@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1142713 > Bug: 1144638 > Bug: webrtc:12126 > Change-Id: I3cdb4d01a5d603b95d03b93b8dd43d81a84f7a2b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519179 > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824332} TBR=tikuta@chromium.org,mbonadei@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1142713 Bug: 1144638 Bug: webrtc:12126 Change-Id: I33f3cf4b84818a8abbf5d468fb9165543af5f434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522982Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#825019}
-
James Hawkins authored
'HEAD' will work when 'master' is renamed to 'main'. Change-Id: Ib59537426e942fcc7ff879c65d6c2eafbff98d69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523391 Auto-Submit: James Hawkins <jhawkins@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#825018}
-
Chris Hamilton authored
Currently there are handful of crashes from Android devices where the browser thinks that IFrameAttributionData should accompany an IPC, but where the renderer isn't sending it. The current browser code conflates two frames being in the same site instance (and hence being LocalFrame parent-children) with two frames being in the same process (it's possible for multiple distinct site instances to fold into the same process). BUG=1146223 Change-Id: Ic0af49bbc7dfab0a5c9af8df4d1c59dcd93f4580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522920 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Auto-Submit: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#825017}
-
Becca Hughes authored
At the moment in Lacros there are two instances of the Media Session Service (MSS) one hosted in ash-chrome and the other in lacros-chrome. This means that sessions in either browser process cannot see sessions from the other. This changes it so when a client asks for lacros-chrome MSS instead of providing a locally hosted MSS it binds the MSS in ash-chrome. BUG=1140215 Change-Id: Ic155a6cd928f0735095f849f309f9075dbb1d36f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485850Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#825016}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604663931-0e7a1a6cfe18868c94b28acade631941d35c92c1.profdata to chrome-mac-master-1604685414-2abb4e2cac01a52ceef5c593f56dfdc41a4ae764.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie589b0919a2d726eb5c6f696474c45c6746149a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523374Reviewed-by:
-
Darin Fisher authored
Bug: 993189 Change-Id: Ifa69e4e87910ad8be6caca11b6cc4e0c2e4180f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520170Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604663931-9bcb947a0377607416b3fb61f11cb5b7ddd933e4.profdata to chrome-linux-master-1604685414-a20e427b698b46e98f8368e23a59bee4b5e7a307.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4278824818a38c0d254b11afba95f786b398e293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523534Reviewed-by:
-
Lukasz Anforowicz authored
Navigations to about:version should either be blocked by RenderProcessHostImpl::FilterURL or rewritten to navigations to chrome://version/ by url_formatter::FixupURL. This CL tries to help catch cases that violate this assumption, by adding an early NOTREACHED and DumpWithoutCrashing calls. Bug: 1145717 Change-Id: Icbae9530ca851ae55d44947ac2f8efb754beec90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519861 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#825012}
-
Yulun Wu authored
Bug: 1146141 Change-Id: I9d3a6dcb37f0435e29ee506bb0c7c2d678435332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522632Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825011}
-
François Beaufort authored
This CL makes sure PictureInPictureWindowControllerBrowserTest SurfaceIdChangeDoesNotMoveWindow test is disabled on Linux while we're investigating the reason why. Bug: 1146047 Change-Id: I4b0579109f2ebfe71ba786df471b86237d027384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521613Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#825010}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1e9cf1a8e1bd..31623e15a8a0 2020-11-06 fmayer@google.com Increase maximum frame limit. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic366e379d1f7990e29f593c745266385b7bb381a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523431Reviewed-by:
-
Tomasz Wiszkowski authored
This change enables errorprone basic null checking. The new flag will raise an error when a @Nullable argument or variable is not checked before being used. The code updates all sites that declared parameters as @Nullable without subsequently checking their values to @NonNull. The change should help push forward the effort to enable the NullAway errorprone extension Bug: 1022427 Change-Id: I6c1e87d87fad98252c3cc3916e3a1034cf4eb8cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521294 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
-
danakj authored
This converts to using the skia::mojom::Bitmap serialize functions to turn an SkBitmap into a string and back for putting into a base::Value and sending over IPC. TBR=senorblanco Bug: 1144462 Change-Id: I10f28bff10aed703e59c500e7f4668f557b51785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521203 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#825007}
-
Jazz Xu authored
This CL makes the following changes: 1. Modified layout so that the title/artist text will have more spaces to the left border when artwork is hidden. 2. Hide artist label and center title label vertically if artist is empty. 3. Modify artwork image so that it will always appear as a square. (If the artwork is not a perfect square, we will scale it up/down and clip the center square of the artwork.) 4. Fix drop down arrow layout bug. Bug: 1144309 Change-Id: If0c7b0af690483644dede6866f54cde4e3beb2ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522675Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825006}
-
Nicolas Ouellet-Payeur authored
One of the histograms was expiring soon, and they all had different expiry dates. Use the same expiry date for all BrowserSwitcher.* histograms, to reduce maintenance burden. Bug: 1138384 Change-Id: I8713ce8519e90faf1c690d0c83c7cf67910f87ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514620 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#825005}
-
Ivan Murashov authored
Without default return value GCC produces a lot of warnings like: ../../base/bind_internal.h:773:1: warning: control reaches end of non-void function [-Wreturn-type] Added return false by default to suppress the warnings. Bug: 819294 Change-Id: I593cd48bf336cb5e7614592a507451a67e0ec1d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520819 Commit-Queue: José Dapena Paz <jdapena@igalia.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#825004}
-
Chong Gu authored
Bug: 1145861 Change-Id: Ibfde85a2832ee6a5124ea417a54acc94b2ea57b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522880Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#825003}
-
