GitLab

Build has migrated to LUCI.

R=danakj@chromium.org

Bug: 839600
Change-Id: I15fab6330a0215b4edf14318993ae4608d269dbe
Reviewed-on: https://chromium-review.googlesource.com/1044772Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556191}

Recent changes that removed some includes such as a92b7636 ("[MessageLoop]
Fix random IWYU preventing message_loop.h cleanup") and
629ba73c ("[MessageLoop] Fix message_loop.h includes") have broken the
build with libstdc++, as secure_display_link_tracker.h uses std::find() but
relied on it being included implicitly by other headers:

    In file included from ../../base/memory/weak_ptr.h:77:0,
                     from ../../content/renderer/media/stream/media_stream_video_source.h:13,
                     from ../../content/renderer/media/stream/media_stream_video_source.cc:5:
    ../../content/renderer/media/stream/secure_display_link_tracker.h: In instantiation of ‘void SecureDisplayLinkTracker<T>::Add(T*, bool) [with T = content::MediaStreamVideoTrack]’:
    ../../content/renderer/media/stream/media_stream_video_source.cc:55:34:   required from here
    ../../content/renderer/media/stream/secure_display_link_tracker.h:32:19: error: no matching function for call to ‘find(std::vector<content::MediaStreamVideoTrack*>::iterator, std::vector<content::MediaStreamVideoTrack*>::iterator, content::MediaStreamVideoTrack*&)’
       DCHECK(std::find(insecure_links_.begin(), insecure_links_.end(), link) ==
              ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../../base/logging.h:888:54: note: in definition of macro ‘DCHECK’
     #define DCHECK(condition) EAT_STREAM_PARAMETERS << !(condition)
                                                          ^~~~~~~~~

Bug: 819294
Change-Id: I1e747d7e15a7be74460012fbe5f207368744114b
Reviewed-on: https://chromium-review.googlesource.com/1043749Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#556190}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/15759121361d..142a92ce8b83

$ git log 157591213..142a92ce8 --date=short --no-merges --format='%ad %ae %s'
2018-05-04 tandrii auth: request refresh tokens with expiry <3 minutes.

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:837087


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Iecb1a28f1e5ffa180639739105193b8f4e5e26d5
Reviewed-on: https://chromium-review.googlesource.com/1044948
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556189}

An unmapped tab can still have an associated |tab_node_id| (e.g. a
foreign tab that has been closed), so the assumption behind the CHECK
prior to this patch was wrong, and the implementation buggy.

According to the reports we've investigated, this scenario occurs for
both local and remote sessions.

Bug: 837517
Change-Id: Ic436fe9eacce131fef5d0394bdfff34d9aedc5b3
Reviewed-on: https://chromium-review.googlesource.com/1044211
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556188}

We were not considering that type attributes in scripts could be
wrapped in quotes.

Change-Id: Id2fd4859c1e1a68bd28bebe6fea46a62b58e417a
Reviewed-on: https://chromium-review.googlesource.com/1043463
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556187}

This Cl resets the suggestion image so that the entity image is not seen
in a non-entity result.

Bug: 839578
Change-Id: I398aee581b559dd8a59ad2d55581f5d55cbbfea5
Reviewed-on: https://chromium-review.googlesource.com/1043101Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556186}

TBR=smut

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6993d7df263e1ffd1a10a4d11fe3b29a66f20f9c
Reviewed-on: https://chromium-review.googlesource.com/1044710
Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org>
Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556185}

https://skia.googlesource.com/skia.git/+log/05cfcff70ced..b9a1e688fd9c

$ git log 05cfcff70..b9a1e688f --date=short --no-merges --format='%ad %ae %s'
2018-05-04 liyuqian Respect SkBitmapDeviceFilteredSurfaceProps in SkThreadedBMPDevice
2018-05-04 benjaminwagner [infra] Move GCE tasks to smaller/larger VMs.
2018-05-04 bungeman Allow finer rotation in Viewer app.
2018-05-04 robertphillips Revert "Fix a bug in SkGpuBlurUtils::GaussianBlur (take 2)"
2018-05-04 bsalomon Remove unused SK_DISABLE_ARC_TO_LINE_TO_CHECK build flag
2018-05-04 bsalomon Remove could not invert matrix SkDebugfs
2018-05-04 mtklein Don't use getDeviceClipBounds() to bound pic ops.
2018-05-02 herb Remove android specific code
2018-05-04 bungeman Avoid drawing BW clipped color glyphs many times.
2018-05-04 fmalita [skottie] Disable on Android Framework builds
2018-05-04 borenet [recipes] Remove core.setup()
2018-05-04 robertphillips Make degenerate kernel in fill_in_2D_gaussian_kernel sum to 1
2018-05-04 robertphillips Fix a bug in SkGpuBlurUtils::GaussianBlur (take 2)
2018-05-04 caryclark Revert "Reland "remove obsolete color defines""
2018-05-04 bsalomon Make RenderDoc work automatically with GLX viewer

Created with:
  roll-dep src/third_party/skia
BUG=chromium:836113


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: Ia3664eaddce0f59e7cb22413152bbe6375884eec
Reviewed-on: https://chromium-review.googlesource.com/1044782
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556184}

This CL adds small tweaks to the UI and layout to bring infobar closer
to Phase 1 design.

Bug: 804652
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib8da40c032387eb9f7f06ad60e6c3283dea56bf8
Reviewed-on: https://chromium-review.googlesource.com/1036541
Commit-Queue: Peter Lee <pkl@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556183}

This CL handles the remaining UI events(scroll/generic motion events)
by forwarding them to native first like the others. They are later
consumed by content components such as JoystickHandler or converted
to other events.

ContentUiEventHandler does the conversion when necessary, and sends
the events down to the associated RenderWidgetHostViewAndroid rather
than putting them back on the view android tree since we are already
at the point of having found the event handler that will consume them.

Bug: 622847
Change-Id: I8aba396c0545cdc8ae3a6f566da54c2707a460c4
Reviewed-on: https://chromium-review.googlesource.com/999236Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556182}

Currently, AppLaunchController assumes that AppLaunchSplashScreenView,
owned by OobeUI, is around during AppLaunchController destruction. Both
AppLaunchController and OobeUI lifetime is controlled by
LoginDisplayHost, but OobeUI is technically owned by login window
(which gets created by LoginDisplayHost, and closed on LoginDisplayHost
destruction).

Whether AppLaunchController get deleted before or after
AppLaunchSplashScreenView largely depends on how the login window is
closed/destroyed - generally the window is destroyed asynchronously
when LoginDisplayHost goes out of scope, in which case AppLaunchController
is deleted before the splash screen view, but this does not seem to be
guaranteed.

For example, in AutoLaunchedNonKioskEnabledAppTest.NotLaunched test with
mash enabled, oobe_ui gets deleted synchronously when ScopedKeepAlive
owned by LoginDisplayHostCommon gets deleted (which happens before the
AppLaunchController is deleted) - ScopedKeepAlive going out of scope
causes MusClient to start closing all widgets.

To work around this have AppLaunchSplashScreenView notify its delegate
(i.e. AppLaunchController) when it gets deleted, so the delegate can stop
referencing it when that happens.

Technically, the linked bug could be fixed by ensuring that app launch
controller is deleted before ScopedKeepAlive, but that seems more
fragile, and it doesn't necessarily address all concerns (e.g. the case
where login window is removed for a reason other than login display host
destruction).

NOTE: The same applies to the ArcKioskController and
ArcKioskSplashScreenView.

Bug: 838992

Change-Id: I9b31293e791c1f8980e780e69f6061f87a968095
Reviewed-on: https://chromium-review.googlesource.com/1041485Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556181}

The test was taking too much time in debug mode.
This CL improves the time needed to test by not editing the session using the UI.

Change-Id: I9809dc08b15deb988f3bbc09b00d3f4ba0a5eda8
Reviewed-on: https://chromium-review.googlesource.com/1042998
Commit-Queue: Martin Rodriguez <rodmartin@google.com>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Georges Khalil <georgesak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556180}

Splits downloadEntry into UkmInfo and InProgressInfo,
added new information needed to resume the download item after chrome crashes.


Bug: 803135
Change-Id: Ided64d9801a3e8e1d8390a4190d17aa3b58d652c
Reviewed-on: https://chromium-review.googlesource.com/1036539
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556179}

Bug: 522298, 839951
Change-Id: I106c081d21c69b3802d4e50ce8ce74f54f6590b1
Reviewed-on: https://chromium-review.googlesource.com/1043252
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556178}

Created as two separate methods, one for reports and one for clients,
to avoid polluting the interface with a data_type_mask as is used
internally. Also, to avoid dealing with confusing difference between
always-true filter and null filter when they should logically be
equivalent, cleaned up ReportingCache to explicitly have two separate
clear data methods, one that clears everything without filter and one
that always assumes it has a valid filter.

Bug: 824997
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: If8fc3698eb61efbdee566dbd55e649723ff1e3d8
Reviewed-on: https://chromium-review.googlesource.com/1038524
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556177}

TARGET_AND_DESCENDANTS event targeting policy does not work properly
under mus/mash. As a result, mouse events are not delivered to
the windows under ExoShellSurface in SystemModalContainer even though
ExoShellSurface says it does not handle the events.

Use DESCENDANTS_ONLY for mus/mash until event dispatching code is
fixed to handle such case.

Bug: 839521
Change-Id: I8e949164d2cd9666468a8995d0bdb8e29f6b9301
Reviewed-on: https://chromium-review.googlesource.com/1044542
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556176}

Add a manually triggered GPU trybot that runs the same configuration
as "Win7 FYI Release (NVIDIA)".

Bug: 838895
Change-Id: I2a2f87ee7b452200a860282b01c673493adbea00
Reviewed-on: https://chromium-review.googlesource.com/1044767Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556175}

1) Update the UI to be the same with the web-ui implementation.

2) Add a button to lock_debug_view.cc|h for easy debugging.

Bug: 836336
Change-Id: I89143c7db149dea31bc6848de18e6ecc6386f98b
Reviewed-on: https://chromium-review.googlesource.com/1044746Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556174}

The previous flakiness might be a device-specific issue that is seen in Intel
HD 530 but not Intel HD 630.

Bug: 690663
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I18b2c9822bf39cfbcd233e2219ac460eb51875b6
Reviewed-on: https://chromium-review.googlesource.com/1044656Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556173}

This CL simply adds the new policies and hooks them up the appropriate
local state preferences.  A follow up CL will start using the policies to
control chrome behaviour.

Bug: 834939
Change-Id: If8a0984a118383a375f2a72c71f0b1cf555fbb6a
Reviewed-on: https://chromium-review.googlesource.com/1032797Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Robert Shield <robertshield@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556172}

Bug: 776877
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4135777822e41a928906e5d42308afd36f8ee40f
Reviewed-on: https://chromium-review.googlesource.com/1044290
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556171}

Serial kernel logging is a deprecated feature of Zircon and should not
be used anymore. This uses a long-running SSH invocation of "dlog"
to pull the logs over the wire. It works equally well on QEMU and on
devices.

Created a stream multiplexer using "poll" to merge the kernel log and
application log into a single stream, which is passed to the symbolizing
filter.

Modified the symbolizer regex rules to allow kernel log timestamps.
Kernel log timestamps can be omitted from the output, but they seem
to be helpful at visually distinguishing kernel output from app output.


Bug: 838671
Change-Id: Icd45f902a49983b4e4ee262de474d69fbef56860
Reviewed-on: https://chromium-review.googlesource.com/1038423
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556170}

I intentionally didn't add "Foreground" to non "Background" workers as
they may be used for background tasks in some configurations and I don't
want it to be confusing for developers.

R=fdoray@chromium.org

Bug: 839525
Change-Id: I8c1e928914aa6d2e35fedc1db4e8a639d39116b2
Reviewed-on: https://chromium-review.googlesource.com/1044501
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556169}

https://chromium-review.googlesource.com/c/chromium/src/+/705955 ("base::flat_map
was missing defaults for duplication handling") removed them in favor of
inheriting them from flat_tree.

This can cause problems with GCC due to
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84782, and the build has been
failing with it since
https://chromium-review.googlesource.com/1000393 ("Mojo C++ Bindings:
unordered_map => flat_map") with a message like this:

    gen/mojo/public/interfaces/bindings/tests/test_unions.mojom.cc: In member function ‘void mojo::test::ObjectUnion::set_f_map_int8(const base::flat_map<std::__cxx11::basic_string<char>, signed char>&)’:
    gen/mojo/public/interfaces/bindings/tests/test_unions.mojom.cc:455:30: error: use of deleted function ‘base::flat_map<std::__cxx11::basic_string<char>, signed char>::flat_map(const base::flat_map<std::__cxx11::basic_string<char>, signed char>&)’
             std::move(f_map_int8));
                                  ^
    In file included from ../../mojo/public/cpp/bindings/clone_traits.h:11:0,
                     from gen/mojo/public/interfaces/bindings/tests/test_unions.mojom.h:22,
                     from gen/mojo/public/interfaces/bindings/tests/test_unions.mojom.cc:15:
    ../../base/containers/flat_map.h:152:7: note: ‘base::flat_map<std::__cxx11::basic_string<char>, signed char>::flat_map(const base::flat_map<std::__cxx11::basic_string<char>, signed char>&)’ is implicitly declared as deleted because ‘base::flat_map<std::__cxx11::basic_string<char>, signed char>’ declares a move constructor or move assignment operator
     class flat_map : public ::base::internal::flat_tree<
           ^~~~~~~~

Work around it by replacing the inheritance statements with actual
constructors and operator=() overloads again. This change does not
completely revert https://chromium-review.googlesource.com/1000393, as the
constructors maintain their new signature (so that they look like
flat_tree's).

Bug: 819294, 837221
Change-Id: I8f37a2c8aa269b3c1025cdc009518a7709e95947
Reviewed-on: https://chromium-review.googlesource.com/1038103
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556168}

We should set this field to distinguish HW codec implementations of Chromium
from SW codecs of WebRTC. googCodecName field already sets VP8/VP9/H264
information, so setting this field to a generic name "HW*coder" should be
enough.

Bug: 838739
Change-Id: I9936daef9a53b6f004ede357e37fd976ca0d9c9e
Reviewed-on: https://chromium-review.googlesource.com/1039023
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556167}

Bug: 829893
Change-Id: I245991138fe88d662d374ec2fe45e08424bd1366
Reviewed-on: https://chromium-review.googlesource.com/1036861Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556166}

This adds {win,mac}_chromium_compile_dbg_ng_patch_on_gclient to make sure that
patching on gclient works as expected.

Bug: 643346
Change-Id: Ife7cb26c1b699be50d85f5e629824e7f205781cd
Reviewed-on: https://chromium-review.googlesource.com/1043345Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556165}

This moves logging of bitstream errors that were previously in the GPU
log to the media log.

To support async destruction correctly, VdaVideoDecoder now implements
the MediaLog interface and handles thread hopping.

Also includes some additional cleanups in VTVDA: improved log messages,
increase the number of requested picture buffers to match recent changes
in DXVAVD, and returns no supported profiles if VideoToolbox fails to
initialize.

Bug: 522298
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7f13deb9e92fdeeeac60479e17081e72c5f22066
Reviewed-on: https://chromium-review.googlesource.com/1038609
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556164}

The SwiftShader library was failing to load properly when used as a WebGL
fallback because of a sandboxing issue. This cl works around that issue
by changing where the SwiftShader initializatin is done.

Credit to zmo@ for this fix, which I cherry picked from:
https://chromium-review.googlesource.com/c/chromium/src/+/1005017/20..21

Fixes:
gpu_tests.gpu_process_integration_test.GpuProcessIntegrationTest.GpuProcess_feature_status_under_swiftshader

Bug: chromium:726075
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I56a00cef70cb630bbf6d5fe7f342a8d5b1c2211d
Reviewed-on: https://chromium-review.googlesource.com/1042496
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556163}

When closing tabs, an observer immediately deletes snapshots from the
snapshot cache. This prevents snapshots from reappearing in an undo
close all tabs operation.

This CL enables snapshot restoration on undo close all tabs by extending
the life of a snapshot when closed with a "close all" operation. Note
this is only extended for regular tabs, not incognito tabs.

The extended life is accomplished by marking tabs for deletion during
a close all operation, rather than immediately deleting the image
from the cache. Later, the marked images are either purged from the
cache, or the marked list is cleared (therefore leaving the images in
the cache).

Bug: 804567
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4710bf46d3ebd4ad347563e5f6a6208a68a58209
Reviewed-on: https://chromium-review.googlesource.com/1041545
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556162}

In https://chromium-review.googlesource.com/c/chromium/src/+/1042500 I
missed a commit which added a crucial line :)

TBR=tedchoc@chromium.org

Bug: 837807
Change-Id: Ibc8f4f69e86ba16cfcff223c72b64481d9289549
Reviewed-on: https://chromium-review.googlesource.com/1044754Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556161}

We were too conservative in setting a larger-than-enough threshold for complete
idle task detection in canvas_async_blob_creator. Based on latest user
statistics, 5 seconds delay for desktop and 9 seconds delay for mobile are good
for 99% users. This long threshold might be contributing to the flakiness on
leak bot of the convertToBlob tests--the delayed task for current thread takes
too long to finish, even longer than the timeout limit of the test, causing a
JS object leak.

Bug: 836278, 787972
Change-Id: I01ced35c4f910b4193adec6f8b26d9a02885a279
Reviewed-on: https://chromium-review.googlesource.com/1042534Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556160}

Also, change the expected HTTP response code from 204 to a
list containing 3 codes (200, 404,and a 3rd one
configurable via field trial experiment).

Change-Id: I403841d93b9f7c8f9096e827ac67116658b15c82
Bug: 839628
Reviewed-on: https://chromium-review.googlesource.com/1043269
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556159}

This is a reland of 86dafb90

Original change's description:
> Add chrome enterprise logo in the theme_resources.grd
>
> The logo is located in
> default_100_percent/google_chrome
> default_200_percent/google_chrome
>
> Bug: 838156
> Change-Id: Id300ef64e70cdc92bcdbad89b5aad00bc5bbd777
> Reviewed-on: https://chromium-review.googlesource.com/1042491
> Reviewed-by: Greg Thompson <grt@chromium.org>
> Commit-Queue: Owen Min <zmin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556093}

TBR=grt@chromium.org

Bug: 838156
Change-Id: I4f05111772577a3b68e1dcea1550792268cabbb0
Reviewed-on: https://chromium-review.googlesource.com/1044572Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556158}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/848c86e3e858..15759121361d

$ git log 848c86e3e..157591213 --date=short --no-merges --format='%ad %ae %s'
2018-05-03 tandrii Update windows bleeding-edge git to 2.17.0

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:811681


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I316a0f743f65642a2c299797055256ab9f9f5dd5
Reviewed-on: https://chromium-review.googlesource.com/1044544Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556157}

Bug: 769012
Change-Id: Iae7e7ff1b338c2302476002c28dcc58378292404
Reviewed-on: https://chromium-review.googlesource.com/1028617
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556156}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: I55617b91fb756ad4f2d94b02dbc6b39b812cf7ce
Reviewed-on: https://chromium-review.googlesource.com/1044890Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556155}

Make the docked magnifier follow touch events.

BUG=837285
TEST=Added new test

Change-Id: Id1fdbe047cdcbf3e8cd35cbf5ddd8712c0c3828c
Reviewed-on: https://chromium-review.googlesource.com/1044493Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556154}

Removes divs from Clear Browsing Data, Accessibility,
   Site Settings, and Site Settings sub pages

Bug: 834600
Change-Id: I28afdc9e4a3823b082dc22da6c44653eabfcdb84
Reviewed-on: https://chromium-review.googlesource.com/1044273
Commit-Queue: Daniel Park <danielpark@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556153}

Use server-controlled 1) maximum number of peeks and 2) minimum delay
in seconds after page loaded to adjust whether to auto peek the bottom
sheet on reverse scroll.

Bug: 833865
Change-Id: I021f94236d8f59a8fac9057b80130e4326517c4e
Reviewed-on: https://chromium-review.googlesource.com/1040345Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556152}