GitLab

Remove speculative debug CHECK added in crrev.com/c/1705014.

Bug: 969135
Change-Id: I18d7867d6ba82818db2eb9992687c1541886b420
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783881
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Auto-Submit: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693376}

Change the LocalizedLandmarkType and LocalizedControlType for the
contentinfo aria role from "content info" to "content information" per
https://www.w3.org/TR/core-aam-1.1/#role-map-contentinfo.

Also update the LocalizedLandmarkType for <footer> when scoped to the
body element to "content information", since it inherits this from
the contentinfo role per https://w3c.github.io/html-aam/#el-footer.

Note that this doesn't affect <footer>'s LocalizedControlType,
which should be "footer" (but is currently still "content info").
That is handled in the separate change at
https://chromium-review.googlesource.com/c/chromium/src/+/1763243.

Bug: 997897
Change-Id: If958b2090447010f0c0f3839739354dd4a0ea683
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772228Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Commit-Queue: Dan Clark <daniec@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#693375}

This CL creates a chrome:flags entry for UseFakeDeviceForMediaStream,
allowing for ChromeOS clients to replace the audio/video capture
devices in the system with a fake capture device, a venerable PacMan
with a timestamp.  Such fake webcam has been around forever for
testing and verification, in the form of a command line, that is
used in a bazillion places, so this CL basically checks the FeatureFlag
and appends the command line if needed, in MediaStreamManager, the
singleton hanging from BrowserMainLoop where media capture first
starts.

The purpose of this flag is to facilitate debugging of webrtc+video
capture on ChromeOS, by allowing the developers to switch off the
capture stack entirely, verifying the WebRTC stack in isolation.

Bug: b:140250310
Change-Id: Iac8ff27ac3cc1a178d58661f53b0ea9737f6d10f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783308Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693374}

Bug: 992121, 992381, 988351, 997741
Change-Id: Ib243ea0a34fb001ea2ace63cef9017927c27c13a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779424
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693373}

This CL regenerates mixed-content test files that reflects
changes [1] and previous changes in https://crbug.com/906850
and removes old files.

Purely mechanical.
This CL largely renames test file names, and [2] contains
old->new file name mapping data.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1586548
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1783799

Bug: 906850
Change-Id: Ic13f66750bd3f45a362ed92fc5aaa4844420b474
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783800Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693372}

This patch turns a DCHECK into CHECK to verify if the DCHECK is still
hit on production builds.

This patch will be landed into version 3903, and will be reverted in
the next version.

Bug: 996037
Change-Id: Ice5237e9a0761b991425b1dbe402350a6ddd9b86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784161Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693371}

The current behavior for a popup is to destroy it, create it and destroy it
again if the element which was clicked/tapped was already owning the popup.
This behavior is causing a flicker effect when animation/drop shadow is added
to the popup.

This behavior can be changed to just store the popup, send the event
to the element and later destroy the popup if needed.

The popup will be destroyed in the following cases:
1. when another element which could open a popup was clicked/tapped
- WebViewImpl::OpenPagePopup is going to call CancelPagePopup
2. when the user has clicked/tapped outside of the popup or on the element which
had already a popup opened - by checking if the saved popup is
the same as the current one

Because of the way EventSender::HandleInputEventOnViewOrPopup is implemented
adding a web_test will not be able to test the impacted scenarios: a popup
should be dismissed when clicking outside of its area and another one should be
opened when clicked/tapped on an element which supports having a popup
(if first popup owner != second popup owner).
Currently EventSender::HandleInputEventOnViewOrPopup will always send the input
event to the popup if there is one. The real world implementation is that the popup
will not receive the event if the click/tap event is outside of its area and the
WebView is responsible for dismissing it.

Bug: 992238
Change-Id: I13b7848e6e734e981d4fb9782e68a3d8123bc5ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745769Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#693370}

Example of failure: https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win%20Builder/4011

Bug: 997673
Change-Id: I25453b2750346e5ee460d76dc4ead6555de11fad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785218Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693369}

Bug: 988639
Change-Id: I354df80a573bf76e114e7f693017c00266621a57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783442
Auto-Submit: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693368}

This adds UMA metrics when a user clicks on the help text in a Click to
Call dialog. We also log which dialog type was shown at that time.

Bug: 995253
Change-Id: If22ca2ee5ec984015f8ef4c771997aa815abe2ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774933
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Alex Chau <alexchau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693367}

The feature is currently default enabled and the flag is expired.

Bug: 1000506
Change-Id: I51911054286297e2bdc071379940603008898422
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784022
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Auto-Submit: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693366}

This update contains implementation of lock which covers Windows.
That makes libphonenumber thread-safe on all platforms.

updated for >2 years.

Binary-Size: this is an update of third_party library, which wasn't
Bug: 976328
Change-Id: I1a2ea13436e2e735eb18a8da481ddd9d630c5fe3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761271
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693365}

- CupsPrinterManager will now detect for network changes.
- Previously, when the network changes CupsPrintersManager would
  wait until ZeroConfDetector updates with new printers.
- This resulted in a small time frame in which CupsPrintersManager
  would still retain stale printers from the previous network.
- This fixes that bug by clearing the all printers upon a network
  change, ensuring only new printers are populated.

Bug: 779602
Test: unittests, end to end manual
Change-Id: I0efe9e0a2252378bca178dc4b6dcea4da6baa978
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764677
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693364}

Bug: 998625
Change-Id: I97a94d94e8fb0e364c0c595c2289079b7e062e83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785100Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693363}

This CL adds separate NotificationChannels for quiet (icon only) and
heads-up (icon + pop-up) permission request notifications, and uses
the newly added kQuietNotificationPrompt value to select the
appropriate channel when displaying a notification permission request.

Bug: 986737
Change-Id: I9b181fb4bcb964fdd065df51b6370ba327070b2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766488
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693362}

This change adds the following metrics to measure if the option
of having the infobar is the best UI option and how disruptive
the experience of having the infobar be automatically replaced
by the keyboard while the keboard is active.

Metrics:
- Number of times the keyboard is automatically replaced by the Infobar
- Duration from when the keyboard is replaced until when the user decides to
  cancel the infobar (not click confirm) to get out of the verification flow.

Bug: 999238
Change-Id: I743028063e8f788270c6c17c15e646b4558df236
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777118Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693361}

Per UX guidance on crbug.com/978380, hide the list of users who are
allowed to sign in when the "Restrict sign-in to the following users"
toggle is in the off position, rather than disabling it.

Bug: 978380
Change-Id: I139955f79ca00efd7024b1626f49521bf472447a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784964Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693360}

Test fails on Windows.

TBR=dalecurtis@chromium.org

Bug: 1000396
Change-Id: I7afae1373abe4afeb88b6993852c35934f63fe36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784131Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693359}

Noticed this as part of another CL. No need to bind the interface (which
associates it with a task runner and creates the necessary objects to
receive replies) until adoption actually occurs.

This makes the parallel construction between the Portal and PortalClient
more obvious (they're both pending or not-pending at the same time).

Change-Id: Icd0b92501eb97f0903faf3cc53a650fc6f5de815
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784940
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Auto-Submit: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693358}

Bug: 988624
Change-Id: I17d50d7f51a404ed9ebf61fae82374ec4e3a3d31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783441
Auto-Submit: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693357}

The value of the "origin trial freeze policy" of a page is updated
by the FreezeOriginTrialPolicyAggregatorAccess, which aggregates
policies from the page's current frames.

Bug: 999594
Change-Id: I8d71a4639ffb1e78854e82c3a309854ca0a6cd08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779106
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693356}

ExecuteWindowCommand will now check for nonblocking execution that
results in target navigated or closed error. When detecting this case,
the command will be retried.

Bug: 999026
Change-Id: I7c06b6a75887c98b842ffd82ec4b241fd9c0e117
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785277Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tricia Crichton <triciac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693355}

https://chromium.googlesource.com/catapult.git/+log/a9cf4462bf62..53a464d7b4f6

git log a9cf4462bf62..53a464d7b4f6 --date=short --no-merges --format='%ad %ae %s'
2019-09-04 sadrul@chromium.org dashboard: Use faster API to get list of metrics.

Created with:
  gclient setdep -r src/third_party/catapult@53a464d7b4f6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC simonhatch@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=simonhatch@google.com

Bug: chromium:998988
Change-Id: I4298601add2934c0ba25f9d9e0e7f4f0a4e1bb89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782762Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#693354}

Again due to string proto fields, the FCM protos will now be base64
encoded.

Bug: 980777
Change-Id: Ie3ea60532b1a0e88f5ffeda4c15353342caf5ed1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785002
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693353}

+ Some plumbing to forward args to the test runner.

Bug: 989654
Change-Id: I61ecbf26ab02fae7aa0792bfbdffbc9cc020b3fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768665Reviewed-by: Andrew Luo <aluo@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693352}

- Restamping the nearby printers element will make nearbyPrinters
  requery for a new set of printers whenever |canAddPrinter| is
  flipped to true.

Bug: 779602
Change-Id: I6dfeebfaa57d615affb8209bba8d23765d43f0f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779563
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693351}

When the AppListView was chached,
AppsContainerView::UpdateControlVisibility was accidentally being called
on closing. This unintentionally set the visibility of many elements to
false. Return early if AppListView is being closed.

Bug: 992335
Change-Id: I2dfd4db9354ff5e5c2324a963ebbb23df35920ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783912Reviewed-by: Matthew Mourgos <mmourgos@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693350}

The test is flaky on Chrome OS and Linux.

TBR=dgozman@chromium.org

Bug: 1000654
Change-Id: Ibef73f609154fd2bd9ab37511b40f96d1822c05d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784880Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693349}

If a value is not provided by the server we fall back to a sane default
on the client side that can handle the intent.

Bug: 1000340
Change-Id: I6714cb617eb9721ab991bf22eda9fd2d1cb9f4c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783859
Commit-Queue: Ben Goldberger <benwgold@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693348}

https://android.googlesource.com/platform/external/perfetto.git/+log/9b34717a9016..65b7843ab9b6

git log 9b34717a9016..65b7843ab9b6 --date=short --no-merges --format='%ad %ae %s'
2019-09-04 taylori@google.com perfetto-ui: Move viewport if no search result

Created with:
  gclient setdep -r src/third_party/perfetto@65b7843ab9b6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I5214723f10e7d7e566cf5edece1e4880afaf62a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783865Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#693347}

This is a reland of 40c58fd0

Relanding because it was not causing test failures after all.
See https://crbug.com/1000694#c6

Original change's description:
> Refactor UpdateScreen
>
> Divide UpdateScreen class into UpdateScreen and VersionUpdater classes. The latter is responsible for communication with UpdateEngineClient and NetworkPortalDetector, and UpdateScreen is responsible for screen's specific logic only.
>
> The purpose of it is to make possible creation of another update screen.
>
> Bug: 997841
> Change-Id: I8a77403dc8e86f304e10021a9d690c015cf8a14a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771596
> Commit-Queue: Petr Smirnov <petrsmirnov@google.com>
> Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#692636}

TBR=petrsmirnov@google.com

Bug: 997841, 1000694
Change-Id: I72874266b405c8aaa128482a066546d7601cce6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784332Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693346}

This CL adds support for PIP (Picture in Picture) window state when
querying ARC window state via autotest_private_api.

This is needed because we are replacing "dumpsys" with "dumpsys --proto"
and "dumpsys --proto" does include the PIP state.
And besides that, it is better to query Ash, than Android, for ARC
states.

TEST=Calling "ash.GetARCAppWindowState" from Tast returns PIP on PIP ARC
     windows.
BUG=chromium:1000774

Change-Id: I4096ab205836f3f3f8b1d4eb964321dd62df77dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785058Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Ricardo Quesada <ricardoq@chromium.org>
Auto-Submit: Ricardo Quesada <ricardoq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693345}

Also rename the RemoteCocoa flag to be kAppShimRemoteCocoa. Scope this
flag to only control RemoteCocoa (the actual app shim is still created),
since that has been more helpful in debugging. Also disable the app
shim menu when RemoteCocoa is enabled.

Bug: 982024
Change-Id: I4a083d4aae892e05e942d5ca5f6252ccca44ca8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775265
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693344}

Breaking downstream builds:

Bug: 1000467, 1000763
Change-Id: Ia5e35ef9d309f3378d7ffc916ed5fd6afc9df7e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784167
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693343}

When the user holds the mouse down over an OOPIF, that OOPIF
captures all mouse inputs, including if the user moves the mouse out of
the OOPIF's boundaries.

A consequence of this is that when the user releases the mouse button,
only the OOPIF sees that, and the frame that the mouse is now over does
not see any mouse events. A consequence of this is that the mouse cursor
will not be updated following a MouseUp.

This CL artifically creates a MouseMove as a result of the
capture-releasing MouseUp in order to trigger any necessary cursor
update.

Bug: 893101
Change-Id: Ib6572149dd1841c9774997928d2afeb158feb757
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773758Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693342}

Properly localize the two strings that are used as user-facing error
messages from the online challenge-response based authentication (a.k.a.
smart card based login).

Bug: 826417
Change-Id: Id3206806a750ba0d347e1b12e6bc0542b5f00d62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778766Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693341}

An error notification is shown when the user uses click to call and
does not have any dialer app present on device. Nothing happens on
tapping on the notification.

Screenshots
https://drive.google.com/open?id=19udCa1fOQHIBr2vm6Qsyu9rZsBn_pst3


Bug: 998433
Change-Id: Ic09691e48f98051274a8484ff55c9354cc1a8178
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781428
Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693340}

This change adds a test that is almost identical to the one above it,
which tests CT enforcement exceptions for specific certificate
authorities. In this case, we'll pretend we're trying to use a legacy
certificate from the Federal Common Policy CA.

Bug: 981598
Change-Id: I8b1d25833f7b9903aa5a2ab5f32880bf9151ebe0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783862Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Nicolas Arciniega <niarci@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#693339}

We decided that a feature flag would be useful in case there's any
problems with the initial testing. So this CL puts an enabled by
default flag in front of the uploading.

Bug: 980777
Change-Id: I4eb399aee2b0d9d732dd5e12e83520b3c3a1e014
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783646
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693338}

This cl migrates kAssistantEnabled and kAssistantHotwordEnabled
preference from arc_prefs to assistant_prefs.

Also updated usages in Assistant Service and ash, removed obsolete
methods.

Detailed design doc: https://goto.google.com/assistant-prefs

Bug: b/110211045
Test: Run existing tests
Change-Id: If53d08622d5fc3b4722a04a2b4a1023358ea1056
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779538Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693337}