GitLab

Query arguments weren't being stripped from file:// URLs by Python's
urlparse.urlsplit, which seems to have caused all WebGL 2.0
suppressions for specific pages to be ignored, instead taking any
wildcard suppressions for that platform or configuration. Fixed this
and added a unit test.

BUG=542901
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/1407643003

Cr-Commit-Position: refs/heads/master@{#353933}

This patch enforced checking the input sample rate to MediaStreamAudioProcessor
by adding checking routines in MediaStreamAudioFifo.

BUG=536607

Review URL: https://codereview.chromium.org/1377103002

Cr-Commit-Position: refs/heads/master@{#353932}

BUG=507796

Review URL: https://codereview.chromium.org/1396313005

Cr-Commit-Position: refs/heads/master@{#353931}

We're hoping to send out a single clang-built canary later this week, and
this will be useful for identifying that.  After that, we can remove this
row again.

BUG=82385,530785

Review URL: https://codereview.chromium.org/1404063002

Cr-Commit-Position: refs/heads/master@{#353930}

Move width/height related properties handling from
LegacyCSSPropertyParser into CSSPropertyParser.

BUG=499780

Review URL: https://codereview.chromium.org/1402963002

Cr-Commit-Position: refs/heads/master@{#353929}

There were some existing cloud_print targets that were hooked up only on Linux, but most of the code was Windows-only. This adds the missing targets and should bring us up to GYP parity.

Fix the cloud print size_t to int warnings and remove the warning disable from GYP.

Move generated resources file from cloud_print/resources.h to cloud_print/service/resources.h to match where the source file is.

Cloud print does some messy things to get the content switches constants, including the file directly in its sources and manually setting LINK_CONTENT_STATICALLY for all targets. In GN, this adds a static_switches target in content that does this in an official way.

Review URL: https://codereview.chromium.org/1393123003

Cr-Commit-Position: refs/heads/master@{#353928}

Originally landed in https://crrev.com/90c4e947, which enabled a code
path where https://crrev.com/6aeb9079 introduced a bug a few hours
earlier. The bug was detected in tests, which resulted in a revert.
https://crrev.com/7a8e3fdf fixed the bug in the hidden code path. It's
safe to reland now.

TBR=zea@chromium.org, estade@chromium.org
BUG=481595

Review URL: https://codereview.chromium.org/1396883005

Cr-Commit-Position: refs/heads/master@{#353927}

This regressed in https://codereview.chromium.org/1304833003/ .

This also updates the 32x32 and 64x64 favicons to match the 16x16 one.

BUG=505953
TEST=Open about:blank, the favicon in the tab shouldn't look undersized
TBR=oshima

Review URL: https://codereview.chromium.org/1395273006

Cr-Commit-Position: refs/heads/master@{#353926}

Remove the reference to preview_sources from GN build file. Once
this lands, next step is removing the actual source file
from android_tools.

BUG=512264

Review URL: https://codereview.chromium.org/1399543004

Cr-Commit-Position: refs/heads/master@{#353925}

This class routes incoming BlimpMessages to registered handlers based on the messages' types.

R=wez@chromium.org,nyquist@chromium.org
BUG=525766

Review URL: https://codereview.chromium.org/1324263003

Cr-Commit-Position: refs/heads/master@{#353924}

BUG=

Review URL: https://codereview.chromium.org/1398373004

Cr-Commit-Position: refs/heads/master@{#353923}

In VS 2015 builds of chrome.dll there are 2473 copies of the ASCIICaseFoldTable array, totaling 633088 bytes.

BUG=541668

Review URL: https://codereview.chromium.org/1398973005

Cr-Commit-Position: refs/heads/master@{#353922}

This adds the following methods to existing Indexed DB interfaces.

* IDBObjectStore.getAll()
* IDBObjectStore.getAllKeys()
* IDBIndex.getAll()
* IDBIndex.getAllKeys()
* IDBObjectStore.openKeyCursor()
* IDBTransaction.objectStoreNames

Spec (2nd Edition Editor's Draft): https://w3c.github.io/IndexedDB/

Launch Tracking: https://crbug.com/525742

Dashboard: https://www.chromestatus.com/features/6537756637396992

Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/uUx7vDWDOd4

Review URL: https://codereview.chromium.org/1363993003

Cr-Commit-Position: refs/heads/master@{#353921}

Added some class description to the 3 objects used in reflection.
Tried to explain as much of the design as I could but had to leave
some out as I didn't fully understand it (put a TODO for this instead).

Also touched a bit the code to better match the intent: some paint
flags were set in a caller instead of in PaintLayerReflectionInfo or
a function never called wasn't marked as such.

Review URL: https://codereview.chromium.org/1391943005

Cr-Commit-Position: refs/heads/master@{#353920}

https://pdfium.googlesource.com/pdfium.git/+log/3acb1ef..24c1eec

BUG=457480,497355
TBR=tsepez@chromium.org

Review URL: https://codereview.chromium.org/1397173005

Cr-Commit-Position: refs/heads/master@{#353919}

This is a small code simplification.

Also clean up border.cc a bit -- use gfx::Insets more consistently, make the
class naming (SolidSidedBorder) match the function naming
(CreateSolidSidedBorder()), and be consistent about whether or not to inline
class methods.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1401933004

Cr-Commit-Position: refs/heads/master@{#353918}

No functional change.

This is intended to support free listing the stream buffer allocations.

Merge internal change: 103088826

R=rch@chromium.org

Review URL: https://codereview.chromium.org/1397113003

Cr-Commit-Position: refs/heads/master@{#353917}

Monorail seems to have taken over the sub-domain and these links do not
work anymore. Use crbug.com instead.

Review URL: https://codereview.chromium.org/1395273005

Cr-Commit-Position: refs/heads/master@{#353916}

R=sky@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/1406633002

Cr-Commit-Position: refs/heads/master@{#353915}

Ensure that DataPipeProducerDispatcher::CreateEquivalentDispatcherAndCloseImplNoLock serializes the object.

Otherwise the channel_ is only serialized later in EndSerializeAndCloseImplNoLock. In between those two calls, if the consumer is closed the channel_ can call the old and destructed DataPipeProducerDispatcher.

BUG=478251

Review URL: https://codereview.chromium.org/1403773005

Cr-Commit-Position: refs/heads/master@{#353914}

The code that detects whether the initial download has completed for
a type had been inadvertently broken by https://codereview.chromium.org/1142423006/

This fix changes Directory::InitialSyncEndedForType back to the
original implementation and adds special handling for implicitly created
root folders (i.e. root folders auto-created locally by the update
handling code). Since the locally created root folders don't get applied
with the rest of downloaded nodes, their base version has to be
explicitly changed from CHANGES_VERSION to some other value at
the end of update application process. That would to indicate that at
least one update has been applied for the type and be consistent with
how the server generated root folders are handled.

BUG=540814

Review URL: https://codereview.chromium.org/1393633003

Cr-Commit-Position: refs/heads/master@{#353913}

BUG=533362

Review URL: https://codereview.chromium.org/1409433002

Cr-Commit-Position: refs/heads/master@{#353912}

Instead of making use of the deprecated types we have in basictypes.h.

BUG=138542, 487868, 488550, 539734
TEST=net_unittests
R=ricea@chromium.org,eroman@chromium.org,wtc@chromium.org

Review URL: https://codereview.chromium.org/1404673003

Cr-Commit-Position: refs/heads/master@{#353911}

This is a test for http://crrev.com/1196193003 and http://crrev.com/1202453002.

BUG=500911

Review URL: https://codereview.chromium.org/1390993002

Cr-Commit-Position: refs/heads/master@{#353910}

Every WebLocalFrameImpl results in the creation of a WebUSBClientImpl so
this patch delays the connection to the embedder's DeviceManager
implementation until it is actually needed. This means it will end up
being connected when the navigator.usb object is first accessed by
Javascript.

This avoids exposing everyone who has enabled the experimental web
platform features flag to instabilities in this new feature and will
generally reduce resource utilization for unused features when this is
shipped.

BUG=538339

Review URL: https://codereview.chromium.org/1404043002

Cr-Commit-Position: refs/heads/master@{#353909}

Fixes queueing up live region output when focus events occur.

BUG=539019

Review URL: https://codereview.chromium.org/1402463005

Cr-Commit-Position: refs/heads/master@{#353908}

BUG=542113

Review URL: https://codereview.chromium.org/1395633003

Cr-Commit-Position: refs/heads/master@{#353907}

NOTE: This is based on the CL here: https://codereview.chromium.org/1369393002/

Before this CL InkDropAnimations were created lazily and never destroyed or
released until the ripple owner was destroyed. This change adds the
necessary events required to destroy an InkDropAnimation when it becomes
hidden.

BUG=522175, 537614

Review URL: https://codereview.chromium.org/1373983002

Cr-Commit-Position: refs/heads/master@{#353906}

BUG=542759

Review URL: https://codereview.chromium.org/1399253004

Cr-Commit-Position: refs/heads/master@{#353905}

Test code can still do this.

BUG=517735

Review URL: https://codereview.chromium.org/1395043002

Cr-Commit-Position: refs/heads/master@{#353904}

BUG=

Review URL: https://codereview.chromium.org/1341503002

Cr-Commit-Position: refs/heads/master@{#353903}

BUG=523418

Review URL: https://codereview.chromium.org/1403853002

Cr-Commit-Position: refs/heads/master@{#353902}

When --gtest_filter is used and contains a list of tests without
wildcards, it is not necessary to query the device for the list of
tests.

This speeds up local development where it's comment to run just a single
test at a time (saves 3 seconds).

BUG=540857

Review URL: https://codereview.chromium.org/1393223002

Cr-Commit-Position: refs/heads/master@{#353901}

While content needs to create a few event types, it almost never needs
to read any data back off them. All of these getters are actually
dead code. I also noticed that WebDOMMouseEvent is dead and removed it.

Review URL: https://codereview.chromium.org/1402023002

Cr-Commit-Position: refs/heads/master@{#353900}

Add virtual destructor
Add include for CONTENT_EXPORT

BUG=526842

Review URL: https://codereview.chromium.org/1405663002

Cr-Commit-Position: refs/heads/master@{#353899}

libyuv::CopyPlane uses some low level optmization that memcpy doesn't have.
This patch replaces the memcpy used when copying video frames to I420
GpuMemoryBuffers with libyuv::CopyPlane.

BUG=

Review URL: https://codereview.chromium.org/1400923003

Cr-Commit-Position: refs/heads/master@{#353898}

https://chromium.googlesource.com/skia/+/eb85b8321bc917169ba26c8fce76b64d2e3dfe81
changed how text baselines are computated, yielding to lowing the
baseline position by 1px in orthogonal writing modes.

NOTRY=true
TBR=herb@google.com,eae@chromium.org

Review URL: https://codereview.chromium.org/1407463003

Cr-Commit-Position: refs/heads/master@{#353897}

This is disabled by default in M46+.

BUG=
TBR=stgao@chromium.org

Review URL: https://codereview.chromium.org/1403983004

Cr-Commit-Position: refs/heads/master@{#353896}

Disable flaky org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest#testTapOnARIAIgnored

TBR=newt@chromium.org
BUG=542874

Review URL: https://codereview.chromium.org/1398243003

Cr-Commit-Position: refs/heads/master@{#353895}

Review URL: https://codereview.chromium.org/1391193006

Cr-Commit-Position: refs/heads/master@{#353894}