Commits · f3ee43c032627e6d21dd65100cb3efab25db9dd8 · eriksson monteiro / tangled

28 Apr, 2012 40 commits

FileBrowser: tuned colors according to mocks. · f3ee43c0

zvorygin@chromium.org authored Apr 28, 2012

BUG=chromium-os:29969
TEST=

Review URL: https://chromiumcodereview.appspot.com/10221035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134477 0039d316-1c4b-4281-b951-d872f2087c98

f3ee43c0

browser/ui: Remove unused definitions of CloseWebDialog() function. · cf1af681

tfarina@chromium.org authored Apr 28, 2012

This function is defined but never called anywhere, so this patch removes it now.

R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10252013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134476 0039d316-1c4b-4281-b951-d872f2087c98

cf1af681

[File Manager] Make sure the new tab is always visible when opening files. · 4a4c87bc

kaznacheev@chromium.org authored Apr 28, 2012

BUG=chromium-os:29875
TEST=

Review URL: https://chromiumcodereview.appspot.com/10255024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134475 0039d316-1c4b-4281-b951-d872f2087c98

4a4c87bc

Disable ExtensionManagementTest.PolicyOverridesUserInstall and · d9084a31

glider@chromium.org authored Apr 28, 2012

ExtensionManagementTest.AutoUpdateDisabledExtensions under AddressSanitizer

BUG=103371,120640
TBR=yoz

Review URL: http://codereview.chromium.org/10187024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134474 0039d316-1c4b-4281-b951-d872f2087c98

d9084a31

[File Manager] Better Google Drive promo layout in Open/Save dialogs · edf41a89

kaznacheev@chromium.org authored Apr 28, 2012

BUG=chromium-os:30138,chromuim-os:30139
TEST=

Review URL: https://chromiumcodereview.appspot.com/10258011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134473 0039d316-1c4b-4281-b951-d872f2087c98

edf41a89

views: Use STLDeleteElements() function in ClearEditHistory(). · 32df4c0d

tfarina@chromium.org authored Apr 28, 2012

R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10222006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134472 0039d316-1c4b-4281-b951-d872f2087c98

32df4c0d

[File Manager] Fixed an error message when pinning a GDrive file failed · c377289a

kaznacheev@chromium.org authored Apr 28, 2012

BUG=chromium-os:27931
TEST=

Review URL: https://chromiumcodereview.appspot.com/10256004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134471 0039d316-1c4b-4281-b951-d872f2087c98

c377289a

Mark OffscreenTabsApiTest.OffscreenTabBasics flaky · b7ec0c2e

glider@chromium.org authored Apr 28, 2012

TBR=rsleevi
BUG=122521
Review URL: https://chromiumcodereview.appspot.com/10258010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134470 0039d316-1c4b-4281-b951-d872f2087c98

b7ec0c2e

Disable SafeBrowsingBlockingPageTest.MalwareIframeReportDetails because of bugs in it. · 8a75d639

glider@chromium.org authored Apr 28, 2012


TBR=panayiotis@google.com
BUG=99159
Review URL: https://chromiumcodereview.appspot.com/10209043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134469 0039d316-1c4b-4281-b951-d872f2087c98

8a75d639

[File Manager] Fixed cursor style for Learn More link · 451acfe8

kaznacheev@chromium.org authored Apr 28, 2012

BUG=chromium-os:30117
TEST=

Review URL: https://chromiumcodereview.appspot.com/10254008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134468 0039d316-1c4b-4281-b951-d872f2087c98

451acfe8

[Photo Editor] Fixed an exception when renaming an edited image. · d31a72ba

kaznacheev@chromium.org authored Apr 28, 2012

BUG=chromium-os:30003
TEST=

Review URL: https://chromiumcodereview.appspot.com/10229003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134467 0039d316-1c4b-4281-b951-d872f2087c98

d31a72ba

[File Manager] Open hosted documents in offline mode · a304ffc6

kaznacheev@chromium.org authored Apr 28, 2012

BUG=chromium-os:28449
TEST=

Review URL: https://chromiumcodereview.appspot.com/10255005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134466 0039d316-1c4b-4281-b951-d872f2087c98

a304ffc6

[File Manager] Keep showing GDrive promo banner while the search box is being used. · 47de3ef0

kaznacheev@chromium.org authored Apr 28, 2012

BUG=chromium-os:30146
TEST=

Review URL: https://chromiumcodereview.appspot.com/10257031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134465 0039d316-1c4b-4281-b951-d872f2087c98

47de3ef0

[File Manager] Fixed an exception when ejecting a removable drive. · bbeed024

kaznacheev@chromium.org authored Apr 28, 2012

BUG=chromium-os:30083
TEST=

Review URL: https://chromiumcodereview.appspot.com/10252005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134464 0039d316-1c4b-4281-b951-d872f2087c98

bbeed024

Disable ExtensionManagementTest.AutoUpdate under AddressSanitizer · eec15d31

glider@chromium.org authored Apr 28, 2012

BUG=120640,103371,94964
TBR=asargent
Review URL: https://chromiumcodereview.appspot.com/10209041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134463 0039d316-1c4b-4281-b951-d872f2087c98

eec15d31

RefCounted types should not have public destructors, net/ · a9813302

rsleevi@chromium.org authored Apr 28, 2012

BUG=123295
TEST=none


Review URL: http://codereview.chromium.org/10066045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134460 0039d316-1c4b-4281-b951-d872f2087c98

a9813302

Updating trunk VERSION from 1121.0 to 1122.0 · 20eef6d1
chrome-release@google.com authored Apr 28, 2012
```
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134459 0039d316-1c4b-4281-b951-d872f2087c98
```
20eef6d1

Crash when trying to close chrome://inspect · 337eb8e9

yurys@chromium.org authored Apr 28, 2012

Stop listening notifications and refreshing chrome://inspect page after it was closed.

BUG=125283
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10206036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134457 0039d316-1c4b-4281-b951-d872f2087c98

337eb8e9

RefCounted types should not have public destructors, sql/ and jingle/ edition · 60e60dd3

rsleevi@chromium.org authored Apr 28, 2012

BUG=123295
TEST=none


Review URL: http://codereview.chromium.org/10038045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134456 0039d316-1c4b-4281-b951-d872f2087c98

60e60dd3

Revert 134443 - Broke win_aura · 215605c4

rsleevi@chromium.org authored Apr 28, 2012

Generate crash dumps when a hung PPAPI plugin is force terminated.

TEST=none
BUG=123021


Review URL: http://codereview.chromium.org/10253016

TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10257028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134455 0039d316-1c4b-4281-b951-d872f2087c98

215605c4

Added page score to the ntp suggestions tab. · 91ac982b

rfevang@chromium.org authored Apr 28, 2012


BUG=
TEST=


Review URL: http://codereview.chromium.org/10115001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134454 0039d316-1c4b-4281-b951-d872f2087c98

91ac982b

[pyauto] Cleanup: Enable a few more pyauto tests · 17252c27

nirnimesh@chromium.org authored Apr 28, 2012

Enabling a few more pyauto tests that were disabled a while back but are
passing now.

TBR=dyu@chromium.org
R=dyu@chromium.org
BUG=82629,69464,75724,75724
TEST=pyauto bots.

Review URL: https://chromiumcodereview.appspot.com/10257027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134453 0039d316-1c4b-4281-b951-d872f2087c98

17252c27

Disable a media test: testBasicPlaybackMatrix · 3454a6e3

nirnimesh@chromium.org authored Apr 28, 2012

TBR=shadi@chromium.org
R=shadi@chromium.org
BUG=125424
TEST=

Review URL: https://chromiumcodereview.appspot.com/10178038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134452 0039d316-1c4b-4281-b951-d872f2087c98

3454a6e3

[pyauto] Cleanup: Enable a bulk of pyauto tests · 41213adc

nirnimesh@chromium.org authored Apr 28, 2012

Enabling a bunch of tests that had been disabled a while back
but actually pass.

R=dyu@chromium.org
TBR=dyu@chromium.org
BUG=35485,50706,85601,85633,109148,119605,123899,115646,35485
TEST=pyauto bots

Review URL: https://chromiumcodereview.appspot.com/10137016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134451 0039d316-1c4b-4281-b951-d872f2087c98

41213adc

Don't read Linux host configuration if binary is not on path. · 719b5841

wez@chromium.org authored Apr 28, 2012

BUG=125217


Review URL: http://codereview.chromium.org/10237012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134450 0039d316-1c4b-4281-b951-d872f2087c98

719b5841

RefCounted types should not have public destructors, webkit/ · e0ffc6f8

rsleevi@chromium.org authored Apr 28, 2012

BUG=123295
TEST=none


Review URL: http://codereview.chromium.org/10066044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134449 0039d316-1c4b-4281-b951-d872f2087c98

e0ffc6f8

Revert 130292 - Disable a bunch of pyAuto tests due to CL 9963028 being reverted. · 49dd0c40

nirnimesh@chromium.org authored Apr 28, 2012

The chrome-qa bots is still running the previous night's build so these tests are failing.

TEST=none
BUG=121594
Review URL: https://chromiumcodereview.appspot.com/9963092

TBR=dyu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10252022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134448 0039d316-1c4b-4281-b951-d872f2087c98

49dd0c40

File Manager: Fix a JavaScript error with unmounting using eject button. · fb8cb77a

benchan@chromium.org authored Apr 28, 2012

BUG=chromium-os:30150
TEST=Test unmounting a SD card and an archive file using eject button.

Review URL: https://chromiumcodereview.appspot.com/10178036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134447 0039d316-1c4b-4281-b951-d872f2087c98

fb8cb77a

RefCounted types should not have public destructors, content/browser part 2 · 69d5c51f

rsleevi@chromium.org authored Apr 28, 2012

BUG=123295
TEST=none
TBR=brettw

Review URL: https://chromiumcodereview.appspot.com/10071038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134446 0039d316-1c4b-4281-b951-d872f2087c98

69d5c51f

[protector,win] Fix... · 355b8538

ivankr@chromium.org authored Apr 28, 2012

[protector,win] Fix protector.ProtectorSessionStartupTest.testSessionStartupPrefMigrationFromHomepage on Win.


BUG=125373
TEST=protector.py
NOTRY=true

Review URL: http://codereview.chromium.org/10178011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134445 0039d316-1c4b-4281-b951-d872f2087c98

355b8538

Revert 134389 - Fix an incorrectly written policy test. It was using a hook... · b3acaa3b

nirnimesh@chromium.org authored Apr 28, 2012

Revert 134389 - Fix an incorrectly written policy test. It was using a hook incorrectly and checking for the wrong condition.

+++++++++++++++++++++++
REVERT NOTES

Broke test
http://build.chromium.org/p/chromium.pyauto/builders/Win7/builds/21229/steps/pyauto_functional_tests/logs/stdio

======================================================================
ERROR: policy.PolicyTest.testDefaultSearchProviderOptions: "Verify a default search is performed when using omnibox."
----------------------------------------------------------------------
Traceback (most recent call last):
  File "E:\b\build\slave\Win7\build\src\chrome\test\functional\policy.py", line 533, in testDefaultSearchProviderOptions
    self.OmniboxAcceptInput()
  File "src\chrome\test\functional\..\pyautolib\pyauto.py", line 1184, in OmniboxAcceptInput
    self._GetResultFromJSONRequest(cmd_dict, windex=windex)
  File "src\chrome\test\functional\..\pyautolib\pyauto.py", line 1052, in _GetResultFromJSONRequest
    additional_info))
JSONInterfaceError: Automation call {'command': 'OmniboxAcceptInput'} received empty response.  Additional information:
No information available.
+++++++++++++++++++++++++

BUG=
TEST=functional/policy.py


Review URL: http://codereview.chromium.org/10256005

TBR=craigdh@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10255022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134444 0039d316-1c4b-4281-b951-d872f2087c98

b3acaa3b

Generate crash dumps when a hung PPAPI plugin is force terminated. · 663fff4c

brettw@chromium.org authored Apr 28, 2012

TEST=none
BUG=123021


Review URL: http://codereview.chromium.org/10253016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134443 0039d316-1c4b-4281-b951-d872f2087c98

663fff4c

Add a new UMA histogram for tracking SpdySessionErrorDetails · cd6d75bc

rch@chromium.org authored Apr 28, 2012

BUG=125213

Review URL: http://codereview.chromium.org/10233016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134442 0039d316-1c4b-4281-b951-d872f2087c98

cd6d75bc

Exclude a new net test from cf net tests. · 77f207df

erikwright@chromium.org authored Apr 28, 2012

This test is not designed to work under Chrome Frame net test configuration.

BUG=None
TEST=Tests pass on Webkit waterfall and Chromium try bots.


Review URL: http://codereview.chromium.org/10256010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134441 0039d316-1c4b-4281-b951-d872f2087c98

77f207df

Refactor media stream infobar delegate code and also fix a typo · 51d1fc6e

yujie.mao@intel.com authored Apr 28, 2012

BUG=NONE
TEST=ui_tests


Review URL: http://codereview.chromium.org/10209022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134440 0039d316-1c4b-4281-b951-d872f2087c98

51d1fc6e

Expand pipelining trial to 100% of dev channel. · 56e1b525

simonjam@chromium.org authored Apr 28, 2012


BUG=110794
TEST=None


Review URL: http://codereview.chromium.org/10170044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134439 0039d316-1c4b-4281-b951-d872f2087c98

56e1b525

Linux: Use the same safe downloads logic as Windows. (try 2) · 83ad0766

thestig@chromium.org authored Apr 28, 2012

BUG=none
TEST=none

First attempt: http://codereview.chromium.org/10241007/

Review URL: http://codereview.chromium.org/10255018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134438 0039d316-1c4b-4281-b951-d872f2087c98

83ad0766

Update .DEPS.git · 443c4db6

chrome-admin@google.com authored Apr 28, 2012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134437 0039d316-1c4b-4281-b951-d872f2087c98

443c4db6

roll gyp 1342:1344 · ae45277e

scottmg@chromium.org authored Apr 28, 2012

1343: ninja windows: fix expansion of some VS macros
1344: Exclude problematic formats from tests, rather than including all other platforms

TBR=thakis@chromium.org

Review URL: http://codereview.chromium.org/10137011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134436 0039d316-1c4b-4281-b951-d872f2087c98

ae45277e

Report VideoDecoder status through ReadCB instead of through FilterHost. · 8d1e8fb0

xhwang@chromium.org authored Apr 28, 2012

BUG=108340
TEST=media_unittests

Review URL: http://codereview.chromium.org/10248002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134435 0039d316-1c4b-4281-b951-d872f2087c98

8d1e8fb0