- 30 Jan, 2015 40 commits
-
-
jamuraa authored
Profiles in bluez are not specific to a device. When client code tries to connect to two different devices, only one profile is created, managed by BluetoothAdapterChromeOS. dbus messages are multiplexed based on the device desired using new class BluetoothAdapterProfileChromeOS. This is a resubmit with bugfixes after https://codereview.chromium.org/851123002/ was reverted by https://codereview.chromium.org/868753006/ BUG=421207 Review URL: https://codereview.chromium.org/888913002 Cr-Commit-Position: refs/heads/master@{#314030}
-
skare authored
BUG=453955 Review URL: https://codereview.chromium.org/888993002 Cr-Commit-Position: refs/heads/master@{#314029}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/ae50934..395f4d8 TBR=junov@chromium.org,vsevik@chromium.org Review URL: https://codereview.chromium.org/886143002 Cr-Commit-Position: refs/heads/master@{#314028}
-
zmo authored
It is not used at all. Note that I didn't change any logic at all except 1) Get rid of NonCachedProgramInfoManager. 2) Merge CachedProgramInfoManager into ProgramInfoManager. 3) Get rid of the Create() function. 4) Add ~VertexAttrib() ~UniformInfo() ~Program() as required by compiler. BUG=453127 TEST=no change at all R=piman@chromium.org Review URL: https://codereview.chromium.org/893713002 Cr-Commit-Position: refs/heads/master@{#314027}
-
sergeyu authored
Previously PolicyWatcher allowed initialization on a thread different from the one it runs on. It's no longer necessary. Also for It2Me it was initialized on UI thread, but was given task runner for the network thread, which causes the DCHECK in the linked bug. Now PolicyWatcher is marked as NonThreadSafe. It's initialized on UI thread for It2Me host and on NetworkThread for the me2me host. Also the file thread is used for blocking operation when reading policies. BUG=453615 Review URL: https://codereview.chromium.org/886913002 Cr-Commit-Position: refs/heads/master@{#314026}
-
jamiewalch authored
The 256x256 and 512x512 pngs are not used anywhere, so I deleted them. BUG=453510 Review URL: https://codereview.chromium.org/890883005 Cr-Commit-Position: refs/heads/master@{#314025}
-
jbauman authored
The precise order (or number) of some of these messages doesn't matter, so just handle them in a loop. Review URL: https://codereview.chromium.org/888693004 Cr-Commit-Position: refs/heads/master@{#314024}
-
ckehoe authored
BUG=453523 Review URL: https://codereview.chromium.org/870053008 Cr-Commit-Position: refs/heads/master@{#314023}
-
dbeam authored
This is the Accessibility Developer Tools suggested color for a 4.5 contrast ratio (minimum for AA rating[1] / audit to stop barking). R=kalman@chromium.org BUG=439227 [1] http://www.w3.org/WAI/WCAG2AA-Conformance Review URL: https://codereview.chromium.org/893603006 Cr-Commit-Position: refs/heads/master@{#314022}
-
stuartmorgan authored
This causes crashes if the shutdown path is used on iOS, because on iOS there's already a higher-level autorelease pool by the time this code can be run. BUG=None Review URL: https://codereview.chromium.org/891843002 Cr-Commit-Position: refs/heads/master@{#314021}
-
mseaborn authored
This pulls in the following Native Client changes: f02226b: (bbudge@chromium.org) Disable mmap_unittest.cc tests on Windows 64 in Debug... 6bc00f6: (dschuff@chromium.org) Update upstream compiler_rt to HEAD and use official git mirror 55d212c: (phosek@chromium.org) Updates the tools Makefile to work with Git ccc9c66: (shyamsundarr@chromium.org) Add all remaining avx2 instructions except vgather. 9595661: (jfb@chromium.org) Enable -Werror for LLVM build aa51c35: (pcc@google.com) Disable -flto when compiling nacl_bootstrap_lib. 476c662: (jfb@chromium.org) PNaCl: Update Subzero and LLVM revision in pnacl/COMPONENT_REVISIONS 2f388a0: (dschuff@chromium.org) Enable SCons testing of arm-nacl-clang on the bots fea15c4: (bbudge@chromium.org) Disable mmap_unittest.cc tests on Windows 64 in Debug... BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk_build Review URL: https://codereview.chromium.org/867463008 Cr-Commit-Position: refs/heads/master@{#314020}
-
kmarshall authored
Fix buffer overflow due to unbounded strlen over the non-null terminated audio policy string. Caught by asan. BUG= Review URL: https://codereview.chromium.org/890683002 Cr-Commit-Position: refs/heads/master@{#314019}
-
Aurimas Liutikas authored
This reverts commit 3952cc42. Retvield messed up in https://codereview.chromium.org/885743003/ and only reverted part of the CL https://chromiumcodereview.appspot.com/889683002/ TBR=newt@chromium.org,tedchoc@chromium.org NOTRY=true BUG=407781 Review URL: https://codereview.chromium.org/892573006 Cr-Commit-Position: refs/heads/master@{#314018}
-
dtseng authored
Currently, when a caller requests a desktop tree and then opens a new windowthe new WebViewmight have an unloaded child root web area because the tree id sent on construction may be stale by the time automation gets it. Adding a notification in WebView::RenderViewHostChanged appears to work properly. This also allows ChromeVox to add one set of listeners on the desktop node. TEST=With ChromeVox Next set to use automation, - navigate within a tab - switch to several tabs and navigate - open new windows and navigate Result should be that events fire properly when tabbing within the new page. Review URL: https://codereview.chromium.org/880063002 Cr-Commit-Position: refs/heads/master@{#314017}
-
dbeam authored
Also adds better support for zoom/wrapping. BUG=438815 R=kalman@chromium.org Review URL: https://codereview.chromium.org/887803003 Cr-Commit-Position: refs/heads/master@{#314016}
-
scottmg authored
Adds functionality to create_installer_archive.py to generate a .d file that includes all of the files that it packages into chrome[.packed].7z. This is done by tracking the source of all the files that are copied into the staging dir that is given to 7za to package the .7z file. The depfile is then used in a gyp 'depfile' to correctly specify the implicit dependencies for the mini_installer target. Previously it used a fake output of 'xxx2.out' to cause it to rebuild every time (which is what we're trying to avoid in this change). Additionally, switch from a rule to an action in gyp -- gyp currently only supports 'depfile' on actions, and as there's only one file being built here, they're equivalent. BUG=342974,451499 Review URL: https://codereview.chromium.org/887673003 Cr-Commit-Position: refs/heads/master@{#314015}
-
bnc authored
This CL changes the argument of GetCanonicalSuffix() from HostPortPair to std::string (both const&) to better document the fact that GetCanonicalSuffix only operates on that field. BUG=392575 Review URL: https://codereview.chromium.org/868753007 Cr-Commit-Position: refs/heads/master@{#314014}
-
kkimlabs authored
- Top level folders are now all the sub folders of Bookmark Bar, Mobile, and Others nodes. - We no longer use Uncategorized. BUG=453024 Review URL: https://codereview.chromium.org/869193008 Cr-Commit-Position: refs/heads/master@{#314013}
-
ariblue authored
BUG=452266 Review URL: https://codereview.chromium.org/887763003 Cr-Commit-Position: refs/heads/master@{#314012}
-
xunjieli authored
This CL implements the following four methods: - getHeaderFields() - getHeaderField(String key) - getHeaderField(int pos) - getHeaderFieldKey(int pos) BUG=398997 Review URL: https://codereview.chromium.org/784853004 Cr-Commit-Position: refs/heads/master@{#314011}
-
morrita authored
Without this, ChannelMojo doesn't work. R=inferno@chromium.org, tsepez@chromium.org TBR=jamesr@chromium.org BUG=453571 Review URL: https://codereview.chromium.org/867903006 Cr-Commit-Position: refs/heads/master@{#314010}
-
jbauman authored
If the bitmap wasn't allocated, return false instead. BUG=411505 Review URL: https://codereview.chromium.org/879143002 Cr-Commit-Position: refs/heads/master@{#314009}
-
scottmg authored
Avoids ninja expecting an import .lib to be generated so that it doesn't continually rebuild because the import lib is "missing". To be landed after gyp roll at https://codereview.chromium.org/890043003/ lands. R=robertshield@chromium.org BUG=342974,451499 Review URL: https://codereview.chromium.org/886123002 Cr-Commit-Position: refs/heads/master@{#314008}
-
felt authored
This updates the permission prompt (infobar and permission bubble) icons with the new icons provided by sgabriel@: https://drive.google.com/a/google.com/folderview?id=0B-Vmdj5n- YddWktRd1BMeHZYWWs&usp=sharing BUG=451490 Review URL: https://codereview.chromium.org/893603003 Cr-Commit-Position: refs/heads/master@{#314007}
-
sdefresne authored
ScheduleAndForget is a thin wrapper around ScheduleTask that hides a base::Bind() call and passing the HistoryBackend pointer as the first parameter. As they are templated function, they prevent splitting HistoryService into a pure virtual interface and a implementation interface that would improve the componentization velocity. BUG=370850 R=droger@chromium.org Review URL: https://codereview.chromium.org/865443005 Cr-Commit-Position: refs/heads/master@{#314006}
-
fsamuel authored
For GuestView types in the browser, such as <webview> in WebUI and <extensionoptions> in WebUI, we would live status messages to appear in the browser. This CL plumbs that information out to the embedder. ContentsMouseEvent, LoadingStateChanged, and UpdateTargetURL are calls out to the content embedder that are used by Browser to update status indicators such as the spinner, and status text. This CL plumbs those calls out from the guest to the embedder. This is a bit racy because guest status and embedder status can interleave but that's OK because these status texts are transient and eventually they'll settle and disappear so there's no long lasting raciness of consequence. BUG=453216 TBR=lazyboy@chromium.org Review URL: https://codereview.chromium.org/880983006 Cr-Commit-Position: refs/heads/master@{#314005}
-
mathp authored
No longer rely on DidFailProvisionalLoad, solving other issues. Includes a rename of URLRequestMockHTTPJob::AddUrlHandler BUG=373455 TEST=NewTabPageInterceptorTest Review URL: https://codereview.chromium.org/845973005 Cr-Commit-Position: refs/heads/master@{#314004}
-
meacer authored
This CL adds Wi-Fi SSID to the captive portal interstitial on Mac and Linux, if the connection is Wi-Fi. WiFiService isn't available on other platforms, so we will be using other mechanisms such as NetworkChangeNotifier on those. BUG=451272 Review URL: https://codereview.chromium.org/887573002 Cr-Commit-Position: refs/heads/master@{#314003}
-
alexclarke authored
This is needed to make the webkit_unit_tests pass when the HTML parseing tasks are posted on the loading task queue. Required for patch https://codereview.chromium.org/876623002 BUG=391005 Review URL: https://codereview.chromium.org/878413002 Cr-Commit-Position: refs/heads/master@{#314002}
-
pmeenan authored
This is in preparation for adding preconnect support which goes through the same underlying plumbing. dns_prefetch was too restrictive of a component name and was only exposing the single method. There are no functionality changes in this CL, just the rename (the namespace was also renamed) BUG=450682 Review URL: https://codereview.chromium.org/848303005 Cr-Commit-Position: refs/heads/master@{#314001}
-
scottmg authored
r2030: win: Add NoImportLibrary flag for ninja generator TBR=grt@chromium.org BUG=451499 Review URL: https://codereview.chromium.org/890043003 Cr-Commit-Position: refs/heads/master@{#314000}
-
scheib authored
BluetoothDispatcherHost is extended to supply all the attributes of the BluetoothDevice web API. Also, add device::BluetoothDevice::VENDOR_ID_MAX_VALUE for use in the IPC message. Depends on https://codereview.chromium.org/882223002/ to define new attributes on WebBluetoothDevice, and will not be visible to script until https://codereview.chromium.org/876623003/ BUG=438305 Review URL: https://codereview.chromium.org/885723002 Cr-Commit-Position: refs/heads/master@{#313999}
-
jsbell authored
The IDB implementation uses journals to track blob files which are to-be-written or to-be-deleted so that the files can be cleaned up following a crash or abort. The journal records are updated as part of a two-phase commit, and during database deletion. The journal updates and cleanups incorrectly assumed that only one transaction could commit at a time per backing store, so the first phase of a second transaction could inadvertently "clean up" the in progress work by a previous transaction, resulting in missing files. Untangle this and ensure that (1) transaction commits only append/remove journal entries, not the entire journal, and (2) changes outside transactions are deferred if transactions are running. R=cmumford@chromium.org BUG=447836 Review URL: https://codereview.chromium.org/865013002 Cr-Commit-Position: refs/heads/master@{#313998}
-
mef authored
BUG=441466 Review URL: https://codereview.chromium.org/890893006 Cr-Commit-Position: refs/heads/master@{#313997}
-
xunjieli authored
UploadTestServer was originally intended for testing uploads. This CL renames it to NativeTestServer, since it has been used as a general test server. BUG=452643 Review URL: https://codereview.chromium.org/873593006 Cr-Commit-Position: refs/heads/master@{#313996}
-
meacer authored
The SSID is going to be displayed in the captive portal interstitial as such: "The network you are using (Google Guest)..." BUG=451272 Review URL: https://codereview.chromium.org/880143003 Cr-Commit-Position: refs/heads/master@{#313995}
-
mstrum authored
Manual verification of the mapping was done using: http://www.html5rocks.com/en/tutorials/doodles/gamepad/gamepad-tester/tester.html This also adds tests to check for mapping regressions for all gamepads. BUG=453178,373942 TEST=GamepadMappingsTest Review URL: https://codereview.chromium.org/875813003 Cr-Commit-Position: refs/heads/master@{#313994}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/f76ca40..ae50934 TBR=junov@chromium.org,vsevik@chromium.org Review URL: https://codereview.chromium.org/889573004 Cr-Commit-Position: refs/heads/master@{#313993}
-
davidben authored
Summary of changes available at: https://boringssl.googlesource.com/boringssl/+log/a87de9b..be629e0 BUG=none Review URL: https://codereview.chromium.org/890893005 Cr-Commit-Position: refs/heads/master@{#313992}
-
mad authored
BUG=None Review URL: https://codereview.chromium.org/890793004 Cr-Commit-Position: refs/heads/master@{#313991}
-