GitLab

Suppress races in browser_sync::NewNonFrontendDataTypeControllerMock::RecordUnrecoverableError (issue 138691)

BUG=138691,138693
TBR=zhaoqin
Review URL: https://chromiumcodereview.appspot.com/10810067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148076 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148075 0039d316-1c4b-4281-b951-d872f2087c98

It's used in addition to frame ids to identify frames correctly.

Also expose the processId via webNavigation.getFrame and getAllFrames

BUG=136090
TEST=ExtensionApiTest.WebNavigationGetFrame

Review URL: https://chromiumcodereview.appspot.com/10805066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148074 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jkummerow@chromium.org

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10790139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148073 0039d316-1c4b-4281-b951-d872f2087c98

It turns out that a CXXRecordDecl can change between the call to
HandleTagDeclDefinition and HandleTopLevelDecl. This happens in the
case of nested class declarations, causing us to fail to emit warnings
in some cases (see the test). See crbug.com/136863 for the full discussion.

BUG=136863
TEST=tools/clang/plugins/tests/test.sh


Review URL: https://chromiumcodereview.appspot.com/10808078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148070 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148069 0039d316-1c4b-4281-b951-d872f2087c98

BUG=126947
TEST=chromeos_unittests and try bots

Review URL: https://chromiumcodereview.appspot.com/10806028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148068 0039d316-1c4b-4281-b951-d872f2087c98

ANDROID_SDK_HOME is set in build/android/envsetup.sh, so android will
try to search for AVDs in that folder when running tests.

If not set this variable in this script, the AVDs created with this script
are invisible for the tests.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10782024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148066 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:32338
TEST=unit tests. Manual testing can be done by setting the new policy in a DM server to true and verifying that external storage is not mount and shown in the file manager in Chrome.


Review URL: https://chromiumcodereview.appspot.com/10697097

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148065 0039d316-1c4b-4281-b951-d872f2087c98

Many tests are failed due to sqlite errors on Android.
The reason is that sqlite need a temporary directory to
store internal temporary files. However, Android doesn't
have this kind of directory while Linux has /var/tmp.

To fix this, use in-memory temporary files. It also includes:
1) Add one unit test in sql unittests to reproduce this
issue for Android.
2) Remove those disabled cases for content unitests on
Android.

BUG=
TEST=run_tests.py -s sql_unittests; run_test.py -s net_unittests


Review URL: https://chromiumcodereview.appspot.com/10809015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148064 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=unit_tests --gtest_filter="GData*"


Review URL: https://chromiumcodereview.appspot.com/10790135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148063 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
BUG=135535
TEST=manually checked the behavior by keep pressing Ctrl-F5 on lumpy


Review URL: https://chromiumcodereview.appspot.com/10802046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148062 0039d316-1c4b-4281-b951-d872f2087c98

BUG=129799
TEST=Manual + autotests


Review URL: https://chromiumcodereview.appspot.com/10808061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148061 0039d316-1c4b-4281-b951-d872f2087c98

This breaks the NaCL compiler, as the addition the base.gypi results in a too long command line. For the sake of getting the tree green, I'm reverting this, although the NaCL compiler is really to blame

Review URL: https://chromiumcodereview.appspot.com/10796047

TBR=kaiwang@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10807083

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148060 0039d316-1c4b-4281-b951-d872f2087c98

The change to use these in the omnibar is coming soon.

TBR=sky@chromium.org

BUG=129598
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10817024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148059 0039d316-1c4b-4281-b951-d872f2087c98

    
Fix ScopedVector API to follow this style.
    
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Variable_Names#Variable_Names

BUG=136196
R=willchan@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10796028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148057 0039d316-1c4b-4281-b951-d872f2087c98

* Update the display bounds correctly in |Fix coordinates for minimize animation|. Update the test so that it will fail with original code, and removed the debugging message that was checked in by mistake.
* Update the display layout after the secondary display is initialized on startup.
* Fix comment in Display.h. It was probably cut&paste error.

BUG=123160
TEST=Updated MultiDisplayTest::NativeDisplayTest

Review URL: https://chromiumcodereview.appspot.com/10795080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148056 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10796047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148055 0039d316-1c4b-4281-b951-d872f2087c98

BUG=110823
TEST=included

Review URL: https://chromiumcodereview.appspot.com/10808093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148054 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146954

Review URL: https://chromiumcodereview.appspot.com/10779008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148053 0039d316-1c4b-4281-b951-d872f2087c98

This CL reverts r144508 because the crash no longer happens.

BUG=134507
TEST=none.

Review URL: https://chromiumcodereview.appspot.com/10808063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148052 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=136944
TEST=No animation of the promo text when opening an NTP.

Review URL: https://chromiumcodereview.appspot.com/10689164

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148051 0039d316-1c4b-4281-b951-d872f2087c98

This change disables PageCyclerCachedBrowserTest.PlaybackMode and PageCyclerCachedBrowserTest.URLNotInCache also on Mac debug bots.

TBR=rdevlin.cronin@chromium.org
BUG=131333
TEST=make the "Mac 10.6 Tests (dbg)(1)" bot green.
Review URL: https://chromiumcodereview.appspot.com/10796105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148048 0039d316-1c4b-4281-b951-d872f2087c98

*) Set min-width to prevent broken layout in narrow windows.
*) Reduce spacing to 8px.
*) Add border-radius to preview image.


BUG=138599
TEST=Manual


Review URL: https://chromiumcodereview.appspot.com/10805079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148044 0039d316-1c4b-4281-b951-d872f2087c98

Depends on http://codereview.chromium.org/10700007/

BUG=133094
TEST=Use browserAction.disable/enable(tabid), observe that the browser action becomes grayed out.

Review URL: https://chromiumcodereview.appspot.com/10789026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148043 0039d316-1c4b-4281-b951-d872f2087c98

R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10787037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148042 0039d316-1c4b-4281-b951-d872f2087c98

SwiftShader can be slower and less stable than the 2D path, so disable force-compositing-mode experiment when using it.


BUG=138127
TEST=


Review URL: https://chromiumcodereview.appspot.com/10796048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148041 0039d316-1c4b-4281-b951-d872f2087c98

It's a case in content unittests. Implement the config for Android.

BUG=
TEST=run_tests.py -s content_unittests


Review URL: https://chromiumcodereview.appspot.com/10815027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148040 0039d316-1c4b-4281-b951-d872f2087c98

Added a key in the manifest file "offline_enabled", for crx-less apps to support offline_mode.

BUG=101782
TEST=unit_test


Review URL: https://chromiumcodereview.appspot.com/10704092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148039 0039d316-1c4b-4281-b951-d872f2087c98

With this CL, IBusEngineService can handle MethodCall and Signal emitting.
To avoid CL delta bloat, let me split the CL.
I will send CL for unit tests soon.

BUG=126947
TEST=try bots

Review URL: https://chromiumcodereview.appspot.com/10806006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148038 0039d316-1c4b-4281-b951-d872f2087c98

R=thakis@chromium.org
BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10800062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148037 0039d316-1c4b-4281-b951-d872f2087c98

Move the functionality into helper that we can use for issuing android
intents.

BUG=136785
TEST=run 'make browser'


Review URL: https://chromiumcodereview.appspot.com/10809061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148036 0039d316-1c4b-4281-b951-d872f2087c98

TBR=atwilson@chromium.org
NOTRY=true
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10810065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148033 0039d316-1c4b-4281-b951-d872f2087c98

The comments in these cases used incorrect reasoning for why the
const_cast<> was safe.  Whether the SQL statements modify the database
is irrelevant.  Add an internal helper to allow them to correctly
accomplish things in a const situation.

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10736042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148031 0039d316-1c4b-4281-b951-d872f2087c98

R=jvoung@chromium.org,robertm@chromium.org
BUG= http://code.google.com/p/nativeclient/issues/detail?id=2195
TEST=nacl_integration (on nacl bots)


Review URL: https://chromiumcodereview.appspot.com/10800084

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148030 0039d316-1c4b-4281-b951-d872f2087c98

This CL renames some classes, but not the source files, to make it easier to
compare the old and new versions. A follow-up CL will rename the files.

BUG=137906


Review URL: https://chromiumcodereview.appspot.com/10804040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148029 0039d316-1c4b-4281-b951-d872f2087c98

ChromeAsyncSocket will be reused by chromoting for XMPP connections,
moving it to jingle/glue.

BUG=137140


Review URL: https://chromiumcodereview.appspot.com/10817013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148028 0039d316-1c4b-4281-b951-d872f2087c98

BUG=132423
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10784037

TBR=ivankr@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10809068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148027 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10806076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148026 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148025 0039d316-1c4b-4281-b951-d872f2087c98