- 08 Dec, 2020 40 commits
-
-
Jimmy Gong authored
Fixed: 1155244 Change-Id: I6d2e0789d3ba517b451f71f3cfe0aae09c27dcae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577859 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#834607}
-
Archie Pusaka authored
BlueZ's device UUIDs property could return either the service UUIDs or the advertised UUIDs (not both), depends on whether the service UUIDs are resolved. Unfortunately there is no simple way to detect which of the two sets of UUIDs are returned. This CL separates the UUIDs tracking. The advertised UUIDs can be retrieved by reading the EIR data, therefore we can treat the UUIDs property as the service UUIDs. In the end, both are merged so a call to GetUUIDs() would get both the service and advertised UUIDs. Bug: b:172359553 Change-Id: I7de6f0c47f3799265b833c4b3be3da84bdf0e458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560347 Commit-Queue: Archie Pusaka <apusaka@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#834606}
-
Kunihiko Sakamoto authored
This allows the urn: scheme in WebBundles' inner URLs, in addition to http and https. Bug: 1082020 Change-Id: I5582444e6d4f6ab29b83045a3d37a13f078071db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578300Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#834605}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8ae45db84a78..03c2a0ffe52f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nancylingwang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: nancylingwang@google.com Change-Id: I0ec24e4d7dddd5f0650ffacb4bc909b6d95c607e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578400Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834604}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I87bc100b3176828efe96261036f832025a478cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578258Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834603}
-
Wei Lee authored
Originally, we cancel intent in window unload listener when closing CCA. However, the the callback of the cancel() method is triggered, the connection between CCA and Chrome might already be tore down. This CL moves the logic to Chrome for SWA version. For platform app version, it still cancels the intent in background page. Bug: b/172337144 Test: tast run [DUT] camera.CCAUIIntent.swa Change-Id: I8362242ad4990aeda947061f756bf35ecf8bf736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573261 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#834602}
-
Joel Hockey authored
Change-Id: I834bd899ae782e33feaf6f7dee2eb219272f579b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578578 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#834601}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8b4990bbd621..e59d8716b300 2020-12-08 syoussefi@chromium.org GL: Expose OES_shader_io_blocks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I9460d9c484f0197fc66ebb48321d93f5fd1835fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578440Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834600}
-
Antonio Sartori authored
In the Blink Content Security Policy code, we switch from using the internal blink type blink::CSPSource to using the mojo type network::mojom::blink::CSPSource for handling CSP source expressions. This is part of a project to harmonize the CSP code in Blink and in services/network, and will make it easier to synchronize Content Security Policies between the two. Change-Id: If7769b321934ee73cf1aa0faa6d8b371360684a7 Bug: 1021462,1149272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412339Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#834599}
-
Marijn Kruisselbrink authored
This is a reland of 2d41c395 The added test was modified to no longer assert that all unsafe files were written to disk successfully. This should make the test pass (albeit with less stringent checks) on file systems/platforms that don't allow all unsafe file names. Original change's description: > Reland "[FSA] Add IsSafePathComponent checks to GetFile/GetDirectoryHandle." > > This is a reland of 00437792 > > The main difference is to make sure iterating over a directory doesn't > return files we don't want to expose either (and not CHECK failing if > such files are found when iterating). > > Original change's description: > > [FSA] Add IsSafePathComponent checks to GetFile/GetDirectoryHandle. > > > > This isn't directly using net::IsSafePortablePathComponent since what > > is safe for the File System Access API is not the same as what is safe > > for Downloads. As such currently this duplicates a lot of the > > implementation of this method, but in a followup we should attempt to > > unify these two implementations as much as possible. > > > > Bug: 1150810, 1154757 > > Change-Id: Iba4c92ef5f1cd924aa22b9dd201762d48b4bbc3b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568383 > > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > > Reviewed-by: Victor Costan <pwnall@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#833042} > > Bug: 1150810 > Bug: 1154757 > Change-Id: I3341b9824a1ac4cbd6f100355960ad55b01f0753 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575370 > Commit-Queue: Victor Costan <pwnall@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834118} Bug: 1150810 Bug: 1154757 Change-Id: Ie5cad9a7b2383c89b96e8a7be6cfe75ad2555fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577614 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#834598}
-
Josh Nohle authored
Previously, the cancel implementation invoked the transfer-update callback before cancelling any ongoing payloads via Nearby Connections. The transfer-update callback subsequently cleaned up the payloads and disconnected before the payloads could be cancelled; so, the payloads would never be cancelled via Nearby Connections and the payload tracker would never receive a cancellation notification. This is particularly harmful to metrics. In this CL, we * cancel payloads via Nearby Connections before doing anytyhing else; * ensure that we provide enough time for the remote device to process cancellation before disconnecting; * make some memory-management improvements, such as copying the ShareTarget in DoCancel()--the notification manager owns the reference passed into Cancel(), and that could easily be invalidated during the cancellation process; * ensure that the payload tracker does not process trivial data sent during a cancellation, notably a 0 value for the number of bytes transferred. Manually verified all types of cancellation. Also, verified that existing metrics and the metrics of https:/crrev.com/c/2571443 are as expected. We still see crbug/1155412 and b/175064390, but those are known, unrelated issues. Fixed: 1156232 Change-Id: I0d480b25d3565a21138d1ae32377cc4f4fcd87c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577767 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#834597}
-
Raphael Kubo da Costa authored
The test was disabled in commit 46327ef9 ("Temporarily disable web tests that use the legacy Protocol global") but was never enabled again. Adapt to changes that have happened in devtools-frontend since then: * Rename Protocol to ProtocolClient <https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107558> * Adjust -expected.txt and essentially revert commit 424f76fd ("update test for devtools inspector backend") <https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2193586> * Remove the last argument to the registerCommand() call. <https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2230524> Bug: 1011811 Change-Id: I7f311536f6c25577f86e8906723f61a6c9b0ad96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575016 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#834596}
-
Nidhi Jaju authored
It is generally safer/preferred to use blink::To instead of static_cast to a derived class from a base class, as it has a security check that the object is actually of the derived class type. Hence, this CL changes the static_cast to use To<ReadableStreamDefaultReader> instead. Bug: 614302 Change-Id: I93d9fe8a833f833c3ba92e84dd02ed0ad3356e3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577390Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Cr-Commit-Position: refs/heads/master@{#834595}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8c0eca5f..53a11922 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifb66213aa84c62e839b496576ad2c4cef60dc121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577702Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834594}
-
Greg Kerr authored
Bug: 1025993 Change-Id: I780717cffbdd5d18f030667e52874d58d21439b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572785 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#834593}
-
Joshua Peraza authored
bccb9504d1fb Roll crashpad/third_party/edo/edo/ 97121c640..6ffbf8331 (19 commits) 70f1ec86f95d ios: Fix setup_ios_gn.py after gn roll 0917d31d19ef Update lss README.crashpad to point to corrected name for license ed132d5ec247 [syslog] Expect logsink client includes 121d92ca3f1a Roll crashpad/third_party/mini_chromium/mini_chromium/ cb82d7129..c748b289b (2 commits) 6c270cf239df linux: Refactor test modules 20cbfa49719c linux: Use mmap for attachments in PtraceBroker 00491d58ee29 linux: Correct handling of load bias 83f194ee8544 linux: Add linux-gate.so to valid vdso prefixes Bug: chromium:1147922, chromium:1128441 Change-Id: If032f0e3c81b5fc1452867ecab4211fa713c276c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573518 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#834592}
-
Michael Bai authored
Adds PropagateAutofillPredictions method in AutofillHandler, it is invoked by ContentAutofillDriver, this seems detour, but reasonable consider AutofillDriver::PropagateAutofillPrediction also applies to ios. Adds OnServerPredictionsAvailable to AutofillProvider and test. Add parameter to enable the autofill download in AutofillHandlerProxy, the download still disabled. Bug: 1151542 Change-Id: I2feb36d57f17ee04bd152ce02f493074ba99419d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574532 Commit-Queue: Michael Bai <michaelbai@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#834591}
-
Tal Pressman authored
These functions are unused. Change-Id: I5cb37b52bf5518490a96d533ffe417cbc920993b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578222Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Tal Pressman <talp@google.com> Cr-Commit-Position: refs/heads/master@{#834590}
-
Leo Lai authored
This issue can be reproduced with enable_nacl = false on top of linux chromos build. Bug: 1126359 Change-Id: I35feda29e79ccb8758e41fe1bb693bfed79c4575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577392Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#834589}
-
Josiah K authored
Before: https://screenshot.googleplex.com/6QKNdedpCna7U8k After: https://screenshot.googleplex.com/97xdZg4vCkbPsVd AX-Relnotes: Move switch assignments from right side of assignments link, to below main label, to match mocks. Bug: 1156233 Change-Id: I3b59a3f2bf94af2e3a8017c421444ce71e452477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576230 Commit-Queue: Josiah Krutz <josiahk@google.com> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Auto-Submit: Josiah Krutz <josiahk@google.com> Cr-Commit-Position: refs/heads/master@{#834588}
-
Meredith Lane authored
This patch has no functional difference, it is just a refactor. This completes the work and removes the remaining pieces of the AXSparseAttributeClients from various places, reducing complexity. The function map has now been renamed to AXSparseAttributeSetterMap, replacing the previous one. AX-Relnotes: N/A Bug: 1068668 Change-Id: Ie76dc4d3bc4f75b863af3877e3034c7417a34378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434419Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#834587}
-
Harry Cutts authored
isherman@ pointed out that this should be set since these names are only ever reported with suffixes. Bug: 1114828 Change-Id: I8d015e50cfbcb23592a28a4f19ec70fdbb02e64f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577836 Auto-Submit: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#834586}
-
Morten Stenshorne authored
There was some old code that wasn't needed anymore, and it was causing trouble for nested multicol. We need to break before a multicol container if it doesn't fit. The column layout algorithm always tries to limit the block size of an inner multicol container, so that it will fit in the outer fragmentation context. If that's not possible, though, we need to break before it and retry in the next outer fragmentainer. So for multicol container children we needed the code path that we previously only ran for child.IsMonolithic(), but we can in fact always do that (if it doesn't fit, and we're allowed to break, let's break!), so just delete the unnecessary code, and fix 5 tests. :) Bug: 829028 Change-Id: I93b6b10c8b427055e69f094b460c13fa68a49fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575031 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#834585}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5c5f0baa72f1..1742f98791c9 2020-12-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ia536fd245755a8c847c59a28439391bc72f94e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578191 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012070600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/4E0Kat64Xt3-kQkf_9Z8eXNVVOdY-Dm0TKYMn0bV9SEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/164161478,b/174637068 Tbr: media-app@grotations.appspotmail.com Change-Id: If8c77cd67cb4daf04634b96acc8604b2808da0cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578165Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607363880-ba632ae780cc1bebf61d324b0c586630719677ae.profdata to chrome-win64-master-1607374595-d12d27ca344e18f0b40a9dc8f54420fe6b49bde9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibdb83918b30c0576bc41ff4ca52348994f686695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577765Reviewed-by:
-
Morten Stenshorne authored
If we're doing nested column balancing (a column-fill:balance multicol container with another column-fill:balance multicol container descendant), we may need to stretch the outer multicol container to make the inner one fit. Just propagate the space shortage detected while laying out the inner column row, so that the outer multicol container can use this to stretch itself. Bug: 829028 Change-Id: I0b45d6f5d02f0f597f2d2de3442e728eb2abbb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574754Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f639a24c5041..554e7574e960 2020-12-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 7c84426d2abe to 84b9bb6621c7 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: Iab52d2347eb67beb9e093b806b10cdcb30e07cd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578398Reviewed-by:
-
Joel Hockey authored
Modify TrashRootEntry DirectoryReader to not create directories if they don't already exist since creating the directories causes unexpected FileWatcher directory rescans which interferes with tests. Downloads no longer shows the dialog for deleting - it shows only the toast. Drive will show the dialog. So for tests that are explicitly testing things about the dialog interaction, I moved the files into Drive. Bug: 953310 Change-Id: I7e155739fc2f694797e904898519336915c0a946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574641Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#834579}
-
cfredric authored
This cl also converts a portion of CanonicalCookie unit tests to use matcher-based code, in order to be able to more easily assert multiple things about multiple parts of the return value of IsSetPermittedInContext. (E.g., being able to make assertions about both the |status| and the |is_allowed_to_access_secure_cookies| fields of the |CookieAccessResult|. This also has the benefit of being more declarative and avoiding declaring temp variables, which are error-prone. In particular, this fixes bugs where the wrong temp variable was accidentally used (lines 2785, 2899). This cl also fixes a bug (in test) where the LEGACY access semantics were accidentally unused, with UNKNOWN being redundantly used instead (lines 2967-2987). Change-Id: I09b981f5f0819807ff5dd769022e4d6baa5f50a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571806Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#834578}
-
Bao-Duy Tran authored
input_methods.txt [1] is the legacy config file from before the migration to extension-based input methods circa 2011. Almost all of its contents are obsolete and should no longer be used for reference. [1] https://source.chromium.org/chromium/chromium/src/+/master:chromeos/ime/input_methods.txt;drc=8cbe6597e4cc8457f4e33ef2ad189f0553f59f54 Bug: 1134526 Change-Id: I4d6023e396b7e44eda47882a33dd093ed10e5dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576993 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Auto-Submit: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#834577}
-
Archie Pusaka authored
In Bluetooth, the UUIDs are given in little endian order. Therefore, the byte array must be reversed before it is encoded into strings. Bug: None Change-Id: I0aeca5a1159566b674638ce3451a33665a5382ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561960Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Archie Pusaka <apusaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#834576}
-
Josiah K authored
Change-Id: I36822be0c3d4e7159780605b2d2902e5aa0ca0e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578397 Auto-Submit: Josiah Krutz <josiahk@google.com> Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Josiah Krutz <josiahk@google.com> Cr-Commit-Position: refs/heads/master@{#834575}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f7af16c5f6fe..8ae45db84a78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nancylingwang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: nancylingwang@google.com Change-Id: Ie2b9f1390c465220e0f86f5203f4bd6cc6f8fff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577014Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1607353071-d7cc2aeaf74b32bdf69634e0f6483d7e4b0ffed2.profdata to chrome-win32-master-1607374595-14878fd6c473cc4aebbe55be6f54c0ff79c3ed8e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4567f19fc485db05ea7cd23391df1973fc27cc93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577811Reviewed-by:
-
Bao-Duy Tran authored
For folders shared with non-CrOS, ideally we should leave the old Monorail component config there, but unfortunately only a single component is allowed, so leave a comment instead. Bug: None Change-Id: I0e8c235e29bffff1ea295d5bb8ff090b6a0a7545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569192Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#834572}
-
Shik Chen authored
Bug: b/172879638 Test: Manually in expert mode Change-Id: I382cd06c1c9fb06a80c82d783d3ca023a3e82542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570837 Auto-Submit: Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#834571}
-
Jeffrey Cohen authored
[Project Code Inclusion] Remove all uses of whitelist/blacklist in chrome/android/.../contextualsearch Bug: 1151331 Change-Id: I73e1bc80116e40a43071d316dd2f72d9e882ffc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576955 Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#834570}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5921e781cd6d..2b3b0f567d42 2020-12-08 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0f52d0f2fd63c0e2fa7b764722a7956bbd4ea0b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578257Reviewed-by:
-
Julie Jeongeun Kim authored
This CL replaces blink::mojom::ResourceType with network::mojom::RequestDestination from ExtensionsBrowserClient::AllowCrossRendererResourceLoad() since blink::mojom::ResourceType is deprecated[1]. [1] https://crbug.com/960143 Bug: 1059639 Change-Id: I848b468f064f4ea938aad9450483ee91fb0bd6ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562002Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
-
