GitLab

GetLocalPathFromURL returns the logical path, not the cache path of the entry.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/14320015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195206 0039d316-1c4b-4281-b951-d872f2087c98

BUG=230220

Review URL: https://chromiumcodereview.appspot.com/14315006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195205 0039d316-1c4b-4281-b951-d872f2087c98

speech-dispatcher 0.8 has changed the location where the libspeechd.h header
file is installed, and users are expected to reference it from the top-level
directory, ie.

  #include <speech-dispatcher/libspeechd.h>

Version 0.8 also installs a .pc pkg-config file.

Since speech-dispatcher 0.7 is still very widespread, we cannot assume this new
structure and .pc file are always available, so resort to adding the
"speech-dispatcher/" prefix to the #include based on whether `pkg-config
--exists' does not fail.

Arguably, we should also start calling `pkg-config --{cflags,libs-only-l,etc}',
but not having the .pc file always available would make the changes more
complicated. Since everything has worked so far without that, keeping the
status quo for now should be fine.

BUG=
TEST=Build with speech-dispatcher >= 0.8 installed.

Review URL: https://chromiumcodereview.appspot.com/14296005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195204 0039d316-1c4b-4281-b951-d872f2087c98

These errors occur when deleting very quickly, just after selecting a file. Such situation happens especially in tests. Along the way fixed the cancellation code.

TEST=Run browser_tests --test_filter="*FileManagerBrowser*Delete*"
BUG=233460

Review URL: https://codereview.chromium.org/14367009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195203 0039d316-1c4b-4281-b951-d872f2087c98

BUG=231331
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/14362031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195202 0039d316-1c4b-4281-b951-d872f2087c98

They had been disabled -- not due to inherent flakiness in the test itself, but due to an environment issue (bug 96594) which affects a good number of tests. I'm following the precedent of others by re-enabling these tests while we work on a solution for the underlying environment issue. Note: We've already had a regression due to the tests being disabled.

TBR=sky
BUG=145476, 128724, 152100, 177487

Review URL: https://chromiumcodereview.appspot.com/14295003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195201 0039d316-1c4b-4281-b951-d872f2087c98

BUG=226354,226350

Review URL: https://chromiumcodereview.appspot.com/14267002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195200 0039d316-1c4b-4281-b951-d872f2087c98

Last revert failed. Who knows why.

> Revert 195143 "Prevent chrome.app JSON schema from loading on ev..."
> 
> Small perf regression.
> 
> > Prevent chrome.app JSON schema from loading on every page
> > 
> > The app API along with app.window and app.runtime have been converted to use
> > the feature system. Bindings are not added to the chrome object for unavailable
> > APIs that are children of available APIs. For example, if chrome.app is
> > available, we will not add lazy bindings to chrome for app.window and
> > app.runtime. This eliminates the need to load the app schema, because we no
> > longer need to get chrome.app to add the app.runtime and app.window bindings.
> > 
> > BUG=55316
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194837
> > 
> > Review URL: https://chromiumcodereview.appspot.com/13604005
> 
> TBR=cduvall@chromium.org
> 
> Review URL: https://codereview.chromium.org/14241030

TBR=kalman@chromium.org

Review URL: https://codereview.chromium.org/14328045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195199 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/14263024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195198 0039d316-1c4b-4281-b951-d872f2087c98

We restore the index from enumerating the entries on disk when the dir mtime doesnt match the index file mtime.
Using the mtime we can reliably detect the stale index on every new entry that has been added or an old entry deleted on disk, since the index file must always the last file created (renamed) in the directory.

BUG=233536

Review URL: https://chromiumcodereview.appspot.com/13933029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195197 0039d316-1c4b-4281-b951-d872f2087c98

- The check to see if the dynamic key slots were all in use
  was comparing the wrong value.
  
- The lengths of the key and value being set wasn't being
  validated. The lower-level code capturing the values
  subsequently terminate the process if a key or value is
  too long for the CustomInfoEntry record.
  
R= cpu@chromium.org, rsesek@chromium.org
BUG=77656

Review URL: https://chromiumcodereview.appspot.com/14262014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195196 0039d316-1c4b-4281-b951-d872f2087c98

This only affects the printing module.

Current Ubuntu versions ships with CUPS 1.6 which complains about
use of deprecated CUPS methods. As we need to continue supporting
platforms using older CUPS versions such as Linux and Mac OS, we
ignore the warning as an error for now.

BUG=226176

Review URL: https://chromiumcodereview.appspot.com/14262006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195195 0039d316-1c4b-4281-b951-d872f2087c98

This patch verifies if there are no Javascript errors at the end of each test. Along the way it removes callbackPass instances, which are not reliable and can cause false positives.

TEST=Run browser_tests --test_filter="*FileManagerBrowser*"
BUG=233142, 233141

Review URL: https://chromiumcodereview.appspot.com/14241010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195194 0039d316-1c4b-4281-b951-d872f2087c98

To move some non-regular MountPointProviders out of webkit/fileapi,
we should not:
- Require FileAPI code change for a new MountPointProvider to
  get/set provider-specific operation context value (e.g.  MediaPathFilter)
- Require a new MountPointProvider type to be listed as a 'frined' of
  FileAPI code

To avoid having these dependencies, this change:
- Makes FileSystemOperationContext inherit from SupportsUserData so that
  MountPointProviders can get/set arbitrary user values with string keys.
- Makes some private methods public (with proper comments) and remove
  the friend list of MountPointProviders

This patch is a part of following change plan (internal only doc):
https://docs.google.com/a/google.com/document/d/1XEtX0OO_RIA_c0KuKvd9yqK5l3XtsTulwXs3c-mAQ1o/view

BUG=175936
TEST=content_unittests:*File*
TEST=browser_tests:*MediaGalleries*

Review URL: https://codereview.chromium.org/14341004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195193 0039d316-1c4b-4281-b951-d872f2087c98

Changes in this CL:
 - The version of the control channel is increased to 3. This allows the host and client to tell if the peer supports capabilities negotiation or not.
 - The client and host negotiate supported capabilities by sending each other a list of the supported capabilities. Capabilities supported by both client and host are assumed to be enabled.
 - The client plugin and webapp negotiate the list of capabilities supported by the client. The webapp has the final word.
 - The DesktopEnvironment interface was extended to provide the list of all supported capabilities and receive the results of negotiation with the client.
 - Added the 'sendInitialResolution' capability. When it is enabled the client sends its screen resolution to the host once the connection has been established.
 - DesktopSessionProxy now waits for the client screen resolution when the 'sendInitialResolution' capability is enabled.

BUG=230893

Review URL: https://chromiumcodereview.appspot.com/13932020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195192 0039d316-1c4b-4281-b951-d872f2087c98

Removed unnecessary query parameter "include-installed-apps=true" from
AddFeedUrlParams. Use base::IntToString instead of StringPrintf for trivial
case.
This is a preparation to add new method into GDataWapiUrlGenerator to support
"search by title exact match".

BUG=232352
TEST=Ran unit_tests

Review URL: https://chromiumcodereview.appspot.com/14240004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195191 0039d316-1c4b-4281-b951-d872f2087c98

The outer sandbox on Linux and OSX was preventing
sysconf(_SC_NPROCESSORS_ONLN) from succeeding, so that NaCl
applications that need the number of threads were getting a
bogus value (-1 when using newlib, and 1 when using glibc).

TEST= run_sysconf_nprocessors_onln_test
BUG= 176522

Review URL: https://chromiumcodereview.appspot.com/14238013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195190 0039d316-1c4b-4281-b951-d872f2087c98

This hooks up the rewritten RawVarData implementation with SerializedVar. It also fixes tests to make sure that shmem ArrayBuffers are actually tested. Previously, no testing of shmem ArrayBuffers was happening because OS_LINUX is never defined in ppapi/tests and none of the other ArrayBuffer test sizes were above the threshhold to invoke that code path. This CL adds a PPB_Testing function to set the threshhold to a lower value, which permits this code path to be taken while still having fast tests.

BUG=

Review URL: https://chromiumcodereview.appspot.com/14208016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195189 0039d316-1c4b-4281-b951-d872f2087c98

BUG=N/A
TEST=N/A

Review URL: https://chromiumcodereview.appspot.com/14311004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195188 0039d316-1c4b-4281-b951-d872f2087c98

Small perf regression.

> Prevent chrome.app JSON schema from loading on every page
> 
> The app API along with app.window and app.runtime have been converted to use
> the feature system. Bindings are not added to the chrome object for unavailable
> APIs that are children of available APIs. For example, if chrome.app is
> available, we will not add lazy bindings to chrome for app.window and
> app.runtime. This eliminates the need to load the app schema, because we no
> longer need to get chrome.app to add the app.runtime and app.window bindings.
> 
> BUG=55316
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194837
> 
> Review URL: https://chromiumcodereview.appspot.com/13604005

TBR=cduvall@chromium.org

Review URL: https://codereview.chromium.org/14241030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195187 0039d316-1c4b-4281-b951-d872f2087c98

This implement an observer of a remote webrtc MediaStream and propagates changes to a WebKit MediaStream.
It propagates adding and removing of remote tracks to existing mediastreams as well as if a remote track has ended.

https://code.google.com/p/webrtc/issues/detail?id=872

BUG=233514

Review URL: https://chromiumcodereview.appspot.com/14200016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195186 0039d316-1c4b-4281-b951-d872f2087c98

auth_service.cc has already switched to use the new chromeos/login/ code.

BUG=None
TEST=git try

Review URL: https://chromiumcodereview.appspot.com/14192013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195185 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Test clean up.

Review URL: https://chromiumcodereview.appspot.com/14189014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195184 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=bluetooth pairing works

Review URL: https://chromiumcodereview.appspot.com/14163005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195183 0039d316-1c4b-4281-b951-d872f2087c98

BUG=179904
TEST=Compile locally. Still waiting for the bots to be updated.

Review URL: https://chromiumcodereview.appspot.com/14141003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195181 0039d316-1c4b-4281-b951-d872f2087c98

This gets rid of some code duplication, and rewrites functions in thunk files
which return void to an alternate, equivalent form.

BUG=

Review URL: https://codereview.chromium.org/14161017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195180 0039d316-1c4b-4281-b951-d872f2087c98

GetEntryCount() was implemented recently with: http://crrev.com/14295013
Now addressing the forgotten TODO.

BUG=230306

Review URL: https://chromiumcodereview.appspot.com/14134005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195179 0039d316-1c4b-4281-b951-d872f2087c98

BUG=230911

Review URL: https://chromiumcodereview.appspot.com/14107010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195178 0039d316-1c4b-4281-b951-d872f2087c98

The problem is that one of the variables was incorrectly placed in the android ifdef. Also, moving the plugins specific section before Misc.

BUG=

Review URL: https://chromiumcodereview.appspot.com/13831008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195177 0039d316-1c4b-4281-b951-d872f2087c98

> Add a short delay before showing the first run bubble.
> 
> R=grt@chromium.org
> BUG=223939
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/13958003

TBR=macourteau@chromium.org

Review URL: https://codereview.chromium.org/14362030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195176 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195175 0039d316-1c4b-4281-b951-d872f2087c98

Please see https://codereview.chromium.org/14192019/

Review URL: https://codereview.chromium.org/14241028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195174 0039d316-1c4b-4281-b951-d872f2087c98

BUG=233549
TBR=oshima

Review URL: https://codereview.chromium.org/14241026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195173 0039d316-1c4b-4281-b951-d872f2087c98

BUG=231019

Review URL: https://chromiumcodereview.appspot.com/14145003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195172 0039d316-1c4b-4281-b951-d872f2087c98

BUG=233029

Review URL: https://chromiumcodereview.appspot.com/14079005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195171 0039d316-1c4b-4281-b951-d872f2087c98

BUG=233213

Review URL: https://chromiumcodereview.appspot.com/14076010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195170 0039d316-1c4b-4281-b951-d872f2087c98

Per the CSS spec, marking part of a user pod as visibility:visible will
make it accessible even if the entire account picker has visibility:hidden.

BUG=232967
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/13852033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195169 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195168 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195167 0039d316-1c4b-4281-b951-d872f2087c98

Summary of changes:
* Addressing Java warnings
* Miscellaneous Java changes

BUG=230645

Review URL: https://chromiumcodereview.appspot.com/14230019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195166 0039d316-1c4b-4281-b951-d872f2087c98