GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282171 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Update smoothness_controller to use results.AddValue(...) (https://codereview.chromium.org/380803002/)

Reason for revert:
Possibly caused Android Tests failures. See http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14520/steps/telemetry_perf_unittests/logs/stdio

E.g.
Traceback (most recent call last):
  _RunPage at tools/telemetry/telemetry/page/page_runner.py:534
    test.RunPage(page, page_state.tab, results)
  RunPage at tools/telemetry/telemetry/page/page_test.py:247
    self.ValidatePage(page, tab, results)
  ValidatePage at tools/telemetry/telemetry/page/page_measurement.py:60
    self.MeasurePage(page, tab, results)
  MeasurePage at tools/perf/measurements/smoothness.py:36
    self._smoothness_controller.AddResults(tab, results)
  AddResults at tools/perf/measurements/smoothness_controller.py:100
    results.current_page, r.name, r.unit, r.value))
  __init__ at tools/telemetry/telemetry/value/scalar.py:19
    assert isinstance(value, numbers.Number)
AssertionError

Original issue's description:
> Update smoothness_controller to use results.AddValue(...)
> 
> BUG=391943
> TBR=nduca@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282131

TBR=nduca@chromium.org,nednguyen@google.com
NOTREECHECKS=true
NOTRY=true
BUG=391943

Review URL: https://codereview.chromium.org/382673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282170 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/377783004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282169 0039d316-1c4b-4281-b951-d872f2087c98

I really managed to botch it. Surprisingly, the tests were all still
okay.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/382633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282168 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/381663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282167 0039d316-1c4b-4281-b951-d872f2087c98

Some drives do not report themselves as removable despite appearing to a user to be a removable drive. Particularly this is the case for some USB sticks. We are fixing this by changing the device listing to list all drives that are either removable or attached via USB. We have already done a similar change for Chrome OS due to some SD card readers listing themselves as non-removable. Chrome OS lists all SD or USB drives. However, we do not have a reliable way to detect SD cards on Windows and Mac so we will continue to use the removable flag.

BUG=391998

Review URL: https://codereview.chromium.org/375703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282166 0039d316-1c4b-4281-b951-d872f2087c98

This change collects contiguous processed frames for each track buffer
and appends them to track buffers' streams as groups of frames rather
than inefficiently appending each frame one at a time. One at a time
appends are still possible in the worst case, since collected processed
frames are appended at the end of ProcessFrames() and also prior to any
NotifyNewMediaSegmentStarting().

R=acolwell@chromium.org, damienv1@chromium.org
BUG=371197
TEST=no media_unittest, MSE layout test, or YT conformance unit test regression locally on Linux

Review URL: https://codereview.chromium.org/381443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282165 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282164 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/874a62acef5ec2ecccdbb99ec4d86402a3341e6a..1c577cd3ee331944b9061ee0eec147b211ee563c

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=jcgregorio@google.com
BUG=

Review URL: https://codereview.chromium.org/375423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282163 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282162 0039d316-1c4b-4281-b951-d872f2087c98

1947: Introduce '--no-duplicate-basename-check' option to disable the check of duplicate basenames 
1946: Makes analyzer strip off a leading path separator
1945: msvs: ensure that failing actions make the build fail with multiple actions

BUG=gyp:303,chromium:383609,gyp:264,gyp:384
TEST=none
R=mark@chromium.org

Review URL: https://codereview.chromium.org/376263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282161 0039d316-1c4b-4281-b951-d872f2087c98

Fix a TODO in athena.gyp.

BUG=None
TEST=None
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/371573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282159 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Temporarily disable WebView fullscreen video tests until we land fullscreen IPC changes (https://codereview.chromium.org/364043002/)

Reason for revert:
revert this as all related CLs are submitted

Original issue's description:
> Temporarily disable WebView fullscreen video tests until we land fullscreen IPC changes
> 
> there are 2 changes needs to be submitted before we reenable the tests:
> 1. https://codereview.chromium.org/290643005/ and
> 2. https://codereview.chromium.org/292573004/
> 
> the blink change will break all the tests, so we need to reenable the tests after the chromium change lands
> 
> BUG=367346
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281165

TBR=boliu@chromium.org
BUG=367346

Review URL: https://codereview.chromium.org/383433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282158 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385673
TEST=manual
NOTRY=True

Review URL: https://codereview.chromium.org/375693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282157 0039d316-1c4b-4281-b951-d872f2087c98

This puts static libraries on mac next to their ninja files, i.e. in
locations like out/Debug/obj/base/libbase_static.a instead of directly
in the output directory. This matches what we do on other platforms and
avoids the need to give every static library a unique name in the GN
build. https://codereview.chromium.org/376773002/ has some discussion
of the history of why this is different in GYP.

Review URL: https://codereview.chromium.org/378123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282156 0039d316-1c4b-4281-b951-d872f2087c98

Deduplicate chrome.isolate items found in angle.isolate. Move comment about
D3DCompiler_43.dll to 32bits build. If it is going to be mapped, it is only for
32 bits builds and not 64 bits builds since this DLL doesn't seem to exist in 64
bits.

R=scheib@chromium.org,kbr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/379843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282155 0039d316-1c4b-4281-b951-d872f2087c98

Extra vsyncs after each rendering cause 1% more power consumption.
Modify VSyncMonitorTest to follow the rule 1 request == 1 vsync.

BUG=

Review URL: https://codereview.chromium.org/377483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282154 0039d316-1c4b-4281-b951-d872f2087c98

exposed to content scripts.

In some cases this dates way back pre-features to when they were incorrectly
first added with an {"unprivileged": true} annotation, like runtime.reload().

R=asargent@chromium.org

Review URL: https://codereview.chromium.org/375173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282153 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282152 0039d316-1c4b-4281-b951-d872f2087c98

This is to get update to checkdeps to update tree walking to not update a list while iterating over it.

TBR=qsr

Review URL: https://codereview.chromium.org/379923006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282151 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/300573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282150 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
NOTRY=true

Review URL: https://codereview.chromium.org/380913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282149 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/382593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282148 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282147 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Signedness mismatch

This relies on https://codereview.chromium.org/376003003 to make FPDF_FillRect()
take a 32-bit value for the color in order to make the changes here as simple
and clean as possible.

This also contains a few other cleanups to make code simpler or more consistent.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/372273005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282146 0039d316-1c4b-4281-b951-d872f2087c98

BUG=47554
TBR=suderman

Review URL: https://codereview.chromium.org/382683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282145 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943

Review URL: https://codereview.chromium.org/377333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282144 0039d316-1c4b-4281-b951-d872f2087c98

Following https://codereview.chromium.org/355573008, the only code left in WebDataService deals with IE 7/8 password data, so move this into a separate (WIN only class) and kill WebDataService.

BUG=181277
TEST=Everything still works
TBR=noms@chromium.org, zea@chromium.org, phajdan.jr@chromium.org
TBR'ing for removal of unneeded includes and API changes in (c/b/profile, c/b/sync, and  c/test/base respectively).

Review URL: https://codereview.chromium.org/364343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282143 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282142 0039d316-1c4b-4281-b951-d872f2087c98

> Adds API test for imageWriterPrivate.writeFromFile
> 
> BUG=384650
> 
> Review URL: https://codereview.chromium.org/336923002

TBR=haven@chromium.org

Review URL: https://codereview.chromium.org/384513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282141 0039d316-1c4b-4281-b951-d872f2087c98

Disable VP9 444 tests.
B=392309

https://codereview.chromium.org/375983002
https://codereview.chromium.org/376873009

R=scherkus@chromium.org, tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/380493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282140 0039d316-1c4b-4281-b951-d872f2087c98

With Xcode 6, the home directory of the iOS Simulator and iossim
processes must match so that the iOS Simulator can find the SimDevice
object created by iossim. Since the existing behavior of iossim is to
create a new, random, home directory on each run (if no -u value is
specified on the command line), the home directories will be  mismatched
if iossim is launched multiple times without killing the iOS Simulator
in between runs.

The fix here is to only override the home directory in iossim if -u
is specified. Since this will often reuse the default SimDeviceSet
(at ~/Library/Developer/CoreSimulator/Devices), functionality
is also changed to reuse an existing SimDevice if possible (though
iossim will create a SimDevice if necessary).

BUG=None
TBR=rohitrao

Review URL: https://codereview.chromium.org/382563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282139 0039d316-1c4b-4281-b951-d872f2087c98

The //build directory in GN shouldn't refer to anything outside of itself so that non-Chrome projects can copy it and re-use the build configuration. speechd relies on third_party/speech-dispatcher. This patch just moves the loader to the speech-dispatcher target, which makes more sense anyway.

TBR=grunell@chromium.org

Review URL: https://codereview.chromium.org/377403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282138 0039d316-1c4b-4281-b951-d872f2087c98

R= binji@chromium.org
TEST= none
BUG= none
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/382603004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282137 0039d316-1c4b-4281-b951-d872f2087c98

a lot.

TBR=rockot@chromium.org

Review URL: https://codereview.chromium.org/379923013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282136 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/376313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282135 0039d316-1c4b-4281-b951-d872f2087c98

R=hansmuller@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/385433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282134 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Assignment inside conditional
* Possibly-uninitialized local variable
* Signedness mismatch

This also contains a small number of other cleanups/simplifications to nearby
code.

BUG=81439
TEST=none
R=teravest@chromium.org

Review URL: https://codereview.chromium.org/375133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282133 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/380803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282131 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384650

Review URL: https://codereview.chromium.org/336923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282130 0039d316-1c4b-4281-b951-d872f2087c98