GitLab

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/241fe49617e2..7a319697e3aa


Created with:
  gclient setdep -r src-internal@7a319697e3aa

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:973101
Tbr: jbudorick@google.com
Change-Id: I76bc33f12347702c8c24e0f911c814d437541eee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019842Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#735003}

Adding UseCounters for postTask, TaskController, and TaskSignal now
that the IDLs have settled a bit and we have something we want to OT.

Bug: 979017
Change-Id: I265bfdf9f6ef3217ec2b65abf62f0af0fd2c0da4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017677Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Scott Haseley <shaseley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735002}

Ensure that the original usage flags a shared image is created with are
retained if its transformed via an ImageBitmap.

Bug: 1036142
Change-Id: I86ac384ab4ceefd9f581115e722b42b44bc3756d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970589
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735001}

When it is enabled, the CL mounts the squashfs image as /dev/vdd.

BUG=b:143780893
TEST=manually place the image file in /run/imageloader as Omaha side
 is not ready yet, manually modify the UpgradeParams, then start ARCVM
 and run 'mount /dev/block/vdd /odm' in android-sh.

Change-Id: I7744ad8d3d2d79b5a2efa21384fa8ea256c0df23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016290
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Auto-Submit: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735000}

Bug: 1045050
Change-Id: Iad5a53d2053b6a27bd08ac6824319af4450c15fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019604
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#734999}

Change-Id: I16e729f7c0dcc994cb691345b05832ec70621641
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019344Reviewed-by: Sam Maier <smaier@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734998}

In preparation of moving ios::ChromeBrowserState to the global
namespace, fix the indentation in app_launcher_tab_helper.mm
as "git cl format" wants to fix it when updating the type of
the browser_state variable.

Fixing the indentitation in a separate CL allow to make the
CL performing the move easier to review.

Bug: none
Change-Id: I7a54bc3c13510c5bfd39b4de7f83bb0512fac056
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014933
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734997}

R=rockot@chromium.org

Change-Id: Iba556a1d642d1dc4fb78e6960af104861396f54e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019364
Auto-Submit: Alexander Timin <altimin@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#734996}

The barebones XR sample was missing a negation, keeping the
start button disabled unexpectedly.

Copy the (fixed) barebones XR sample to create a barebones
AR sample with an optional DOM Overlay.

Also add a bit of CSS to make the barebones "enter XR" button
a bit easier to hit (and less ugly).

Change-Id: Ia2750b4c83d75d3f1faf3628a8593c9c78960442
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016357
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Auto-Submit: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734995}

TBR=rsleevi@chromium.org

Bug: 1045472
Change-Id: Ic4d076cf953355b8bd816af4712542d52264f21f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019408
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734994}

The ChromeBrowserState has been moved from the "ios" namespace
to the global namespace by http://crrev.com/c/2014913. Fix the
uses from ios::ChromeBrowserState to ChromeBrowserState.

Also remove includes of chrome_browser_state_forward.h and use
a simple forward declaration instead (since the old name is no
longer necessary).

This CL was uploaded by git cl split.

R=marq@chromium.org

Bug: 1042208
Change-Id: I84a18e74598f0cdabaa1b04a4953cc49903e060e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017511
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734993}

Updating testSignInOpenSettings to make it more clear, and to simplify
the code.

Change-Id: I07420ced98606498b4e15722776b07e6f934b09e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015248
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734992}

Bug: None
Change-Id: I32d97be235c917b49a3bcb7866cf5083f4b0175f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005975Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734991}

The ChromeBrowserState has been moved from the "ios" namespace
to the global namespace by http://crrev.com/c/2014913. Fix the
uses from ios::ChromeBrowserState to ChromeBrowserState.

Also remove includes of chrome_browser_state_forward.h and use
a simple forward declaration instead (since the old name is no
longer necessary).

This CL was uploaded by git cl split.

R=noyau@chromium.org

Bug: 1042208
Change-Id: I60e6158956d7e37747845e8ee68d06b97b2eecd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017428Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734990}

The ChromeBrowserState has been moved from the "ios" namespace
to the global namespace by http://crrev.com/c/2014913. Fix the
uses from ios::ChromeBrowserState to ChromeBrowserState.

Also remove includes of chrome_browser_state_forward.h and use
a simple forward declaration instead (since the old name is no
longer necessary).

This CL was uploaded by git cl split.

R=noyau@chromium.org

Bug: 1042208
Change-Id: Ic10c1f5b1f65ac65d14cea64f0ad688aef5eb971
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014973Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734989}

Mistakenly updated the system image package instance ID rather than the
avd package instance ID in crrev.com/c/2003563.

Bug: 922145
Change-Id: Id7535607acc4e73415b5f39a1ba08262c92897ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017822
Auto-Submit: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734988}

WebTimeNavigationObserver is used to notify its event
listeners when a navigation finishes.

Bug: 1034551
Change-Id: Ic233f11bbf17b6c0c6eccda9b9f52c8ded3feea7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004994Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734987}

Following bot results are included.
1101 1105 1108 1111 1112 1114 1115 1116 1118 1119 1120

52 lines were removed and 12 lines were deflaked by consecutive
results since 1094.

TBR=yosin@chromium.org
NOTRY=true

Bug: 982194
Change-Id: Ia243b17fbe6214e126ceaf5c47f94e4d4835975a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016682Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734986}

This CL merges client memory into user data; removing parts of the client
memory and parts of the former user data. In a previous CL, user data
ownership was moved to the controller to allow it to be retained across
multiple collect user data actions. With this CL, client memory is
removed/merged into user data so that all the user values retained on the
client will eventually be kept in a single place. Also in this change,
selected_profile, billing_address and shipping_address are no longer
separate/individual fields on the user data, rather they are stored in
the autofill profiles map.
Note that the action delegate can now provide the user data instead of
the client memory. This is plumbed through from the controller via
the script tracker.


Bug: b/148132177
Change-Id: Ife130d7537680fd214459bc2d80610cd8c3dfea3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014450
Commit-Queue: Marian Fechete <marianfe@google.com>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#734985}

Similarly to r733548 this change migrates the remaining
base::PostTaskAndReplyWithResult APIs to use base::OnceCallback and
updates their call sites.

TBR=danakj@chromium.org

Bug: 714018
Change-Id: I50d1038be0efc180313e43556848984ce0a42720
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016624
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734984}

https://dawn.googlesource.com/dawn.git/+log/d87e67684558..fa06dd0b6210

git log d87e67684558..fa06dd0b6210 --date=short --first-parent --format='%ad %ae %s'
2020-01-24 cwallez@chromium.org Fix Vulkan Swiftshader build on macOS

Created with:
  gclient setdep -r src/third_party/dawn@fa06dd0b6210

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I1c6cca7a1f55424e81a508c642a4d61e3096f3c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019078Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734983}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e2a36ca29e3d..05eb37fad076

git log e2a36ca29e3d..05eb37fad076 --date=short --first-parent --format='%ad %ae %s'
2020-01-24 aerotwist@chromium.org [Global] Update refs to UI.shortcutRegistry
2020-01-24 tvanderlippe@chromium.org Migrate web_audio/ to import cross-module
2020-01-24 tvanderlippe@chromium.org Migrate persistence/ to import cross-module
2020-01-24 tvanderlippe@chromium.org Migrate timeline_model/ to import cross-module
2020-01-24 aerotwist@chromium.org [Global] Update refs to Persistence.persistence
2020-01-24 aerotwist@chromium.org [Global] Update refs to SDK.domDebuggerManager
2020-01-24 tvanderlippe@chromium.org Migrate settings/ to import cross-module
2020-01-24 aerotwist@chromium.org [Global] Update refs to SDK.isolateManager & SDK.domModelUndoStack
2020-01-24 tvanderlippe@chromium.org Migrate javascript_metadata/ to import cross-module
2020-01-24 aerotwist@chromium.org [Global] Update refs to UI.context
2020-01-24 almuthanna@chromium.org Improve CharacterIdMap max capacity test
2020-01-24 mathias@chromium.org [e2e] Simplify collectAllElementsFromPage helper
2020-01-24 tvanderlippe@chromium.org Migrate search/ to import cross-module
2020-01-24 aerotwist@chromium.org [Global] Update refs to UI.actionRegistry

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@05eb37fad076

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1006759,chromium:1044632,chromium:1045385
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Icf903fdd6ead922950215988b1b89f81e9b6757e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019077Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734982}

*/EncryptedMediaTest.Playback_VideoOnly_MP4_AV1_10bit/*
*/EncryptedMediaTest.Playback_VideoOnly_WebM_Fullsample/*
*/EncryptedMediaTest.ConfigChangeVideo_EncryptedToClear/*

TBR: tmathmeyer@chromium.org
Bug: 1045393, 1045382, 1045376
Change-Id: Id1e866fa48d372d1fd88413d2fee8d159bad6fa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019107Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734981}

In the event that Vulkan or Metal are available and in use but GL is
blocked, remove it from the list of fallback options. The first
fallback will go to Swiftshader.

Bug: 1005383
Change-Id: I4e1f471374072a74f82d55e08e0e84c98c6f7b90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016345
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734980}

BUG=None
TEST=try, no real code change

Change-Id: Ib552103883e98a83e7748a47c5a755f34b34b708
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018003Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734979}

Logs if parsing the ice candidate message was successful.

Bug: 1021984
Change-Id: I5c7adaed6e3fef5e7e5417f8edd6d11381e6f95f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014942Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734978}

Bug: 958893
Change-Id: I65e220fd47755686ef3a2a58468de2a640473c8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013361
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734977}

The ChromeBrowserState has been moved from the "ios" namespace
to the global namespace by http://crrev.com/c/2014913. Fix the
uses from ios::ChromeBrowserState to ChromeBrowserState.

Also remove includes of chrome_browser_state_forward.h and use
a simple forward declaration instead (since the old name is no
longer necessary).

This CL was uploaded by git cl split.

R=javierrobles@chromium.org

Bug: 1042208
Change-Id: Id68870da5b0d31aeccffaedfbc2aead625bcefba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017466Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734976}

IE doesn't seem to unencode single-quote characters (') in the query-string of a
URL. With this patch, Chrome unencodes single-quotes before sending it off to
IE.

Bug: 1030184
Change-Id: I0c5e21b5789dfe357272ea87ca33f3c486fec7ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019762
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734975}

This is a second attempt to fix a unittest race.

The main thread gets a callback to update its total cache size that is
posted after the cache entry is created. Wait for that to be run
before checking the cache size.

I was able to reproduce the issue this time and can confirm that this
fixes it.

Bug: 1042441
Change-Id: Ic3f0f5a05415ba391be2887a3597c9645faac661
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015738Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734974}

This reverts commit 1454ded8.

Reason for revert:
There are timing differences in the behavior of AccessTokenFetcher
and PrimaryAccountAccessTokenFetcher. We need to change the behavior
of PAATF in another CL, then we can use the new version here with
the unconsented primary account.

Original change's description:
> chromeos: Migrate TokenHandleFetcher to unconsented primary account
> 
> SplitSettingsSync will allow the user to opt-out of browser sync.
> However, IdentityManager::GetPrimaryAccount() assumes the user has
> consented to sync. Switch to using the "unconsented" primary account,
> which exists whether or not the user has consented to sync.
> 
> This code doesn't add a DCHECK that the unconsented primary account
> exists because there are managed guest session tests that don't
> have a primary account but still exercise this code path.
> 
>       and on device
> 
> Test: existing login browser tests, manual tests of login on linux
> Bug: 1042400
> Change-Id: I14ee7bcc18c294dee31c26fcc9bed537836516b4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015589
> Commit-Queue: James Cook <jamescook@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#734647}

TBR=jamescook@chromium.org,xiyuan@chromium.org

Change-Id: I42942890e077e1a4d613816b084f900bac7299c5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1042400
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019409Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734973}

Add a test file for the ShareSheetCoordinator with a few basic tests.

Bug: 1009124
Change-Id: I65494bdefade392d46d645d41ee3bd1555b99b34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993758
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734972}

This code may be triggered from the main thread.

BUG=none
TEST=none

Change-Id: I72943d34eab9271cc2d94cbc3e1f064361b6c603
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018064Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734971}

SIGSYS fields were added to siginfo_t on glibc in version 2.17,
which is quite old now. Additionally, musl libc uses a different
name (__si_fields) for its internal struct members.

To fix this, use the libc-defined members if they are available,
otherwise fall back to _sifields, as is done currently.

Change-Id: I6a542a1817df7e31309a1043b899328a50834f7d
Bug: 1045069
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015735Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734970}

StartSurfaceToolbarCoordinator is not created for tablets.
Added a null check.

Bug: 1044902
Change-Id: Ibca30bff92cabae9fc14db204c2a871ac93e04b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016966Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Mia Glaese <glamia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734969}

Before this change, when an interrupt that ran inside of a PromptAction
failed, the PromptAction would ignore the callback with a
INTERRUPT_FAILED status and never return. The client would get stuck.

With this change, PromptAction properly forwards errors and stop actions
from interrupts.

Bug: b/146311363
Change-Id: I7d2133746ecd6e6ee4c45796b1d106cecc46b65c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014938Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734968}

This moves UnsafeResource from components/security_interstitials/content
to components/security_interstitials/core, and moves the methods in
UnsafeResource that depend on content/ into unsafe_resource_util.{h, cc}. This
makes it possible to use UnsafeResource on iOS.

SafeBrowsingUrlCheckerImpl uses UnsafeResource, so this CL is a step towards
refactoring SafeBrowsingUrlChekerImpl to make it usable on iOS.

TBR=boliu,carlosil,jkarlin

Change-Id: Ie981a39f1f42dd3a08162759c70582c0e15256c0
Bug: 1028755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015344Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734967}

The ChromeBrowserState has been moved from the "ios" namespace
to the global namespace by http://crrev.com/c/2014913. Fix the
uses from ios::ChromeBrowserState to ChromeBrowserState.

Also remove includes of chrome_browser_state_forward.h and use
a simple forward declaration instead (since the old name is no
longer necessary).

This CL was uploaded by git cl split.

R=javierrobles@chromium.org

Bug: 1042208
Change-Id: Ieae5c6ac2742659716e71514c178ea9a9d02c269
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017462Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734966}

proactive tab discarding has been removed, there's no more "CanDiscard"
column on the discards page.

Bug: 1044782
Change-Id: Iecd8c33c2fabc935b580951b1c6d383546ff0394
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017926
Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734965}

We are converting Android WebView Safe Browsing interstitials to
committed interstitials, so that interstitials work more like other
error pages. In WebView, existing error pages don't need to run JS,
but interstitials do. This CL forces images and scripts to be enabled
for error pages so that interstitials work properly (e.g., clicking on
buttons works) even if the app has disabled JS for web content. Images
and script are force-enabled by allowlisting the underlying error page
URL in AwContentSettingsClient, similar to how content settings are
allowlisted for error pages in ContentSettingsAgentImpl for Chrome
(https://cs.chromium.org/chromium/src/chrome/renderer/content_settings_agent_impl.cc?type=cs&sq=package:chromium&g=0&l=616).

I have not added tests in this CL because this will already be covered
by existing Safe Browsing WebView tests once they are switched over to
use committed interstitials
(https://chromium-review.googlesource.com/c/chromium/src/+/1909276/). This
CL can be manually tested by visiting a link on
https://testsafebrowsing.appspot.com in an app that has Javascript
disabled for WebView and clicking the "Details" link and observing
that the interstitial UI changes.

Bug: 1018809
Change-Id: I46f71738a2af3ff7361922ef0cde1522bcfb6e3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017987Reviewed-by: Carlos IL <carlosil@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734964}