Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 17 Dec, 2017 13 commits
    • Morten Stenshorne's avatar
      [LayoutNG] Fragmentainer breaks between line boxes. · f410ff66
      Morten Stenshorne authored 
      Constraint spaces for inline nodes also need to support block
fragmentation, due to floats.

We need to allow a (0,0) inline break token if we break before the first
line. If there's no break token for the inline layout context, it means
that we have finished all lines. Which is quite the opposite of being at
the very beginning.

There are some new test failures. One source is that we don't yet
support column-span:all, and now that we break between lines, what used
to pass by accident may no longer pass.

Making floats in an inline formatting context play along was tricky, and
I'm pretty sure that the solution I came up with needs to be improved.
For now, skip floats associated with the line when we resume layout at.
Floats that got broken inside will create break token children of the
token created for the containing block node, and will be break token
siblings of the inline break token to resume at (although they are not
siblings, node-wise).

The legacy layout write-back code doesn't work too great, especially
with LayoutNGPaintFragments enabled (but there are problems if that flag
is disabled too).

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I01634daf75a7d80a663ec24991eec8b4094aeeda
Reviewed-on: https://chromium-review.googlesource.com/829376
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: default avatarEmil A Eklund <eae@chromium.org>
Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524628}
      f410ff66
    • Weidong Guo's avatar
      Display mirroring persistency changes · fa8dfaa6
      Weidong Guo authored 
      Changes:
1. Change mirroring persistency rule to:
If previous mirror mode is not set (e.g. no external display in previous
configuration), turn on mirror mode if at least one of the external
displays was in mirror mode before and turn off mirror mode otherwise.
If previous mirror mode is set, mirror mode remains its previous value
as long as there are more than 1 displays.
For example:
Case 1: Connect display A; Turn on mirror mode; Connect display B. B
should be in mirror mode as well.
Case 2: Connect display A; Turn on mirror mode; Remove A; Reconnect A; A
should be in mirror mode.
Case 3: Connect display A; Turn on mirror mode; Remove A; Connect
display B. B should not be in mirror mode.
Case 4: Connect display A; Turn on mirror mode; Connect display B;
Remove B; Remove A; Reconnect B; B should be in mirror mode.

2. Fix a bug in MirrorWindowController: mirroring source display may be
changed in mirror mode (e.g. Connect two external displays; Turn on
mirror mode; Close internal display lid; Then the internal display will
be replaced with one external display as the mirroring source.),
reflector and mirror windows should be updated in this case.

3. Fix broken test.

Bug: 785416,792207
Test: MultiMirroringTest.*
Change-Id: Ia1da9f25df2bcc04f98ab087478a14685fff7708
Reviewed-on: https://chromium-review.googlesource.com/804647
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: default avatarMitsuru Oshima <oshima@chromium.org>
Reviewed-by: default avatarAhmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524627}
      fa8dfaa6
    • Rohit Rao's avatar
      [ios] Tests for nullptr before using _popupView. · 3e4254d9
      Rohit Rao authored 
      When the BVC presentation experiment is enabled and the last incognito tab is
closed, transition animations continue to run even after the incognito
BrowserState is destroyed.  Variables that are cleared in
|browserStateDestroyed| must be tested for nullptr before use.

BUG=787821

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic5443690337d311e1ce3e347e563d3111cc06f5e
Reviewed-on: https://chromium-review.googlesource.com/831095
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: default avatarJustin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524626}
      3e4254d9
    • Luke Sorenson's avatar
      Add Component version number to MPP API callback. · e9dca222
      Luke Sorenson authored 
      Bug: 794273
Change-Id: I340114ad83e2dcdd5fd2b8d0dea721d0705e53b3
Reviewed-on: https://chromium-review.googlesource.com/822820Reviewed-by: default avatarToni Barzic <tbarzic@chromium.org>
Commit-Queue: Luke Sorenson <lasoren@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524625}
      e9dca222
    • Jungshik Shin's avatar
      Exclude ar-001 and en-150 from the available locale list · a2b72993
      Jungshik Shin authored 
      Bug: 789905
Test: CrOS OOBE language menu does not have ar-001 and en-150.
Change-Id: I5f9489edf5819e789558bf53ddb4ecbb389e6a45
Reviewed-on: https://chromium-review.googlesource.com/828070Reviewed-by: default avatarAlexander Alekseev <alemate@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524624}
      a2b72993
    • Koji Ishii's avatar
      [auto] Update FlagExpectations for LayoutNG · 05fe1715
      Koji Ishii authored 
      Following bot results are included.
2493 2495 2496 2498 2499 2500 2502 2505 2508 2511 2512 2513 2524 2526

16 lines were removed by consecutive passes since 2485.

TBR=eae@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I1c0ecfac97903ff168d97597290ebf7f17037de9
Reviewed-on: https://chromium-review.googlesource.com/831309
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524623}
      05fe1715
    • Oystein Eftevaag's avatar
      Disable system_health.desktop_common load:media:youtube on mac · acf6a918
      Oystein Eftevaag authored 
      TBR=nednguyen@chromium.org
BUG=795585

Change-Id: Idbe16201235a53ad7669478d58611708e607d5bc
Reviewed-on: https://chromium-review.googlesource.com/831508Reviewed-by: default avataroysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524622}
      acf6a918
    • Mikel Astiz's avatar
      Expose and sync summary of replaced navigation entries · ba9cf2fd
      Mikel Astiz authored 
      We would like to sync this data in order to make sync-ed history entries
corresponding to history.replaceState() and similar Javascript events
distinguishable from user-initiated events (typed URLs or clicks on
bookmarks).

Most notably, this solves the problem of duplicates in the NTP for
server-side suggestions, which otherwise may count the URL after
replaceState() as being typed by the user and hence worth suggesting.

Design Doc (accessible to Google employees only):
https://docs.google.com/document/d/1g8w7VkLjI1V1f5N_Hkn3Lb66C3iUbV91SufFu2vEBSk/

Bug: 751023
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I7616d5f1782c0ee9af779d2c102a29b042ce44a1
Reviewed-on: https://chromium-review.googlesource.com/738095Reviewed-by: default avatarStefan Kuhne <skuhne@chromium.org>
Reviewed-by: default avatarNicolas Zea <zea@chromium.org>
Reviewed-by: default avatarCharlie Reis <creis@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524621}
      ba9cf2fd
    • George Burgess IV's avatar
      Add basic clang-based AFDO support. · b822aab9
      George Burgess IV authored 
      This patch adds support for clang-based AFDO to Chromium.

AFDO stands for Automatic Feedback Directed Optimization. In short, it
allows you to use the postprocessed output of a special `perf` command
to inform the compiler of hot/cold code, among other things.

This allows users to easily specify a profile to use, and allows for
platforms to specify default profiles. It turns none of this on on its
own.

At the moment, this is very sharp and pointy, since the sample profile
isn't a dependency for anything. Ideally, anything built with AFDO
should depend on the profile. I have a CL to make this easily possible
(CL:827560), but think this is useful enough (given care) to get in now.

(and with clang_use_default_sample_profile set to true). We built
with profiles and failed to `gn gen`, respectively. Patch seemed to be
a nop running on an otherwise "regular" build.

Bug: 794750
Test: Ran the build with and without clang_default_afdo_profile defined
Change-Id: I7b2730d52875f108681232f4d8ce7e82e7570a74
Reviewed-on: https://chromium-review.googlesource.com/828277Reviewed-by: default avataragrieve <agrieve@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524620}
      b822aab9
    • Yafei Duan's avatar
      [Offline Pages] Adding UMA for saving and deleting pages. · dc171dd3
      Yafei Duan authored 
      Adding UMA for saving and deleting pages:
- Refactored DeletePageTask for metric collection.
- Added new histogram names and made old ones obsolete.
- Updated related tests with histogram tester.

This CL also contains:
- Renamed test_util to test_utils for consistency.
- Added offline_pages::model_utils for utility methods used across all
  tasks and model itself.
- Updated OfflinePageItemGenerator for testing support

Bug: 772204
Change-Id: I894da05d510addbf01f3dd9b7ccda29b27404752
Reviewed-on: https://chromium-review.googlesource.com/811829Reviewed-by: default avatarMark Pearson <mpearson@chromium.org>
Reviewed-by: default avatarFilip Gorski <fgorski@chromium.org>
Reviewed-by: default avatarDmitry Titov <dimich@chromium.org>
Commit-Queue: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524619}
      dc171dd3
    • chromeos-commit-bot@chromium.org's avatar
      Automated Commit: Committing new LKGM version 10222.0.0 for chromeos. · b1e19689
      chromeos-commit-bot@chromium.org authored 
      TBR=chrome-os-gardeners@google.com

Change-Id: I118b5e3c5799130dc23cde5ee601d50b7f331631
Reviewed-on: https://chromium-review.googlesource.com/831566Reviewed-by: default avatarChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524618}
      b1e19689
    • chrome-release-bot's avatar
      Updating trunk VERSION from 3297.0 to 3298.0 · 6586a208
      chrome-release-bot authored 
      TBR=govind@chromium.org

Change-Id: I98fdf9497b8e9ac33ff1554c02898296e590a16c
Reviewed-on: https://chromium-review.googlesource.com/830791Reviewed-by: default avatarchrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524617}
      6586a208
    • Xiaohui Chen's avatar
      Make VoiceInteractionControllerClient a singleton. · 0f40dd5e
      Xiaohui Chen authored 
      Previously VoiceInteractionControllerClient has the same life cycle as
ArcVoiceInteractionFrameworkService, which is only alive when primary
profile running and has ARC++ enabled.  This life cycle isn't a good
fit for VoiceInteractionControllerClient since it is used to update
Ash states, which has a global life time.  It caused bugs like in multi-
profile, and restricted profile, Ash UI wasn't properly rendered.

BUG=b:68664196
TEST=unit tests and locally build and manually test multi-profile

Change-Id: I8495e2c41274db385741b86d778c96e15a25b977
Reviewed-on: https://chromium-review.googlesource.com/827540
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524616}
      0f40dd5e
  3. 16 Dec, 2017 27 commits