- 04 Apr, 2018 40 commits
-
-
Timothy Loh authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/4725eead5924..9c3e7ed65adc $ git log 4725eead5..9c3e7ed65 --date=short --no-merges --format='%ad %ae %s' 2018-04-03 timloh Add constants and proto for updating Crostini App Registry 2018-04-02 derat system_api: Add org.chromium.LockScreenService constants. Created with: roll-dep src/third_party/cros_system_api Bug: 821662 Change-Id: I15e4f707e7b7060a2bc67f8f75d58d3d71b84995 Reviewed-on: https://chromium-review.googlesource.com/994652Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#547962}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/adcf030f6910..a1df57cdc657 $ git log adcf030f6..a1df57cdc --date=short --no-merges --format='%ad %ae %s' 2018-04-03 ehmaldonado roll-dep: Support dictionaries in deps revisions. 2018-04-03 ehmaldonado Revert "presubmit support: Run all tests in parallel." Created with: roll-dep src/third_party/depot_tools BUG=chromium:760633,chromium:819774 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I965e7d61676852711ede33839ace1676344891d2 Reviewed-on: https://chromium-review.googlesource.com/994130Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547961}
-
Matt Mueller authored
Dual certificate verification trial: Add Net.CertVerifier_TrialComparisonResult histogram and uma_only mode. Bug: 649026 Change-Id: I634907d0751c42b4fa25ad62446d5030a1ae918b Reviewed-on: https://chromium-review.googlesource.com/990753 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#547960}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I81d05739dd71d1ae126ad695713e1024e1899e03 Reviewed-on: https://chromium-review.googlesource.com/994674Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#547959}
-
Findit authored
This reverts commit f4196ee3. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 547943 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Y0MTk2ZWUzNjMwODE1MGNjNTVlN2RmMGY0OGE1MjZiODQ4ZTQzYWYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/Mac/40051 Sample Failed Step: compile Original change's description: > media: Add CdmServiceTest > > This is a ServiceTest tha runs CdmService in-process (packaged) which > covers some basic interaction between CdmService and CdmFactoryImpl. > > Bug: 826039 > Test: Adds new tests to media_service_unittests > Change-Id: I85e99c22dba375d61de1a4be327953e0bf02600d > Reviewed-on: https://chromium-review.googlesource.com/989212 > Commit-Queue: Xiaohan Wang <xhwang@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: John Rummell <jrummell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547943} Change-Id: Ifa173b1917ddcde24b6e6d57ea54fb7d22aa4d5f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 826039 Reviewed-on: https://chromium-review.googlesource.com/994713 Cr-Commit-Position: refs/heads/master@{#547958}
-
Xi Cheng authored
Disable histogram persistence during uninstall since there's neither a directory in which to write them nor a browser to subsequently upload them. This allows to add LOG(ERROR) without breaking the installation tests when it detects the storage directory does not exist. Also, do not attempt to store histograms from setup.exe executions dedicated to crashpad. Otherwise, this will trigger LOG(ERROR) in the destructor of class PersistentHistogramStorage. Bug: 734095 Change-Id: Iffff0fab25eedb7f934144802e805ba2d047a42a Reviewed-on: https://chromium-review.googlesource.com/987541Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#547957}
-
Jiaquan He authored
This is a reland of db8976b8 Original change's description: > app_list: merge AppListViewDelegate into AppListClientImpl in Chrome. > > This commit does a few things: > > - merges the Chrome AppListViewDelegate into AppListClientImpl; > - cleans up unused references; > - updates methods to proper accesses. > > Ownership of major classes: > > - Each user has its own AppListSyncableService, and it holds its own > AppListModelUpdater, ModelBuilders, etc. > - There's only one AppListClientImpl in ChromeBrowserMainExtraPartsAsh > shared by all users, and it holds Search classes, a mojo pointer to > the AppListControllerImpl in Ash, etc. > - There's only one singleton AppListServiceImpl shared by all users, and > it holds AppListControllerDelegateImpl. > > Their lifecycles: > > - Among these classes, AppListClientImpl is the first to be initiated, in > PreProfileInit. It binds to AppListController in Ash, and then tells > AppListServiceImpl two pointers (AppListController*, AppListClientImpl*). > - When AppListServiceImpl receives the two pointers, it should have been > initiated as a singleton. > - The AppListClientImpl is associated with the current active user profile > when it's accessed from AppListServiceImpl. > > Bug: 733662 > Change-Id: Iac6de011185bf88c4b3c575871b69bd7a67c340b > Reviewed-on: https://chromium-review.googlesource.com/974660 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Jiaquan He <hejq@google.com> > Cr-Commit-Position: refs/heads/master@{#546247} Bug: 733662 Change-Id: Ia779e0ec795a9457dc7214f38b528c2dab688b90 Reviewed-on: https://chromium-review.googlesource.com/991232 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#547956}
-
Adrienne Walker authored
Every caller to CheckPendingGpuWorkTiles wants signals, some callers just issue signals synchronously and others request the function to issue signals asynchronously (and do an additional flush and recheck). This makes every IssueSignals synchronously called as a part of CheckPendingGpuWorkTiles instead of having unnecessary callbacks. https://chromium-review.googlesource.com/c/chromium/src/+/993157 fixes bugs that are required for these changes. Some tests like ResourcelessSoftwareLayerTreeHostImplTest.*SkipsUpdateTiles check to make sure that prepare tiles is not set, but this is only true if IssueSignals is async (so that the test passes) because both activate and draw were signalled together previously. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0395c9d2a73ae287fcc9e0786560ce62a79f7ffd Reviewed-on: https://chromium-review.googlesource.com/992861 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#547955}
-
bsheedy authored
Adds support for and enables the fake VrCore head tracker in VR benchmarks. This causes the tests to ignore any actual movement from the test device, and instead sweep the view back and forth horizontally in 180 degree arcs. Bug: 828190 Change-Id: I25681867116360d5071a01fcea725994fe340e74 Reviewed-on: https://chromium-review.googlesource.com/993872Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#547954}
-
Pedro Amaral authored
This reverts commit a17de6fe. Reason for revert: The options in the selection menu don't work. Copy and Select All don't do anything. Original change's description: > Interstitial call ShowContextMenu on Android > > Override |ShowContextMenu()| in InterstitialPageImpl and have it call > |WebContentsViewAndroid.ShowContextMenu()| on Android. This is done to > show the floating text selection menu (see linked bug). > > Bug: 823173 > Change-Id: I01090aee43536cd06c8f8bc28ebccf5c2767d0d8 > Reviewed-on: https://chromium-review.googlesource.com/977240 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Carlos IL <carlosil@chromium.org> > Commit-Queue: Pedro Amaral <amaralp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#546210} TBR=boliu@chromium.org,amaralp@chromium.org,carlosil@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 823173 Change-Id: Ia0743769b372b93acda2835c2274456f3a5379a0 Reviewed-on: https://chromium-review.googlesource.com/994191Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#547953}
-
Yoshifumi Inoue authored
This patch changes "5569741.html" to utilize |selection_test()| for ease of maintenance. Following patch will rename "5138441.html" to "indent_paragraph_at_empty_paragraph_in_list_item.html". Note: "5569741.html" is failed on layout_ng bot due by pixel test. Bug: 679977, 636993 Change-Id: Ib1b84bdf0c864c54cc1a039db56406c3a3c5fc77 Reviewed-on: https://chromium-review.googlesource.com/991656Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547952}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/81094bec..b9e32970 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: If1c81b3a047ba4c0b0355d5d5bf0332eeba0753a Reviewed-on: https://chromium-review.googlesource.com/994393Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#547951}
-
Marijn Kruisselbrink authored
This is no longer used in blink (and shouldn't be used anymore), so can safely be removed. Also removes RenderThreadImpl::GetFileThreadTaskRunner, and moves its usage to create task runners closer to where they are used. Bug: 828364 Change-Id: I1c72edfd8da56b21d93ce76d24277ad5ef582383 Reviewed-on: https://chromium-review.googlesource.com/992817Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#547950}
-
Erik Chen authored
Chrome's TLS implementation is not safe to use after internal structures have been destroyed during thread destruction. On POSIX, doing so will cause extra, unnecessary work as internal structures are recreated, then destroyed later. On Windows, doing so will cause a leak. This CL adds a kDestroyed state that Chrome TLS sets after it finishes destruction. Slot::Get() DCHECKs that state != kDestroyed. There are currently two legitimate cases where an external consumer would need to check the status of kDestroyed. The heap-profiling shim can be invoked by BoringSSL's thread destructor. It's important that this doesn't cause re-entrancy into Chrome TLS. This CL adds a private function ThreadLocalStorage::HasBeenDestroyed which is exposed via friendship for the two implementations of the heap profiler to use. Change-Id: I5bd8dca3d48ee1c9d456bc05fa0824800575ca38 Bug: 825218 Reviewed-on: https://chromium-review.googlesource.com/978393 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Dmitry Skiba <dskiba@chromium.org> Cr-Commit-Position: refs/heads/master@{#547949}
-
chcunningham authored
Trying to track down causes of the crash (initializing a null renderer). Bug: 827990 Change-Id: I2fe20dd55921eaf43fccb89a69ee9f9135443b4f Reviewed-on: https://chromium-review.googlesource.com/994142Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#547948}
-
Eugene But authored
This histogram will help to understand how many downloads are failed because the user quit the app as well as how many downloads were performed while the app was inactive. CanceledAfterAppQuit metric will be logged in a separate CL (crrev.com/987200). Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8d2d07159a178373038479a3189feaf7a93cf57f Reviewed-on: https://chromium-review.googlesource.com/981327 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#547947}
-
Tsuyoshi Horo authored
Bug: 768705,788619 Change-Id: I18474261a0bb443b5ed7186adb8bc68227ece26c Reviewed-on: https://chromium-review.googlesource.com/994492 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#547946}
-
Kent Tamura authored
Also, fix new path. All *.mojom.js files in third_party/WebKit/public/, and new directory should be third_party/blink/public/. Bug: 578345 Change-Id: Icb5e06c1094b2fdc5f8c057bffb530e208e5ae57 Reviewed-on: https://chromium-review.googlesource.com/990855 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#547945}
-
Tetsui Ohkubo authored
Previously, CapsLock notification is generated from TrayCapsLock, which is going to be removed when UnifiedSystemTray is launched. This CL separates the notification generation from TrayCapsLock to CapsLockNotificationController. TEST=CapsLockNotificationControllerTest BUG=824631 Change-Id: I56bf6df710f4f06c60f19c98d0b2c46a98ce1486 Reviewed-on: https://chromium-review.googlesource.com/991623 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#547944}
-
Xiaohan Wang authored
This is a ServiceTest tha runs CdmService in-process (packaged) which covers some basic interaction between CdmService and CdmFactoryImpl. Bug: 826039 Test: Adds new tests to media_service_unittests Change-Id: I85e99c22dba375d61de1a4be327953e0bf02600d Reviewed-on: https://chromium-review.googlesource.com/989212 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#547943}
-
Koji Ishii authored
Following bot results are included. 4541 4542 4551 4554 4556 2 lines were removed and 1 lines were deflaked by consecutive results since 4493. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Id19c247a62decf08d167a27b3dffc93c119d85fb Reviewed-on: https://chromium-review.googlesource.com/992253 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#547942}
-
yusukes authored
BUG=None TEST=no code change Change-Id: I29b509c01415dcbce90e129ce168b35e771b7a25 Reviewed-on: https://chromium-review.googlesource.com/994172Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#547941}
-
Lei Zhang authored
Make sure there is text output when converting from PDF to PS for text with negative size, which should be rendered rotated 180 degrees with respect to the origin. BUG=806746,827748 Change-Id: Ia214f25f8fdb945ecb5a046e07313e3237b2cf84 Reviewed-on: https://chromium-review.googlesource.com/989424 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#547940}
-
yusukes authored
djacobo@ owns c/b/c/apps/intent_helper/ already. This CL does the same for c/b/c/arc/. BUG=None TEST=no code change Change-Id: I732ab869f8cd1a58d833f81522e1653a12e4afcb Reviewed-on: https://chromium-review.googlesource.com/994063Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#547939}
-
Wenzhao Zang authored
To use the switch: 1) Install the build that contains this CL. 2) Go to dev console, open /etc/chrome_dev.conf 3) Append: --rlz-ping-delay=1 (or any value) 4) Save and exit, run "restart ui" (or reboot the device) to make the switch take effect. TBR=rogerta@chromium.org Bug: None Change-Id: I8431d0cb3a376b5e5aa0b35ff7d155110324716a Reviewed-on: https://chromium-review.googlesource.com/994141Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#547938}
-
Kyle Horimoto authored
Previously, //components/cryptauth was open to several platforms, and the pure-virtual class SecureMessageDelegate had only one concrete implementation, SecureMessageDelegateChromeOS. As of https://chromium-review.googlesource.com/c/chromium/src/+/984441, this component is now CrOS-only, so this CL moves SecureMessageDelegateChromeOS to //components/cryptauth and renames it to simply SecureMessageDelegateImpl. This CL also moves the factory pattern from the pure-virtual class to the implementation itself and changes client sites to call the factory's static NewInstance() function, which cleans up code significantly by removing the need to pass SecureMessageDelegate::Factory instances around. This CL is in preparation for utilizing SecureMessageDelegateImpl in the Device Sync service in //chromeos/services/device_sync. Bug: 824568, 752273 Change-Id: If06b49485cd6146159c09af5babc3f0afe1116c2 Reviewed-on: https://chromium-review.googlesource.com/993474 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#547937}
-
John Budorick authored
TBR=tandrii@chromium.org No-Try: True Bug: 790130 Change-Id: Ic6dc278bca6cfc04d0ee5ffe3cc560077e980cc6 Reviewed-on: https://chromium-review.googlesource.com/994542 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#547936}
-
Jay Civelli authored
Contains the following changes: a9626b9 Disable AVX512 for iOS simulator xcode 9 builds. a694e33 Make the gflags library optional in the CMake build d4cfc7b Fix building with clang targeting x86_32 mingw efb70e5 Fix building the library with cmake for windows 816b7b1 Add __attribute__ ((__target__ ("avx512vbmi"))) 4ad3334 Pass float parameters via vector 2 float and "w" for scalar multiply. by Frank Barchard d868089 Fix building with clang targeting x86_32 mingw by Martin Storsjö 548ec65 Require clang 6 for AVX512 support by Frank Barchard c21af29 jpeg remove empty function declarations by Frank Barchard fdad629 Add a method to force the CPU flags by Jay Civelli 6ecd76a Make libyuv use the hermetic xcode toolchain. by Patrik Höglund 9d70f13 cpuid sandbox friendlier avoiding getenv() by Frank Barchard 83aa751 AVX512 VMBI version of ARGBToRGB24 by Frank Barchard 004954c cpu disables for AVX 512 and unittest show decimal by Frank Barchard 1d509f2 ARGBToRGB24_AVX2 version by Frank Barchard 3009890 NV21ToRGB24_AVX2 and SSSE3 by Frank Barchard Change-Id: I5dcd923114ac6a696408ca6e5206f11aabb232fc Reviewed-on: https://chromium-review.googlesource.com/988217Reviewed-by:
Frank Barchard <fbarchard@chromium.org> Commit-Queue: Frank Barchard <fbarchard@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#547935}
-
James Hawkins authored
R=isherman@chromium.org Bug: none Test: none Change-Id: I037ff111a1ce3f4ba70473569abd8008378c00ed Reviewed-on: https://chromium-review.googlesource.com/994278 Commit-Queue: James Hawkins <jhawkins@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#547934}
-
Ryan Landay authored
This CL adds a flag for making the Android tab switcher always use horizontal mode (currently used in landscape mode) in portrait mode. Later CLs will refine the experience so we can run a public experiment. Bug: 828224 Change-Id: Iee9417c6e6c3b39df07202da453da71da9cbe72b Reviewed-on: https://chromium-review.googlesource.com/991400 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#547933}
-
Sammie Quon authored
Using two fingers was not restricted which brought a bunch of other bugs. Only allow one item to be dragged at a time. Still allows switching of fingers midway, so we just check the item which requests drag events is the same as the current drag item, instead of checking the gesture finger id. Test: ash_unittests WindowSelectorTest.DraggingWithTwoFingers Bug: 827435 Change-Id: I2c897b1b3c483b5df7a98a658f575a6ebd706acd Reviewed-on: https://chromium-review.googlesource.com/988294 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#547932}
-
Esmael El-Moslimany authored
Bug: 698694 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I55642580b173c544659cceee504ecef035047d9b Reviewed-on: https://chromium-review.googlesource.com/992869Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#547931}
-
Tsuyoshi Horo authored
Bug: 768705,788621 Change-Id: I0e0b2eb03da7c6c65e871db94c836ac4c06a46e6 Reviewed-on: https://chromium-review.googlesource.com/994493Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#547930}
-
Dave Schuyler authored
This CL is a step toward making views children manage their views. This step moves the data members, but still does the layout in the result view. A later Cl will move the layout. Bug: None Change-Id: I82c498c0ae648b57d750828f687d9064ccee29dd Reviewed-on: https://chromium-review.googlesource.com/994243 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#547929}
-
Andrii Shyshkalov authored
Testers: * "Mac Release (Intel)" * "Mac Retina Release (AMD)" R=hinoka@chromium.org, kbr@chromium.org Bug: 790063,790077,790066 Change-Id: I4a6fb8e97e7bae5462771d9d0a91cd3f02ebd095 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/994119 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#547928}
-
Kent Tamura authored
* Change the default log level from DEBUG to INFO * Change some logs from info() to debug() * Show "Update ..." log only if a file is actually updated. * Remove a raw |print| statement. Bug: 578345, 767672 Change-Id: I6fa6e5f548cd48bf7bad38795db7f3828f045d61 Reviewed-on: https://chromium-review.googlesource.com/991340Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#547927}
-
Emily Hanley authored
Bug:827663 Change-Id: I297b5307d40630bcbede26206cd449649d75876a NOTRY=true # Flake Change-Id: I297b5307d40630bcbede26206cd449649d75876a Reviewed-on: https://chromium-review.googlesource.com/992635 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#547926}
-
Bence Béky authored
Bug: 819101 Change-Id: Ic5070b5c26313a6b4c991abfc83228f9ef12f99b Reviewed-on: https://chromium-review.googlesource.com/990532Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#547925}
-
Kent Tamura authored
We don't need to update #includes in generated files. Bug: 578345 Change-Id: Ib559f672d1aa535967a71143bf56131dca890e1d Reviewed-on: https://chromium-review.googlesource.com/991272Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#547924}
-
Xianzhu Wang authored
The situation doesn't cause corrupted rendering but just slightly affects performance. It's fine not to DCHECK given that the situation is rare. Bug: 805024 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iac8cd617d5df51da2516fc6a9df1308a0daaedd0 Reviewed-on: https://chromium-review.googlesource.com/990074 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#547923}
-