- 10 Aug, 2020 40 commits
-
-
Wei-Yin Chen (陳威尹) authored
Before this CL, when FieldTrials.collectFieldTrials() is invoked, mergeFeatureLists() has not been called, so enabled features are not correctly populated. This makes collectFieldTrials() produce incorrect data, which leads to the crash in applyFieldTrials(). This CL makes sure the enabled/disabled features specified in the command line arguments are visible to FieldTrials. Bug: 1113847, 1102633 Change-Id: I5c49c41c87fd0219c73a967db2ee33dc8237f52f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344805Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#796552}
-
Livvie Lin authored
Change-Id: I82144f8ae9653006132b7aaef81c4810b8d8cf9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342128Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796551}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7b17f160f76a..ff337e33c90c 2020-08-10 fawazm@google.com [WebAuthn] Add Credential Table 2020-08-10 brgoddar@microsoft.com Add histograms for Devtools Experiments If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1034663,chromium:1107636 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2faad8bb00b68217ebdfb933ea78e32f027c89eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347186Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796550}
-
Matt Wolenetz authored
To prepare for cross-thread HTMLMediaElement+MediaSource API attachments, aka "MSE-in-Workers", this CL decouples the MediaSource object from what is directly registered. A new type, MediaSourceAttachment, is used to register available MediaSource objects, and a simple concrete implementation is included in this type to resolve the underlying MediaSource for use in actual attachment. This CL is needed as a prerequisite for cross-thread attachments because subsequent CLs are significantly complex. They will: 1) Move MediaSourceRegistry singleton creation to modules initializer to ensure it is owned on the main thread, even if a worker thread was the first to need it (see bullet 3, below). 2) Update MediaSourceAttachment to be an interface and move the communication between HTMLMediaElement and the MediaSource to be done via the interface with concrete implementation(s) in modules. 3) Add a cross-thread attachment implementation. This part will be complex, and will be better handled if the existing same-thread behavior and the new cross-thread behavior are distinct implementations of a common attachment interface. Further, having a non-oilpan type (the concrete implementations of MediaSourceAttachment) as the registrable enables the implementations to safely operate when lifetimes of either side of the attachment vary. And such a non-oilpan type must be used as the registrable if the registry singleton's internal initialization is done prior to Oilpan being ready (during the modules initializer). 4) Refine the interface and concrete implementations for performance and quality specific to the types of attachment being used. BUG=878133 Change-Id: I8376f6483142d3653e5d39d76f5a245c80365b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300804Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#796549}
-
Sven Zheng authored
Tests are based on recent jobs: https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/829? https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/828? https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/827? Bug: 1111979 Change-Id: Ife35a71ae4a90697ee39ad7c0d8eba23d456a522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347364Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#796548}
-
Xianzhu Wang authored
We should invalidate the tilings only when we are updating tiles for the sync tree. Bug: 1110872d Change-Id: Id00da58c78bf86423eba368085b9a3a75b855e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344808 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#796547}
-
Robert Ma authored
Also remove Retina tags from all expectation files. Bug: 1104846 Change-Id: If16ec3610f4120628f834a72fe02750e70418320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346855 Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796546}
-
Etienne Pierre-doray authored
Best effort max tasks always acts like MayBlock. This is to prevent issue where many WILL_BLOCK BEST_EFFORT tasks increase the thread pool capacity, which is undesirable. This new behavior is similar to FixedMaxBestEffortTasks, but keeps the increase around to prevent deadlocks. https://uma.googleplex.com/p/chrome/variations/?sid=4a990d53992445c75cf9665227ab221c Bug: 1026785 Change-Id: I4be2f478c730cc75f8d358665edec72ad651902f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300343 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#796545}
-
Dana Fried authored
Due to cautious rollout of WebUI/tablet tabstrip and hover card preview images, we need more time with these metrics. Bug: 1112398 Change-Id: I97558bc5b715f3f8e401bb021feacec3721489c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343874Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#796544}
-
chrome://flagsMoe Ahmadi authored
Adds chrome://flags/#promo-browser-commands in order to facilitate testing the promo browser commands. For every new command, an option should be added to this flag. Selecting that option would replace the middle-slot promo on the NTP with a mocked promo and replaces the promo URL with command:<ID>. Bug: 1106421 Change-Id: I53e07d8fcdea057f43d9ff086c49a93565d79969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346834Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#796543}
-
Kramer Ge authored
CommitOverlays is a more generic IPC that packages multiple overlay configurations for a frame before sending it to browser process. This replaces the CommitBuffer IPC. This CL merely adds CommitOverlays. It does not send multiple buffers using it. This is 3/? CL for overlay forwarding using wl_subsurface. Bug: 1063865 Change-Id: Id71d055bdb14b3d2e97cb2eef8811dca56323899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314665Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#796542}
-
Varun Khaneja authored
Bug: 1104919,1114674,1114498,1114447 Change-Id: I3f795b4084d6c8346a6a9c0ead9719e84be88ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347144 Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#796541}
-
Sam Sebree authored
This change uses native_theme_base.cc and controls_refresh.cc to update the styling for the range native controls in dark mode. Bug: 1107287 Change-Id: Id176b010a0be12c192452b0cefcfb9166881ba3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342306 Commit-Queue: Sam Sebree <sasebree@microsoft.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796540}
-
Becca Hughes authored
We have our own product in Feedback for Kaleidoscope so we should use that for feedback. BUG=1111981 Change-Id: I107a8d9a50557e6e1ffcb308a94ba5760e1c1062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343633Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#796539}
-
Fred Mello authored
https://docs.google.com/document/d/1WUuivgpuYFdDZqsfuz3wMgfZgOAcNH8Dpl07rjKmdNY Bug: 1112872 Change-Id: Iccfd03e67e5ac236234b3e612986c85b9137aba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346724 Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#796538}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ea8be2120ee6..46a324a16c4b 2020-08-10 robertphillips@google.com Move GrSmallPathAtlasMgr to its own file and out-line 2020-08-10 johnstiles@google.com Update style guidance for [[fallthrough]]. 2020-08-10 robertphillips@google.com Clarify that the GrDirectContext uniquely holds the text atlas manager If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: fmalita@google.com Change-Id: Ic7c0a29b43c2382688581f040b872832d01d14c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346883Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796537}
-
David Trainor authored
This has been failing on Android P bots. TBR: blundell@chromium.org Bug: 1114795 Change-Id: Id46c6175aa7f6742a37fd41e0cdc1d3b83cb996a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347164 Auto-Submit: David Trainor <dtrainor@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#796536}
-
Darwin Huang authored
Update the section discussing auto, to use `` delimiter pairs, and be consistent with the comment style section below. Change-Id: Ib175db1b97a426c66dbc27bdbcce31f680783baa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347304 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#796535}
-
Filip Gorski authored
Change-Id: I1de39333d4dcdecf5266f5ce42907601ccc815f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346999Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#796534}
-
Tom Anderson authored
This fixes a regression after [1] in which I erroneously changed != to == in 2 places. This was causing a bug in setups that have high-resolution scrolling where the scroll distance would not get reset when switching to another app, scrolling, then switching back to Chrome. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2316436 R=nickdiego Bug: 1113903 Change-Id: I4a0adce22687ccc4a79986bf5d4d5bd8f71c66dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346952 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#796533}
-
Liquan (Max) Gu authored
Change: * Encapsulate PRClient in CPRImpl. Before the change, PRImpl had to manage the lifespan of PRClient and CPRImpl. After the change, PRImpl only need to manage the lifespan of CPRImpl, as PRClient is no longer visible to PRImpl. * Clarify that PR#close can only be called by the renderer * Create CPRImpl#teardown to play the role of closing (should have called #close if not for the collision with the PR#close interface). * Clarify the usage of CPRImpl#teardown, BPR#close, PRImpl#close. Add mHasClosed/mHasTorndown for CPRImpl#teardown and PRImpl#close to make sure these methods can be called within themself without worrying deadloop. For example, while PRImpl#close calls CPRImpl#teardown, CPRImpl#teardown can call PRImpl#close back without causing deadloop. Acronym: PRClient = PaymentRequestClient CPRImpl = ComponentPaymentRequestImpl BPR = BrowserPaymentRequest PR = PaymentRequest Bug: 1102522 Change-Id: Ic6495f02593f9a1cfad9747e52e9dcf3a05b1018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343631 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796532}
-
Scott Violet authored
As it's flaky on windows as well. BUG=1099395 TEST=test only change TBR=hajimehoshi@chromium.org Change-Id: Ie3277c33c16ca1cb1a589934a8077f783d3e7c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346056Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#796531}
-
Henrique Nakashima authored
Plain simple move since these classes have no dependencies. This is a step to modularize AsyncTabParamsManager to .tabmodel. Bug: 1112920 Change-Id: Ia9a6810c1eabf1a97c8baa06354df6faf7c51dff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335912Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#796530}
-
Thiabaud Engelbrecht authored
For reference, the UNIT_TESTS batch can be run locally using: out/.../bin/run_chrome_public_test_apk -A Batch=UnitTests Bug: 989569 Change-Id: Icea283a01697c4fdade7039d8b4ef629af835655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346984Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Cr-Commit-Position: refs/heads/master@{#796529}
-
Yuly Novikov authored
on Nexus 5X. RetryOnFailure on both validating and passthrough CB. TBR=kbr Bug: 1043431, 914631 Change-Id: I615bb84874e46954d2db6945c0c6afdc1ee310cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346992Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#796528}
-
Robert Ogden authored
See bug, but there's a slight regression in startup time for starting the probe which isn't actually that useful for the first nav anyways. Bug: 1113691 Change-Id: Idc50e39067bc54f5dc8263b89add6dc8b3cf1bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346739Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#796527}
-
Chong Gu authored
Logs are already handled via SystemLogReader. Bug: 1067356 Change-Id: Ide3a2d5545e1e8cdbd302be184612699ad149a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347051 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796526}
-
Stephanie Kim authored
Referenced 10.15 update CL https://chromium-review.googlesource.com/c/chromium/src/+/1776218 Bug: 1112846 Change-Id: Ie06190e48432caa75b55b69894a4384a3319580c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339702 Commit-Queue: Stephanie Kim <kimstephanie@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#796525}
-
Ben Mason authored
TBR=dullweber@chromium.org Bug: 1112409 Change-Id: Idf31c4a8d709ddc3f4f87cff63d63881f0198424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346853Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#796524}
-
Mario Bianucci authored
SetNeedsDisplay() was being called many times, when every other test limits it to a certain number of times. This test should only call it once, and doing so prevents it from running wildly and flaking on the single threaded versions. Bug: 1111302, 1112507 Change-Id: I2038c89e73b7b92b03133a4cf8487a9a54467fb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343221Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#796523}
-
Dan Sanders authored
This improves our alignment with the current draft spec, and exposes the APIs required to implement planar access. Bug: 1096717, 1096722, 897297 Change-Id: Ic9f33ce703e4492d61ad5784c849b8816a75b89f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341836Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#796522}
-
Jeff Yoon authored
Appending linux as a supproted platform for the update pgo script. Adding the linux.pgo.txt with the latest profile information. Bug: 1105530 Change-Id: I63ec40b915970d9ad8a06aaaf594dcbf96dad109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347070 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Auto-Submit: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#796521}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b27f3f1980fd..c92cc9537f56 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sky@google.com,eirage@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1112335,chromium:1112941 Tbr: sky@google.com,eirage@google.com Change-Id: I921deb41683d7f7ae19c02ba73fcb24648e2a7cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346877Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796520}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I56741401e5e24da0fb37448c109ec507925c8be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346912Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#796519}
-
behdad authored
- ActivateDuration is removed as it is covered by CompositorLatency.Activation - BeginMainFrameIntervalCritical is removed as it is no longer useful Bug: 1039311 Change-Id: Ic2b31c0835a6956b4ead0cbf4c1bc75a19c74088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342576 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#796518}
-
Nicolás Peña Moreno authored
This CL improves crossiframe.html by waiting for the load event (so it knows the iframe is ready), and makes it faster by awaiting for both the main frame and iframe observers at the same time. It also improves the buffered-and-duration test by considering cases in which the first event does actually get buffered due to machine slowness. Bug: 1074048 Change-Id: Ieb356a4a4bbcfca8454e8a76334df70867b4f954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343487Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#796517}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597060771-94a7300bd1819f6d10eaf4c394bfbc10cebf8f71.profdata to chrome-mac-master-1597082402-653f85831e858c9a0c668621a5e4055f49c06c11.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I7d77310effe572ae55e7b5d836da5e437a47adc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796516}
-
Kurt Catti-Schmidt (SCHMIDT) authored
This is the corresponding IA2 fix for the selection-iframe crash here: https://chromium-review.googlesource.com/c/chromium/src/+/2300266 The approach is different for IA2. Since IA2's setSelectionRanges requires actual nodes to be passed in, it doesn't make sense to move the selection range to different nodes than specified. Instead, this change simply returns E_INVALIDARG when two nodes are provided that exist in different trees. I generally don't like this approach, as it is reporting implementation limitations as a user-error, but I think it's the best approach for this particular scenario. A browser test was added that would crash without this fix in place. AX-Relnotes: n/a Bug: 1110522 Change-Id: Ifa8e9e7b43c52d611d0c77b134f5cb0ab3b86357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340291 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#796515}
-
Jimmy Gong authored
- Introduce a "stopped" state when the printer is in an error state and is waiting for the user to fix the issue. - For example, if a user prints to a printer that is out of paper, the ongoing print job will now update to reflect that status. - Updated browser and unit tests to reflect this change. Screenshot (full view): https://screenshot.googleplex.com/YPR4R40jNeV Screenshot (collapsed view): https://screenshot.googleplex.com/A64F7TvHspR Bug: 1093527 Test: BrowserTest and UnitTest Change-Id: Ia72f23d67066d5640698163759ddf4151a59e07a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342309 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#796514}
-
Sammie Quon authored
It will be between the IME pod and palette pod. Will add a simple test and place it on the correct shelf in a latter CL. Test: manual Change-Id: If67b781f558643aa42c501dddb8ebaba1017f445 Fixed: 1113938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342117 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#796513}
-