- 22 Feb, 2019 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6ff0f3bb. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." cd40220a "Fix as=fetch preload where preload is used before response arrives" 1d89521e "[LayoutNG] Force relayout when constraint spaces change." 98e7141b "Fix 2_tracks, 3_tracks wpt/webvtt tests" f82f5505 "[LayoutNG] Fix inline-level OOFs inside a block-level context." 1a46f4bb "v8binding: Make PaintWorkletGlobalScope use IDL callback function" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: If82d0dff652b9f016e283b6735009436a7473953 Reviewed-on: https://chromium-review.googlesource.com/c/1483150Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634681}
-
Stefan Zager authored
The IntersectionObserver algorithm must run using the throttling status that was in effect when the frame was generated. Since the IO steps have been moved to happen later (in RunPostLifecycleSteps), we must delay propagating throttling status. BUG=933694,928228 R=bokan@chromium.org Change-Id: Ic6a5fc37d3871eb30d8d1138d5c63fe8d61b53c8 Reviewed-on: https://chromium-review.googlesource.com/c/1481998Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#634680}
-
Robert Ogden authored
The new icon, same as the other preview icons, is simpler and smaller. This CL implements the UI mocks, specifically: * New speedometer icon * No enabled/disabled shading * 24dp instead of 32dp Bug: 909915 Change-Id: Icf4aed99869986b8e285a14e3179e7a054584667 Reviewed-on: https://chromium-review.googlesource.com/c/1481795Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#634679}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0a94c0324d42..b4fdbb737c98 git log 0a94c0324d42..b4fdbb737c98 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 perezju@chromium.org [Telemetry] Clean up tracing_controller code Created with: gclient setdep -r src/third_party/catapult@b4fdbb737c98 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:931236 TBR=sullivan@chromium.org Change-Id: I03538f3a11396644509e2af97924070ecf05a82e Reviewed-on: https://chromium-review.googlesource.com/c/1482933Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634678}
-
oysteine authored
This reverts commit 8b42fd6c. Reason for revert: Flakes https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOGI0MmZkNmM5MmZiNjY2MWNmYzNlOTIzNWM4NmYwMjU2MjZkZjA4ZQw Original change's description: > Revert "Tracing: Move the tracing service in-process again to figure out test flakes" > > This reverts commit 6b27bca8. > > Reason for revert: Should be fixed with https://chromium-review.googlesource.com/c/chromium/src/+/1474309/ > > Original change's description: > > Tracing: Move the tracing service in-process again to figure out test flakes > > > > Effectively temporarily reverting https://chromium-review.googlesource.com/c/chromium/src/+/1412016 > > > > Bug: 914579, 929142 > > Change-Id: I443e41fee17f6f09ca5cf5c243dbf330bafef6f8 > > Reviewed-on: https://chromium-review.googlesource.com/c/1456871 > > Commit-Queue: oysteine <oysteine@chromium.org> > > Reviewed-by: ssid <ssid@chromium.org> > > Reviewed-by: Alexei Filippov <alph@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#629738} > > TBR=alph@chromium.org,oysteine@chromium.org,ssid@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 914579, 929142 > Change-Id: I9585a500916c0d90b16901572823a3c7c14bbbbb > Reviewed-on: https://chromium-review.googlesource.com/c/1477877 > Reviewed-by: oysteine <oysteine@chromium.org> > Reviewed-by: ssid <ssid@chromium.org> > Commit-Queue: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634229} TBR=alph@chromium.org,oysteine@chromium.org,ssid@chromium.org Change-Id: I87f62967a2a0006b3b2f7a8c91bd44a26306643d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 914579, 929142 Reviewed-on: https://chromium-review.googlesource.com/c/1483250Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#634677}
-
Daniel Bratell authored
In an effort to reduce or even ban symbol shadowing, this renames a variable to avoid such shadowing. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The exact error this avoids is: third_party/blink/renderer/core/svg/svg_svg_element.cc:456:28: error: declaration shadows a local variable [-Werror,-Wshadow] TransformationMatrix transform; ^ third_party/blink/renderer/core/svg/svg_svg_element.cc:449:19: note: previous declaration is here AffineTransform transform; ^ Bug: 923510 Change-Id: I99c001d0eb513d73bfc33d540601479a6fd7280d Reviewed-on: https://chromium-review.googlesource.com/c/1482975 Auto-Submit: Daniel Bratell <bratell@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#634676}
-
Devon O'Brien authored
The Symantec Log, Symantec 'Sirius' Log, and Symantec 'Vega' Log are being retired with an effective date of February 16, 2019 with a timestamp of 1550275200. Bug: 928879 Change-Id: I8f9a3da420acdda7739662481fe505bc7c46bf3e Reviewed-on: https://chromium-review.googlesource.com/c/1481606Reviewed-by:
Andrew Whalley <awhalley@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Andrew Whalley <awhalley@chromium.org> Cr-Commit-Position: refs/heads/master@{#634675}
-
Antonio Gomes authored
R=haraken@chromium.org CC=blink-reviews-onion-soup@chromium.org BUG=891908 Change-Id: I554a5c747731442113973674ebdf758e111c1f35 Reviewed-on: https://chromium-review.googlesource.com/c/1483170 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#634674}
-
Michael Lippautz authored
Otherwise, DataTransfer retains the last document that used a JS wrapper through Page->DragController->DragState->DataTransfer->... Bug: 928781,843903 Change-Id: I92219fb9a325a8a9d0ceb7050512b22f6942c85f Reviewed-on: https://chromium-review.googlesource.com/c/1479991Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#634673}
-
Christos Froussios authored
This reverts commit 4c800eb7. Reason for revert: Suspected of breaking PolicyPrefsTest.PolicyToPrefsMapping on browser_tests on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel First failure https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/20456 Original change's description: > Add DeviceWilcoDTCAllowed device policy > > Create new boolean policy to control wilco diagnostics and telemetry > controller if it is present on the device. > > BUG=b:123926018 > TEST=unit_tests > > Change-Id: I8161a36424310fbabfc580d3931121dc7a5c5492 > Reviewed-on: https://chromium-review.googlesource.com/c/1456075 > Commit-Queue: Polina Bondarenko <pbond@chromium.org> > Auto-Submit: Polina Bondarenko <pbond@chromium.org> > Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634641} TBR=bartfab@chromium.org,pbond@chromium.org Change-Id: Iff0d905d9c103369822a5c88f90f877e2d289f2e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:123926018 Reviewed-on: https://chromium-review.googlesource.com/c/1483021Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#634672}
-
Dave Tapuska authored
These shipped in M71. BUG=829937,383813 Change-Id: I7e221ad086b637f2031e7ad9a8092f4c38ce9a8a Reviewed-on: https://chromium-review.googlesource.com/c/1478487Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#634671}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ac7e7332..9eb6c534 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4d50befd9dd24c5817ec1c56f0602c1caf18c84c Reviewed-on: https://chromium-review.googlesource.com/c/1483151Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634670}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/65438812ba0d..8aa00f037148 git log 65438812ba0d..8aa00f037148 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 tzik@chromium.org Add missing absl/memory/memory.h to rtc_event_generic_ack_received.cc 2019-02-22 eladalon@webrtc.org Rename "OnReceivedFrame" to "OnAssembledFrame" 2019-02-22 sprang@webrtc.org Remove VideoSender and fold code into VideoStreamEncoder 2019-02-22 eladalon@webrtc.org Create LossNotificationController 2019-02-22 jonasolsson@webrtc.org Allow IceConnectionState to become failed without ever connecting. 2019-02-22 ssilkin@webrtc.org Lower SSIM thresholds. Created with: gclient setdep -r src/third_party/webrtc@8aa00f037148 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:752720,chromium:None,chromium:933786 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I044eb3aa0ebd117950114a7810d5c4d6d8cca835 Reviewed-on: https://chromium-review.googlesource.com/c/1482934Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fdd15284affe..c6461681d608 git log fdd15284affe..c6461681d608 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 reed@google.com add hinting to gm Created with: gclient setdep -r src/third_party/skia@c6461681d608 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I33655fec020758b5b91691f739baa72858e3eea8 Reviewed-on: https://chromium-review.googlesource.com/c/1482936Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6abcf043ece1..0d74d6a30bce Created with: gclient setdep -r src-internal@0d74d6a30bce The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8d1cfc81fafe621478d0c921ff636619b29f08df Reviewed-on: https://chromium-review.googlesource.com/c/1482931Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634667}
-
Pavol Marko authored
This reverts commit 2b682cae. Reason for revert: Re-enabling the test. According to https://crbug.com/933295, the root cause should be fixed. Original change's description: > Disable PolicyTest.ExtensionAllowedTypes on Linux > > The test is flaky on Linux and Windows. > linux-xenial-rel suffers the most. > > TBR=pastarmovj@chromium.org > > Bug: 934297 > Change-Id: I9fd2df0ed9a531bb81f9ba01627726443786e603 > Reviewed-on: https://chromium-review.googlesource.com/c/1480000 > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Commit-Queue: Christos Froussios <cfroussios@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634241} TBR=pastarmovj@chromium.org,cfroussios@chromium.org Change-Id: I094ad7fd410d80732bd037bda37164f4068b7891 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 934297 Reviewed-on: https://chromium-review.googlesource.com/c/1483017Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
-
Nicolas Ouellet-payeur authored
A string used in BrowserSwitcher was missing an example value for a placeholder. Bug: 934099 Change-Id: I92e000b6e74619108845421f47fe11b6b193d5e7 Reviewed-on: https://chromium-review.googlesource.com/c/1479845Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#634665}
-
Nico Weber authored
https://chromium.googlesource.com/external/github.com/google/cld_3.git/+log/484afe9ba743..c0e79be769c5 $ git log 484afe9ba..c0e79be76 --date=short --no-merges --format='%ad %ae %s' 2019-02-21 thakis Fix -Wextra-semi warnings. 2019-02-14 tikuta small fix for BUILD.gn 2018-12-22 wtambellini Add CMake script 2018-12-22 wtambellini Add CMake script Created with: roll-dep src/third_party/cld_3/src Bug: 926235,931596 Change-Id: I9afc9a4062e108af2707617445519abed20a695b Reviewed-on: https://chromium-review.googlesource.com/c/1482553Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#634664}
-
Elly Fong-Jones authored
The roll to gtm 51863009 fixed these. Bug: 386671 Change-Id: I868b7bb711dd3871af7b9d5f812dcf66c5db1439 Reviewed-on: https://chromium-review.googlesource.com/c/1482556 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Nico Weber authored
Bug: 934255 Change-Id: I62a14227132236c335c4e201f7f73b5e93af716d Reviewed-on: https://chromium-review.googlesource.com/c/1479834 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#634662}
-
Daniel Erat authored
Add owners for the wake-on-wifi-packet flag, which is aparently still being evaluated for supporting Android Doze in ARC. Bug: None Change-Id: I07ca507bd6045501d8dbb97abe52c8432d241648 Reviewed-on: https://chromium-review.googlesource.com/c/1482000 Auto-Submit: Dan Erat <derat@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#634661}
-
Daniel Bratell authored
PTRACE_GET_THREAD_AREA is not in ptrace.h in Ubuntu 16.04 when building for Linux without a sysroot so get it from somewhere else, in this case asm/ptrace-abi.h. Follow up to https://chromium-review.googlesource.com/c/1479092 Bug: 934238,933418 Change-Id: I3e1ace31a6f5a4ab65bbe712e1516d7b5fa009a5 Reviewed-on: https://chromium-review.googlesource.com/c/1481316Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#634660}
-
Daniel Bratell authored
In an effort to reduce or even ban variable shadowing, this renames a variable to avoid such shadowing. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The exact warnings this avoids are: third_party/blink/renderer/core/dom/element.cc:3940:35: error: declaration shadows a local variable [-Werror,-Wshadow] else if (const Attribute* attribute = ^ third_party/blink/renderer/core/dom/element.cc:3938:30: note: previous declaration is here if (const Attribute* attribute = attributes.Find(xml_names::kLangAttr)) ^ third_party/blink/renderer/core/dom/node.cc:2113:17: error: declaration shadows a local variable [-Werror,-Wshadow] const Node* node = chain[index - 1]; ^ third_party/blink/renderer/core/dom/node.cc:2107:15: note: previous declaration is here const Node* node = this; ^ third_party/blink/renderer/core/dom/range.cc:529:36: error: declaration shadows a type alias in namespace 'blink' [-Werror,-Wshadow] typedef HeapVector<Member<Node>> NodeVector; ^ third_party/blink/renderer/core/dom/container_node.h:84:7: note: previous declaration is here using NodeVector = HeapVector<Member<Node>, kInitialNodeVectorSize>; ^ third_party/blink/renderer/core/dom/range.cc:750:36: error: declaration shadows a type alias in namespace 'blink' [-Werror,-Wshadow] typedef HeapVector<Member<Node>> NodeVector; ^ third_party/blink/renderer/core/dom/container_node.h:84:7: note: previous declaration is here using NodeVector = HeapVector<Member<Node>, kInitialNodeVectorSize>; ^ Bug: 925310 Change-Id: I8bc037dd1cf54baf5f6fe1ed93b1ead391313e8a Reviewed-on: https://chromium-review.googlesource.com/c/1478876Reviewed-by: -
Daniel Bratell authored
This reverts commit 5760a6f2. Reason for revert: Clashed with some other change so all Android builders died with: [1078/8826] CXX obj/android_webview/common/aw_cookie_manager_wrapper.o FAILED: obj/android_webview/common/aw_cookie_manager_wrapper.o ../../android_webview/browser/net_network_service/aw_cookie_manager_wrapper.cc -o obj/android_webview/common/aw_cookie_manager_wrapper.o ../../android_webview/browser/net_network_service/aw_cookie_manager_wrapper.cc:40:43: error: reference to type 'const std::string' (aka 'const basic_string<char, char_traits<char>, allocator<char> >') could not bind to an lvalue of type 'bool' cookie_manager_->SetCanonicalCookie(cc, secure_source, modify_http_only, ^~~~~~~~~~~~~ gen/services/network/public/mojom/cookie_manager.mojom.h:179:82: note: passing argument to parameter 'source_scheme' here void SetCanonicalCookie(const net::CanonicalCookie& cookie, const std::string& source_scheme, bool modify_http_only, SetCanonicalCookieCallback callback) final; ^ 1 error generated. Original change's description: > Take scheme in CookieStore::SetCanonicalCookieAsync, not just whether it's secure. > > This permits to check it against list of cookieable schemes (fixing #850044), and is > a prerequisite for getting rid of SetCookieWithOptionsAsync in favor of everything > using SetCanonicalCookieAsync. > > Bug: 850044 > Change-Id: I890cf266767a124b116fc553932a74b5a97ed943 > Reviewed-on: https://chromium-review.googlesource.com/c/1450420 > Commit-Queue: Maks Orlovich <morlovich@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634646} TBR=jam@chromium.org,caseq@chromium.org,tsepez@chromium.org,eugenebut@chromium.org,pwnall@chromium.org,mkwst@chromium.org,morlovich@chromium.org Change-Id: I17b82ee596c4cdcebfc8774f06b7e155ead8c514 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 850044 Reviewed-on: https://chromium-review.googlesource.com/c/1482460Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#634658}
-
Raphael Kubo da Costa authored
https://chromium-review.googlesource.com/c/1460187 ("Fix gn build on 'Build From Tarball' bot") together with https://gn-review.googlesource.com/c/gn/+/4000 ("Pass -lpthread when linking instead of -pthread") have caused the GN bootstrap process to fail when --use-custom-libcxx is not used. The reason is that -nodefaultlibs (passed to the compiler when linking with --use-custom-libcxx) causes -pthread to be ignored. To work around that, that GN CL started passing -lpthread so that it was added back to the command-line. However, if we are _not_ using --use-custom-libcxx, the whole process fails because -lpthread is specified at the wrong position in the command-line and the symbols are not resolved correctly. In this CL, make the --use-custom-libcxx build explicitly pass -lpthread to the linker so that we can later go back to passing -pthread in the GN build, as the compiler then knows where to put the right flags in the command line. Bug: 934793 Change-Id: Id8bf242bf461fb5146e1ac28d187082c43fdafbb Reviewed-on: https://chromium-review.googlesource.com/c/1482959 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
-
Christos Froussios authored
The tests are flaky. TBR=khmel@chromium.org Bug: 934796 Change-Id: Ic526200eca2f906d4bbb035fa9d0fa1599b063af Reviewed-on: https://chromium-review.googlesource.com/c/1483016Reviewed-by:
-
Colin Blundell authored
None of these includes are needed (they can be forward declarations), and eliminating them prevents the includes from transitively leaking. TBR=droger@chromium.org Change-Id: Ibc7aa3358897fd243a43c7dc5cdf5fc5860504a1 Reviewed-on: https://chromium-review.googlesource.com/c/1482956 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#634655}
-
Christos Froussios authored
The test is flaky on Mac10.13 Tests (dbg) Bug: 934818 No-try: True No-presubmit: True Change-Id: I22fa3d42ac61f35fbd5f54831265895f297177f9 Reviewed-on: https://chromium-review.googlesource.com/c/1483053Reviewed-by:
-
Stephane Zermatten authored
This change updates the hardcoded error messages to match the latest mocks. Bug: 806868 Change-Id: I44eebf0c0ed988dca60f4537996667baf0443904 Reviewed-on: https://chromium-review.googlesource.com/c/1481413 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#634653}
-
Tom Anderson authored
https://chromium.googlesource.com/external/libaddressinput.git/+log/d7ed8e2f3f35..81e7ead903f5 $ git log d7ed8e2f3..81e7ead90 --date=short --no-merges --format='%ad %ae %s' 2019-02-14 thomasanderson Fix build with Windows/libc++ Created with: roll-dep src/third_party/libaddressinput/src BUG=801780 R=rouslan,mathp Change-Id: I64fbefb0173b7914e87e5c735b0bb0d50cc01a6e Reviewed-on: https://chromium-review.googlesource.com/c/1482001 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#634652}
-
Gyuyoung Kim authored
The OnionSoup effort has a goal of allocating all garbage-collectable Blink objects with Oilpan or PartitionAlloc. However, the some classes of //blink/renderer/core/xml and //blink/renderer/core/xmlhttprequest have not yet been allocated with them so far. So their uses of non-garbage-collected objects should be restricted to cases where the garbage collector can discover their references. The macros of Allocator will be useful for the non-garbage-collected objects to avoid unintended allocations. After some analyzes, it was concluded that for the case of XMLParserContent class, it makes sense to use USING_FAST_MALLOC because it has been used with scoped_refptr<> In DeferredEvent class case, it makes sense to use DISALLOW_NEW because it has been used by a member variable with a reference. Bug: 919389 Change-Id: I18da5a1078b91caec8ad69c338ef874c9395f7e5 Reviewed-on: https://chromium-review.googlesource.com/c/1482280Reviewed-by:
-
Gyuyoung Kim authored
The OnionSoup effort has a goal of allocating all garbage-collectable Blink objects with Oilpan or PartitionAlloc. However, the some classes of //blink/renderer/core/workers has not yet been allocated with them so far. So their uses of non-garbage-collected objects should be restricted to cases where the garbage collector can discover their references. The macros of Allocator will be useful for the non-garbage-collected objects to avoid unintended allocations. After some analyzes, it was concluded that for the case of InstalledScriptsManager, WorkerBackingThread, and WorkerSettings classes, they make sense to use USING_FAST_MALLOC because they have been used with smart pointers. Bug: 919389 Change-Id: I9d57544ae8a64ccf5c7a79fe9db95693902aefa8 Reviewed-on: https://chromium-review.googlesource.com/c/1482279Reviewed-by:
-
Alex Clarke authored
Some PostTask closures do exciting things on destruction like posting other tasks. Some of them call ThreadTaskRunnerHandle::Get and these where crashing because it had gone away. This patch fixes that. Bug: 933295 Change-Id: I7f48e2743dcebe38f9f6e9f08030d762760fc733 Reviewed-on: https://chromium-review.googlesource.com/c/1482954Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#634649}
-
Stephane Zermatten authored
With this change, with verbose level 3 enabled, we can see the rectangles that form the touchable element area, as defined by the script, if any. Bug: 806868 Change-Id: I2fb28988bb1a7db62d3fab907868d0d81df9be86 Reviewed-on: https://chromium-review.googlesource.com/c/1479961 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
-
Clemens Arbesser authored
The text was changed to match the description in the doc: https://docs.google.com/document/d/1rtaxREBeL9gp4vRcwGgoxkGlQ8ns08aZqBxRUNrTUqc/edit#bookmark=id.kzi3ubtldlm3. Also fixed an issue where a line break was inserted in between the 'learn more' link. Bug: 806868 Change-Id: I34f3bdda778b854da46751d80ddd9ee27df21717 Reviewed-on: https://chromium-review.googlesource.com/c/1480002Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#634647}
-
Maks Orlovich authored
This permits to check it against list of cookieable schemes (fixing #850044), and is a prerequisite for getting rid of SetCookieWithOptionsAsync in favor of everything using SetCanonicalCookieAsync. Bug: 850044 Change-Id: I890cf266767a124b116fc553932a74b5a97ed943 Reviewed-on: https://chromium-review.googlesource.com/c/1450420 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#634646}
-
Roman Sorokin authored
Bug: none Change-Id: I03bb3dbe57b254e35b8946bf42c78a613a59d661 Reviewed-on: https://chromium-review.googlesource.com/c/1482458 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#634645}
-
David Roger authored
InlineLoginHandlerImpl can only be used when force signin is enabled, or with the Google Credential Provider on windows. This CL removes support for other flows. Bug: 915678 Change-Id: I0ceff59eef46d8be957a5d55e597c3a1925ed92b Reviewed-on: https://chromium-review.googlesource.com/c/1466984 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#634644}
-
Hans Wennborg authored
Otherwise the 'size' command doesn't work unless there's a system xcode around, which there isn't on newer buildbots. Bug: 934698 Change-Id: I930ee63b695ab000efa301abc2c169111eb66da3 Reviewed-on: https://chromium-review.googlesource.com/c/1482950 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Konstantin Ganenko authored
Previously simple cache 2 stream's EOF signature was checked at end of the read, not when the entry was opened. R=morlovich@chromium.org Change-Id: Ic7672fbaa7bcec19337a9004da8c966b8a0029c7 Reviewed-on: https://chromium-review.googlesource.com/c/1477830Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Konstantin Ganenko <ganenkokb@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#634642}
-
