GitLab

Previously the name of the enum value was wrong. This CL fixes it:
EntryChangedKind.CREATE -> EntryChangedKind.CREATED.

BUG=364258
TEST=manually

Review URL: https://codereview.chromium.org/257803013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266562 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 945604a5.

BUG=351824
TBR=dbeam@chromium.org, rmsousa@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/257823005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266561 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of Move  service_discovery_client_impl.* into chrome/common. (https://codereview.chromium.org/250793011/)

Reason for revert:
Reland original patch. The revert didn't solve the sizes regression.

Original issue's description:
> Revert of Move  service_discovery_client_impl.* into chrome/common. (https://codereview.chromium.org/256923003/)
> 
> Reason for revert:
> [Sheriff] Speculating that this lead to a sizes regression:
> https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux-64&tests=sizes&rev=266525&checked=core
> 
> Will reland otherwise.
> 
> Original issue's description:
> > Move  service_discovery_client_impl.* into chrome/common.
> > It's need to be used by utility and browser processes.
> > 
> > BUG=349645
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266487
> 
> TBR=thestig@chromium.org,vitalybuka@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=349645
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266535

TBR=thestig@chromium.org,vitalybuka@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=349645

Review URL: https://codereview.chromium.org/252023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266560 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Store default search provider data in dictionary pref. (https://codereview.chromium.org/229763005/)

Reason for revert:
Speculative revert for introducing lots of leaks. See: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/2026

Original issue's description:
> Store default search provider data in dictionary pref, and add DefaultSearchManager class to handle the reading and writing of this pref (DefaultSearchManager will eventually all default search related concerns).
> 
> This pref will be used to persist data about user-selected 
> default search providers. In future CLs, support will be added for default search providers set by policy and sync.
> 
> 
> BUG=365762
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266479

BUG=365762
TBR=gab, erikwright, Peter Kasting, Cait Phillips
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/258933009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266559 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266558 0039d316-1c4b-4281-b951-d872f2087c98

Chromium base revision: 266531 / d751dd54
Old Skia revision: 14349
New Skia revision: 14390
Control CL: https://codereview.chromium.org/250923012

This CL was created by Skia's roll_deps.py script.

Bypassing commit queue trybots:
NOTRY=true

Review URL: https://codereview.chromium.org/251083006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266557 0039d316-1c4b-4281-b951-d872f2087c98

In https://codereview.chromium.org/254783004 the semantics of the scale
parameter for GesturePinchUpdate on Mac is being corrected to be a scale
factor (1.0 no zoom) instead of a weird magnification value (where 0 means
no zoom).  This is important because GesturePinchUpdate events are
coalesced together by multipling (not adding) their scale values.

This CL updates the browser zoom logic to compensate for this change in
scale values.

BUG=289887

Review URL: https://codereview.chromium.org/255843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266556 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266555 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff rossberg@chromium.org in case of problems.

TBR=rossberg@chromium.org

Review URL: https://codereview.chromium.org/258883004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266554 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366585

Review URL: https://codereview.chromium.org/254533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266553 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366597
R=nasko@chromium.org,jcivelli@chromium.org

Review URL: https://codereview.chromium.org/257463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266552 0039d316-1c4b-4281-b951-d872f2087c98

Note:
Currently FaviconTabHelper implements both FaviconClient and FaviconDriver.
A follow up CL will create a ContentFaviconDriver class that implements
FaviconDriver. FaviconTabHelper will then own an instance of the
ContentFaviconDriver, instead of inheriting from FaviconDriver.

BUG=362074

Review URL: https://codereview.chromium.org/255843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266551 0039d316-1c4b-4281-b951-d872f2087c98

This is a minor bugfix to https://codereview.chromium.org/229063003,
changing the comparison of USB VID to ignore the case.

BUG=288562, 347371

Review URL: https://codereview.chromium.org/255933006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266550 0039d316-1c4b-4281-b951-d872f2087c98

This is duplicated functionality now, as one can use DevTools touch emulation instead.

BUG=337142

Review URL: https://codereview.chromium.org/258503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266549 0039d316-1c4b-4281-b951-d872f2087c98

On some platfroms, mouse events come with a bad timestamp, which leads to
awkward time-dependent gestures. For example, fling animation may be almost
instant.
Using base::TimeTicks::Now() is good enough for emulation purposes, because
emulator spawns new events itself.

BUG=367156

Review URL: https://codereview.chromium.org/250923005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266548 0039d316-1c4b-4281-b951-d872f2087c98

In order to create a favicon component, we are removing dependencies on chrome/.

TBR=bsalomon1
BUG=359592
NOTRY=true

Review URL: https://codereview.chromium.org/246893004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266547 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127016
TEST=manual
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/250803005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266546 0039d316-1c4b-4281-b951-d872f2087c98

When we run out of stack space for example, we can't create an handle.

BUG=363417
R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/259993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266545 0039d316-1c4b-4281-b951-d872f2087c98

Chromium-side part of the following:
https://codereview.chromium.org/247263010/
https://codereview.chromium.org/256723002/

BUG=365252

Review URL: https://codereview.chromium.org/255813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266544 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266543 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=172711:172734&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/259993005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266542 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=run the test

Review URL: https://codereview.chromium.org/259823008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266541 0039d316-1c4b-4281-b951-d872f2087c98

Debug:

$ gn gen out/Debug_gn --args=is_debug=true
$ ninja -C out/Debug_gn translate_core_browser translate_core_common

Release:

$ gn gen out/Release_gn --args=is_debug=false
$ ninja -C out/Release_gn translate_core_browser translate_core_common

BUG=None
TEST=see above, it LINKS.
R=brettw@chromium.org
TBR=droger

Review URL: https://codereview.chromium.org/250373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266540 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/256593006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266539 0039d316-1c4b-4281-b951-d872f2087c98

If a buffer is missing duration and is being held back, then the cluster
parser now holds back all other tracks' buffers that have same or higher
(decode) timestamp. This keeps the timestamps emitted for a cluster
monotonically non-decreasing and in same order as parsed, even across
tracks within the cluster.

Adds a related new WebMClusterParserTest, updates related
ChunkDemuxerTests and removes an obsolete TODO now that bug 361786 is
fixed by r265340.

R=acolwell@chromium.org
BUG=363421
TEST=All media_unittests and MSE http layout tests pass locally on Linux

Review URL: https://codereview.chromium.org/239343007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266538 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367283

Review URL: https://codereview.chromium.org/258693010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266537 0039d316-1c4b-4281-b951-d872f2087c98

Adding the arm64 target to gyp_webview.

BUG=354405
NOTRY=true

Review URL: https://codereview.chromium.org/251813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266536 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Move  service_discovery_client_impl.* into chrome/common. (https://codereview.chromium.org/256923003/)

Reason for revert:
[Sheriff] Speculating that this lead to a sizes regression:
https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux-64&tests=sizes&rev=266525&checked=core

Will reland otherwise.

Original issue's description:
> Move  service_discovery_client_impl.* into chrome/common.
> It's need to be used by utility and browser processes.
> 
> BUG=349645
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266487

TBR=thestig@chromium.org,vitalybuka@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=349645

Review URL: https://codereview.chromium.org/250793011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266535 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Add nacl_loader_unittests to the chromium_builder_tests (https://codereview.chromium.org/260003005/)

Reason for revert:
Unconditionally adds a nacl dependency, breaks disable_nacl=1 builds

Original issue's description:
> Add nacl_loader_unittests to the chromium_builder_tests
> 
> TEST=ninja -C out/Release chromium_builder_tests
> BUG=364751
> R=hidehiko@chromium.org
> TBR=mseaborn@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266521

TBR=hidehiko@chromium.org,mseaborn@chromium.org,hamaji@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=364751

Review URL: https://codereview.chromium.org/256933004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266534 0039d316-1c4b-4281-b951-d872f2087c98

We'll have to figure out a way to maintain this file without blocking v8
rolls. While the gyp files in v8 don't change very often, they sometimes
do, and since the CQ checks the gn build, we have to find a way to
update gn in lock step

BUG=none
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/256793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266533 0039d316-1c4b-4281-b951-d872f2087c98

Gallery.app refers a few Files.app script files, so the CL also changes so that the files can be imported from the Gallery.app

BUG=358698
TEST=manually

Review URL: https://codereview.chromium.org/246543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266531 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367701
TBR=finnur@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/254983005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266530 0039d316-1c4b-4281-b951-d872f2087c98

The kGoogleServicesUsername pref indicates that Chrome is signed in with a
GAIA account. Since device-local accounts do not have GAIA credentials,
this pref should not be set for them.

BUG=327849
TEST=Extended browser tests

Review URL: https://codereview.chromium.org/251703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266529 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367190

Review URL: https://codereview.chromium.org/250803008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266528 0039d316-1c4b-4281-b951-d872f2087c98

Gin Java Bridge passes values between Java and JS using base::Value.
Since there are some kinds of data that can't be represented in JSON,
we use base::BinaryValue that holds GinJavaBridgeValue. And we don't
use base::BinaryValue for anything else (this is enforced by our
Strategy for V8ValueConverter).

BUG=355644
R=bulach@chromium.org, jochen@chromium.org

Review URL: https://codereview.chromium.org/252393004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266527 0039d316-1c4b-4281-b951-d872f2087c98

Verify how the existing implementation deals with Date, Function and RegExp
JS objects. This is to make sure that we configure V8ValueConverter appropriately
in the Gin-based implementation.

BUG=355644
R=benm@chromium.org

Review URL: https://codereview.chromium.org/251773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266526 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=347927

Review URL: https://codereview.chromium.org/254993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266525 0039d316-1c4b-4281-b951-d872f2087c98

CreateSnapshotFile and GetFileStreamReader used to sniff the content
of the files and returned error if it does not look like media data.
This CL adds a mode to disable the check, and use the disabled mode
in MTP mounting in Chrome OS file manager.

BUG=367004

Review URL: https://codereview.chromium.org/251723004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266524 0039d316-1c4b-4281-b951-d872f2087c98

Retry r266297 with static initializer fix.

This reverts commit 9ca50c9f.

BUG=351824
TBR=rmsousa@chromium.org

Review URL: https://codereview.chromium.org/259943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266523 0039d316-1c4b-4281-b951-d872f2087c98

It seems that the per-file /components/password_manager* section should match the content of /components/password_manager/OWNERS. The diff is exactly dubroy and vabr (present in the latter, missing in the former). This CL adds them to the former.

NOTRY=true

Review URL: https://codereview.chromium.org/251723005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266522 0039d316-1c4b-4281-b951-d872f2087c98