GitLab

Fixes a flaky issue introduced in the recent tabs submenu tests due to
inspecting possibly unset timestamp values. Also fixes a pre-existing issue
where sync ids for tabs were not being set, which the refactor brought
to light.

BUG=671902, 671902
TBR=msw

Review-Url: https://codereview.chromium.org/2562853002
Cr-Commit-Position: refs/heads/master@{#437604}

* up contrast to 4.5:1 for small text
* fix some aria roles
* update header colors (and make settings match while I'm at it)

R=calamity@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2555693006
Cr-Commit-Position: refs/heads/master@{#437603}

The net stack will not send HTTP requests to a specific set of
blacklisted ports, but the OS may assign one of	those ports to
the EmbeddedTestServer.  This was causing spurious net_unittests
failures on iOS when it happened.  This CL modifies the
EmbeddedTestServer to retry until it is assigned a
non-blacklisted port.

BUG=607630

Review-Url: https://codereview.chromium.org/2562893002
Cr-Commit-Position: refs/heads/master@{#437602}

building the URLRequestContext manually.

This change is entirely internal, so it does not yet actually take a config
object as an argument.

BUG=523858
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2502683003
Cr-Commit-Position: refs/heads/master@{#437601}

R=alph@chromium.org

Review-Url: https://codereview.chromium.org/2563763003 .
Cr-Commit-Position: refs/heads/master@{#437600}

Turns out, typ treats the absence of the unit tests as failure,
and we don't have any tests at the moment.

R=peria,bashi,haraken
BUG=672738

Review-Url: https://codereview.chromium.org/2557403003
Cr-Commit-Position: refs/heads/master@{#437599}

We would like to ensure following execution order when calling PresentationRequest.start():

1. resolve start() promise
2. fire PresentationRequest onconnectionavailable event
3. fire PresentationConnection onconnect event

To fire event after resolving promise, we need to dispatch events asynchronously

BUG=669213

Review-Url: https://codereview.chromium.org/2547143002
Cr-Commit-Position: refs/heads/master@{#437598}

BUG=621903
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2563443005
Cr-Commit-Position: refs/heads/master@{#437597}

The AutocompleteTextFieldEditor draws a background, apparently even when
you call setDrawsBackground:NO (at least during editing). Because of the
1pt spacing set by UX between the security decoration border and the
start of omnibox text, this background started drawing into the
decoration's hover rect. On the right edge it drew into the edge of the
focus ring.

This cl	prevents the AutocompleteTetFieldEditor	from drawing a
background, relying instead on the background drawn by the textfield's
cell. It also changes decorations to be drawn after the cell's interior,
to prevent the background overlap when not editing.

R=avi@chromium.org
BUG=669870,672518

Review-Url: https://codereview.chromium.org/2562863002
Cr-Commit-Position: refs/heads/master@{#437596}

BUG=672392
TEST=trybots pass

Review-Url: https://codereview.chromium.org/2558083005
Cr-Commit-Position: refs/heads/master@{#437595}

This is follow-up for CL[0] that moved passing of WebRTC rendering frames
off of main thread. That CL caused a regression in test[1] where the number
of unique frames encoded is less, suggesting that we are dropping frames.
Traces showed that compositor thread may be blocked by long texture upload
calls and frames get accumulated in the meantime. We might be dropping
frames due to the limit of having only 3 frames in flight.

This CL addresses this issue by moving these calls to IO thread directly.
In order to do it:
- FrameDeliverer classes in MediaStreamVideoRendererSink and WebMediaPlayerMS
are moved to IO thread.
- WebMediaPlayerMSCompositor::EnqueueFrame gets called on IO thread.
- Since WebMediaPlayerMSCompositor operates on three threads, I made it a ref
counted object. This way, we do not need to create multiple WeakPtr factories
or synchronize/block destruction on multiple threads.

[0] https://codereview.chromium.org/2472273002/
[1] crbug.com/667262

BUG=667262,652923
TEST=Tested running JS alert() in console during an AppRTC loopback.

Review-Url: https://codereview.chromium.org/2529263004
Cr-Commit-Position: refs/heads/master@{#437594}

Java tests that involve building dex files can reach the dex
method limit when their dependencies pull at lot of content.
This CL enables multidexing for a few targets that fail
building when we stop pre-proguarding the play services library

BUG=668211

Review-Url: https://codereview.chromium.org/2563663002
Cr-Commit-Position: refs/heads/master@{#437593}

https://skia.googlesource.com/skia.git/+log/4993b95f532f..291c62a0ff2c

$ git log 4993b95f5..291c62a0f --date=short --no-merges --format='%ad %ae %s'
2016-12-09 halcanary clean up old Makefiles
2016-12-09 jcgregorio docs: Use the new floating ment on skpaint.md
2016-12-09 halcanary SkImageEncoder::* going away
2016-12-08 fmalita [SVGDom] Clipped clipPath support
2016-12-09 mtklein update Win/Android toolchain setup after rolling GN
2016-12-09 djsollen Don't compile the Skia tools for PDK builds.
2016-12-09 halcanary Commit Queue: Add NoGPU build bot.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=herb@google.com

Review-Url: https://codereview.chromium.org/2554423006
Cr-Commit-Position: refs/heads/master@{#437592}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ce8eb03c..e050386b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2564093002
Cr-Commit-Position: refs/heads/master@{#437591}

BUG=647305

Review-Url: https://codereview.chromium.org/2563743002
Cr-Commit-Position: refs/heads/master@{#437590}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/e9afa18..a67124d

BUG=672719
TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2565543004
Cr-Commit-Position: refs/heads/master@{#437589}

This removes 20 files from //net compilation.

BUG=672672

Review-Url: https://codereview.chromium.org/2561293002
Cr-Commit-Position: refs/heads/master@{#437588}

This property is unused and unnecessary.

BUG=648498
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2555373006
Cr-Commit-Position: refs/heads/master@{#437587}

In particular, check the cases of async URLRequest::Read successes.

Also add ResourceHandler re-entrancy checks to TestResourceHandler,
which the current API is designed to avoid.

Review-Url: https://codereview.chromium.org/2552463002
Cr-Commit-Position: refs/heads/master@{#437586}

BUG=669668
TEST=ScrollbarAnimationControllerThinningTest.DontFadeAfterReleasedNear,
ScrollbarAnimationControllerThinningTest.FadeAfterReleasedFar,
ScrollbarAnimationControllerThinningTest.MoveNearAndDontFadeOut,
ScrollbarAnimationControllerThinningTest.MoveOverAndDontFadeOut
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2552813002
Cr-Commit-Position: refs/heads/master@{#437585}

This change has the browser controls depend on the window viewport
rather than the visible viewport when drawing. This allows for the
math to be consistent across layouts that use the controls and
fixes the toolbar swipe layout.

To facilitate this, the SceneOverlay interface was updated to
include the window and visible viewports when updating their
respective SceneLayers.

BUG=652892

Review-Url: https://codereview.chromium.org/2542883004
Cr-Commit-Position: refs/heads/master@{#437584}

BUG=none
TBR=ben@ for content/renderer

Review-Url: https://codereview.chromium.org/2559343003
Cr-Commit-Position: refs/heads/master@{#437583}

BUG=672602

Review-Url: https://codereview.chromium.org/2567473003
Cr-Commit-Position: refs/heads/master@{#437582}

The workaround in that class to watch DidStartNavigationToPendingEntry is only for the non-PlzNavigate case, since with PlzNavigate all navigations happen in the browser.

This fixes
PredictorBrowserTest.RendererInitiatedNavigationPreconnect
with PlzNavigate.

BUG=504347

Review-Url: https://codereview.chromium.org/2559203003
Cr-Commit-Position: refs/heads/master@{#437581}

Revert of Cleanup sign checking in safe math code (patchset #1 id:1 of https://codereview.chromium.org/2564493003/ )

Reason for revert:
This change was not a performance improvement.

Original issue's description:
> Cleanup sign checking in safe math code
>
> Signed comparison is less code and matches the optimal compiler
> heuristics better than masking.
>
> TBR=scottmg
> NOTRY=true
>
> Committed: https://crrev.com/99bfa52d9dea53984ae4da5ee44eff0002928453
> Cr-Commit-Position: refs/heads/master@{#437342}

TBR=scottmg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2563003003
Cr-Commit-Position: refs/heads/master@{#437580}

Revert of Remove bad comment in HasSignBit (patchset #1 id:1 of https://codereview.chromium.org/2562643005/ )

Reason for revert:
The original change was not actually a performance improvement.

Original issue's description:
> Remove bad comment in HasSignBit
>
> Remove a bad comment left behind from crrev.com/437342
> TBR=scottmg
> R=scottmg
> NOTRY=true
>
> Committed: https://crrev.com/6b15c686879f6747935a517f74f579f7ae46d797
> Cr-Commit-Position: refs/heads/master@{#437416}

TBR=scottmg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2559183004
Cr-Commit-Position: refs/heads/master@{#437579}

The fullscreen manager can be null in cases where a different
activity is showing. This CL adds a check to make sure it is there
before using it.

BUG=672730, 670459

Review-Url: https://codereview.chromium.org/2557403004
Cr-Commit-Position: refs/heads/master@{#437578}

This was causing different versions of Java JVM other than user's
default.

BUG=669999

Review-Url: https://codereview.chromium.org/2558183002
Cr-Commit-Position: refs/heads/master@{#437577}

This will allow us to get server-side suggestions on the local NTP.

BUG=514752
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2532103002
Cr-Commit-Position: refs/heads/master@{#437576}

Moves include of ojbc_property_releaser to the implementation file to
allow this to be included from ARC code.
Also moves ivars to the implementation file, per style guide.

BUG=672510
TEST=None

Review-Url: https://codereview.chromium.org/2561133002
Cr-Commit-Position: refs/heads/master@{#437575}

BUG=613123

Review-Url: https://codereview.chromium.org/2554403004
Cr-Commit-Position: refs/heads/master@{#437574}

After this CL Physical Web suggestions on the NTP can be dismissed.
The list is stored in prefs. It is pruned on fetches and when URL is
lost.

BUG=667766

Review-Url: https://codereview.chromium.org/2560783002
Cr-Commit-Position: refs/heads/master@{#437573}

Revert of Change ExecLinkWrapper to not buffer all tool output (patchset #2 id:20001 of https://codereview.chromium.org/2558153002/ )

Reason for revert:
Reverting under suspicion for crbug.com/672841.

Original issue's description:
> Change ExecLinkWrapper to not buffer all tool output
>
> /verbose linking of chrome.dll creates over one GB of output. This
> causes ExecLinkWrapper to consume over two GB of memory which leads to
> an OOM failure in the 32-bit depot_tools python, and the loss of all
> of the valuable output. This change modifies ExecLinkWrapper to
> process the output one line at a time, thus avoiding the OOM.
>
> I've tested that this handles the 1.1 GB of output which the previous
> version of this function failed on and I've visually confirmed that the
> output looks the same - no extraneous blank lines, for instance, when
> displaying warnings, errors, or 1.9 million lines of verbose output.
>
> I also verified that the script stays idle when waiting for output -
> blocking on .readline().
>
> BUG=672182
>
> Committed: https://crrev.com/5d0d1b0bf01acb3ebe3a5ef27ebf2f3180ab1d1d
> Cr-Commit-Position: refs/heads/master@{#437126}

TBR=brucedawson@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=672182

Review-Url: https://codereview.chromium.org/2564893002
Cr-Commit-Position: refs/heads/master@{#437572}

Moves the focus to the expiration year field when the expiration month
field gets filled with a second character and move the focus to the
cvc input field when the expiration year field gets filled with a
second character.

Also adds more detailed error messages for invalid expiration month and
year.

BUG=671762

Review-Url: https://codereview.chromium.org/2557873002
Cr-Commit-Position: refs/heads/master@{#437571}

Revert of Mark virtual/android/media/mediadocument/media-document-with-download-button.html as flaky (patchset #1 id:1 of https://codereview.chromium.org/2560033003/ )

Reason for revert:
The issue had just been fixed by https://codereview.chromium.org/2555373005 before this marking.

Original issue's description:
> Mark virtual/android/media/mediadocument/media-document-with-download-button.html as flaky
>
> BUG=672696, 672371
> NOTRY=true
> TBR=asargent@chromium.org, grt@chromium.org, vasilii@chromium.org
>
> Committed: https://crrev.com/f26da5af712a45c4ee62d79e6da2530a591ce987
> Cr-Commit-Position: refs/heads/master@{#437466}

TBR=asargent@chromium.org,grt@chromium.org,vasilii@chromium.org,yhirano@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672696, 672371

Review-Url: https://codereview.chromium.org/2564623005
Cr-Commit-Position: refs/heads/master@{#437570}

- Follow up to http://crrev.com/2549443003
- Move RequestAnimationFrameCallback and AnimationComplete class
  definitions to .cpp file
- Prefix enums with k
- Change direction() and behavior() to getDirection() and getBehavior()
  respectively
- Use case insensitive match for direction and behavior
- Remove trueSpeed()
- Use String::numberToStringECMAScript to convert double to String instead of using String::format which is locale sensitive

BUG=669656

Review-Url: https://codereview.chromium.org/2554403002
Cr-Commit-Position: refs/heads/master@{#437569}

For example if we have "http://example.com/" and "http://example.com",
then their paths should match.

BUG=647588

Review-Url: https://codereview.chromium.org/2550093005
Cr-Commit-Position: refs/heads/master@{#437568}

BUG=672676

Review-Url: https://codereview.chromium.org/2557743008
Cr-Commit-Position: refs/heads/master@{#437567}

https://skia.googlesource.com/skia.git/+log/a129dfef2aaa..4993b95f532f

$ git log a129dfef2..4993b95f5 --date=short --no-merges --format='%ad %ae %s'
2016-12-08 scroggo Do not create SkGifCodec if true size is not known
2016-12-09 robertphillips Revert "Revert "Add antialiasing to SkDropShadowImageFilter's shadow draw""
2016-12-09 reed Revert[2] "remove SK_SUPPORT_LEGACY_CLIP_REGIONOPS"
2016-12-09 mtklein Roll GN

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=herb@google.com

Review-Url: https://codereview.chromium.org/2555103008
Cr-Commit-Position: refs/heads/master@{#437566}

Review-Url: https://codereview.chromium.org/2562883002
Cr-Commit-Position: refs/heads/master@{#437565}