GitLab

This method is unused in Chromium and downstream, so remove it.

BUG=149477


Review URL: https://chromiumcodereview.appspot.com/11412274

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170578 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163690

TBR=bartfab@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/11348327

TBR=isherman@chromium.org
Review URL: https://codereview.chromium.org/11421186

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170577 0039d316-1c4b-4281-b951-d872f2087c98

Also addresses an issue on Chrome OS where we'd unnecessarily spin up
the DataTypeManager if the user cancelled out of a sync setup (after a
dashboard clear), and adds some comments.

Lastly some tests were firing TOKEN_LOADING_FINISHED on a fake / mock
TokenService, but calling TokensLoadedFromDB was still returning
false -- fixed that (needed for this patch).

BUG=80194, 128692


Review URL: https://chromiumcodereview.appspot.com/11348220

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170576 0039d316-1c4b-4281-b951-d872f2087c98

Browser needs to communicate with the embedder when 
the guest renderer swaps hardware buffers.
Embedder needs to provide textures for the guest to render into.

BUG=143429


Review URL: https://chromiumcodereview.appspot.com/11364133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170575 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163607

Review URL: https://codereview.chromium.org/11415238

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170574 0039d316-1c4b-4281-b951-d872f2087c98

BUG=153777


Review URL: https://chromiumcodereview.appspot.com/11414204

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170572 0039d316-1c4b-4281-b951-d872f2087c98

Revert 170550 - Revert 170477 - Removes the |event| parameter from ActivationDelegate::ShouldActivate and makes the method const.

It is mostly unused, except for one place in RenderWidgetHostViewAura, where depending on the event type etc it will have a consequence. I think it's bad for a method with a const-sounding name like "ShouldActivate" to have side-effects.

Instead, I made the RWHVA store the data that would indicate a pointer activate and check that state during OnActivated(). It'd be a little cleaner if OnActivated had some way of knowing what the currently processed input event was, hence the TODO.

http://crbug.com/162100
R=sadrul@chromium.org
Review URL: https://codereview.chromium.org/11419251

TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/11416292

TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/11434062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170571 0039d316-1c4b-4281-b951-d872f2087c98

This improves startup time by about 20ms.

BUG=163215

Review URL: https://chromiumcodereview.appspot.com/11411249

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170568 0039d316-1c4b-4281-b951-d872f2087c98

This intro has a very brief description of the API usage and a link to any related docs,
if available.

At the moment, the related docs are in the heading 4.
In a separate cl, I will add 'Availabile in' information, and may use a table format for both related doc and available in.

This cl also includes broken link fixes to app_hardware.html.

Note: this does not include experimental APIs or APIs with existing intros.
Additional improvements to be made in separate cls.

Review URL: https://codereview.chromium.org/11412117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170567 0039d316-1c4b-4281-b951-d872f2087c98

BUG=6295515


Review URL: https://chromiumcodereview.appspot.com/11412076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170565 0039d316-1c4b-4281-b951-d872f2087c98

The mac buildbots use an older version of python 2.6 that doesn't support
adding directories to zipfiles. Work around it by adding an empty file with the
same zip path (which is basically what later versions do anyway).

BUG=none
R=sbc@chromium.org
TBR=noelallen@chromium.org
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11428111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170564 0039d316-1c4b-4281-b951-d872f2087c98

BUG=153137
TEST=Add a ?id=<extension_id> to the chrome://extensions page url and that extension should become highlighted.
Review URL: https://codereview.chromium.org/11434024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170561 0039d316-1c4b-4281-b951-d872f2087c98

BUG=157800

Review URL: https://codereview.chromium.org/11280258

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170560 0039d316-1c4b-4281-b951-d872f2087c98

This gives a 5% increase in cc_perftests.

Before:
*RESULT SevenTabSwitcher: frames= 1519.00 runs/s
*RESULT 10_10_layer_tree: frames= 541.09 runs/s

After:
*RESULT SevenTabSwitcher: frames= 1594.62 runs/s
*RESULT 10_10_layer_tree: frames= 569.31 runs/s

BUG=163035
R=jamesr,sky


Review URL: https://chromiumcodereview.appspot.com/11414265

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170559 0039d316-1c4b-4281-b951-d872f2087c98

For the given repro case, textInputType seems to get stuck in the
previous input type whereas textInputInfo is checking whether
an editor exists for the focused frame and exiting early with
with TextInputType set to None. Switching to using textInputInfo
in getTextInputType, as the comments in the header suggests the use of
textInputType by itself as an API should be deprecated anyway.

BUG=162831


Review URL: https://chromiumcodereview.appspot.com/11419218

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170558 0039d316-1c4b-4281-b951-d872f2087c98

BUG=158379


Review URL: https://chromiumcodereview.appspot.com/11348311

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170557 0039d316-1c4b-4281-b951-d872f2087c98

The breakpad export has been unused for the last five months, so I suppose it's safe to remove it entirely.

BUG=162405
TEST=Chromium Win (aura) bot should be able to compile metro_driver.dll.

Review URL: https://chromiumcodereview.appspot.com/11412265

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170555 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163548
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/11416279

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170554 0039d316-1c4b-4281-b951-d872f2087c98

BUG=158308
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/11428105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170553 0039d316-1c4b-4281-b951-d872f2087c98

Adds ShellPanelAsh and window_type=panel support to ShellWindow

BUG=161102


Review URL: https://chromiumcodereview.appspot.com/11363250

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170552 0039d316-1c4b-4281-b951-d872f2087c98

Revert 170477 - Removes the |event| parameter from ActivationDelegate::ShouldActivate and makes the method const.

It is mostly unused, except for one place in RenderWidgetHostViewAura, where depending on the event type etc it will have a consequence. I think it's bad for a method with a const-sounding name like "ShouldActivate" to have side-effects.

Instead, I made the RWHVA store the data that would indicate a pointer activate and check that state during OnActivated(). It'd be a little cleaner if OnActivated had some way of knowing what the currently processed input event was, hence the TODO.

http://crbug.com/162100
R=sadrul@chromium.org
Review URL: https://codereview.chromium.org/11419251

TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/11416292

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170550 0039d316-1c4b-4281-b951-d872f2087c98

There's a lot of valuable information in coalesced nudges.  Currently, one
nudge source can overwrite another, which leaves us in the dark as to why the
client behaved a certain way.  In fact, today we can't even determine whether
or not any coalescing was done.  

By logging all the coalesced sources and their payloads, we can learn a lot
more about client behaviour.  I'm hoping to use this to improve our
notification effectiveness metrics.

BUG=138613

Review URL: https://chromiumcodereview.appspot.com/11416126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170549 0039d316-1c4b-4281-b951-d872f2087c98

large data sets.

Also, go back to a limit of 200k entries, to monitor things, and increase the
version number to have clean stats after this change.

BUG=147383
TEST=none
Review URL: https://codereview.chromium.org/11415222

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170548 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163111
TBR=nona@chromium.org,satorux@chromium.org

Review URL: https://codereview.chromium.org/11428120

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170547 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170546 0039d316-1c4b-4281-b951-d872f2087c98

TBR=danno@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11412270

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170545 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162733
TEST=Test proxy settings on a system with GNOME3.

Review URL: https://codereview.chromium.org/11348279

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170544 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=jam@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11414240

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170543 0039d316-1c4b-4281-b951-d872f2087c98

Webkit bug: https://bugs.webkit.org/show_bug.cgi?id=103701


Review URL: https://chromiumcodereview.appspot.com/11299277

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170542 0039d316-1c4b-4281-b951-d872f2087c98

BUG=51636


Review URL: https://chromiumcodereview.appspot.com/11434043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170540 0039d316-1c4b-4281-b951-d872f2087c98

BUG=158821

Review URL: https://codereview.chromium.org/11418265

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170539 0039d316-1c4b-4281-b951-d872f2087c98

R=asanka@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11412202

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170533 0039d316-1c4b-4281-b951-d872f2087c98

Fix the following chromium-style warning:
../../chrome/browser/ui/views/frame/desktop_browser_frame_aura.h:43:3: error: [chromium-style] Overriding method must have "virtual" keyword.

By adding the missing 'virtual' keyword.

TEST=build/gyp_chromium -Duse_aura=1, ninja -C out/Debug chrome should link.
TBR=sky@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11316277

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170531 0039d316-1c4b-4281-b951-d872f2087c98

`chrome --app-id=x --incognito` currently launches an app in incognito mode, which is not allowed. After this patch it will simply ignore the --app-id flag.


BUG=155130


Review URL: https://chromiumcodereview.appspot.com/11348315

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170529 0039d316-1c4b-4281-b951-d872f2087c98

A BrowserPluginPropertyBinding is bound to a particular property name, so there
is no point to passing in the property name on GetProperty and SetProperty.

BUG=None


Review URL: https://chromiumcodereview.appspot.com/11299279

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170528 0039d316-1c4b-4281-b951-d872f2087c98

BUG=158821

Review URL: https://codereview.chromium.org/11416289

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170527 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170526 0039d316-1c4b-4281-b951-d872f2087c98

This is needed before we can land:

https://codereview.chromium.org/11412233/

BUG=

Review URL: https://chromiumcodereview.appspot.com/11316232

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170525 0039d316-1c4b-4281-b951-d872f2087c98

Before focusing did not work, which was especially noticeable for users using ChromeVox or those using keyboard only. This patch resolves following issues:
* Automatically focus the default button (depending on the screen).
* Focus the cancel button by default in the reset screen.
Besides, now it is possible to focus any control by default, not only buttons.

TEST=Turn on ChromeVox and navigate through the oobe screens.
BUG=161896


Review URL: https://chromiumcodereview.appspot.com/11421111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170524 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170523 0039d316-1c4b-4281-b951-d872f2087c98