- 22 Jan, 2020 40 commits
-
-
Daniel Hosseinian authored
Epson printers use the "Ink" attribute instead of other commonly used attributes like "ColorModel". Remove unnecessary scoping in some unit tests. Bug: 1043255 Change-Id: I3a71c0354de266cf41b99d06372e883e8b200eb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014101Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#734136}
-
Sebastien Lalancette authored
This reverts commit dbfd6f35. Reason for revert: CrSettingsSiteSettingsPageTest.UMALoggingTestsPart2 is failing flakily. Bug: 1044708 Original change's description: > Revert "[Sheriff]: Revert "More Settings Page Interaction UMA"" > > This reverts commit 0bfc424a. > > Reason for revert: Found cause of revert and fixed > > Original change's description: > > [Sheriff]: Revert "More Settings Page Interaction UMA" > > > > This reverts commit 561bf1af. > > > > Reason for revert: > > Strongly suspect this is causing failures on the debug builders: > > [29058:775:0117/070736.663833:ERROR:CONSOLE(49)] "Mocha test failed: PersonalizationOptionsTests_AllBuilds signinAllowedToggle > > Error: Uncaught TypeError: Cannot read property 'PRIVACY_CHROME_SIGN_IN' of undefined (chrome://settings/privacy_page/personalization_options.js:102) > > > > r732804 was reverted earlier for the same reasons, but there are still failures coming from the settings code, albeit less > > > > Original change's description: > > > More Settings Page Interaction UMA > > > > > > Move the settings enum and the call to uma to a separate browser proxy. > > > > > > Add UMA to all site settings subpage interactions and new toggles moved to the main settings card > > > > > > Bug: 1032584 > > > Change-Id: Icadd71d4511fa1f604f2d3acbda92c0e84700173 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967651 > > > Commit-Queue: Sean Harrison <harrisonsean@chromium.org> > > > Reviewed-by: Dan Beam <dbeam@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#732785} > > > > TBR=dbeam@chromium.org,harrisonsean@chromium.org > > > > Change-Id: Id4ee78d89487ecf7e6d1935088d02b29de89c7c8 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1032584 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007829 > > Reviewed-by: Leonard Grey <lgrey@chromium.org> > > Commit-Queue: Leonard Grey <lgrey@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#732870} > > Change-Id: Id60aa270741ac9305effac5a13587eb1a1d89102 > Bug: 1032584 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007716 > Reviewed-by: Dan Beam <dbeam@chromium.org> > Commit-Queue: Sean Harrison <harrisonsean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733913} TBR=dbeam@chromium.org,lgrey@chromium.org,harrisonsean@chromium.org Change-Id: I9491e91268ed0ef59837a49161d79692e9c44ceb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1032584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015562Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#734135}
-
Mustafa Emre Acer authored
This binary is used for debugging, so there's no direct impact to Chrome. Change-Id: Ib6a7120de8e28f135d83e816974e9ccaa3dd077a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913048 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#734134}
-
Saman Sami authored
Add trace events to all non-trivial methods of DrmThread and all methods in DrmThreadProxy that block. Bug: 1034559 Change-Id: I4f77dc84f0e35f2f405d2a9f4658c865800cf44e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013812Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#734133}
-
sandromaggi authored
Adding completeness check on address in UI. Bug: b/147718960 Change-Id: I6307c420867cc9c2616b96432baaea7884e71773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012381Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#734132}
-
rbpotter authored
Autogenerate Polymer 3 versions of CrFingerprintProgressArc and its tests. This will be used by chrome://settings in future. Bug: 1042558 Change-Id: I5a628f2e2dd96bc91b607a453b862022555a04c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013630Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#734131}
-
Allen Bauer authored
Bug: 648382 Change-Id: I1342c7735c5a78dbddd482de7f7a6c2ceb9b9e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014126 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#734130}
-
John Lee authored
Bug: 1032778 Change-Id: I7701cdfe36f29110d1da957d87605ddbbc8b9179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013912Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#734129}
-
Vladislav Kuzkokov authored
This situation may come up if policy was changed after printer was selected. We reject printing job since silently omitting username and filename could be confusing. Bug: 1042798 Change-Id: Iba385503d8f7e960291728d6515ca7c236220847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004992Reviewed-by:
-
Mason Freed authored
Cleanup. This feature has been enabled by default since M76. Change-Id: I3f1009f6a749b214dec3bb72c7730e35d91f928f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008428 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#734127}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=kolos@chromium.org Bug: 1041419 Change-Id: I9f15c46d6dd88dfb97ed26c5cfe233881d2c8643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997769 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#734126}
-
Owen Min authored
WallClockTimer is able to run the task with wall clock delay which is not paused when the computer is sleep. WallClockTimer is currently in relaunch_notification component. enterprise reporting will temporarily depends on it. WallClockTimer will be moved into base later. Also, removing the RequestTimer and let ReportScheduler use WallClockTimer directly. Bug: 1039673 Change-Id: Ic3a2c695717c9fee6af5172d7a12e2afb2ed561b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005648 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#734125}
-
Stephen Chenney authored
The new Style and Layout metrics correlate as expected with the old combined metric, so it is safe to remove it. Bug: 1044355 Change-Id: I6fb51394195d9e48c40801e946934f8a6775ed61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013496Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#734124}
-
Aga Wronska authored
Parse PerAppTimeLimits policy received from the server and store app limits data in AppActivityRegistry. This will be followed up by processing app limits. Bug: 1015654 Test: AppTimeTest Change-Id: I29691e0c801762a73f01cce217826423359957eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001411Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#734123}
-
Allen Bauer authored
Bug: 648382 Change-Id: I89d44f2b4ed34827d0451db4cbfa801a6c6cf3fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013512Reviewed-by:
-
Hans Wennborg authored
This reverts commit 71932bd3. Reason for revert: This broke the stack_allocated.cpp test, see https://ci.chromium.org/p/chromium/builders/ci/ToTLinux/9408 Original change's description: > blink_gc_plugin: Disallow Members for stack-allocated types > > Members in stack allocated types issue redundant write-barriers. This CL > provides an option --no-members-in-gc-allocated, which prohibits use of > them. > > Bug: 1044611 > Change-Id: Icc83756d9a1d6e414a09b705c0f008f9e79c4ae9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010986 > Commit-Queue: Anton Bikineev <bikineev@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734022} TBR=haraken@chromium.org,mlippautz@chromium.org,bikineev@chromium.org Change-Id: I3ae05fc50c49a3d668a3cb4d49c0fb010225861f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1044611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015342Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#734121}
-
Jonathan Freed authored
Bug: 1037085 Change-Id: Id384314ee43361434c9beade56fef7d101fb6189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983626Reviewed-by:
-
jonross authored
We removed --fuzzy-diff from the default Linux configuration in: https://chromium-review.googlesource.com/c/chromium/src/+/1989866 As a part of this we needed to disable SkiaRenderer, as this feature had been developed with -fuzzy-diff on and we were not certain the impact. We have since tested re-adding it, and it appears that some rebaselines are needed. This requires 130 baseline changes in the main tests, along with similar rebaselines for these tests which have been duplicated in various VirtualTests. The vast majority of the differences are small color variations in anti-aliasing, and some gradient representations. Some ref_tests cannot be rebaselined, issue 1043675 was filed to track those affected by SkiaRenderer so that we can triage them accordingly. TEST=blink_web_tests Bug: 1039401, 1043675, 1044032 Change-Id: Idfcbdac1416067d6922b20a6cadc9180ecce82fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994088Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#734119}
-
Bo Liu authored
This became flaky after https://chromium-review.googlesource.com/c/chromium/src/+/1986934 Using frame number to track the draw progress in a test is no longer valid since it is possible to two commits and activations to happen without a invalidate/draw. Use a separate count to keep track of no-damage invalidates. Bug: 1025695 Change-Id: I511a5af56373c417ee25ccd3bdf3eca67dc92f15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014981Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734118}
-
Shahbaz Youssefi authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/af64a9e826bf..dc77030acc9c The spirv-tools autoroller didn't roll this repo. Bug: 1044061 Change-Id: I80878e58d3655f3ed42eb28664d05e101d2a9f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014982 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#734117}
-
Ben Pastene authored
Reduces some copy-pasted code. Bug: 937821 Change-Id: Ic306e0235de76b43145a58214a95f497e5b2330c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013906Reviewed-by:
George Burgess <gbiv@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#734116}
-
Andrey Kosyakov authored
We used to omit pseudoId from nodes that carry ids other than those exposed in the protocol. This does not really make sense, as in case of DOMSnapshot domain those nodes would be misrepresented as regular nodes, and in case of DOM agent, this would lead to inconsistency where a node within pseudoNodes array of its parent wouldn't have the pseudoId attribute. With this CL, we always set pseudoId on all pseudo nodes and move filtering to higher level when populating the array of pseudoNodes. As a drive-by, this also adds dom-snapshot tests to the set of tests that run with experimental features disabled. BUG: 1043394 Change-Id: I58fc5a15e28b30118bffea5cbb2e9620c08f0084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007944 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#734115}
-
Ahmed Fakhry authored
The AutoNightLight feature is enabled only on kohaku via the chromeos session manager [1]. However, the session manager does not start the guest session, and therefore, does not setup its command-line flags. This CL adds the ability to copy a list of whitelisted features to the guest session command-line if they are enabled in the current session (the sign-in screen). [1]: https://cs.corp.google.com/chromeos_public/src/platform2/login_manager/chrome_setup.cc?q=p:chromeos_+AutoNightLight&g=0&l=105 BUG=1044344 TEST=Make sure AutoNightLight is enabled on kohaku in guest sessions. Change-Id: Ie18e9a0e98d4b54bcd753d3bdbb8ecd422fa16e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013739 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#734114}
-
Sebastien Lalancette authored
TBR=tommycli@chromium.org Bug: 1030551 Change-Id: I6d707a3cbfd189b6d94287c995e8db8bc60a3027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014125Reviewed-by:
-
Peter Boström authored
Prevents leaving user traces in Incognito while still allowing the window to stay in sync with pinning done in non-Incognito windows. Bug: chromium:970023 Change-Id: I68a3fe0e6b7696578a2199994ced6db5a3c71faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990148 Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734112}
-
Alex Ilin authored
At the end of the remote consent flow, a Gaia page calls OAuthConsent.setConsentResult(consentResult) JS function. consentResult should be eventually passed to the browser. The Gaia page is loaded within a <webview> within a Chrome-internal identity extension. The Gaia page passes the result to the browser in two steps: 1) Pass a string from the webview JS to the extension JS. 2) Pass a string from the extension JS to the browser. 1) is achieved using chrome.runtime.sendMessage() API as described in https://developer.chrome.com/extensions/messaging#external-webpage. To hide this implementation detail from Gaia, the identity extension injects a script into the Gaia page defining OAuthConsent.setConsentResult() function. For 2), we add setConsentResult() function to identityPrivate extension API. The function handler passes the result to GaiaRemoteConsentFlow through a registered callback in extensions::IdentityAPI. Bug: 1026237 Change-Id: I1b955fc44979249f520563bd0a33cc2d6fd0aecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000791 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#734111}
-
Wez authored
Fuchsia builds have been forcibly disabling safestack because it broke V8 tests under Fuchsia, and forcibly enabling shadow-call-stack in advance of it becoming the toolchain default, to gauge size impact. Enabling shadow-call-stack under x64 is not recommended and breaks code which uses C++ exceptions, which is true of some V8 code & tests. Since the toolchain default should now be correct, remove the overrides entirely. Bug: 1028617, 821951 Change-Id: I36333f8cff5ea62584032a802337cdeb95f33466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014407 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#734110}
-
Adam Ettenberger authored
[1] https://www.w3.org/TR/html-aam-1.0/#html-element-role-mappings [2] https://w3c.github.io/core-aam/#mapping_role_table For UIA the only difference between a <form> with an accessible name and one without is a <form> that does not have an accessible name : 1. Has no corresponding ARIA Role. 2. Does not have a UIA Landmark Type Unfortunately if a role is not mapped, then the node becomes a generic container which can break expectations for both aria-setsize and aria-posinset because |AXTree::PopulateOrderedSetItems| cannot detect the form without adding a check for StringAttribute::kHtmlTag and will recursively include descendants of the form with the siblings of the form. In particular, not mapping a role broke : DumpAccessibilityTreeTest.AccessibilityAriaPosinset/* ... the 2 radioButton nodes inside the form and the 2 radioButton siblings of the form would all have setSize=6, and the posInSet of the later 2 nodes was also offset to be 5 and 6 respectively. Because the reasoning behind these differences is to prevent an unlabeled form from acting as a landmark, I kept the change local to UIA Landmark Type. Bug: 1042420 Change-Id: I2bc4e052e81d447aea42d3585cbe65a2baa1165c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003257Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Cr-Commit-Position: refs/heads/master@{#734109}
-
Dave Tapuska authored
Fix a bad cast that had existed for years (originally written by in crrev.com/d322c5ca) This was only recently uncovered by clusterfuzz when we added virtuals to the WebInputEvent in crrev.com/547be407. Fortunately the cast shouldn't have caused any issues. BUG=1044379 Change-Id: I47463bd671b17beba9e2ebd5803ec1ea93236bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013477Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#734108}
-
Mohammad Refaat authored
SideSwipeController initializer now take a Browser instead of browserState and tabModel. SideSwipeView will be initialized with webStateList instead of tabModel. Bug: 783777, 1043370 Change-Id: I5ed4e20b9bb6f8def9f6fff89a333bdfc142b59d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008003 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#734107}
-
Nate Chapin authored
This wrapping up of parameters leaves SecurityContext construction much more readable. To enable this, SecurityContextInit needs to be usable as a const reference in the SecurityContext constructor. This doesn't work currently, because there are two functions that move and return a std::unique_ptr. This CL therefore changes construction of the SecurityContextInit to store the state need to later construct the objects that will be returned wrapped in a std::unique_ptr. Bug: 1029822 Change-Id: Ic1f17ac22aa38eb77614735d41609941457d6698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006074 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#734106}
-
Eric Stevenson authored
NativeLibraries.java has a dependency issue that creates problems for Trichrome Webview 64 bit component builds. This CL adds a workaround of these issues by just listing a single native library, libmonochrome.cr.so, which does have the right dependencies (listed in the "NEEDED" section of the binary). The problem and fix both only affect trichrome component builds. Bug: 1042107 Change-Id: Ib4873daeccf89373cacf1aace1240b6d708331f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008464Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#734105}
-
Shawn Pickett authored
Bug: 984851 In http://crrev.com/c/1708013, a change was committed to improve battery life by avoiding unnecessary media caching. This submission, driven by feedback from http://crbug.com/984851, makes an additional adjustment in preparation for testing trials. It adds a check to verify that the device is running on battery and is not connected to AC power. Since the goal is to improve battery life, this scopes the change so that it doesn't impact scenarios when the device is connected to power. The potential disadvantage is that the caching behavior can now be different depending on whether the device is connected or not. Since the entire change is under a feature key, the idea is to verify that the reduction in media caching does not lead to any discernible difference in user-facing functionality between the scenarios during the testing trials. Change-Id: I8b73da81a509962701e30cfd43f36b34b0dc70b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830069Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Shawn Pickett <shawnpi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#734104}
-
Alexei Svitkine authored
Removes a method declaration that no longer exists and fixes a comment reference. Bug: None Change-Id: Ic80f0c0acc391d0eb4d9dd5459054a438d282327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013891 Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#734103}
-
rbpotter authored
This test only appears to have failed in the CL that disabled it on the Mac bot. Re-enable it for other platforms. Bug: 1044390 Change-Id: Ic1d6290e7ae2cb9ebfdb6d4d2038cb7a64a3ee7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013911Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/afc469d68c53..71fa12130a57 Created with: gclient setdep -r src-internal@71fa12130a57 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If328a1db5f93bea9a06e6e472d7d19db5b833f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013771Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734101}
-
Robbie Gibson authored
The text zoom level is stored in a user pref and keyed based off the current url host and the current iOS content size category. This means that if the user changes the zoom on one page and then changes the accessibility text size, the earlier change won't affect the page in the new text size. Thus, if a page is broken at one accessibility text size, any user adjustments will not affect other text sizes. This does not clear the preferences when browsing data is cleared. That will be added later. Bug: 1028938 Change-Id: I5a3a71f2bfa3d84750f714d2e2cffa869f40ccc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002520 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#734100}
-
khmel@chromium.org authored
This one is important to estimate health of secondary account sign-in. This stats should also be used for estimation of secondary account sign-in improvements. BUG=1036943 BUG=b:/146792085 TEST=N/A Change-Id: I80c2ec4886fcaad79cb1de07899c01e2a9f9b997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980897 Commit-Queue: Yury Khmel <khmel@chromium.org> Auto-Submit: Yury Khmel <khmel@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#734099}
-
Jeremy Roman authored
This could happen if such an element is created in a document with portals enabled and moved into a document with portals disabled. Bug: 1040627 Change-Id: I8925a02d21c7d6a124def303d903d0b715836d93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013473 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#734098}
-
Sajjad Mirza authored
The win10_chromium_x64_coverage_rel_ng tryjob needs to run the same test targets as win10_chromium_x64_rel_ng to make sure that coverage mode will not break the latter when it is enabled. Bug: 1041689 Change-Id: Ib1edad65f58770930475bdb354d8dee7e8ae6ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006265Reviewed-by:
-
