GitLab

The exit-code from remoting_me2me_host will be used to communicate to the
daemon that the Host ID was rejected as invalid.


BUG=110046
TEST=Run remoting_me2me_host with invalid host.json


Review URL: http://codereview.chromium.org/9301026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120031 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120030 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9314027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120029 0039d316-1c4b-4281-b951-d872f2087c98

BUG=112137
TEST=sign into Chrome, open settings page, click Google Dashboard link

Review URL: https://chromiumcodereview.appspot.com/9310006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120028 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104418
TEST=none


Review URL: http://codereview.chromium.org/9316007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120027 0039d316-1c4b-4281-b951-d872f2087c98

BUG=108171



Review URL: http://codereview.chromium.org/9159068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120026 0039d316-1c4b-4281-b951-d872f2087c98

Adds two new observer methods to allow code to be notified when a Window is added/removed from a RootWindow. This allows hierarchy-specific cleanup code to execute when a Window is removed rather than when it is destroyed, necessary for multiple root windows.

http://crbug.com/112131
TEST=see unittests
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119976

Review URL: http://codereview.chromium.org/9315015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120025 0039d316-1c4b-4281-b951-d872f2087c98

The manager sends signals when additional adapters (including the
initial) are added, we may need these to obtain properties before
the default adapter is switched so hook up that signal so the
observer can take it.

BUG=chromium-os:22086
TEST=verified signals are received

Change-Id: I895c699eaef2f77f70ad855601b16e9a7c731ebb


Review URL: http://codereview.chromium.org/9302027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120024 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=added unittest.


Review URL: http://codereview.chromium.org/9301016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120023 0039d316-1c4b-4281-b951-d872f2087c98

This is equivalent to GetLastState().error. It saves copying 6 ints. This is temporary until skia does not invoke MakeCurrent for every GL call.

BUG==112187

Review URL: http://codereview.chromium.org/9314020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120022 0039d316-1c4b-4281-b951-d872f2087c98

* Show status area volume control when the command line has --show-volume-status 
* Create AudioHandler::VolumeObserver class and helpers so VolumeMenuButton and VolumeControlView can observe volume changes from key presses.
* Move GetAudioHandler() common code in VolumeMenuButton and SystemKeyEventListener that returns the AudioHandler singleton only if the mixer has finished initializing to AudioHandler::GetInitialized().
* Handle mute in VolumeMenuButton correctly.

BUG=chromium-os:22080
TEST=Should see the volume control in the status area on builds with USE flag is_desktop set. The volume control icon and menu should be in sync with volume key button controls.
Review URL: https://chromiumcodereview.appspot.com/9169033

TBR=achuith@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9310018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120019 0039d316-1c4b-4281-b951-d872f2087c98

Revert 120005 - Enabled pressing TAB to traverse through the Omnibox results, removed moving the caret to the end of the line with TAB, and filtered out redundant URLs.

This adds the ability to move through Omnibox result matches using TAB in addition to the arrow keys. To enable this, pressing TAB to move the caret to the end of the line was removed and the keyword hint/shortcut logic has been modified.

The Omnibox popup now shows keyword markers on the right side of matches that have associated keywords (represented by a right arrow). When this kind of match is selected, and the keyword is accepted, the match changes appearance by animating in the associated keyword match from the right to display the "Search X for <>" message. 

If multiple matches have the same keyword then only the most relevant match will display the keyword marker and hint. Pressing TAB while a keyword hint is shown will enter keyword mode in place; the results will no longer change when keyword mode is entered. Additionally, substituting keyword provider matches will only be shown if a keyword substitution
is available.  

Finally, results with redundant destination URLs (e.g., "foo.com", "www.foo.com") will have the less relevant URLs filtered out.

This also addresses some GTK omnibox browsertest flakiness; see bug 112041.

Contributed by aaron.randolph@gmail.com

BUG=57748,76278,77662,80934,84420
TEST=Press TAB to move the selection down the list of results, SHIFT+TAB to move up.

Review URL: http://codereview.chromium.org/6731036

TBR=aaron.randolph@gmail.com
Review URL: https://chromiumcodereview.appspot.com/9310017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120018 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None.
TEST=Run any test.


Review URL: http://codereview.chromium.org/9301025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120016 0039d316-1c4b-4281-b951-d872f2087c98

This test must be run manually for now, and will be used in its current
state only temporarily to compare results across different ChromeOS
devices.

BUG=None
TEST=Verified the test runs successfully on a local Alex device.

Review URL: https://chromiumcodereview.appspot.com/9320001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120015 0039d316-1c4b-4281-b951-d872f2087c98

TBR=acolwell
BUG=109875
TEST=none


Review URL: http://codereview.chromium.org/9317023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120014 0039d316-1c4b-4281-b951-d872f2087c98

This is check-in for mattias.
Original review: http://codereview.chromium.org/9315011/

Note that this hard-wires policy OAuth fetching in login_utils.cc to the
authentication profile. I'm not entirely sure this is a good idea, but
required since the user profile isn't in a state to allow successful
requests at this point (the use-shared-proxies flag is off). Other stuff
in login_utils.cc might need the hack too (sync?).

BUG=chromium-os:25703
TEST=Verify fix for chromium-os:25703
TBR=mnissler@chromium.org,zelidrag@chromium.org,sumit@chromium.org,pastarmovj@chromium.org,kuan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9309024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120013 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120012 0039d316-1c4b-4281-b951-d872f2087c98

See http://codereview.chromium.org/9233048 for the actual change. 

BUG=109574
TEST=Go to http://i18nl10n.com/chrome/euc_webkit_8EE3.html and make sure there's no alert box popping up.
TBR=tsepez
Review URL: https://chromiumcodereview.appspot.com/9314007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120011 0039d316-1c4b-4281-b951-d872f2087c98

Fix compile error
Fix to show virtual keyboard on linux build

BUG=chromium-os:10620
TEST=build success with GYP_DEFINES="use_virtual_keyboard=1"


Review URL: http://codereview.chromium.org/9200011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120010 0039d316-1c4b-4281-b951-d872f2087c98

BUG=111985
TEST=


Review URL: http://codereview.chromium.org/9159047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120009 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/9317022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120008 0039d316-1c4b-4281-b951-d872f2087c98

BUG=80621
TEST=Open a page which is part of an app, in another tab install the app, reload the original page. The renderer process for the tab should be switched.


Review URL: http://codereview.chromium.org/9169065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120007 0039d316-1c4b-4281-b951-d872f2087c98

BUG=111900
TEST=Invoke 'Clear Browsing Data' from the wrench menu, should bring up the correct dialog.
Review URL: https://chromiumcodereview.appspot.com/9309018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120006 0039d316-1c4b-4281-b951-d872f2087c98

Enabled pressing TAB to traverse through the Omnibox results, removed moving the caret to the end of the line with TAB, and filtered out redundant URLs.

This adds the ability to move through Omnibox result matches using TAB in addition to the arrow keys. To enable this, pressing TAB to move the caret to the end of the line was removed and the keyword hint/shortcut logic has been modified.

The Omnibox popup now shows keyword markers on the right side of matches that have associated keywords (represented by a right arrow). When this kind of match is selected, and the keyword is accepted, the match changes appearance by animating in the associated keyword match from the right to display the "Search X for <>" message. 

If multiple matches have the same keyword then only the most relevant match will display the keyword marker and hint. Pressing TAB while a keyword hint is shown will enter keyword mode in place; the results will no longer change when keyword mode is entered. Additionally, substituting keyword provider matches will only be shown if a keyword substitution
is available.  

Finally, results with redundant destination URLs (e.g., "foo.com", "www.foo.com") will have the less relevant URLs filtered out.

This also addresses some GTK omnibox browsertest flakiness; see bug 112041.

Contributed by aaron.randolph@gmail.com

BUG=57748,76278,77662,80934,84420
TEST=Press TAB to move the selection down the list of results, SHIFT+TAB to move up.

Review URL: http://codereview.chromium.org/6731036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120005 0039d316-1c4b-4281-b951-d872f2087c98

TBR=thakis

Review URL: http://codereview.chromium.org/9315018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120004 0039d316-1c4b-4281-b951-d872f2087c98

To be removed when r119687 reaches official builds.

BUG=None
TEST=None

TBR=dennisjeffrey@chromium.org
R=dennisjeffrey@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9233037

TBR=nirnimesh@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120003 0039d316-1c4b-4281-b951-d872f2087c98

xib changes: Cleared the "Key Equiv" field from the Change button.

BUG=112204
TEST=


Review URL: http://codereview.chromium.org/9307017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120002 0039d316-1c4b-4281-b951-d872f2087c98

Cleanup: Delete some 0 byte files that are still lying around as a result of a CQ bug. (no code review because the CL is "empty")

BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120000 0039d316-1c4b-4281-b951-d872f2087c98

On Mac, the search field's cancel button appeared to be missing. This was caused by applying
a transformX() to header elements to allow them to side-scroll properly. This CL changes to
use margin-left instead. The behavior is the same, but now the cancel button appears properly.
I will be filing a WebKit but since this is probably a core issue with the search control.

BUG=112046
TEST=Verify that search field displays a cancel button when not empty.
Review URL: https://chromiumcodereview.appspot.com/9318009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119999 0039d316-1c4b-4281-b951-d872f2087c98

R=nduca

Review URL: https://chromiumcodereview.appspot.com/9318008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119998 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/9318004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119997 0039d316-1c4b-4281-b951-d872f2087c98

In accelerated compositing mode we can't start rendering until the
native window (HWND/gtk widget) are created on Windows and GTK without
aura. For most render_widgets the code today is racy, but for
window.open() and similar creation paths this is a race that we pretty
much always lose. This defers the first DoDeferredUpdate on a render_widget
until its host_window_ is available.

Also defers querying for GL_CHROMIUM_supports_swapbuffers_callback
extension until the first draw, since the context isn't ready until the
host window is available.

BUG=106815
TEST=start with --force-compositing-mode and --show-fps-counter, load up
a page that uses window.open() to open a popup, and confirm that the
popup is in compositing mode


Review URL: http://codereview.chromium.org/9225050

TBR=jamesr@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9316015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119996 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:25708
TEST=None

R=dtu@chromium.org


Review URL: http://codereview.chromium.org/9314006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119995 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/9314004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119994 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119993 0039d316-1c4b-4281-b951-d872f2087c98

BUG=99858
TEST=KeyboardOverlayDialog should show up on aura build.


Review URL: http://codereview.chromium.org/9250029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119992 0039d316-1c4b-4281-b951-d872f2087c98

The change just fixes a gyp style nit in a non-default code path.

BUG=96629
TBR=thakis

Review URL: http://codereview.chromium.org/9309014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119991 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104551
TEST=compile


Review URL: http://codereview.chromium.org/9160012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119990 0039d316-1c4b-4281-b951-d872f2087c98

* Reset the state of a GestureSequence after a tap/double-tap gesture.
* Do not send scroll-update gestures when both delta-x/delta-y are zero.

BUG=none
TEST=aura_unittests:GestureRecognizerTest.GestureTapFollowedByScroll

Review URL: https://chromiumcodereview.appspot.com/9318010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119989 0039d316-1c4b-4281-b951-d872f2087c98

BUG=112153
TEST=no


Review URL: http://codereview.chromium.org/9315008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119988 0039d316-1c4b-4281-b951-d872f2087c98