GitLab

This CL creates a generic place for heap profiler perftests, and adds
couple of stack frame deduplicator related perftests.

BUG=739378

Review-Url: https://codereview.chromium.org/2976843002
Cr-Commit-Position: refs/heads/master@{#486544}

Because the registration of BluetoothAdvertisements is asynchronous,
it is possible for the object which registered it (in this case,
a BleAdvertiser::IndividualAdvertisement) to have been destroyed by
the time the BluetoothAdvertisement finished registering. Due to
crbug.com/741050, this results in a BluetoothAdvertisement without
an owner to unregister it eventually, leaving it permanently dangling.

This CL works around the issue (until it is resolved) by creating a
static method which is available when the registration callback
fires. If the IndividualAdvertisement is destroyed when registration
is finished, the BluetoothAdvertisement is unregistered.

Bug: 739883
Change-Id: I33f210f3bc89504ba670387460b3ffe2ba3fdcf1
Reviewed-on: https://chromium-review.googlesource.com/567561
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486543}

Bug: 
Change-Id: I2ba1fc5b7910720490710c74a3b90353c6670718
Reviewed-on: https://chromium-review.googlesource.com/570505Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486542}

DomSnapshot is modified to populate NodeValue for textarea, input and option elements.

radio/checkbox and option elements are populated with a checked/selected string

BUG=546953

Review-Url: https://codereview.chromium.org/2971133002
Cr-Commit-Position: refs/heads/master@{#486541}

These currently imply monocularly rendered content which is quite
disruptive in VR. Until the UI for these requests is properly supported
in VR, we should deny them.

BUG: 728421
Change-Id: Iaeaa2c3f90d3f59667b199ee2ed850bb0bf9db4e
Reviewed-on: https://chromium-review.googlesource.com/569398
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486540}

This is the recommended way to use the new @available feature.
Also happens to work around clang-format not understanding
__attribute__.

Bug: 735328,741084
Change-Id: I3f518b23037d2cdd23a5e32c0fc3de1f865bedd0
Reviewed-on: https://chromium-review.googlesource.com/570007
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486539}

For more details, see https://goo.gl/q2GSav

Bug: chromium:720302
Change-Id: Iebdadcb48633b9c05a8a8e6af4cc1b01fac01d6d
Reviewed-on: https://chromium-review.googlesource.com/534934
Commit-Queue: Eric Holk <eholk@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486538}

Now when we move the mouse into an element while pressing the left button,
we do not update the hover states of the element. We should update hover
states of the element, which is now underneath the mouse cursor no matter
the mouse button is pressed or not.

The design doc:
https://docs.google.com/document/d/1TgqvDg8L_TkEiNjBUaz39FDgxpp5aj9ZdIWeQSanKHY/

BUG=122746

Review-Url: https://codereview.chromium.org/2965603002
Cr-Commit-Position: refs/heads/master@{#486537}

- The canonical name of the warning is now -Wunguarded-availability,
  so use that
- Remove a spurious dupe of the flag in device/gamepad which caused
  the flag to be passed twice to compiles there
- Remove a redeclaration that's no longer needed

Bug: 735328
Change-Id: I510c7b6f6835ef971df4fb746f612fdf875edc31
Reviewed-on: https://chromium-review.googlesource.com/570741
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486536}

after a refactoring at http://crrev.com/ad6d8a9bbf9bd5e2.
As a follow-up of the refactoring, this CL inlines the alias to its users
in //components

base: :StaticAtomicSequenceNumber is an alias of base::AtomicSequenceNumber
Change-Id: Iacd76aadcfd612e6886f368b1d209e9651d1045b
Reviewed-on: https://chromium-review.googlesource.com/568199
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486535}

1. InputDeviceManager becomes a thread-local singleton instead of a global
   singleton. UI Service instantiates DeviceDataManager, which is the service-
   side implementation of InputDeviceManager, while the browser uses
   InputDeviceClient, which is the client-side implementation.

2. PlatformEventSource also becomes a thread-local singleton. This is to prevent
   ash and the browser from executing code on the UI Service's thread by
   registering PlatformEventObservers (e.g. via UserActivityDetector). In the
   futurer we may need a client-side implementation of PlatformEventSource.

3. GPU Service checks if a PowerMonitor singleton exists before creating one.
   This is temporary until GPU Service runs in a separate process from the UI
   Service. (crbug.com/609317).

BUG=722527

Review-Url: https://codereview.chromium.org/2978873002
Cr-Commit-Position: refs/heads/master@{#486534}

It is possible to font loading to fail. Such as when the peer closes during a
synchronous mojo call to load a font.

Currently this is treated as a fatal error, which leads to flaky tests.

This change updates PlatformFontLinux to instead fallback to providing the
default font in these cases. While logging the error.

TEST=mash_browser_tests

Bug: 738441
Change-Id: I2717a0fdf561be82e6d393863a0cfd13b19ae480
Reviewed-on: https://chromium-review.googlesource.com/568789Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486533}

EnumerateInputMethodEditors() is a much simpler function that does
pretty much the same thing as what ShellExtensionEnumerator is doing.

This CL creates EnumerateShellExtensions() to replace
ShellExtensionEnumerator.

In addition to the code being simpler, this doesn't leave a useless
class instance laying around when it is finished.

Bug: 690173
Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: Ib0ff9dfcbc20b307666cf1f9d1f676565f8c8f25
Reviewed-on: https://chromium-review.googlesource.com/562496Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486532}

TBR=scheib@chromium.org

Change-Id: I1fadaab55044a9a6dbf4717d189cd5168dd851cb
Reviewed-on: https://chromium-review.googlesource.com/571079Reviewed-by: Vincent Scheib <scheib@chromium.org>
Commit-Queue: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486531}

This will allow to pass any parameter to the test binary. For example
it's useful to pass --gtest-list-tests to get list of tests in the
binary.

Change-Id: I32ffb2e35df621a3fc6f6d8518cde8f744a599f3
Reviewed-on: https://chromium-review.googlesource.com/568600
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486530}

This reverts commit 5657b403.

Reason for revert: Telemetry test flakes, see: crbug.com/742039

Original change's description:
> Remove LayerImpl dependency from LayerTreeImpl::DidUpdateScrollOffset
> 
> This patch removes the LayerImpl references from DidUpdateScrollOffset.
> Instead of looking up scroll and transform property nodes with Layers,
> ElementId is used.
> 
> The invariant now used in LayerTreeImpl::DidUpdateScrollOffset (and
> Layer::UpdateScrollOffset) is that a scroll node should exist or the tree
> should be marked as needing a rebuild which will update the scroll node;
> there should be no other codepaths that update scroll offset. A TODO
> has been added to require that a scroll node exists in all cases.
> 
> Tests have been modified to ensure property trees exist before updating
> scroll offset. This should be true in all real cases but is not for
> synthetic testing scenarios.
> 
> A bug has been fixed in UpdateScrollChildPosition where the scroll layer
> was not actually scrollable.
> 
> Bug: 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I75d881a0c05a6fd81ae028bdaead9481641d201f
> Reviewed-on: https://chromium-review.googlesource.com/560584
> Commit-Queue: Philip Rogers <pdr@chromium.org>
> Reviewed-by: enne <enne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485335}

TBR=pdr@chromium.org,enne@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 742039
Change-Id: Idd87e6af6a88a3b033864310134b8a379316ab9e
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/570698Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486529}

Currently each RenderWidget sends cursor update messages independently
based on its last seen mouse position, with no awareness of other
RenderWidgets overriding the mouse cursor. This causes problem due to
race conditions where RenderWidgets in multiple renderer processes are
changing the cursor graphic as the user moves the mouse, and also
creates inconsistency because a RenderWidget does not know that a
different RenderWidget has modified the cursor.

This CL adds a CursorManager class to content, which tracks the last
cursor update received by each RenderWidgetHostView, and signals the
root RWHV to show the correct cursor for the view that the mouse is
currently over.

Bug: 614540, 545237
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Id7355b69f13f9e13a5113b5f63228ddf067352ed
Reviewed-on: https://chromium-review.googlesource.com/558271
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486528}

The new class provides access to the SystemURLRequestContext via
an in-process NetworkService and the NetworkContext Mojo API.
Eventually, we should remove IOThread entirely, and have the
SystemNetworkContextManager perform all configuration of the
SystemRequestContext, and provide access to it as well.

The in-process network service currently just takes a
URLRequestContextBuilder from IOThread and uses that to create the
URLRequestContext, but this gives us a path to switch over
configuration so that it goes through the NetworkService API. It also
lets us switch consumers over to using the NetworkContext API without
having to create a wrapper that supports both the shiny new Mojo API
the legacy one.

When network service is enabled, the SystemNetworkContextManager will
use an out-of-process URLRequestContext instead of an in-process one,
while the IOThread will continue to use an in-process ones.

BUG=715695

Review-Url: https://codereview.chromium.org/2968293002
Cr-Commit-Position: refs/heads/master@{#486527}

The header can be merged with the implementation. Removing the extra
file will result in a little less maintenance.

This is a pure refactor.  No code was changed.

BUG=734280

Review-Url: https://codereview.chromium.org/2963173003
Cr-Commit-Position: refs/heads/master@{#486526}

This reverts commit a66ebc8a.

Reason for revert: Appears to have caused compile failure on Linux x64: https://luci-milo.appspot.com/buildbot/chromium/Linux%20x64/44132

Original change's description:
> Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager
> 
> Modify TickClock dependency injection for BrokenAlternativeServices to use a setter instead of a constructor param.
> Add TickClock dependency injection for HttpServerPropertiesImpl and HttpServerPropertiesManager for testing.
> 
> Add BrokenAlternativeService::Clear() and update HttpServerPropertiesImpl::Clear() to call that.
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
> 
> BUG=705029
> 
> Change-Id: Idb411192e47d275cde3362b479a6b9e9fa773a17
> Reviewed-on: https://chromium-review.googlesource.com/562604
> Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Commit-Queue: Yixin Wang <wangyix@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486519}

TBR=rch@chromium.org,holte@chromium.org,zhongyi@chromium.org,wangyix@chromium.org

Change-Id: I946b3205a67356c0130ef53efbba245a1768d601
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 705029
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/571259Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486525}

Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/T8r1SrZUEZM

Bug: chromium:711083
Change-Id: Ieb9c7b3fcf76d6b13ef0c89d676cecf02b0daa78
Reviewed-on: https://chromium-review.googlesource.com/513531Reviewed-by: Brad Nelson <bradnelson@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Mircea Trofin <mtrofin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486524}

- Remove message queue / message handling logic from PresentationDispatcher.
- Move Send{Text,Binary}Message methods from WebPresentationClient to
WebPresentationConnectionProxy.
- Remove unused DidReceive*Message methods from WebPresentationController.

Note that there is behavior change; previously the sending of a message is
blocked on the other side having processed the previous message
successfully. This pattern was previously used for control flow purposes
and is no longer deemed useful.

Bug: 684116
Change-Id: I3589c4c047e7b5c16ff1a92a0d5e72bbf932023f
Reviewed-on: https://chromium-review.googlesource.com/563766
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486523}

Bug: 739091
Change-Id: Ifbc99e569813dfc2c2ae674beee3e1ea0c062666
TBR: keishi@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/569838
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486522}

See doc for description:
https://docs.google.com/document/d/1JC1RgMyxBAjUPSHjm2Bd1KPzcqpPPvxRomKevOkMPm0/edit

Bug: 736501
Change-Id: I28d61d66948d7ae2403312489cf246247a3f50b3
Reviewed-on: https://chromium-review.googlesource.com/547016
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486521}

Creating RegisterInProcessServices() in BrowserProcessPlatformPart, and moving
the CrOS-specific service registration code from ChromeContentBrowserClient to
CrOS BrowserProcessPlatformPart.

BUG=722527

Review-Url: https://codereview.chromium.org/2977043002
Cr-Commit-Position: refs/heads/master@{#486520}

Modify TickClock dependency injection for BrokenAlternativeServices to use a setter instead of a constructor param.
Add TickClock dependency injection for HttpServerPropertiesImpl and HttpServerPropertiesManager for testing.

Add BrokenAlternativeService::Clear() and update HttpServerPropertiesImpl::Clear() to call that.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng

BUG=705029

Change-Id: Idb411192e47d275cde3362b479a6b9e9fa773a17
Reviewed-on: https://chromium-review.googlesource.com/562604Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Yixin Wang <wangyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486519}

Reset ES3 pixel pack parameters and PIXEL_PACK_BUFFER binding in DrawingBuffer before ReadPixels() and recover them later.

BUG=740603
TEST=new conformance test
R=kbr@chromium.org,piman@chromium.org

Change-Id: I3ea54c6cc34f34e249f7c8b9f792d93c5e1958f4
Reviewed-on: https://chromium-review.googlesource.com/570840Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486518}

MSC doesn't define SSE, so this wasn't working properly on Windows

Bug: 686253
Change-Id: I5e49e9dec43228288261160d8e9eede9b4a6bf75
Reviewed-on: https://chromium-review.googlesource.com/570351
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486517}

This code was obsoleted with the PrinterDetector interface introduction,
and is not referenced (nor even built).  It should have been nuked in
an earlier change but was overlooked, apparently.

Bug: 
Change-Id: Iba5ca7a61e5e61ab27281ad7525204d8ceefc33c
Reviewed-on: https://chromium-review.googlesource.com/570126Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Justin Carlson <justincarlson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486516}

This is a reland of f3a69e04

Bug: 672489
Change-Id: I7f4c6a679ced59e839650f372a3c79bea106534e
Reviewed-on: https://chromium-review.googlesource.com/570508
Commit-Queue: Justin Schuh <jschuh@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486515}

All projects that need to change the default mac min SDK now directly do so via
a GN arg.

Bug: chromium:740693
Change-Id: I99f04d482177e6ec8a5d1306f68cb2410b0beb0e
Reviewed-on: https://chromium-review.googlesource.com/566078
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486514}

Bug: 739664
Change-Id: I158511a9d8ccd85561adc1f59d67ee7f9386d343
Reviewed-on: https://chromium-review.googlesource.com/568818Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486513}

This change adds UseCounter (for publicly visible % of Page Visits
statistics) and RAPPOR reporting to help us gauge the frequency of these
types of MSE API usages encountered in Chrome usage.  Such data may
assist subsequent work to clarify the spec, improve our implementation,
and potentially deprecate support.

"KeyframeTimeGreaterThanDependant" reporting: (Bug 739931)
If nonkeyframe's PTS precedes the PTS of the keyframe necessary to
decode it, this (in ISO-BMFF terminology) is not SAP Type 1 (though
other bytestreams might also encounter this GOP structure, too.) Our
buffering mechanism should gracefully handle this type of GOP, but the
MSE spec is unclear for how to precisely report resulting buffered
ranges and handle buffering/playback of overlaps of these types of
streams.

"MuxedSequenceMode" reporting: (Bug 737757)
If a multitrack SourceBuffer is used in 'sequence' AppendMode, the spec
leads to frequently surprising and undesirable results, usually due to
automatic timestampOffset updates based on one track after a
discontinuity are applied to all tracks.

At least bug 739931 may impact current PTS/DTS compliance work tracked
by bug 718641.

BUG=739931,737757,718641

Change-Id: I4fabb4ae0b389c5ce2eecb361d4b67c6d4874b04
Reviewed-on: https://chromium-review.googlesource.com/567558Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Alexei Svitkine (slow) <asvitkine@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486512}

Change-Id: I10e8f8bebfc0099e982610dc3a527f282d126cb8
Reviewed-on: https://chromium-review.googlesource.com/569455Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486511}

There's already a MEDIA_EXPORT on everything else in media/audio/alsa/;
this one was missed.

BUG=NONE
TEST=NONE

Change-Id: Ia79046f0cee05b1da12074f0c69e073381644499
Reviewed-on: https://chromium-review.googlesource.com/570938Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Jenny Wong <jyw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486510}

When UI Service runs inside the browser process in its own separate thread,
there is a few things it needs to do differently:

 1. It shouldn't set its Screen as a global singleton.
 2. It shouldn't set its ClientNativePixmapFactory as a global singleton.
 3. It can't access the ResourceBundle from its own thread - that can only be
    done from the browser thread.

The third point is the source of most of the complexity in this CL. UI Service
needs to manipulate the cursor, which is done through the ui::ImageCursors
object, which needs to load resources. Since resources can't be loaded on the
UI Service's thread, a mechanism is introduced to let the UI Service do this by
posting tasks to the browser's thread task runner, which is passed into the
UI Service's constructor.

This CL doesn't contain browser-side changes to run the UI Service in-process.

BUG=722527

Review-Url: https://codereview.chromium.org/2979933002
Cr-Commit-Position: refs/heads/master@{#486509}

The FileDescriptorWatcher POSIX wrapper assumes that it is safe to call
StopWatchingFileDescriptor() on a MessageLoopForIO::FDWatcher instance
from within an FDWatcher event callback.

The Fuchsia implementation was incorrectly keeping a record of the
asynchronous IO |handle_| for the freshly-ended wait operation, which
was causing StopWatchingFileDescriptor to try to re-cancel the
already-ended wait.

Bug: 741788
Change-Id: Id1572166fcdb166c6be5700ea7e137b486ebaf5d
Reviewed-on: https://chromium-review.googlesource.com/569278Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486508}

Always place it in the center of the "root window for new windows", which
is the display where the user last interacted with a window.

This fixes a regression where the dialog could be centered over a tabbed
browser window. It also fixes a couple cases where adding a new Wi-Fi
network from the status tray menu on a secondary monitor would open the
dialog on the primary monitor.

Added some basic test coverage to NetworkConfigView.

Bug: 740316
Test: chrome browser_tests. Also manually add a new Wi-Fi network during OOBE, at the login screen, and after login on both primary and secondary displays.
Change-Id: I60f2070dea9f39da586c97ff8b178fc34c5fb325
Reviewed-on: https://chromium-review.googlesource.com/569025
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486507}

Bug: NONE

Change-Id: Id7209e1084e4e493c8773552a753fb6656e83f5c
Reviewed-on: https://chromium-review.googlesource.com/542944
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Blaise Bruer <allada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486506}

BUG=724695

Change-Id: Ibb733a5ac20664aa4bac20fe41e13ffe1523ffef
Reviewed-on: https://chromium-review.googlesource.com/570665Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486505}