- 12 Mar, 2020 40 commits
-
-
Oksana Zhuravlova authored
This reverts commit 7909edf0. Reason for revert: the original issue was fixed in https://crrev.com/c/2100931 Original change's description: > Revert "[COEP] Report CacheStorage/CORP violations in service workers" > > This reverts commit c4f44550. > > Reason for revert: this change blocks reverting https://crrev.com/c/2096687 for blink_web_tests failing on Mac10.14 Tests: https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/2403 and Win7 Tests (1): https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/100679 > > > Original change's description: > > [COEP] Report CacheStorage/CORP violations in service workers > > > > Do not call BindCacheStorageInternal until we have a COEP reporter to > > pass to RPH::BindCacheStorage. > > > > Change-Id: I25fd317cbcd6fd84d924472ca73facc007b50c71 > > Bug: 1060980 > > Cq-Do-Not-Cancel-Tryjobs: true > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100056 > > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#749644} > > TBR=yhirano@chromium.org,shimazu@chromium.org > > Change-Id: Ife904e199a931e0e19963526d88f7c31578a12bb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1060980 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100711 > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749706} TBR=yhirano@chromium.org,shimazu@chromium.org,oksamyt@chromium.org Change-Id: I40bf1e6a59f33b5bee237cb10105b4e2af3704bf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1060980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101292Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#749778}
-
Marc Treib authored
Bug: none Change-Id: I6d215536c172038cad55bf5a26f296149efe78f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100929 Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#749777}
-
Aya ElAttar authored
Bug: 1044716 Change-Id: Ia3ae4e9b88dd4f2ffcaf75d73d72f98fc2bc9976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098788Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#749776}
-
Ian Wells authored
This is a reland of d6d50478 Fixes the original CL's test failures on release builds and updates the protos being used. Original change's description: > Feed refactor: Proto conversion > > Add StreamModelUpdateRequest and functions for converting wire protos into store protos > > Bug: 1044139 > Change-Id: I243ebabc331884500dec480c69d843d38546a34e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020545 > Commit-Queue: Ian Wells <iwells@chromium.org> > Reviewed-by: Dan H <harringtond@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747983} Bug: 1044139 Change-Id: I2b265170886b0a34dcc7b0abfcd563a6648c7593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095080 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#749775}
-
edchin authored
TBR=jlebel@chromium.org Bug: 1061085 Change-Id: I0ec1b61971ac6b9723b8f6eab2425b97aa84c5c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100717Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#749774}
-
Nate Fischer authored
No change to logic, only docs. This adds a pros/cons list for emulators. This moves the note about the Play Store into a con below, and replaces it with a table of contents at the top. Test: Upload to gerrit > open file > click "gitiles" Change-Id: I023924b88f53ac0b6b3c96e16743c12cfcf839f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098994 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#749773}
-
Daniel Rubery authored
After consultation with the APP team, we decided on a different set of strings to use for the deep scanning of APP users downloads. Screenshots of new UX: https://screenshot.googleplex.com/tgDGutEfHoz.png https://screenshot.googleplex.com/czzpfZg7uu0.png Bug: 1020418 Change-Id: I0f2f604b60031fac2d1b0fd0a7be64499164f780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099288 Auto-Submit: Daniel Rubery <drubery@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#749772}
-
Daniel Rubery authored
Since some features gated by this policy won't be "security" per se (such as forced updates or improved privacy features), rename the policy to AdvancedProtectionAllowed. This is safe because AdvancedProtectionExtraSecurityAllowed was first introduced in M82. Bug: 1056358 Change-Id: I6826e8956e76449dd89a8b649bb23eddb2637113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099296 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#749771}
-
Jan Wilken Dörrie authored
This change adds strings and metrics for the case when we request a plaintext password for editing purposes. Bug: 1047726 Change-Id: Iae233c8a3e476ab0105a152f5a6099e9a4585c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098622 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#749770}
-
Jon Mann authored
Bug: 966270 Change-Id: If3e181f61e0cbf3dd5adb673c182797ee6a42006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097835Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#749769}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5c243308. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" 3254ad50 "[ScrollTimeline] Support composited scroll-linked Web Animation" 8847f636 "MixedContent: Add WPTs for subresource fetching from workers" 51efe83e "InsecureRequestPolicy: Add WPTs for subresource fetching from workers" e423572a "Reveal only the initial frame URL in performance.measureMemory" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Id3a26b60cb1117f8680cdb6248884e77c5646fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100531Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749768}
-
Thomas Lukaszewicz authored
Updated color ids for tab background and foreground colors. New tab ids describe the specific tab state they represent. These ids will help in transitioning over to Color Pipeline in future changes. Bug: 1056916 Change-Id: I098955025bbdd00bb73b4dc9de63b877acfa4880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092553 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#749767}
-
Ulan Degenbaev authored
Bug: 1049093 Change-Id: I0aff32daa6558e0984c75f93b5de744859e14d01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098786 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#749766}
-
Chris Evans authored
Apple filed a bug asking Edge to stop using deprecated CFBundleTypes in the Edge Info.plist. * Added LSItemContentTypes for all types already listed * Created UTImportedTypeDeclarations for ones that aren't already listed in Apple's list of supported types * Removed entries for CFBundleTypeOSTypes, CFBundleTypeExtensions and CFBundleTypeMIMETypes Bug: 1060363 Change-Id: Ib31b33b28c74adb4efc6a1e253ae87cc90439cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098569Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f092e4d0ff25..b8996ddac0b1 git log f092e4d0ff25..b8996ddac0b1 --date=short --first-parent --format='%ad %ae %s' 2020-03-12 titovartem@webrtc.org Revert "Temporary debug logging for SingleProcessEncodedImageDataInjector" 2020-03-12 jakobi@webrtc.org Clamp stable target bitrate to min/max allocated bitrate. 2020-03-12 peah@webrtc.org ACM: Corrected temporary buffer size 2020-03-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 96fc083e..97afa2b0 (749472:749589) 2020-03-12 danilchap@webrtc.org Pass callbacks for RtcpReceiver at construction 2020-03-12 phoglund@webrtc.org Write protos as binary. Created with: gclient setdep -r src/third_party/webrtc@b8996ddac0b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029452 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8c59d536d109774f30672879bd295c7be30b47c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100298Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749764}
-
Shakti Sahu authored
This CL creates the TileService interface, factory in native and connects them to the Java layer. Bug: 1059409 Change-Id: I964eb6d662a86196f6dc764e7de33703765de7e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097304 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#749763}
-
Colin Blundell authored
WebLayer's logic for launching external intents currently resides in a static Java method that is called directly by C++. However, we are in the course of changing WebLayer to share //chrome's ExternalNavigationHandler.java, which will need to be a member of TabImpl.java. To prepare for that change, this CL changes the C++->Java hookup to go via TabImpl. This CL has no behavioral changes. I tested manually that basic intent launching still works in weblayer shell. Bug: 1031465 Change-Id: Iaa8a16838226b70ec865316543fe51d81f95bca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100850 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#749762}
-
Rainhard Findling authored
Change-Id: I9d976bd4c1a7af54500afbab57dea102f4301498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100768 Auto-Submit: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#749761}
-
Francois Doray authored
Surprisingly, some methods of a BrowserListObserver registered via BrowserTabStripTracker never get invoked. This is the root cause of a bug about reloading tabs when changing focus https://crbug.com/871834. Also, OnBrowserSetLastActive() is invoked for all Browsers whereas OnBrowserAdded()/OnBrowserRemoved() are invoked only for tracked Browser. This CL removes the support for adding a BrowserListObserver using BrowserTabStripTracker. Code that needs a BrowserListObserver can add it directly on the BrowserList. This makes the interaction with the BrowserTabStripTrackerDelegate less ambiguous. Bug: 871834 Change-Id: I3257004f0ac711c72ce3abcade333ea1032c467e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037455 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#749760}
-
Andres Calderon Jaramillo authored
This CL adds a new thumbnail checksum to test-25fps.h264.json to fix a failure in guado and rikku after a mesa uprev. buddy is also failing flakily but it seems to be because it sometimes skips the affected test (so that's a different bug). Interestingly, other Broadwell devices are not affected (I don't know why). See b:149099620 for details on why this is justified. TL;DR: the difference in the result before and after the mesa uprev is visually insignificant. Additionally, we take the chance to fix an incorrect if statement that was preventing the test from saving the result of the test as a PNG on failure. Tast will be modified accordingly after this CL lands. Bug: b:149099620 Test: video.DecodeAccel.h264 passes on rikku. Change-Id: I4f1d4a79e11059de4255a14f2e7a6d7c5342c9ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099408Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#749759}
-
Eric Orth authored
ResolveContext now allows registration of observers for DoH server status to get notifications on session change or servers becoming unavailable. This both replaces the started_doh_probe_requests_ in HostResolverManager that was used for restarting things on config/connection change, and it also allows triggering restarts on servers becoming unavailable due to failures. Additional changes: *Probe runners Start() now only starts probes for servers for which it is not running, and leaves alone probes that are already running. *Now that probes aren't forced to completely restart on every Start() call, to avoid leaking state between connections, DnsSession is now refreshed on connection change. *With DnsSession being changed on connection change, ResolveContext now does all work on session change rather than having special logic to handle connection change. *Stopped handling probes differently for online vs offline, as it was causing unnecessary complication, when it's safe to just let probes attempt, even when offline. Bug: 1022059 Change-Id: I65cc132baa04e74ea8d0f01e1844027dcbe60c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067626Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#749758}
-
Greg Guterman authored
This is a reland of 5c614415 This CL now has checks for the bucket-specific keys in waterfall.pyl as well as the generated bucket json files and makes sure they're consistent. Original change's description: > infra: Generate source side spec by bucket > > Doesn't include internal builders. > > Bug: 1028719 > Change-Id: Iec40cb84086ed23cd7d5ca60c317296460466497 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033847 > Commit-Queue: Gregory Guterman <guterman@google.com> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745574} Bug: 1028719 Change-Id: I830a3f4c100130eeedf5c676ce9b5003590a5e8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083938 Commit-Queue: Gregory Guterman <guterman@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#749757}
-
Yuke Liao authored
We do not support Clang profiling in nacl toolchains, so disable it. Bug: 1058979 Change-Id: I397e3c9feaf8eabcd6e7e9895c9f85d96199efd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100888Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#749756}
-
Chris Lu authored
Change-Id: I4b00efdc6fca7161d1ad82404b4bcac4a25a04ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098271 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#749755}
-
Maksim Moskvitin authored
DirectoryCryptographer usages are replaced with CryptographerImpl. KeyParams moved to encryption_helper.h. Bug: 1061045 Change-Id: I4674ea9b0d5c162b672269622d8361bdfdf25279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100933 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#749754}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c7796cf40d5e..27402f3ffd34 git log c7796cf40d5e..27402f3ffd34 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 tcwang@google.com toolchain_util: Run yapf 2020-03-11 gredelston@google.com Fix broken cros_fuzz_unittest.py 2020-03-11 saklein@chromium.org api/controller: Convert manual BuildTarget instantiations 2020-03-11 saklein@chromium.org cros_build_lib: Move out GetSysroot. Created with: gclient setdep -r src/third_party/chromite@27402f3ffd34 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I88a450737c0df3e55e7a9564cbcc0ea39a235bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100576Reviewed-by:
-
Robert Ogden authored
Opaque, non-transient NIKs can be created by calling CreateOpaqueAndNonTransient(). Since it is now possible to have opaque origins being saved to disk, Origin and NIK can now serialize themselves with an opaque NIK. Serialization notes: * url::Origin adds [De]serialize methods which fully serializes the origin into a base64 string. * Origin's [De]serialize methods are private and can only be used by friend classes, which NetworkIsolationKey is. Bug: 1055911 Change-Id: Ia6b949c9cc3b80b8d56f7ec3a1ea810c1c1308ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072906Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#749752}
-
Denis Kuznetsov authored
This change improves OOBE startup time for 0.8 sec in debug mode (~2%). Bug: 1058022 Change-Id: I1a6a8780afc4a0c2e28759beb6faeaadaef547ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100807Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#749751}
-
Evan Stade authored
This doesn't affect most tab modals, such as permissions and js dialogs, because those have associated C++ objects which react to navigations and close the dialogs. This affects/fixes the form re-post confirmation dialog, which until now would not dismiss on a navigation. It also removes code to explicitly close that dialog when the tab is destroyed, as it duplicated functionality from TabModalLifetimeHandler. Bug: 1059853 Change-Id: I9d6c3c1843c1b39faf5836adf535f108bfa00eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095137 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#749750}
-
Danyao Wang authored
This CL is the Android counterpart of crrev.com/c/2097242. It sends the real RenderFrameHost from Java to native when initializing service worker based payment apps. This ensures that manifest fetching happens within the correct frame. Bug: 1055360 Change-Id: Ie1953ec749cf04a173cd80cc09cb07f5e60ffeaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100013 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#749749}
-
Luca Hunkeler authored
Bug: 1059442 Change-Id: I150d2d3f7c4ead040bd144891b4d1e045ec5b4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100791 Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#749748}
-
Jun Mukai authored
A lot of performance tests have been disabled but most of the cases they're flaky only on asan/lsan/msan bots, and that is natural because the performance is worse due to additional sanitizing. Also those performance numbers won't be helpful anyways. Considering that, it would be better to simply exclude them from sanitizer builds. This CL does not re-enable disabled tests. I'll do that after this CL is landed, one-by-one, so that we can handle the problem separately in case of unexpected failures on dbg/rel bots. Bug: 1057868 Test: build interactive_ui_tests on asan flag Change-Id: I69c22ab575d95d2ba500556ae81ab603fde44b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099328Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#749747}
-
Clark DuVall authored
bundletool was updated with the fix needed for shared_resources=true. Bug: 1033098 Change-Id: I7b6f540a02d9ab4335e002726d83555d01655c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099285 Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#749746}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3181426885c3..8297869795cb git log 3181426885c3..8297869795cb --date=short --first-parent --format='%ad %ae %s' 2020-03-12 jacktfranklin@chromium.org Generate `protocol.d.ts` files in devtools-frontend 2020-03-12 taoalpha@google.com Fix “open in new tab” for URLs with newlines 2020-03-12 tvanderlippe@chromium.org Add missing license headers Created with: gclient setdep -r src/third_party/devtools-frontend/src@8297869795cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9cb1aeaacf799fd6f182c0e353d03ec9970edd93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100579Reviewed-by:
-
Oksana Zhuravlova authored
This reverts commit 756820dd. Reason for revert: content_browsertests failing on https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81901, https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/64935, https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/100660 Original change's description: > Ensure UI Automation GetFocus reaches focused node in web content > > AXPlatformNodeDelegate::GetFocus() returns the node within the called > node's subtree that currently has focus. When an element in web content > has focus, and a delegate in Views is asked for focus, that delegate can > only reach as far as the web content root. Calling GetFocus() again on > the web content root ensures that the platform API returns the currently > focused node. > > Bug: 928811 > Change-Id: Ice47eed0a8ea4281beb48624942ac2428fb1950f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099162 > Reviewed-by: Ian Prest <iapres@microsoft.com> > Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#749386} TBR=kbabbitt@microsoft.com,iapres@microsoft.com Change-Id: I824a736750c54aaa81e9ef0bf6d8e23d41089a25 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 928811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100892Reviewed-by:
-
Friedrich Horschig authored
The new error state TOO_MANY_PASSWORDS_AND_QUOTA_LIMIT allows users to start a check in the already existing state TOO_MANY_PASSWORDS until the quota is exceeded. Screenshots are available at https://crbug.com/1047726#c64 Bug: 1047726 Change-Id: Ibf8dace79cbd612701e5e6b35fea473fc8be797b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098687 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
Eugene But authored
This histogram existed to check if specific condition still occurs, and that condition still occurs. Bug: 1059796 Change-Id: I8d52b04b6fafa274c0ced21fe619608ef0069e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095351 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#749742}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/7e857092052e..7e366320bba5 git log 7e857092052e..7e366320bba5 --date=short --first-parent --format='%ad %ae %s' 2020-03-12 bclayton@google.com Update Marl to 64d123947 2020-03-12 bclayton@google.com VkImage: Implement BC7 texture format 2020-03-11 bclayton@google.com Update Marl to 94a361cf0 Created with: gclient setdep -r src/third_party/swiftshader@7e366320bba5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1058107 Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic6e430df23520a2cbca93671c22edecb2e5fd7b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100578Reviewed-by:
-
David Van Cleve authored
While field trial testing configs' _experiment_ names don't matter, I just learned it's necessary that their _study_ names match their server-side configurations. This change renames the ReducedReferrerGranularity field trial testing config entry to LimitReferrerGranularity in order to meet this requirement. Change-Id: I2403ebc3b20919639b875553d588209e46ed6b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036663Reviewed-by:
-
Christos Froussios authored
Bug: 1047726 Change-Id: I090fa23b5d3b4edc94cd9b40b5385be6a01fe14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100971 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
-
