GitLab

a NaCl page reload / surf-away regression.
BUG=NaCl ppapi audio proxy
TEST=native_client/tests/ppapi_example_audio

Review URL: http://codereview.chromium.org/6300011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72099 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70327
TEST=none

Review URL: http://codereview.chromium.org/6268009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72098 0039d316-1c4b-4281-b951-d872f2087c98

BUG=47955,69883
TEST=When a tab is closed with a download in-progress and Task Manager displayed, the network activity is reflected in the Browser resource's Network total.

Review URL: http://codereview.chromium.org/6383002
Patch from James Weatherall <wez@chromium.org>.

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/6341006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72096 0039d316-1c4b-4281-b951-d872f2087c98

BUG=47955,69883
TEST=When a tab is closed with a download in-progress and Task Manager displayed, the network activity is reflected in the Browser resource's Network total.

Review URL: http://codereview.chromium.org/6383002
Patch from James Weatherall <wez@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72095 0039d316-1c4b-4281-b951-d872f2087c98

A NULL |result| should DCHECK, but not crash.  This is a short term solution to the top-crasher, will still DCHECK for devs while a longer term fix is determined.

BUG=68783, 69833
TEST=none

Review URL: http://codereview.chromium.org/6275011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72094 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6352003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72093 0039d316-1c4b-4281-b951-d872f2087c98

being notified after the object has been destroyed.

BUG=69441
TEST=none

Review URL: http://codereview.chromium.org/6299014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72092 0039d316-1c4b-4281-b951-d872f2087c98

  grep --include="*.gyp*" -nr -F "ppapi_egl" .

However this library causes NaCl to require third_party/mesa which relative to NaCl is large.

This CL moves the definition of this static library from ppapi to the lib/gl directory under ppapi so that PPAPI users are not forced to DEPS in mesa.

Review URL: http://codereview.chromium.org/6342012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64800
TEST=Verify that the checkbox for the Mac address book appears in autofill options.
Review URL: http://codereview.chromium.org/6278012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72089 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6264007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72088 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6354010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72087 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=run out/Debug/views_examples, it should work as before.

Review URL: http://codereview.chromium.org/6377004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72086 0039d316-1c4b-4281-b951-d872f2087c98

BUG=56415,43716
TEST=Verify language & settings panel functionality on dom-ui settings window.
Review URL: http://codereview.chromium.org/6296017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72085 0039d316-1c4b-4281-b951-d872f2087c98

Fix crash in PluginService if the keys are null.  It's still unclear why this is happening now as opposed to before.  This change just fixes the crash in the meantime.

BUG=70317
Review URL: http://codereview.chromium.org/6313007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72083 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72079 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r72069.

The ARM build gave this compiler warning:
cc1plus: warnings being treated as errors
third_party/WebKit/Source/WebCore/platform/graphics/FontCache.cpp: In function 'const WTF::AtomicString& WebCore::alternateFamilyName(const WTF::AtomicString&)':
third_party/WebKit/Source/WebCore/platform/graphics/FontCache.cpp:139: error: 'timesNewRoman.unstatic.3258' may be used uninitialized in this function
make: *** [out/Release/obj.target/webcore_platform/third_party/WebKit/Source/WebCore/platform/graphics/FontCache.o] Error 1

TBR=jorlow

Review URL: http://codereview.chromium.org/6248012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72078 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72076 0039d316-1c4b-4281-b951-d872f2087c98

1) Change style to match style guide.
2) Use "git svn info" so we can use the same parsing code for
   both git and svn.

TEST=ran manually

Review URL: http://codereview.chromium.org/6263009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72074 0039d316-1c4b-4281-b951-d872f2087c98

It is returning Unicode so it should be a string16.
The callers want a string16 anyway.

TEST=compiles

Review URL: http://codereview.chromium.org/6306006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72073 0039d316-1c4b-4281-b951-d872f2087c98

can happen if we try to edit a profile that is in the process of being removed,
but for which we haven't been notified that it's removed yet.

BUG=69327
TEST=none

Review URL: http://codereview.chromium.org/6323012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72071 0039d316-1c4b-4281-b951-d872f2087c98

fails flakily.

TBR=isherman
BUG=70323
TEST=none

Review URL: http://codereview.chromium.org/6351012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72070 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jorlow

Review URL: http://codereview.chromium.org/6300010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72069 0039d316-1c4b-4281-b951-d872f2087c98

As of today, we have dedicated chromium trybots that can run the sync
integration tests, but it requires developers to explicitly send try
jobs to these bots via the --bot switch.

Now that the sync trybots are stable, it is time to make this process
automatic by adding a PRESUBMIT.py file to chrome/browser/sync, that
adds the sync trybots in addition to win, mac and linux to the list of
preferred trybots.

This patch adds such a PRESUBMIT.py file, that includes
win_sync, mac_sync and linux_sync to the list of preferred trybots.

BUG=70311
TEST=modify something under chrome/browser/sync and do a "git try" or "gcl try"

Review URL: http://codereview.chromium.org/6275010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72067 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72065 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69135
TEST=none
TBR=gavinp


Review URL: http://codereview.chromium.org/6300009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72063 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6380006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72062 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70149
TEST=None

Review URL: http://codereview.chromium.org/6349007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72061 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=<this is the test>

Review URL: http://codereview.chromium.org/6338013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72059 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6272013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72058 0039d316-1c4b-4281-b951-d872f2087c98

button.

BUG=69145
TEST=none

Review URL: http://codereview.chromium.org/6241010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72057 0039d316-1c4b-4281-b951-d872f2087c98

BUG=67716
TEST=none

Review URL: http://codereview.chromium.org/6269014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72056 0039d316-1c4b-4281-b951-d872f2087c98

collect extra information (driver_vendor, gl_renderer, etc.) on Mac/linux.
Note that this CL takes some code from rlp's long outstandingCL (with her
permission).

BUG=49579
TEST=unittest

Review URL: http://codereview.chromium.org/6346007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72055 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6296018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72054 0039d316-1c4b-4281-b951-d872f2087c98

instance with resources and has most callers retrieve the dispatcher
according to the appropriate instance. This isn't hooked up to anything yet.

This changes some PPB_Flash interface methods to use PP_Bool.

The most challenging part of the change is in the plugin_var_tracker which
now needs to track which dispatcher each var object came from, and remap var
IDs since each renderer will be generating var IDs in its own space, which
will likely overlap. A similar system will need to be done for resources
which is not implemented yet.

I added some null checks in audio_impl because audio_ can be NULL in some
cases when using the trusted API. I discovered this when testing NaCl for
this patch.
Review URL: http://codereview.chromium.org/6282007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72053 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6339007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72051 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72050 0039d316-1c4b-4281-b951-d872f2087c98

incorrectly clearing the selection.

BUG=62872
TEST=none

Review URL: http://codereview.chromium.org/6275009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72048 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6255007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72047 0039d316-1c4b-4281-b951-d872f2087c98

pidfile.

SPDY frames were leaking when used with DataFrame and OutputList.
HUP signal will now reopen the log file.
Remote IP obtained for 'forward-ip-header' was incorrect.
Added connection idle timeout.
Fixed up pidfile handling.
Flip server now creates and locks a pid file.

Patch from Kevin Lindsay: kelindsay@gmail.com

BUG=none
TEST=self

Review URL: http://codereview.chromium.org/6332010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72046 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6340008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72045 0039d316-1c4b-4281-b951-d872f2087c98