GitLab

Bug: 717696
Change-Id: I454fe19234a10f0665399cc5f3cae0d4abe1d471
Reviewed-on: https://chromium-review.googlesource.com/1011408Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550777}

https://webrtc.googlesource.com/src.git/+log/3ef3bfc2aafa..3acffc3b1668

$ git log 3ef3bfc2a..3acffc3b1 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:811683,chromium:None,chromium:831093,chromium:None,chromium:None,chromium:b/77825904,chromium:None,chromium:None,chromium:None,chromium:831996,chromium:None,chromium:796112,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:827917


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ib12df502703e5c0d6c0d1dcb935f69f0166fa0be
Reviewed-on: https://chromium-review.googlesource.com/1012762
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#550776}

https://pdfium.googlesource.com/pdfium.git/+log/996c93068bfc..b71d24c1affe

$ git log 996c93068..b71d24c1a --date=short --no-merges --format='%ad %ae %s'
2018-04-13 thestig Patch lcms to mark data structures as const.
2018-04-13 npm Fix integer overflow in CPDF_Font::FallbackFontFromCharcode
2018-04-13 hnakashima Add test for circular CPDF_Function::Load().
2018-04-13 thestig Add CPDF_ColorState::SetPattern().
2018-04-13 thestig Get rid of CPDF_Color::GetColorSpace().
2018-04-13 dsinclair Add CPDF_Metadata unittests
2018-04-13 dsinclair Hide XML parsing inside CXFA_XMLLocale
2018-04-13 dsinclair Move SharedForm check to CPDF_Metadata class

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:831583,chromium:830221


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I5cd3fc28ca70459b9d57cf025cd02fba8e5d81cc
Reviewed-on: https://chromium-review.googlesource.com/1013045
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#550775}

WebRTC is redesigning the thread model in PortAllocator and its
subclasses. The new threading assumption is that every method of
PortAllocator (including the destructor) must be called on the same
thread after Initialize is called. This allows a PortAllocator subclass
to be constructed and configured on one thread, and passed into an
object that uses it on a different thread.

The above new assumption should be reflected in Chromium objects that
directly use the WebRTC implementation of PortAllocator.

Bug: 832310
Change-Id: I3610a714320f6e230e4e3e15c1101bcafbcc175c
Reviewed-on: https://chromium-review.googlesource.com/1011257Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Qingsi Wang <qingsi@google.com>
Cr-Commit-Position: refs/heads/master@{#550774}

Conditionally disables this test on dbg win.

BUG=832947
TBR=mfoltz@chromium.org
NO-TRY=True

Change-Id: I96ed4a788378adc0b89a17eae03d0a9f1d0ffb81
Reviewed-on: https://chromium-review.googlesource.com/1013204Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550773}

ContextLost_WebGLBlockedAfterJSNavigation
ContextLost_WebGLUnblockedAfterUserInitiatedReload
on Android Nvidia (Nexus 9 and Shield TV)

BUG=832886
TBR=kbr@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I0b945fe5c02824ae92524d7592d899a9f1bac504
Reviewed-on: https://chromium-review.googlesource.com/1012982
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550772}

This patch adds a new tab to the net-internals page, which shows the
current contents of the Reporting cache.  This includes a section on any
queued reports, and a section showing any origins that we've received
Reporting headers from.

Bug: 829353
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I496d360fb1cf0f5e6c626e72415d8a624a25151b
Reviewed-on: https://chromium-review.googlesource.com/998752
Commit-Queue: Douglas Creager <dcreager@google.com>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550771}

Update the orientation of the dropdown when the root view is
updated.

Bug: 823262, 828759
Change-Id: Iaa5f8bff123afaf0674e93f67f223f9a3156f840
Reviewed-on: https://chromium-review.googlesource.com/1012471Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550770}

Changes from first reland attempt at https://crrev.com/c/1011287:
- fix an additional source of flakiness in ChromeOS login tests

Changes from original attempt at https://crrev.com/c/999182:
- fix flakiness in two additional ChromeOS login tests
- fix CSP WPT tests to not depend on ordering between iframe's onload
  and postMessage - see https://crbug.com/832319.

Previously, we sent the IPC to forward a cross-process postMessage
immediately.  This caused a behavioral difference from the
same-process case where the postMessage is always scheduled.  Namely,
in a scenario like this:

  frame.postMessage(...);
  doSomethingThatSendsIPCsToFrame(frame);

the IPCs from JS following the postMessage would've been ordered
incorrectly, causing |frame| to see their side effects after the
postMessage dispatch in the cross-process case, whereas they would be
seen before the postMessage dispatch in the same-process case.  One
example of this is frame.focus(), and another is a frame element
onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after
a postMessage dispatched from an inline script while the frame was
still loading.

To resolve these ordering concerns, this CL changes cross-process
postMessage to do a PostTask on the sender side before sending the
message to the browser process.  This improves the current state of
the world, but does not yet achieve a perfect match for the IPC
ordering in the same-process case - see discussion on the bug.

Bug: 828529
Tbr: dcheng@chromium.org
Change-Id: If2cc6591db31471adff0d84ec0b689905e21cdf1
Reviewed-on: https://chromium-review.googlesource.com/999182Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Original-Original-Commit-Position: refs/heads/master@{#550284}
Reviewed-on: https://chromium-review.googlesource.com/1011287
Cr-Original-Commit-Position: refs/heads/master@{#550621}
Reviewed-on: https://chromium-review.googlesource.com/1012472
Cr-Commit-Position: refs/heads/master@{#550769}

It looks like when we're computing the number of static
initializers on mac we're still assuming a 32-bit word and not the
64-bit words that we actually use, and so we mis-report the
number of initializers as twice what they actually are.

All of this perf expectation code needs to be ripped out and
replaced with some dumb static checks, but for now, this CL
just updates the expected number from 2 (the correct number) to
4, and updates the checksums in the json file to get the presubmit
to pass.

BUG=831951, 832854
TBR=avi@chromium.org, wolenetz@chromium.org, thakis@chromium.org
NOTRY=true
NOTREECHECKS=true

Change-Id: Ie6de49af3cc1443b8acc36ce80946ea50e5a76ab
Reviewed-on: https://chromium-review.googlesource.com/1013205
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550768}

Bug: 716490
Change-Id: I990f15d48f1556464d5558e2d8398f6b0c32f250
Reviewed-on: https://chromium-review.googlesource.com/1008824Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550767}

This code used to assume that the local_time_ was equivalent to the
active time, but that isn't true. Active time is local time - start
delay, so the start delay (time_offset_) shouldn't be removed when
converting local_time_ to 'real' time.

Bug: 824782
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3cc570c4054843bf31cdba0f58917f4566ccd8b1
Reviewed-on: https://chromium-review.googlesource.com/1008062
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550766}

Command-line switches that should be independent of policy/flag
settings are now cached in UserSessionManager, so they're not lost
when a different set of command-line switches is applied.
Currently, the only such persistent switch is --profile-requires-policy
set by UserCloudPolicyManagerChromeOS.

The long-term plan is to further develop this mechanism in a way to make
manual re-parsing of switches (see e.g.
|KioskAppManager::GetSwitchesForSessionRestore|) unnecessary. This will
be done in a follow-up CL.

      and manual: Enable IsolateOrigins user policy and
      ephemeral_user_enabled device policy, sign-in into a user account.

Bug: 831460
Test: browser_tests --gtest_filter=SiteIsolationFlagHandlingTest*
Change-Id: I1276b20018b0c4305309123e46dd3411aeda5ac0
Reviewed-on: https://chromium-review.googlesource.com/1010343
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550765}

This reverts commit 5cf8deb5.

Reason for revert:

After cleaning up the unused Xcode versions and iOS runtime versions, disk usage has dropped to around 80%. Putting ios-simulator back to CQ.

Original change's description:
> [cq.cfg] Make ios-simulator 100% experimental
> 
> Unfortunately this builder seems to have a recipe bug with
> analyze and the way it runs one of the test suites.
> 
> R=​jchinlee@chromium.org, tandrii@chromium.org
> TBR=jbudorick@chromium.org
> 
> Bug: 832483
> Change-Id: I64d774535b52a92981a597d6c23e45659ae6aae1
> Reviewed-on: https://chromium-review.googlesource.com/1011825
> Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550512}

TBR=iannucci@chromium.org,jchinlee@chromium.org,tandrii@chromium.org,jbudorick@chromium.org

Change-Id: Ib83e5589367de8b0d698dd614f5a3ddeaf56aff8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 832434
Reviewed-on: https://chromium-review.googlesource.com/1012819Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550764}

Using wpt-import in Chromium 17c449d1.
With Chromium commits locally applied on WPT:
303956b6 "Enable WPT tests for the Generic Sensor classes"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15537

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=danyao

No-Export: true
Change-Id: I25b07be14844495fbc2d4137ea73ae71d4553734
Reviewed-on: https://chromium-review.googlesource.com/1012738
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550763}

Changes:
1. Create a window container right above wallpaper container. The app
   list window will be put in this container in tablet mode to be shown
   as a desktop/home.
2. Change the properties of app list in tablet mode: opacity, background
   blur, avoiding scroll events, etc.
3. Avoid closing the app list in tablet mode with activities like
   launching app, window focus change, back button, accelerators, etc.
4. Change the behavior of home button in tablet mode to minimizing all
   windows. Also it will exit overview mode and split view mode if they
   are on.
5. Listen to tablet mode and overview mode events to modify app list
   properties.

BUG=831711

Change-Id: I338d8365100906b0c409c763d2c97c32abaf5918
Reviewed-on: https://chromium-review.googlesource.com/949768
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550762}

Spec:
https://drive.google.com/corp/drive/folders/0B_2Uyb2Rhx2ObU5VTFJVWHR2WW8

Bug: 800945
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9035fb027b998a71af6312a4365c5c85193dbcec
Reviewed-on: https://chromium-review.googlesource.com/982818Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550761}

Conditionally disables this test on OS_WIN.

BUG=832885
TBR=rdevlin.cronin@chromium.org
NO-TRY=True

Change-Id: Ic2a069cfdc4a07d42cf06af42919c7a20947c278
Reviewed-on: https://chromium-review.googlesource.com/1012994Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550760}

This parameterizes AutofillInteractiveTest and subclasses to run with
the feature either enabled or disabled. The goal is to help us
ensure it's to enable the feature for Canary/Dev.

I'm investigating if there are other tests that should be affected by
the feature, and will update them in follow up CLs.

Bug: 768881
Change-Id: I13b0bf654374728749ce7c5b3829bc02ff386cd3
Reviewed-on: https://chromium-review.googlesource.com/1005888
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550759}

When an OOPIF is created and then quickly deleted, it is possible for
ChromeDriver to be still working on initializing the target when the
target is detached. This causes ChromeDriver to crash by accessing
memory that has already been freed. This CL fixes the issue by locking
the data structure while it is still in use, to prevent deallocating the
memory too early.

Bug: chromedriver:2354
Change-Id: I790ed6eb01ca7b09b699a95b6178426b7290a542
Reviewed-on: https://chromium-review.googlesource.com/1005880Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550758}

Reland "Use the internal copy of gvr_shim in unofficial builds if the internal repository is available."

This change was originally reverted because the included prebuilts
caused crashes in component builds. The prebuilts included with this
change have been updated to fix the component build problem.

Original commit message:
> Use the internal copy of gvr_shim in unofficial builds if the internal repository is available.
>
> Otherwise, link against a new set of gn-built prebuilts.
>
> Bug: 749784
> Change-Id: Id96666125226b3400bb92c31e5c97a7c2a64624d
> Reviewed-on: https://chromium-review.googlesource.com/947577
> Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Brandon Jones <bajones@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#546707}

Bug: 749784
Change-Id: I1c7c8c1dc1f96228c81b43d40148be7a54dfcae2
Reviewed-on: https://chromium-review.googlesource.com/1008618Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550757}

https://chromium.googlesource.com/angle/angle.git/+log/56c8577b4dbf..a912046dc3e1

$ git log 56c8577b4..a912046dc --date=short --no-merges --format='%ad %ae %s'
2018-04-12 lucferron Vulkan: DrawElements with line loops client side memory support
2018-04-10 lucferron Vulkan: Lineloops edge base bugfix and new tests
2018-04-12 jmadill ImageIndex: Consolidate layer/cube face.
2018-03-20 courtneygo Add json build file generation
2018-04-09 lfy GLES1: Built-in matrix operations

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: Ifbb5896b025022f9abc261f14ccce9355965fbcd
Reviewed-on: https://chromium-review.googlesource.com/1011263Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#550756}

An abort signal before a lock is granted causes the promise returned
by navigator.locks.request() to reject. But if the signal comes in
after the lock is granted, the signal should not change the promise
behavior (it resolves with the result of the callback function).

The existing test was insufficient to catch a bug here; fix the bug
(no-op the abort if it comes in too late) and improve test coverage.

Bug: 828990
Change-Id: I1b056a05ba49e284fb8eea76bd9652a904232c60
Reviewed-on: https://chromium-review.googlesource.com/999828Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550755}

We are working to enable full guard regions for WebAssembly memories on all
64-bit platforms, whereas previously they were only used when the WebAssembly
trap handler feature was used. Since each memory + guard region requires 8 GiB
of address space, the original 16 GiB limit is no longer sufficient. This CL
makes the behavior of having a higher hard limit on the address space and a
lower soft limit that is raised when needed to allocate a WebAssembly memory
available even when not using trap handlers.

Bug: chromium:828499, v8:7619
Change-Id: I31a279176b91bf18be140a15bf2f64ae62debba1
Reviewed-on: https://chromium-review.googlesource.com/1000334Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Eric Holk <eholk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550754}

Bug: 831798
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id27d20963ae03a92aff7ae6d5e0fb6ab04da0773
Reviewed-on: https://chromium-review.googlesource.com/1008602
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550753}

It turns out "mac" and "sierra" in the same expectation means all
macOS, not just Sierra.

Tbr: kainino@chromium.org
Bug: 526748
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I26b9849ba342fd058b5568739034c754ab75c842
Reviewed-on: https://chromium-review.googlesource.com/1012518Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550752}

The previous checkin for "996594:Adding SupportsDX12 and SupportsVulkan to UMA histogram
for the Windows platform" did not quit the GPU process after the job is complete.

base::RunLoop().QuitCurrentWhenIdleDeprecated() is added to the end of the function of the second
GPU process to fix this issue.

BUG=832596
TEST=manual,Chrome task manager
R=zmo@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ifadb24d39b24a9a5a6cdc0c33e66bcfc42d5a5a7
Reviewed-on: https://chromium-review.googlesource.com/1012595Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550751}

Reordering native views causes multiple changes to the window tree.
This CL instantiates a ScopedPauseOcclusionTracking in
DesktopNativeWidgetAura to ensure that occlusion is recomputed after
the reordering is done rather than after each individual change.

Note: It has been discussed that occlusion should be recompute once
per frame if the window tree has changed since the last frame, rather
than in direct response to window tree changes. That would fix this
issue. However, it is a more involved change, so having this simple
fix in the meantime is still relevant. https://crbug.com/832645

Bug: 829918, 832645
Change-Id: I043be75b53ee10683f8bd5bdbe298bdbcf54a987
Reviewed-on: https://chromium-review.googlesource.com/1010602Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550750}

TBR=juncai@chromium.org

Bug: 769401
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I8c3f9956b131c171fc35e5fdb78f5f9ec53e2cd1
Reviewed-on: https://chromium-review.googlesource.com/1012445Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550749}

BUG=823634
BUG=b/74621390
TEST=Manual tests with WM test app. Exo unit tests pass.

Change-Id: I0e0595fc62a50498790fd99144b547a88d1d9ba6
Reviewed-on: https://chromium-review.googlesource.com/996401
Commit-Queue: Garfield Tan <xutan@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550748}

This view controller will be used as a base view controller for Download
Manager presentation. Download Manager must be presented under toolbar
view, so using BVC as a base view controller does not work.

This CL replaces BrowserContainerView with BrowserContainerViewController
which should not cause any functional changes.

Bug: 818264
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I93d66906c671a8647589db8d9717ab2dcd26cd51
Reviewed-on: https://chromium-review.googlesource.com/981684Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550747}

ChildProcessSecurityPolicy can be used on any thread.
This CL moves the security policy check to UI thread, so that all
the content/ dependencies in BeginResourceDownload() are removed()

BUG=803135

Change-Id: I97ecb0788f099d010627599275553ad268404345
Reviewed-on: https://chromium-review.googlesource.com/1008869Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550746}

It extracts the statically accessible interface of MessageLoop (through
MessageLoop::current()) from its core interface.

See message_loop_current.h for more details.

Note: At first it seemed like the easiest approach would have been to
introduce MessageLoopInterface as the public interface which MessageLoop
implements (and only return an interface pointer from current()). But
that doesn't work once we get in MessageLoopForUI (and ForIO) territory
as it would need to both be a MessageLoop (MessageLoop is-a
MessageLoopInterface) and a MessageLoopInterfaceForUI
(MessageLoopInterfaceForUI is-a MessageLoopInterface) and we have
diamond inheritance... This thus enforces the current approach of
MessageLoopCurrent being a separate class that merely represents a
MessageLoop*. I think this is cleaner overall as well because it will
allow must callers to include solely message_loop_current.h and
ultimately have very few files including the message_loop.h impl (I'll
also move MessageLoop::current() to MessageLoopCurrent::Get() in a
follow-up).

This CL adds many temporary implicit back-and-forth casts. After landing
this, I plan to script migrations of the actual usage to the proper
types with the goal of eventually disconnecting the two APIs (so that
few callers actually need message_loop.h anymore and it's obvious what a
replacement of MessageLoop needs to provide statically and/or what we
need to deprecate before making such a move).

This CL is a contract with the reviewer that I will follow-up with many
TBRed CLs for trivial mass renames.

Even though the implicit casts might not seem like this CL does much
overall, it still required 25 precursor CLs (ref. crbug.com/825327) and
landing this CL locks in those gains.

Removed the two TestWatchingFromBadThread tests which are irrelevant now
that going through MessageLoopForIOCurrent enforces usage on same thread
via a ThreadChecker.

NOPRESUBMIT=True (calls to deprecated MessageLoop methods)

Bug: 825327
Change-Id: Ie66a394d02a162289aabe155436a583bfb024e8d
Reviewed-on: https://chromium-review.googlesource.com/957760
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550745}

Add a kill method to ChildProcessConnection to force kill the service.
Also add a new field that keeps track of whether the process is killed
intentionally. Add a junit test to verify this.

Bug: 693484
Change-Id: Iaae9e82e611be97b9694fc8d67b23ba090220840
Reviewed-on: https://chromium-review.googlesource.com/1003635Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550744}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/b5d17629393d..c23684514c93

$ git log b5d176293..c23684514 --date=short --no-merges --format='%ad %ae %s'
2018-04-13 ihf Revert "chromeos_config: add bettyvirgl builder."

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:807873


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ic52798de6b856ce362f5d1ed42b0eef29e79395a
Reviewed-on: https://chromium-review.googlesource.com/1012598
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#550743}

In r535735 we made WebView responsible for showing an overlay (like a
sad tab) when the WebContents has crashed. When the overlay was showing
we hid the NativeViewHost to be safe (using SetVisible(false)).
This had the unintended consequence of closing modal dialogs such
as a cookie dialog or dangerous download warning dialog.

In testing, it seems safe to not actually hide |holder_|, the
NativeViewHost. The overlay is absolute-positioned on top of it,
and it's not possible to focus the WebContents. This was more
or less true in the previous Sad Tab implementation where it
was displayed in a Widget on top of the WebView instead of as a
child View.

Bug: 826248, 821312
Change-Id: I748afeff1ac8d7e1fa18ccafe709706f803ae6cc
Reviewed-on: https://chromium-review.googlesource.com/1008621Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550742}

Change-Id: I459baac99f1b4d94e8f1b96ddfd3c66a561a80db

Bug: 817377
Change-Id: I459baac99f1b4d94e8f1b96ddfd3c66a561a80db
Reviewed-on: https://chromium-review.googlesource.com/998190Reviewed-by: Luke Z <lpz@chromium.org>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550741}

DrawingBuffer::TransferToStaticBitmapImage() is the common function shared by
commit() and transferToImageBitmap() in OffscreenCanvas WebGL, as well as the
VR display frame submission. The two OffscreenCanvas APIs miss a release
callback; as a result, release_callback populated by image extraction function
PrepareTransferableResourceInternal is invoked very early with a "lost
resource" signal. On the other hand, VR display frame submission has correctly
implemented a release callback that is releasing previous frame whenever there
is a new frame coming in.

This is a very likely reason to contribute to the flakiness of these two
OffscreenCanvas APIs, while the VR display is working well.

This CL adds a release callback to OffscreenCanvas commit(). I will follow-up
with another CL that adds release callback to OffscreenCanvas
transferToImageBitmap() and another CL that enables the relevant gpu
pixel tests.



Bug: 809227, 735228
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ia6e2c613de416f1e6e2a0f1c833d9e82e47fed4f
Reviewed-on: https://chromium-review.googlesource.com/1010466Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550740}

https://skia.googlesource.com/skia.git/+log/c6c5eade823a..21dfd846724a

$ git log c6c5eade8..21dfd8467 --date=short --no-merges --format='%ad %ae %s'
2018-04-13 angle-skia-autoroll Roll third_party/externals/angle2/ ed8d5ec73..cc1293775 (1 commit)
2018-04-12 liyuqian Limit our IsBadForDAA for stroke width > 0 and <= 2
2018-04-12 csmartdalton ccpr: Actually blacklist ANGLE
2018-04-12 angle-skia-autoroll Roll third_party/externals/angle2/ 14f4817c4..ed8d5ec73 (8 commits)
2018-04-12 reed can't abort looper loop, as saveCount won't be balanced
2018-04-12 egdaniel Don't create lazy proxys if their width/height is greater than max tex size
2018-04-12 robertphillips Actually generate the gm images on the DDL1 bot
2018-04-12 caryclark son of path is rect bug
2018-04-12 ethannicholas workaround for buggy macOS GLSL shader compiler
2018-04-12 egdaniel Delete getRenderTargetHandle call on SkSurface.
2018-04-12 reed check for non-finite values output by clipper
2018-04-12 brianosman Fail fast when trying to make a texture that's too large
2018-04-12 djsollen Include shadow ops in the debugger.
2018-04-11 liyuqian Reland "Add private fIsBadForDAA bit to SkPath"
2018-04-12 reed add conservative bounds to raster tiling
2018-04-12 reed always clear the looper when we're unrolling it, to not confused devices
2018-04-11 robertphillips Disable CCPR and the small path renderer on DDL1 bot
2018-04-12 caryclark another rect is path fix
2018-04-11 robertphillips Add SK_SUPPORT_LEGACY_BACKEND_OBJECTS
2018-04-11 csmartdalton Implement Sk2f Load2
2018-04-11 csmartdalton ccpr: Blacklist ANGLE again
2018-04-11 robertphillips Allow SkImage_Gpu to fail some requests in DDL mode
2018-04-11 cwallez update_meta_config: Use new LUCI optional GPU trybot on Windows
2018-04-11 csmartdalton Implement Sk4f min/max
2018-04-11 liyuqian Remove obsolete comment
2018-04-11 benjaminwagner Upgrade PixelC and NexusPlayer OS.
2018-04-12 angle-skia-autoroll Roll third_party/externals/angle2/ 2dadd1d08..14f4817c4 (2 commits)
2018-04-11 caryclark fix bm gm
2018-04-12 mtklein skcms→1654786 concat gamut transform matrices together

Created with:
  roll-dep src/third_party/skia
BUG=chromium:824145,chromium:821353,chromium:818693,chromium:820245,chromium:820470,chromium:824145,chromium:815092


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=borenet@chromium.org

Change-Id: Ic83a9e3addd0c3593736a5bd03a4b4b2d37b7c51
Reviewed-on: https://chromium-review.googlesource.com/1011738Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Eric Boren <borenet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550739}

At this point almost all callbacks were removed from CRWWebDelegate and
the only remaining callbacks are related to Native Content size (moved in
this CL) and external app launching (will be moved to PolicyDecider).

CRWNativeContentProvider is still heavily used for features like NTP,
Old Download Manager, Error Pages, Reading List. It will take more time
to get rid of Native Content Provider, so size callbacks can temporary
live there.

Bug: 674991
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia5c6d565a116c858f3fe5fefa4964364144a8279
Reviewed-on: https://chromium-review.googlesource.com/1010822Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550738}