GitLab

> Add UMA stats for ExtensionCache
> 
> Reported metrics:
> - number of extensions in cache
> - size of cache on disk
> 
> BUG=316371
> TEST=manual
> 
> Review URL: https://codereview.chromium.org/148013004

This causes compile failures on ChromeOS. See comments on original CL for
details.
TBR=dpolukhin@chromium.org

Review URL: https://codereview.chromium.org/139173009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247822 0039d316-1c4b-4281-b951-d872f2087c98

Event-targeters (e.g. wm::EasyResizeWindowTargeter) now do the necessary work
for allowing a window to receive events outside of its bounds. So these methods
on aura::Window are no longer necessary.

BUG=318879
R=ben@chromium.org

Review URL: https://codereview.chromium.org/133873004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247821 0039d316-1c4b-4281-b951-d872f2087c98

ui/gfx/ depended on net/ for two things, SortedDisplayURL and gfx::ElideUrl().
SortedDisplayURL was not used by anything other than its own unit test and is
deleted in this patch.  ElideUrl() is only used from
chrome/browser/ui/(gtk|cocoa|views), so this patch moves the functionality up
to chrome/browser/ui/elide_url.(h|cc) and the unit test to
chrome/browser/ui/tests/elide_url_unittest.cc.

R=sky

Review URL: https://codereview.chromium.org/143463006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247820 0039d316-1c4b-4281-b951-d872f2087c98

BUG=337122

Review URL: https://codereview.chromium.org/137263015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247819 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316168

Review URL: https://codereview.chromium.org/131003007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247818 0039d316-1c4b-4281-b951-d872f2087c98

These warning showed up for me when trying to build
chromium using the gcc 4.8 ARM cross compiler in
Ubuntu/saucy.

Review URL: https://codereview.chromium.org/129683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247817 0039d316-1c4b-4281-b951-d872f2087c98

> Cache feedback reports to disk in case of send failure.
> 
> R=zork@chromium.org
> BUG=249853
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246992
> 
> Review URL: https://codereview.chromium.org/141433011

This introduced a race condition picked up by the TSAN bots.

BUG=339326
TBR=rkc@chromium.org

Review URL: https://codereview.chromium.org/149993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247816 0039d316-1c4b-4281-b951-d872f2087c98

I looked through the cs.chromium.org results for

codedoutputstream -file:.pb.cc -file:.java -file:.pb.h

but don't see any other instances of this exact problem in
non-test code (and in fact, some with similar looking
constructs: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/protobuf/src/google/protobuf/io/coded_stream_unittest.cc&l=320 )

R=zea@chromium.org
BUG=338962

Review URL: https://codereview.chromium.org/149073006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247815 0039d316-1c4b-4281-b951-d872f2087c98

due to new static initializers in gl_bindings_autogen_gl.cc

> Ensure GL initialization only happens once, and provide common init path
> 
> Currently tests initialize GL by calling into methods that should be
> internal to the gl bindings code. Instead, everyone should go through
> GLSurface::InitializeOneOff.
> 
> Also GLSurface::InitializeOneOff early outs if it was already called,
> leading to a pattern of initializing GL all over the place just in case
> and not having a clear idea of where it should be set up. Instead, DCHECK
> that it is not called more than once, and move calls to this method to
> be during process startup for unit test suites instead of mid-test.
> 
> This adds two test variants of InitializeOneOff for tests to call, that
> set up OSMesa or Mock GL bindings, via GLSurface::InitializeOneOff.
> 
> R=piman, sievers
> BUG=270918
> 
> Review URL: https://codereview.chromium.org/135213003

TBR=danakj@chromium.org

Review URL: https://codereview.chromium.org/149953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247811 0039d316-1c4b-4281-b951-d872f2087c98

BUG=230018
TEST=manual tests on Peppy

Review URL: https://codereview.chromium.org/144983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247806 0039d316-1c4b-4281-b951-d872f2087c98

Previously it was misusing subprocess.Popen such that no output
was ever captured from checkperms.py.

Also, changed the check to use input_api.subprocess instead of importing subprocess.

R=maruel@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/143013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247805 0039d316-1c4b-4281-b951-d872f2087c98

Dependencies added in the range 247769-247777, I suspect 247775, a blink roll,
since that caused this last time, and was since reverted.

BUG=None
NOTRY=true
NOTREECHECKS=true
TBR=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/149443010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247802 0039d316-1c4b-4281-b951-d872f2087c98

Now that Aura is required for Windows, we can safely delete the non-Aura
mock theme code and simplify the logic for the other cases.

R=jam@chromium.org
BUG=330735

Review URL: https://codereview.chromium.org/139903015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247799 0039d316-1c4b-4281-b951-d872f2087c98

This was modified in r247446 to cover some new leaks which apperaed.
The modification narrowed the suppression which has made some old leaks
in crypto tests on Linux and ChromeOS start reappearing.

TBR=eugenis@chromium.org
NOTRY=true
BUG=321976

Review URL: https://codereview.chromium.org/132233061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247798 0039d316-1c4b-4281-b951-d872f2087c98

> Change default mode of extension install verification
> 
> Right now the default mode is to make requests against the server unless
> the experiment group says not to, and that may be contributing to some
> unexpected load we're seeing. So this CL changes it to not do that.
> 
> It also adds some histograms to help measure the success rate and
> sources of requests to the server.
> 
> BUG=335379
> R=finnur@chromium.org
> 
> Review URL: https://codereview.chromium.org/149353002

TBR=asargent@chromium.org

Review URL: https://codereview.chromium.org/147983011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247797 0039d316-1c4b-4281-b951-d872f2087c98

The java test is fixed in https://codereview.chromium.org/147083010/

BUG=None
R=craigdh@chromium.org

Review URL: https://codereview.chromium.org/137423013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247796 0039d316-1c4b-4281-b951-d872f2087c98

Add flackr to ash/wm/overview/OWNERS

BUG=None
NOTRY=true

Review URL: https://codereview.chromium.org/145973008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247795 0039d316-1c4b-4281-b951-d872f2087c98

This eliminates two descriptor leaks -- the downloaded nmf file, and
the nexe itself.  One socket (on Linux) still leak.  Because Unixes
always use the lowest available number and the leaked descriptor is
the highest numbered one while the F@H nexe is running, this implies
that this might be a PPAPI proxy related leak, since proxy hookup is
the last thing that happens before the application itself runs.

See /home/bsy/fd-leak-log for time-lapsed view of what happens when a
F@H NaCl module finishes and another starts up.

TEST= manually running F@H and checking /proc/<renderer>/fd/*
BUG= 335186
R=bbudge@chromium.org, dmichael@chromium.org

Review URL: https://codereview.chromium.org/147083014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247794 0039d316-1c4b-4281-b951-d872f2087c98

Currently tests initialize GL by calling into methods that should be
internal to the gl bindings code. Instead, everyone should go through
GLSurface::InitializeOneOff.

Also GLSurface::InitializeOneOff early outs if it was already called,
leading to a pattern of initializing GL all over the place just in case
and not having a clear idea of where it should be set up. Instead, DCHECK
that it is not called more than once, and move calls to this method to
be during process startup for unit test suites instead of mid-test.

This adds two test variants of InitializeOneOff for tests to call, that
set up OSMesa or Mock GL bindings, via GLSurface::InitializeOneOff.

R=piman, sievers
BUG=270918

Review URL: https://codereview.chromium.org/135213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247793 0039d316-1c4b-4281-b951-d872f2087c98

This is part of a long-running background task to remove the remaining
uses of the unchecked IPC_ENUM_TRAITS() macro.

BUG=246708

Review URL: https://codereview.chromium.org/149193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247791 0039d316-1c4b-4281-b951-d872f2087c98

Right now the default mode is to make requests against the server unless
the experiment group says not to, and that may be contributing to some
unexpected load we're seeing. So this CL changes it to not do that.

It also adds some histograms to help measure the success rate and
sources of requests to the server.

BUG=335379
R=finnur@chromium.org

Review URL: https://codereview.chromium.org/149353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247790 0039d316-1c4b-4281-b951-d872f2087c98

Chrome for Android does not use chrome://help so we should not include
the strings for it.

BUG=326023
R=newt@chromium.org

Review URL: https://codereview.chromium.org/142573005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247789 0039d316-1c4b-4281-b951-d872f2087c98

This moves ExtensionSystem to extensions/browser.
It also moves setting the channel for Features to ChromeExtensionsBrowserClient.
It also removes the duplicate ExtensionSystem::GetForBrowserContext.

BUG=337707
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/147923005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247788 0039d316-1c4b-4281-b951-d872f2087c98

BUG=323015
TBR=tonyg
NOTRY=True

Review URL: https://codereview.chromium.org/149773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247787 0039d316-1c4b-4281-b951-d872f2087c98

Mainly replacing bool parameters with enum values

BUG=none
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/149073007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247785 0039d316-1c4b-4281-b951-d872f2087c98

BUG=297132

Patch set 1 is the original CL:

https://codereview.chromium.org/137543002/

which broke tests on the memory bots. Path set 2 contains the fix for the test failure.

Review URL: https://codereview.chromium.org/148213010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247784 0039d316-1c4b-4281-b951-d872f2087c98

This refactors all the windows code out of external_protocol_dialog.cc
into the cross-platform ShellIntegration interface, and makes the
external_protocol_dialog.cc implementation use the existing
external_protocol_dialog_delegate.cc interface.

BUG=337660
R=sky@chromium.org

Review URL: https://codereview.chromium.org/132903018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247783 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromedriver:690

Review URL: https://codereview.chromium.org/147083010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247782 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
NOTRY=True
TBR=bengr1

Review URL: https://codereview.chromium.org/133793006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247781 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=yoz@chromium.org

Review URL: https://codereview.chromium.org/149883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247778 0039d316-1c4b-4281-b951-d872f2087c98

Telemetry had two classes that were tightly linked: TemporaryHTTPServer and
MemoryCacheHTTPServer. Before this patch. TemporaryHTTPServer's job was to
spawn a child process and then launch in that child process the
MemoryCacheHTTPServer, scrape its serving port, and then establish port
forwarding between the browser and that port.

This refactors this slightly:
- TemporaryServer takes on the job of staritng a subprocess inside of which
  a server will be launched, plus the logic for matchmaking to that child
  process' selected serving port.
- The portions specific to what the child process actually does on that port
  are abstracted behind TemporaryServerBackend class.
- MemoryCacheHTTPServer is rephrased in terms of a TemporaryServer and
  TemporaryServerBackend.

R=tonyg

Review URL: https://codereview.chromium.org/148583014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247777 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247776 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=165996:166035&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/147593009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247775 0039d316-1c4b-4281-b951-d872f2087c98

This patch changes all metrics in RenderingStats to be lists of lists
(one per timeline range). Right now, we only need this feature for frame_timestamps,
but it is cleaner to handle all metrics the same way and it preserves more
information.
The discrepancy calculation was modified to handle list-of-list inputs
correctly.

R=nduca@chromium.org,dominikg@chromium.org
BUG=338796

Review URL: https://codereview.chromium.org/149093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247773 0039d316-1c4b-4281-b951-d872f2087c98

R=zork@chromium.org
BUG=249853

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246992

Review URL: https://codereview.chromium.org/141433011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247772 0039d316-1c4b-4281-b951-d872f2087c98

This CL creates the PasswordManager component and moves a leaf file needed as
part of unit test support into it.

BUG=334616,334637
TBR=zea

Review URL: https://codereview.chromium.org/148383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247771 0039d316-1c4b-4281-b951-d872f2087c98

This action does a sanity check of the JavaScript files to make sure that the types are used consistently.

The jscompile build target is off by default. Use run_jscompile=1 to enable.

BUG=
R=jamiewalch@chromium.org

Review URL: https://codereview.chromium.org/149043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247770 0039d316-1c4b-4281-b951-d872f2087c98

Any struct of size > 4 bytes should be passed by const ref. 
Passing by ref for these structs is faster than passing by value,
especially when invoking function has multiple parameters and some
other scenarios mentioned in the bug.

BUG=159273

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247426

Review URL: https://codereview.chromium.org/145313006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247769 0039d316-1c4b-4281-b951-d872f2087c98

As part of issue 330908, I've scrutinized JSONWriter on all angles. Despite failing to optimize it much; here are some micro optimizations and style cleanups I came up with, might as well put them in (although their impact appears to be minimal from local profiling).

BUG=330908

Review URL: https://codereview.chromium.org/139903013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247765 0039d316-1c4b-4281-b951-d872f2087c98

That way, event converters can be organized in whichever way is most useful
for the platform. For evdev, organize by device path. This will let us find
out which which devices have already been opened and is needed for hotplug.

Review URL: https://codereview.chromium.org/133233008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247764 0039d316-1c4b-4281-b951-d872f2087c98