- 19 Aug, 2019 40 commits
-
-
Abhishek Bhardwaj authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/bcf5f02a0d0a..d740747810e9 $ git log bcf5f02a0..d74074781 --date=short --no-merges --format='%ad %ae %s' 2019-08-08 apusaka system_api: separate bluetooth constants 2019-06-07 sukhomlinov system_api: request type for vTPM EK certificate 2019-08-06 abhishekbh power: Add minium guaranteed delay timeout to RegisterSuspendDelayReply 2019-07-15 iby crash: Tast test for crash loop reporting 2019-07-16 zuan cryptohome: Add GetLoginStatus to UserDataAuth and proxy 2019-07-25 zuan cryptohome: Add LockToSingleUserMountUntilReboot to UserDataAuth and proxy 2019-07-22 cmtm remove unused scan_vendor_priv flag 2019-08-13 abhishekbh system_api: Add allow_untrusted flag to StartVMRequest 2019-08-13 juwa system_api: vm_tools: add bytes exported to export progress message 2019-07-26 akhouderchah shill: service: Add disconnecting state 2019-08-13 nverne system_api, vm_host_tools: Add OsRelease message to cicerone and tremplin 2019-08-07 lamzin shill, system_api: use Mac instead of MAC in names 2019-07-26 ejcaruso shill: add Metered property to Service 2019-06-14 dtor system_api: fix VmToolsStateChanged message definition Created with: roll-dep src/third_party/cros_system_api Bug:None Test:Compile. Change-Id: If40acdca7f0b9231c815bbce3e81e878b3c0edfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759389Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Chris Morin <cmtm@chromium.org> Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Cr-Commit-Position: refs/heads/master@{#688172}
-
Francois Doray authored
Bug: 948455, 982146, 976123 Change-Id: If04b6996437204c6e1cc7d926ea259d46eb108c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757504 Commit-Queue: François Doray <fdoray@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#688171}
-
Joe DeBlasio authored
This CL updates the strings for the details/advanced section of the lookalike interstitial to use the friendlier 'details' phrasing. Bug: 987359 Change-Id: Ib010231f79358fc52d85b60ce9913a0fe7e79332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759211 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#688170}
-
kylechar authored
Don't encourage using |my_thread_checker_| as the name. Bug: none Change-Id: I90d7df90131128996e88e2b07f1b3d5f2f51f255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758712 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#688169}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/13d55b39e183..82c85d4f089f git log 13d55b39e183..82c85d4f089f --date=short --no-merges --format='%ad %ae %s' 2019-08-19 saklein@chromium.org BinhostService: RegenBuildCache sans git operations. Created with: gclient setdep -r src/third_party/chromite@82c85d4f089f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I3f857969aee41789c58e6152aeae6dfc55c800f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760894Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688168}
-
Ian Kilpatrick authored
This was broken in: https://chromium-review.googlesource.com/c/chromium/src/+/1745396 This adds this functionality back in, and performs the data passing via the constraint-space, and layout-result (as opposed to setting this information explicitly on the layout-object classes. Bug: 993306 Change-Id: I5083ad782227657a19301cf61b2867be603f521a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757739Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#688167}
-
Alex Khouderchah authored
Bug: chromium:954635 Change-Id: Iacb78c434999fabd1f1fdadc9fdca0d8829cb26f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754089 Commit-Queue: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#688166}
-
Sahel Sharify authored
This reverts commit 3b6a2d96. Reason for revert: MSAN builds are consistently failing(e.g. builds #1361,#1362) because of virtual/controls-refresh/fast/forms/controls-new-ui/color/color-picker-appearance-set-type.html web test which is first added in the original cl. https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN Original change's description: > Reland "Implement visual color picker" > > This is a reland of c74afcfa > > Original change's description: > > Implement visual color picker > > > > This CL adds to the implementation of the new color picker to provide > > functionality that allows the user to select colors visually. There > > are a few different components being added to the VisualColorPicker. > > They have been described in the ColorPicker.js file, but their > > description are also being shared herewith for convenience. > > > > EyeDropper: Allows color selection from content outside the color > > picker. (This is currently just a placeholder for a future > > implementation.) > > ColorViewer: Provides a view of the selected color. > > ColorSelectionArea: Base class for ColorWell and HueSlider that > > encapsulates a ColorPalette and a > > ColorSelectionRing. > > ColorPalette: Displays a range of colors. > > ColorSelectionRing: Provides movement and color selection > > functionality to pick colors from a given > > ColorPalette. > > ColorWell: Allows selection from a range of colors, between black and > > white, that have the same hue value. > > HueSlider: Allows selection from a range of colors with distinct hue > > values. > > > > This change includes connecting the existing manual color picker with > > the newly implemented visual color picker. If the user manually enters > > a new color value, it will be reflected visually, and similarly if the > > user visually selects a new color, the manual values will also get > > updated. > > > > Bug: 983311 > > Change-Id: I32f3e647bae5da25a664a1f6cd1dd2462feb3984 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747857 > > Reviewed-by: Kent Tamura <tkent@chromium.org> > > Reviewed-by: Mason Freed <masonfreed@chromium.org> > > Commit-Queue: Sanket Joshi <sajos@microsoft.com> > > Cr-Commit-Position: refs/heads/master@{#687144} > > Bug: 983311 > Change-Id: I35596ee04bd3e3df481e9096f747b07e8413e3c1 > > > TBR'ing original reviewers. Not making any changes to the original patch. It is > suspected that the MSAN test failure that lead to the original patch being > reverted was an unrelated issue. I have been unable to reproduce the failure > locally and this change does not touch C++ code. Per the recommendation here: > https://bugs.chromium.org/p/chromium/issues/detail?id=994447, relanding this > change as is to see if the MSAN failure still occurs. > > TBR: tkent@chromium.org,masonfreed@chromium.org > Change-Id: I35596ee04bd3e3df481e9096f747b07e8413e3c1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758705 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Sanket Joshi <sajos@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#688011} TBR=chrishtr@chromium.org,tkent@chromium.org,masonfreed@chromium.org,sajos@microsoft.com Change-Id: I1461f16f7f40374fa1508b6c8b7802d46cf521ea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 983311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761015Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#688165}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/72fbaf4d465e..73b9263523ee git log 72fbaf4d465e..73b9263523ee --date=short --no-merges --format='%ad %ae %s' 2019-08-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@73b9263523ee The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: None Change-Id: Ice637e335c99c01a7f27fd7ebfe11baa782ba94d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760539Reviewed-by:
-
Jimmy Gong authored
- Autoconf printers do not have PPDs; therefore, do not have an associated manufacturer and model. - This change hides those fields in the edit dialog for autoconf printers. Bug: 947183 Test: browser test, end to end manual Change-Id: Ibdff515e2ba356a873df6f8cf6326d2a8f1a8735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746628 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#688163}
-
Matt Simmons authored
R=yusufo@chromium.org Bug: 990979 Change-Id: Ie198810daeef73289d3ff559735a079b236a1cf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755415Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#688162}
-
Mario Bianucci authored
Pinch zoom was incorrectly not being preventDefault'd sometimes, in two different scenarios: either the transition from scroll->pinch, or from fling->pinch. In both cases, events were being queued in the TouchpadPinchEventQueue, then TouchpadPinchEventQueue::ProcessMouseWheelAck was receiving ACKs, which TPEQ assumed were the ACKs for the events that it had already queued. While this is often true, it was not always the case. Sometimes, the event ACKs from the scroll or fling would arrive after the pinch events had been queued already, in which case the ACKs would be processed as if they were for pinch events, when they weren't. This resulted in the pinch zoom not always being preventDefault'd. This CL fixes this by checking the event that was being ACK'd vs the event that TPEQ expects an ACK for, and if they don't match then it early outs and ignores the ACK. Bug: 908758 Change-Id: Ifbad8e3ae46947c75b4680dc516398b69cf2cc89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725349 Commit-Queue: Mario Bianucci <mabian@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#688161}
-
Yaron Friedman authored
They make lots of changes for linker and have shown ownership Change-Id: I3bff1ef4cc9557cf0940d9ecb64ffba459d656a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758497 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#688160}
-
Vlad Tsyrklevich authored
Android WebView has a stricter privacy model because it runs in embedders memory spaces. To ensure crash dumps don't include information from the embedding process, additional sanitization is performed on the crash dump. To make GWP-ASan work under sanitization, white list GWP-ASan memory regions that are required by the crash handler. Furthermore, add support for testing under sanitization on Linux/Android (the only platforms that currently support sanitization.) CQ-DEPEND=chromium:1756705 Bug: 973167 Change-Id: I6a48b17bd128f44ffd62fe0f180db79c175a561b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757160Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#688159}
-
Xianzhu Wang authored
Update VisualViewport class documentation to reflect the current status. Rename some fields to make them consistent with the class's public API: - inner_viewport_container_layer_ => container_layer_ (existing public API: ContainerLayer) - inner_viewport_scroll_layer_ => scroll_layer_ (existing public API: ScrollLayer) - scale_transform_node_ => page_scale_node_ (existing public API: PageScaleNode) - translation_transform_node_ => scroll_translation_node_ (existing public API: GetScrollTranslationNode) Change-Id: Ifa1826e2494b04e3c50098d40f52c92df8c00213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758739 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#688158}
-
Tomasz Wiszkowski authored
This change removes clock icon from site suggestions. Bug: 994847 Change-Id: I1ac2e656bf4bdb955cf00662d737481f90634cf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758630 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#688157}
-
Tommy Li authored
Currently, if the user presses an End Key on an intranet URL with no path, i.e. "https://foobar" elided to "foobar/", the cursor position will not end up in the right place. This is because the elided form is not a strict substring of the full formatted URL. This CL fixes this corner case and adds a test. Bug: 883310 Change-Id: Id3bb4c24da05dc8de3b2703edc5b12c1f2e3cab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759230 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#688156}
-
Leon Han authored
This is a follow-up CL for addressing comments in crrev.com/c/1737993: https://chromium-review.googlesource.com/c/chromium/src/+/1737993/14/third_party/blink/web_tests/external/wpt/resources/chromium/nfc-mock.js#276 BUG=520391 Change-Id: I92ac1229d59d1a76d830f2a1d58acf04c2846f3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760596 Auto-Submit: Leon Han <leon.han@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#688155}
-
Peter K. Lee authored
- Reverts the revert in http://crrev/c/1755004, i.e. instantiates the collection of persistent histograms. - Registers a FileMetricsProvider to upload collected metrics. - Added ios_chrome_metrics_service_client_unittest.mm, patterned after chrome_metrics_service_client_unittest.cc. Bug: 994743 Change-Id: Id8e7ce79f0825eb1cd4c1fb7051709c1d3880cc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752699 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#688154}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f8221786d088..3f7932e73316 git log f8221786d088..3f7932e73316 --date=short --no-merges --format='%ad %ae %s' 2019-08-19 csmartdalton@google.com Add kRequiresManualMSAAResolve to GrInternalSurfaceFlags Created with: gclient setdep -r src/third_party/skia@3f7932e73316 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: None Change-Id: I74b45021250035c7ee7d84e8942ef9211eec5b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760022Reviewed-by:
-
Sahel Sharify authored
This cl marks a few fast/convas tests as slow on Mac and/or Debug builds. Their virtual/gpu equivalents have already been marked as slow. TBR=fserb@chromium.org NOTRY=TRUE Bug: 983642 Change-Id: I2c4ad66a9c073b8f8402710b7d0e87456dfc4e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760142 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1e38d7c2. With Chromium commits locally applied on WPT: 1da9cc73 "[LargestContentfulPaint] Add larger content tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ie3b512564ddceb1ab3658717de1c7a6a51c47c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760415Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688151}
-
Stefan Zager authored
FrameSchedulerImpl relies on a "frame visible" state bit propagated from LocalFrameView via RenderThrottlingStatusChanged(). However, it is possible that the bit never gets propagated because the frame doesn't actually transition throttling state. In that case, FrameSchedulerImpl will not throttle timers as it should. This patch ensures that the state bits are properly forwarded to the scheduler, even if the LocalFrameView's throttling status doesn't change. BUG=971590 R=alexclarke@chromium.org Change-Id: I5913a3d118479ccd84b77ef86f0582f4892a3c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758224Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#688150}
-
Jordan Taylor authored
This change extracts shared functionality (related to recomputing calculated timing) from AnimationEffect and WorkletAnimationEffect Bug: 915344 Change-Id: Ia01f938d3589a79a6702bf3efbab8aa0654a6ed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740867Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#688149}
-
Tanmoy Mollik authored
AccountTracker in gcm get account_id from identity_manager. This account_id should not be std::string so that it is not confused with gaia_id or email. Bug: 959157 Change-Id: Ie5f861bf6632226d6105a5c47b51f0dd0edc1516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739427 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#688148}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/92433291..05137a76 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I78a3cf9d115deeb3befd8dd1438c03a17b0b0108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760414Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688147}
-
Alexei Svitkine authored
This reverts commit 87dac882. Reason for revert: Breaks UMA recording. Original change's description: > Add full system profiles in .pma file as part of metrics init. > > Prior to this change, only an incomplete system profile, notably > missing field trials and uma_default_state fields, was stored > at this point. So unclean shut downs after this point in time, > but before the initial metrics log was saved would not include > that info. This change fixes that by running the code that > populates all the system profile fields. > > Since we're now calling ProvideSystemProfileMetrics() twice, the > logic in FieldTrialsProvider was no longer correct in tracking > the log creation time. Instead, this CL updates the API to have > that be passed in. > > Additionally, Chrome OS an Screen Info providers needed updates since > their dependencies are not yet available this early, so they are not > able to provide all the information this early. > > Finally, webview unit tests needed updating to init mojo as they are > now exercising the provider code which has a Mojo dependency. > > Bug: 992538 > TBR: sky@chromium.org > Change-Id: Iae54398065470e390b70507d5b3ac09d5a983c9f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746909 > Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Cr-Commit-Position: refs/heads/master@{#687000} TBR=sky@chromium.org,rkaplow@chromium.org,asvitkine@chromium.org,torne@chromium.org,bcwhite@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 992538 Change-Id: I4a25324788960d2e61325c2a41812c5da18087f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760869Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#688146}
-
Xianzhu Wang authored
This is a preparation of replace cc::TransformNode::pre_local and post_local with a simple Point3DF for transform origin. Previously post_local was used in the following cases (other than for transform origin): - root layer: external transform (above root) and device scale factor - page scale layer: for page scale This CL removes the case of - the same layer for root layer and page scale layer, and - custom transform on the root layer, so that we can use cc::Transform::local for external transform and device scale factor in the transform node of the root layer, and for page scale in the transform node of the page scale layer. This is an intermediate step before we switch all impl-side cc unit tests to layer list mode. After that, we no longer need dedicated page scale layer. Bug: 993937 Change-Id: I4b6b0340bd6b2421a2c29844989e3ffef078dcf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756712 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Stephen McGruer authored
Bug: 900581 Change-Id: Ib27f3df1a5aeb76ba8e24b5b1040a75efb7a1f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760139Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#688144}
-
Jimmy Gong authored
Bug: 965721 Test: manual end to end Change-Id: I6dbf6081d1babde6f0476a93b66392864acf2898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760858Reviewed-by:
-
Gabriel Charette authored
(second half of https://chromium-review.googlesource.com/c/chromium/src/+/1756247) This is step #1 of the mass migration. Some of these will be backported to SingleThreadTaskEnvironment in a later phase. scoped_task_environment.h will also only move in a follow-up CL. TBR=dcheng@chromium.org Bug: 992483 Change-Id: Ie80f083eeeb209180ab3c2884f1b566f73549cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756248Reviewed-by:
-
Tanisha Mandre authored
Architecture: Superclass - scannerView Subclasses - qrScannerView - Shift the video preview view and preview overlay view to shared 'scanner' directory. Bug: 990744 Change-Id: Ib81957f80d18b205865d9e4e6390c4ca56e4cf77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736889 Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Gang Wu authored
******************************Resource Sizes Diff****************************** Specifics: +77,824 bytes main lib size +626,344 bytes main dex size +1,028,222 bytes normalized apk size InstallSize: +402,088 bytes APK size +1,134,911 bytes Estimated installed size (Android Go) +2,932,517 bytes Estimated installed size InstallBreakdown (+2,929,368 bytes): +3,954 bytes Native resources (no l10n) size +2,139 bytes Non-compiled Android resources size +77,824 bytes Native code size +3,412 bytes PNG drawables size +603 bytes Package metadata size +2,813,504 bytes Java code size +27,932 bytes Compiled Android resources size Dex: +2,938 entries fields +2,473 entries strings +3,989 entries unique methods +1,255 entries types +3,989 entries methods Change-Id: I5a72a2c017cfdc16b56308d59e11ae205baaf6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759928Reviewed-by:Sky Malice <skym@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688140}
-
Alex Moshchuk authored
This is in preparation for requiring WARN_UNUSED_RESULT on NavigateToURL() usage in tests. Bug: 425335 Change-Id: I27391139d718457da50d9e96d7ffc958d1d4a11e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755544Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#688139}
-
Philip Jägenstedt authored
Change-Id: Ied8e0177399d514a26be17092f4dcdbbcf659574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757989Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#688138}
-
Alex Clarke authored
Split off from https://crrev.com/c/1751324 The ResourceLoadPriority tests send Priority and a Status result via postMessage. Due to the way this is implemented the test is unnecesarially sensitive to the loading order and can fail even when the thing it's actually testing passes. This patch changes the message to a key-value pair which is more robust. Bug: 971191 Change-Id: Ieb7d7d736c363b75a0b1e2e1f1a2ad95cfaddbff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760226 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
-
Joshua Peraza authored
components/crash/ supports multiple embedders (not just chrome) so chrome specific crash configuration should live in its CrashReporterClient implementation. Change-Id: I6406f06e1a228c69bcaa4654a7743d039229fa3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756423Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#688136}
-
Peter Kasting authored
This minimizes the readability cost for using custom frame colors. Bug: 854738 Change-Id: Ifee3e07a6a1317c93c1e5bccdcce921008d7e58a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759223 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#688135}
-
Thomas Tangl authored
Bug: 966388 Change-Id: Ic07d37be9443516563817533c5bd2613b973c6b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760207 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#688134}
-
sczs authored
Bug: 979201 Change-Id: Idfc2836db82f7f8ae68b580e84f2fbb65aba1337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759222Reviewed-by:
-
