GitLab

BUG=413249
TBR=loislo@chromium.org

Review URL: https://codereview.chromium.org/653933002

git-svn-id: svn://svn.chromium.org/blink/trunk@183673 bbb929c8-8fbe-4397-9dbb-9b2b20218538

 - SkRecord stores all matrix-changes as setMatrix.  This accounts for translate -> setMatrix in #6.

 - SkRecordNoopSaveLayerDrawRestore turned the saveLayer/drawRect/restore in #9-#11 into a single drawRect.


This test is suppressed by skia/skia_test_expectations.txt, so I will have to
remove that in a follow-up CL.

BUG=408985

Review URL: https://codereview.chromium.org/656533002

git-svn-id: svn://svn.chromium.org/blink/trunk@183672 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Animated clipping has to be disabled until it is not supported properly.
With removing the clip property from animatedPropertyTypeForCSSAttribute
animted clipping is considered as an unknown animation and won't cause
assertion failure later.

R=kouhei@chromium.org,fs@opera.com
BUG=422955

Review URL: https://codereview.chromium.org/656443002

git-svn-id: svn://svn.chromium.org/blink/trunk@183671 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Screenshots:

Before / popover:
http://picpaste.com/before1.png

Before / details:
http://picpaste.com/before2.png

After / popover:
http://picpaste.com/after1.png

After / details:
http://picpaste.com/after2.png

BUG=403508

Review URL: https://codereview.chromium.org/471163005

git-svn-id: svn://svn.chromium.org/blink/trunk@183670 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none

Review URL: https://codereview.chromium.org/653613002

git-svn-id: svn://svn.chromium.org/blink/trunk@183669 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove unused functions WTFSetCrashHook, WTFInstallReportBacktraceOnCrashHook and WTFInvokeCrashHook.

WTFSetCrashHook, WTFInstallReportBacktraceOnCrashHook functions are not
called from anywhere, Actually these functions were only used during old WebKit
days by other WebKit ports. Now it is no longer useful for Blink, hence removing.

BUG=

Review URL: https://codereview.chromium.org/615593002

git-svn-id: svn://svn.chromium.org/blink/trunk@183667 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews,haraken
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/653053002

git-svn-id: svn://svn.chromium.org/blink/trunk@183666 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Clean up forward declarations in Source/core/inspector

These forward references are not needed anymore. After
this patch, Source/core/inspector has no unneeded forward references
any more.

Review URL: https://codereview.chromium.org/650183003

git-svn-id: svn://svn.chromium.org/blink/trunk@183665 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently, all module files are copied by the 'copies' GYP actions.
This patch makes build_applications.py copy the app HTML and directories
into the output directory.

R=dgozman, pfeldman@chromium.org

Review URL: https://codereview.chromium.org/646413002

git-svn-id: svn://svn.chromium.org/blink/trunk@183664 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL caused https://code.google.com/p/chromium/issues/detail?id=420048

> Oilpan: Move MediaStreamSource, MediaStreamComponent and MediaStreamDescriptor
> to oilpan's heap
> 
> - MediaStreamSource, MediaStreamComponent and MediaStreamDescriptor must be moved
> to oilpan's heap in one go because their lifetime are tightly coupled.
> 
> - Removed m_descriptor->setClient(0) from MediaStream's destructor. This is OK
> because MediaStreamDescriptor has a strong Member back to the Client
> (i.e., MediaStream).
> 
> - Removed m_component->source()->removeObserver(this) from MediaStreamTrack's
> destructor. This is OK because this CL made the observers weak
> (i.e., MediaStreamSource::m_observers is a hash set of weak members to
> MediaStreamTrack objects).
> 
> - Removed WebMediaStreamTrack::ExtraData::m_owner because it's unused.
> 
> - Introduced MediaStreamComponentDisposer to delay the destruction of
> MediaStreamComponent::m_extraData. The ExtraData is exposed to the web
> and some Chromium objects inherit from the ExtraData. If we clear the
> m_extraData in the MediaStreamComponent's destructor, those Chromium-side
> objects are also destructed in the MediaStreamComponent's destructor.
> This is problematic because the destructors of the Chromium-side classes
> can touch other on-heap objects in the Blink side. To avoid the issue,
> we need to delay the destruction of the ExtraData to thread-specific
> weak processing. The disposer pattern actually makes the deletion of
> the extra data happen earlier and not later. The disposer makes sure
> that the extra data is destructed in weak processing which is run before
> sweeping and therefore all the objects are still alive and can be touched.
> 
> 
> - The same problem arises for MediaStreamDescriptor and MediaStreamSource.
> This CL adds MediaStreamDescriptorDisposer and MediaStreamSourceDisposer.
> 
> - This CL depends on https://codereview.chromium.org/543603003/ and https://codereview.chromium.org/549153002.
> 
> BUG=340522
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181702
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182399
> 
> Review URL: https://codereview.chromium.org/552653005

TBR=haraken@chromium.org

Review URL: https://codereview.chromium.org/650413003

git-svn-id: svn://svn.chromium.org/blink/trunk@183663 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If a style change is due to animations updating their interpolated values
only, store a clone of the RenderStyle before the animated properties are
applied to use as a base for updating RenderStyle for the next frames.

The base RenderStyle is stored on the ActiveAnimations object and cleared
when a recalc is triggered by changes that require rule matching.

The machinery for detecting if a LocalStyleChange is caused by an animation
update only was already in place, so this CL is making use of that.

Running blink_perf.animation shows a frame rate increase of 18-40% with
the exception of three tests which are unchanged.

In general this seems to shave off nearly 50% of the time used in
recalcStyle for each animation frame if no inherited properties are
animated. For instance, in "The expansion of the dictionary definition card"
from issue 377939.

R=dstockwell@chromium.org,esprehn@chromium.org
BUG=377939,421822

Review URL: https://codereview.chromium.org/635203003

git-svn-id: svn://svn.chromium.org/blink/trunk@183662 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After pressing last radio button in the list, on pressing downArrow it will select back first radio button, similarly after pressing last radio button in the list, on pressing upArrow it will select last radio button.

For this change I have added one test case : radio-checked-LastorFirst-then-DownorUp-keyDown.html. This HTML contains a list of radio buttons and after selecting last radio button downArrow keyDown event raised. Similarly done for first radio button also.


R=habib.virji@samsung.com
BUG=408512

Review URL: https://codereview.chromium.org/546753002

git-svn-id: svn://svn.chromium.org/blink/trunk@183661 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL allows FormData submitted with empty name field to be appended. According to xhr spec https://xhr.spec.whatwg.org/#interface-formdata name field should be appended as it is i.e without checking whether it is empty. 
Firefox and IE behaves according to spec and allow empty names field to be appended. This CL makes Blink to be compatible with spec and other browsers.

BUG=415804

Review URL: https://codereview.chromium.org/609733004

git-svn-id: svn://svn.chromium.org/blink/trunk@183660 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Print error messages to DevTools console for rejected Promises that are unhandled by the platform end-of-turn.

BUG=393913
R=pfeldman, yurys

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183464

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183598

Review URL: https://codereview.chromium.org/625943002

git-svn-id: svn://svn.chromium.org/blink/trunk@183659 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=418536

Review URL: https://codereview.chromium.org/633073002

git-svn-id: svn://svn.chromium.org/blink/trunk@183658 bbb929c8-8fbe-4397-9dbb-9b2b20218538

RenderGrid::resolveContentBasedTrackSizingFunctions() was not spec
compliant because it used to compute content-based track sizes going
track-by-track. The specs clearly specify that instead, we should collect
all items spanning content-sized tracks and process them one by one after
sorting them by ascending span.

The obvious issue in the old implementation is that a grid item spanning the
first track was always processed before a non spanning item in the second
track. That leads to weird track size computations.

Review URL: https://codereview.chromium.org/592803003

git-svn-id: svn://svn.chromium.org/blink/trunk@183657 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=419676

Review URL: https://codereview.chromium.org/634543002

git-svn-id: svn://svn.chromium.org/blink/trunk@183656 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=pfeldman

Review URL: https://codereview.chromium.org/625843002

git-svn-id: svn://svn.chromium.org/blink/trunk@183655 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Made top controls work with virtual viewport pinch-to-zoom. (Blink) (patchset #3 id:100001 of https://codereview.chromium.org/643473002/)

Reason for revert:
Broke PinchViewportTest.TestTopControlsAdjustment on Mac bots (e.g. see https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7/builds/32476/steps/webkit_unit_tests/logs/TestTopControlsAdjustment)

Original issue's description:
> Made top controls work with virtual viewport pinch-to-zoom. (Blink)
> 
> Together with the Chromium-side patch, makes top controls work properly
> under the virtual viewport mode of pinch zoom. The key changes on the
> Blink side are to adjust both the PinchViewport and FrameView max scroll
> bounds to account for the change in the top controls offset on the
> compositor. Additionally, I changed these to make the same floating point
> and snapping calculations as in the compositor to prevent losing pixel
> fractions.
> 
> Chromium side: https://codereview.chromium.org/641873003/
> 
> BUG=364109
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183639

TBR=aelias@chromium.org,rbyers@chromium.org,bokan@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=364109

Review URL: https://codereview.chromium.org/655763002

git-svn-id: svn://svn.chromium.org/blink/trunk@183653 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This property is parsed and stored on RenderStyle, but it's not
used anywhere, i.e. it has no effect.

If we later decide that we want this after all, we can re-implement
it as 'aspect-ratio' behind a flag.

Review URL: https://codereview.chromium.org/647723002

git-svn-id: svn://svn.chromium.org/blink/trunk@183652 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This makes it possible to use a converter, and makes
style/animation application cleaner.

Review URL: https://codereview.chromium.org/644953003

git-svn-id: svn://svn.chromium.org/blink/trunk@183651 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ScriptForbiddenScope used to trigger a fatal assert if Blink tried to
execute script in a forbidden scope. This was problematic because
plugins often tried to run scripts inside these scopes.

To prevent these crashes, AllowSuperUnsafeScripts was added as an opt
out to allow plugin-triggered scripts to execute script anyway in these
dangerous contexts. This lead to bugs like https://crbug.com/367210,
where something that should be "impossible" wasn't.

In order to prevent random code from having to work around edge cases
that only happen when script shouldn't even be running, the entry points
for executing user script have been updated to first check if scripting
is forbidden. If it is, they just return undefined or an empty object as
appropriate.

A followup patch will attempt to apply a similar approach for handling
internal scripts.

BUG=363099,371084

Review URL: https://codereview.chromium.org/648423003

git-svn-id: svn://svn.chromium.org/blink/trunk@183650 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Title should reflect action that will happen when button is pressed.

BUG=414140

Review URL: https://codereview.chromium.org/632253002

git-svn-id: svn://svn.chromium.org/blink/trunk@183649 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=183641

BUG=415031
TBR=sataya.m@samsung.com

Review URL: https://codereview.chromium.org/652983003

git-svn-id: svn://svn.chromium.org/blink/trunk@183648 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=423211

Review URL: https://codereview.chromium.org/653833002

git-svn-id: svn://svn.chromium.org/blink/trunk@183647 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Moved the following blocks from interface.cpp to interface_base.cpp:
- security_check_functions,
- install_conditional_attributes, and
- install_conditional_methods

BUG=380523

Review URL: https://codereview.chromium.org/645833002

git-svn-id: svn://svn.chromium.org/blink/trunk@183646 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=423203

Review URL: https://codereview.chromium.org/636173006

git-svn-id: svn://svn.chromium.org/blink/trunk@183645 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none
TEST=no layout test failure

Review URL: https://codereview.chromium.org/645743003

git-svn-id: svn://svn.chromium.org/blink/trunk@183644 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds a set of trace events to track reason when
StyleInvalidator invokes Node::setNeedsStyleRecalc. One of the trace events is guaranteed to be issued before StyleInvalidator issues setNeedsStyleRecalc on the node. The trace events come with InspectorStyleInvalidatorInvalidateEvent, which contains inspector node id, human readable reason string, and optionally the tagName/id/class/attr/invalidationList involved.

This is to be used from devtools so we post process and find the StyleInvalidator trace event on the given node to see the detailed reason for why StyleInvalidator decided issue setNeedsStyleRecalc on the node.

BUG=410701

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183177

Review URL: https://codereview.chromium.org/580373002

git-svn-id: svn://svn.chromium.org/blink/trunk@183643 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The WebSocket implementation has moved to chrome. As it is stable now, let's
delete the old implementation.
This CL doesn't delete some platform/ and web/ classes, as some chromium-side
code depends on them.

BUG=423201
R=ricea@chromium.org

Review URL: https://codereview.chromium.org/639333003

git-svn-id: svn://svn.chromium.org/blink/trunk@183642 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove Overlay Scrollbar if not scrollable along that axis. If the 
scrollSize along that axis is zero then set scrollbar along that
axis to false. This is applicable to Solid-Color scrollbars in Android
& Overlay scrollbars in the Aura.

BUG=415031

Review URL: https://codereview.chromium.org/643933002

git-svn-id: svn://svn.chromium.org/blink/trunk@183641 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=388375,401381
TBR=nhiroki@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/642933008

git-svn-id: svn://svn.chromium.org/blink/trunk@183640 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Together with the Chromium-side patch, makes top controls work properly
under the virtual viewport mode of pinch zoom. The key changes on the
Blink side are to adjust both the PinchViewport and FrameView max scroll
bounds to account for the change in the top controls offset on the
compositor. Additionally, I changed these to make the same floating point
and snapping calculations as in the compositor to prevent losing pixel
fractions.

Chromium side: https://codereview.chromium.org/641873003/

BUG=364109

Review URL: https://codereview.chromium.org/643473002

git-svn-id: svn://svn.chromium.org/blink/trunk@183639 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to latest editor's draft http://rawgit.com/w3c/html-api-map/master/index.html
meter tag should have MSAA+IA2 Role as ROLE_SYSTEM_PROGRESSBAR and
AX role as AXGroup and Role description as "group"

BUG=421376

Review URL: https://codereview.chromium.org/652663003

git-svn-id: svn://svn.chromium.org/blink/trunk@183638 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL adds a fast, conservative way to determine if we are in the main thread.

1) In ThreadState::init(), take the underestimated size of the main thread.

2) When ThreadState::current() is called, check if the current stack address is within the underestimated size from the stack start of the main thread. If yes, we can immediately return the mainThreadState() without looking up TLS. Otherwise, we look up TLS.

TLS is very slow especially in Mac and Windows. This CL improves blink_perf.parser.querySelector-* (and other) benchmarks by 6% in Mac.

BUG=420515

Review URL: https://codereview.chromium.org/643883002

git-svn-id: svn://svn.chromium.org/blink/trunk@183637 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently we count CSS properties in CSSPropertyParser::parseValue (the
non-static version). This function is used recursively for shorthands,
so we end up tracking many CSS properties which haven't been specified
by users.

This patch moves the check up a level, so that it is only called on
properties specified by a user. I've also made it only count properties
that succeeded at parsing (behaviour wouldn't change for declarations
that fail to parse if we removed the property).

This should reduce the usage numbers on chromestatus.com for many
properties. For example while border-spacing is not specced as a
shorthand, it is implemented as a shorthand and we end up measuring
-webkit-border-horizontal-spacing whenever we parse border-spacing.

Review URL: https://codereview.chromium.org/642583006

git-svn-id: svn://svn.chromium.org/blink/trunk@183636 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I misremoved the UseCounter in the process of moving marquee implementation
to JS. This CL readds the UseCounter.

Review URL: https://codereview.chromium.org/653753003

git-svn-id: svn://svn.chromium.org/blink/trunk@183635 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The Slimming Paint codepath wasn't properly adding paint offsets
to the applied clip rects, causing only a fraction of text to be
drawn. Also adding a debug red background to make it more obvious
when we're failing to paint. Cribbed from FrameView's old paint
code.

BUG=423071

Review URL: https://codereview.chromium.org/654713003

git-svn-id: svn://svn.chromium.org/blink/trunk@183634 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Tried to improve readability. Also re-arranged the for-loop a bit.

This CL is part of splitting up [1].

[1] https://codereview.chromium.org/639433002

R=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/652703002

git-svn-id: svn://svn.chromium.org/blink/trunk@183633 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Unify the pixel snapping logic for selection rects by moving the logic
into selectionRectForText and having selectionRectForSimpleText and
selectionRectForComplexText respectively return precise values.

R=fmalita@chromium.org

Review URL: https://codereview.chromium.org/648633003

git-svn-id: svn://svn.chromium.org/blink/trunk@183632 bbb929c8-8fbe-4397-9dbb-9b2b20218538