- 20 Mar, 2020 40 commits
-
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/69c5dd70e796..e5753d2fb87e git log 69c5dd70e796..e5753d2fb87e --date=short --first-parent --format='%ad %ae %s' 2020-03-20 cwallez@chromium.org Enable (and fix) the DeviceLost tests on Metal Created with: gclient setdep -r src/third_party/dawn@e5753d2fb87e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Icfc92a9397e56cf3dd82a9dd5c6b3e083b631b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112524Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752036}
-
Andrew Grieve authored
Support recently added to resource_sizes.py in 6d51b2ee Bug: 1059928 Change-Id: I2bdcdd4a1c4f3b4ad3517443363b3a40383dc6bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111787Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#752035}
-
arthursonzogni authored
TBR=yhirano@chromium.org Bug: None Change-Id: Ib4ef9bb1903d6cf54b65f909f7b242c5bdbe8cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110024Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#752034}
-
Nicholas Verne authored
Bug: 1062113 Change-Id: I7c2f9b00f3a5a0385b534fe20f50a9f20321b3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105663 Auto-Submit: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#752033}
-
edchin authored
The tab grid animator relies on the condition that BVCContainerViewController only has one subview which has the named guide it needs. However, crbug.com/1053452 shows this is condition is not always met. Tab grid animator should not be the unwitting enforcer that BVCContainerViewController does not contain superfluous subviews. Tab grid animator should just find the named guide it needs. If BVCContainerViewController having other subviews is a problem, that invariant should be enforced somewhere other than in this animator. Bug: 1053452, 860234 Change-Id: I4a622920301998e8d3211039c6594a637ad54bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112139 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#752032}
-
Mark Cogan authored
As part of preparing for multi-window, the URLLoadingService needs to be migrated to be a BrowserAgent instead of a KeyedService. That change is itself fairly large, but as an additional complication URLLoadingService is used in downstream code. This CL is the tenth and final in a series of changes needed to complete this refactor: 1. (crrev.com/c/2089687) Add a new provider API upstream that passes both a Browser and temporary URL loading shim to CreateLogoVendor. 2. Implement this new API downstream and add support for initializing the LogoController with both Browser and the loading shim. Use the loading shim for loading URLs if it is present. 3. (crrev.com/c/2089785) Upstream, call the new CreateLogoVendor() API. 4. Downstream, remove support for the old CreateLogoVendor() API and update LogoController to only be initialized with a Browser and the shim loader. Remove downstream use of the URLLoadingService. 5. (crrev.com/c/2105314) Upstream, refactor URLLoadingService to be URLLoadingBrowserAgent, updating the upstream implementation of the loading shim passed downstream in CreateLogoVendor(). 6. (crrev.com/c/2106182) Upstream, add a new provider API that no longer passes the loading shim into CreateLogoVendor(). Delete the now- unused provider API that was removed downstream in step 4. 7. Downstream, remove use of the loading shim from LogoController and have it fetch the URLLoadingBrowserAgent from its Browser parameter. Implement the new shim-less CreateLogoVendor() API. Have the old shimmed API call the new shimless one. 8. (crrev.com/c/2106578) Upstream, call only the new shimless API. Remove the shim implementation in calling code. 9. Downstream, remove the shimmed API. 10.Upstream, remove the shimmed API, including the shim definition. Bug: 1046374 Change-Id: I7724b3d552239a67585495e7dd5a3f82630a9c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106849 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#752031}
-
Rushan Suleymanov authored
Introduce a test which is equivalent to SingleClientBookmarksSyncTest.DownloadTwoPre2015BookmarksWithSameItemId desktop test. Bug: 1048984 Change-Id: I729a296c28a91cac345c48b5f8f8982f7551c56e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111150Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#752030}
-
Morten Stenshorne authored
The script that I ran for CL:2111672 must have failed to remove this line because it didn't have a bug entry. TBR=kojii@chromium.org Change-Id: I7175a7e7bc65bb29bb789e6030d46be33ddd1eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112368Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#752029}
-
Mikel Astiz authored
This reverts commit cd858876. Reason for revert: a more aggressive logic can be implemented and is safer against users that are already in a broken state (empty cache GUID). Original change's description: > Fix sync Nigori cache GUID left empty upon mismatch > > In the error-handling codepath where a mismatch is found on the cache > GUID, when sync is starting for Nigori, the new cache GUID should be > stored in the ModelTypeState. Otherwise, it would remain empty, which > means the next sync start the mismatch detection doesn't take place. > > This can explain cache-GUID mismatches being ignored, and bad > consequences such as violating the sync protocol by sending a non-empty > progress marker despite the sync birthday being empty. > > Change-Id: I48d4b35a61dd20f56c416779bee686e1d582606d > Bug: 1063021 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111090 > Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> > Auto-Submit: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com> > Cr-Commit-Position: refs/heads/master@{#751966} TBR=mastiz@chromium.org,mmoskvitin@google.com,rushans@google.com Change-Id: I2de46c2cd71e30f99b3a953c815de8f78d3a568c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1063021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112631Reviewed-by:
-
Elly Fong-Jones authored
Also, clean up some old NULLs, and 'git cl format' the file. Bug: 39725 Change-Id: I03cd568a537a962ffcd80318026f74b816c0bb10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108829Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#752027}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4b55ff097b9d..f22744971516 git log 4b55ff097b9d..f22744971516 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 sgilhuly@chromium.org Update Scissor code in Skia Dawn Created with: gclient setdep -r src/third_party/skia@f22744971516 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1062664 Tbr: egdaniel@google.com Change-Id: I8268a77633bc5341b824d14dcce802418f749caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112514Reviewed-by:
-
Mark Brand authored
Fixes the deps for profile_import.mojom, and adds missing ipc/SECURITY_OWNERS for the profile_import typemaps. Fixes the includes for policy_value.typemap. Removes the unused V8CacheOptions from web_preferences.typemap. Fully-qualifies several other typemapped types. This is a cherrypick/split from https://chromium-review.googlesource.com/c/chromium/src/+/2108507 Change-Id: Icc4e82dfbe0a04c342e7f51ada54c77b3af77876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107493 Commit-Queue: Mark Brand <markbrand@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#752025}
-
Mario Sanchez Prada authored
As it's also mentioned in crrev.com/c/1117847, it is possible for |frame_| to get reset during the lifetime of RFHI in case the render process crashes, so we need to protect against this to prevent the browser from crashing if a call to SnapshotAccessibilityTree gets run in such scenario. It would be preferable not to allow that to happen in the first place, but such change is out of scope in the context of fixing the particular crash reported in crbug.com/1062442, so let's add an extra check and a TODO pointing to the issue tracking this problem (crbug.com/859110). Bug: 1010831, 1062442 Change-Id: I972302eefb67a6f2a77597de1a8c28d85536b301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112465 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Nohemi Fernandez authored
As a part of the sign-in architecture migration clarify the difference between presenting the sign-in flow for first-run using a navigation controller and presenting the sign-in flow for upgrade and normal sign-in using a view controller. This is a follow-up to patch 2107866. Bug: 971989 Change-Id: Ia31a47b86956e9db701b8cc1ce6679e71c293278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095069Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Auto-Submit: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#752023}
-
Maxim Kolosovskiy authored
http://crrev/750176 introduced |was_lead_warning_shown_| to track whether a credentials leak dialog was shown. The flag was introduced behind the compilation flag ENABLE_PASSWORD_CHANGE. Now we need |was_leak_warning_shown_| even if |ENABLE_PASSWORD_CHANGE| is not defined because the flag will be used by a Java integration test, which is independent of |ENABLE_PASSWORD_CHANGE|. This CL also renames |was_leak_warning_shown_| to |was_leak_dialog_shown_| as it is more consistent with the method name |WasCredentialLeakDialogShown|. Bug: 1057608 Change-Id: Ie0cce7dfd37f967bcd2013b441c0783dbe269c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109704 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#752022}
-
Tricia Crichton authored
Since version 55, wasThrown is no longer a value in a command response dictionary. This CL removes the code that checked wasThrown, and updates the unittests to use the new exceptionDetails label to test for exception notification. Bug: chromedriver:3399 Change-Id: I6de07192d32e9f7a2a86649388cfe397f7694065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111032Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#752021}
-
Elly Fong-Jones authored
These now use BrowserWithTestWindowTest instead. The only wrinkle was that both of these suites need to set up and wait for the bookmark service to be ready. Bug: 39725 Change-Id: I45be03eeade25ac2a0b5b002e81f2f8a46ae0d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108962Reviewed-by:
-
Stephen McGruer authored
On Chromium CI, this occasionally dips above 6s and times out. Looks like its just a bit slow, not hanging entirely, so giving it more time to finish seems ok. Bug: 1062725 Change-Id: I255dc421733cd0938a34ff02b1154d49327a47d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110830Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#752019}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e3bc20cd8816..ed744e295fb9 git log e3bc20cd8816..ed744e295fb9 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 szuend@chromium.org Typecheck sdk/TracingManager.js with TypeScript 2020-03-20 aerotwist@chromium.org [global] Remaps self.SDK.consoleModel 2020-03-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-03-20 tvanderlippe@chromium.org Write .clang-format when updating node_modules 2020-03-20 szuend@chromium.org Typecheck sdk/SDKModel.js using TypeScript 2020-03-20 tvanderlippe@chromium.org Typecheck bindings/LiveLocation.js with TypeScript Created with: gclient setdep -r src/third_party/devtools-frontend/src@ed744e295fb9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1058320,chromium:1061125 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id924fc767b11d86230045038b853f27668b1c2b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112513Reviewed-by:
-
Stephen McGruer authored
On Chromium CI, this occasionally dips above 6s and times out. Looks like its just a bit slow, not hanging entirely, so giving it more time to finish seems ok. Bug: 1060689 Change-Id: I4de10f756760d1cc19183c449aa23fb107e2c858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112408 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
-
Stephen McGruer authored
On Chromium CI these are occasionally spiking to 7s, causing timeouts. Bug: 1062667 Change-Id: Ib4d21732c74c14b83b492945314813eff0f8c36b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110523 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
-
Victor Hugo Vianna Silva authored
This removes an update that got accidentally duplicated in https://chromium-review.googlesource.com/c/chromium/src/+/2014926/1..2 Change-Id: I2b5a92d083c4ca3bbe83dae60408549055384b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111317Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#752015}
-
Brian White authored
Bug: 1053139 Change-Id: Ie9cec438ebfcfe99d1068fec9c89a969e958dd1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108801Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
Stephen Chenney authored
When a background image is positioned with respect to the bottom edge of the background positioning area it may be incorrectly snapped. This is most obvious for very narrow images intended to attach to the edge of the positioning area. Fix such cases by accounting for the existing snapping changes in the positioning area when computing the offset. Bug: 994096 Change-Id: I24f971082a35c4bc9b3e85632f51511cdbf86c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108342 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#752013}
-
Peter Wen authored
This clarifies the intent of the previous _java_header_patterns as well as includes more targets that ultimately uses java_library_impl. Also makes use of filter_exclude for header generation. Bug: 1056299 Change-Id: Ia241a8c7256a567d2d41cbb0901d90cb0c05a29d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110686 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#752012}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a0199a91..65a94404 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia236ea464304831e945d269983f4da1987459a59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111576Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752011}
-
Dan Harrington authored
And forward updates to FeedStream surfaces. Bug: 1044139 Change-Id: I3fada9c5054b2cfa8c3d412bca8a655ac38a2501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107706 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#752010}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/464e9ff4f368..44baaea9783e git log 464e9ff4f368..44baaea9783e --date=short --first-parent --format='%ad %ae %s' 2020-03-20 Richard.Townsend@arm.com fix: use x86 Python 3 binary where available Created with: gclient setdep -r src/third_party/depot_tools@44baaea9783e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I12013be12f833dd927ed4cf4b683f5f1950b5f97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112470Reviewed-by:
-
Clemens Arbesser authored
Bug: b/145043394 Change-Id: I32068d58638d7dfaf94f1112d622118b6bdfafaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107993 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#752008}
-
Fredrik Söderqvist authored
An <svg> element can have both a 'mask' and a '-webkit-mask' property (both yielding a Mask paint property), so we need to (re)check the existence of the masker LayoutObject before creating the SVGMaskPainter. Bug: 1063166 Change-Id: I55ce2b22185275b4dd23aefa65316230d98d960b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111316Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#752007}
-
Liquan (Max) Gu authored
Context: * WebPaymentIntentHelper#createPayIntent * WebPaymentIntentHelper#createIsReadyToPayIntent Change: * throws IllegalArgumentException for these inputs - null or empty packageName - null or empty activityName - null or empty id - null merchantName - null or empty schemelessOrigin - null or empty schemelessIframeOrigin - invalid certificateChain - invalid methodDataMap - null total - invalid modifiers * test all these above Bug: 1057488 Change-Id: I5affd2503551f3976287d3f83c07a126bc8a933c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103863 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#752006}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4432f93ff194..8d03f6fcf682 Created with: gclient setdep -r src-internal@8d03f6fcf682 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ibf94e53eb941fc7e4e2464aa6d06eabb9a259e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112404Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752005}
-
Mathias Bynens authored
DevTools front-end CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2112361 Bug: chromium:1056588 Change-Id: Id9b97397d114a1fe2fb57ca10d0aad3131a7ae44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111179 Commit-Queue: Mathias Bynens <mathias@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#752004}
-
Sami Kyostila authored
Story filters are now required for pinpoint job configs as of https://chromium.googlesource.com/catapult.git/+/41a6191ed80e747e0924c4f9286597f84492b530 Change-Id: I5f3ec92bd6f335ff683dcd002cc90487fce0bfdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112468 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#752003}
-
Gauthier Ambard authored
The |_documentController| wasn't reset between two files, leading to an issue where it wasn't pointing to the correct file. Fixed: 1062392 Change-Id: I5c4214c793c0e4e10f2c16af189c899683ba95b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111092 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
Create a dedicated method in content::mojom::RenderAccessibility to perform hit testing over an accessibility object that expects a reply that might include the required information to perform another hit testing, if a child frame was found to exist at the especified point. By doing this we can remove the HandleAXChildFrameHitTestResult() method, previously added to content::mojom::RenderAccessibilityHost, and fix the current situation where a message from an untrusted renderer would be sent to the browser when a child frame is found, since now such information would be shared as a reply to the original HitTest() method invoked from the browser process. Bug: 1010831, 1060223 Change-Id: I5b60d8a5e4b9f7fb2fc658c4f9156d7721b38db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105217Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#752001}
-
Elly Fong-Jones authored
This change: 1) Moves the bulk of CocoaTest to a separate class, CocoaTestHelper, that can be held as a member 2) Removes CocoaTest::Init, which was misnamed and mostly unused, and replaces it with MarkCurrentWindowsAsInitial for the one use case that does need it 3) Removes a lot of testing macros from the CocoaTest header since they are either unused or only used in a single place 4) Also creates a //chrome CocoaTestHelper analog that bootstraps the Cocoa app bundle, for use in tests that need Cocoa but don't inherit from CocoaTest (eg because they inherit from another fixture) Bug: 39725 Change-Id: I463480fbdbe4942561269478dc2f396db8ea8fb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107766Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#752000}
-
Denis Kuznetsov authored
Bug: 955194 Change-Id: I39b6c4c28ce1ee69f078b3875308b6ca486f749e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110871Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#751999}
-
Mikhail Khokhlov authored
Change-Id: Ia2333c6856de7e9bb8ff1ddd26fba3d0af62d6f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112358Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#751998}
-
Luciano Pacheco authored
Use requestAnimationFrame() to change the CSS to collapsed the search box to give the chance for the button to process the collapse at the click. Add a test so we don't regress on this again. Test: browser_tests --gtest_filter="*searchButtonToggles*" Bug: 1062148 Change-Id: I628fb0b22f0a0223d659743618e7077ff0a7007d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112171 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#751997}
-
