GitLab

https://skia.googlesource.com/skia.git/+log/46a324a16c4b..0952991c4275

2020-08-10 egdaniel@google.com Fix vulkan render pass ctor.
2020-08-10 johnstiles@google.com Replace SkSL string macros with inline constexpr char arrays.
2020-08-10 robertphillips@google.com Remove GrStyledShape.h from GrSmallPathShapeData.h
2020-08-10 johnstiles@google.com Update ProcessorCloneTest to use a processor tree depth of 3.
2020-08-10 johnstiles@google.com Update MakeChildFP to allow processor hierarchies to be created.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC fmalita@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: fmalita@google.com
Change-Id: I65dbd0e87861dd1e8a4f10e23e38f0b0a90ec49c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347310Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#796597}

Bug: 1114251
Change-Id: I59f4fbe6cf6cc96895eb3e2d9bc8b8578009a5c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342256
Auto-Submit: Gary Tong <gatong@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Ilia Samsonov <isamsonov@google.com>
Commit-Queue: Gary Tong <gatong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796596}

Rewrote PRESUBMIT.py (and associated tests) to new format. Runs
REQUIRE_PRESUBMIT_VERSION at the top so that depot_tools can be
made aware of the change and can time/rdb wrap each of the Check...
functions separately, while also ensuring that they have the new
version of depot_tools.

Requires the newer version of presubmit_support.py in depot_tools,
which is described in crrev.com/c/2341828

Change-Id: I102e8c75834aff1eccdf4a27ffe6f0953b76ee57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341362Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Saagar Sanghavi <saagarsanghavi@google.com>
Cr-Commit-Position: refs/heads/master@{#796595}

TBR=rsleevi@chromium.org

Change-Id: If0b22ffdf07996b5c97861521bd950e28c74ec34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346731Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796594}

Current boundsForRange will clip the bounds to ancestors. This CL adds an unclippedBoundsForRange method. The method will not clip bounds to the ancestors of the nodes.

The previous CL 2335390 (Add an optional boolean parameter in boundsForRange) was reverted considering compatibility (see 2343876). The implementation of this CL is similar to 2335390.

Bug: 775659
Change-Id: I189e9f21228e30693b3d89559c20c45afb890593
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345681
Commit-Queue: Lei Shi <leileilei@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796593}

These functions allow a limited range of domains to be encoded in 22
bits for inclusion in BLE adverts.

BUG=1002262

Change-Id: I122af89cada6e6416d3a647b3ecdc724a8289f47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340063
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#796592}

Creates a vpcc box based on the configuration info.

R=sandersd

Bug: 1103432
Test: Updated unittests.
Change-Id: I3d5152b59c6f6ad82da25e699eba2d8bf5ba44ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346607
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796591}

It's flaky.

BUG=1114854
TEST=test only change
TBR=katie@chromium.org

Change-Id: Ia6ccd9a91b654fb3bc36a2da4e37925fd5a13745
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347249
Auto-Submit: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796590}

ag/12295631 refines accessible name computation, therefore we should
not compute accessible_name in two different places.

Bug: b/162193325
Test: None
Change-Id: I466e7c32f47e5578eb38015118a5d598c218a7ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336000
Commit-Queue: Sara Kato <sarakato@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796589}

The original CL was landed in one piece and reverted due to apparent
perf regressions.  Reland in sections to try and determine more
precisely whether there is any perf impact.

This CL lands only test changes, which should have no perf impact.

Bug: none
Change-Id: Iaa9885be7e994328b91da6fa3f24ade20e0ed56a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346935
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796588}

In content scripts, rename match_data_urls to match_origin_as_fallback.
The associated bug has the full discussion, but this field better suits
matching multiple schemes, and will apply to any frame where we need to
compare the initiator/precursor origin.

Note: this is a pure rename CL. It does *not* adjust any of the
functionality.

Bug: 55084
Change-Id: Iec4ba3e8f0bb0559eb800cc3e0d453c7b353598e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340494Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796587}

Some of the entries in UMA for NetworkServiceError shows
as numbers like 21-25 instead of field names.

Extend the NetworkServiceError enum to add new fields

BUG=chromium:1108089

Change-Id: Ibcb8561dd7d8cfe0ebcb99d0aa81e713159fc667
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335804Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Abhishek Kumar <kuabhs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796586}

I'd like to still work on a fix that doesn't reduce the size for bots
with less RAM, but need something quick'ish to fix bot.

Bug: 1098333
Change-Id: Ifdfe8f07712e5073419ea0c0c0eb89092c31a1de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347384
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#796585}

Cause of revert: The previous CL tried to add a key to
accelerators_cocoa.mm without adding to menu item
Solution: remove change in accelerators_cocoa.mm but keep the change in
global_keyboard_shortcuts_mac.mm

This is a reland of 9b3d32d9

Original change's description:
> Tab Search: Setup keyboard shortcut
>
> Setup ctrl(cmd on Mac) + shift + e as tab search keyboard shortcut
> for all desktop platforms
>
> Bug: 1099917,1112558
> Change-Id: I6c50b26714d678d0f89d2c846909ff0b802e4f0d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329944
> Commit-Queue: Yuheng Huang <yuhengh@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Robert Liao <robliao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#795750}

Bug: 1099917
Bug: 1112558
Change-Id: I4639649e6b0b839ead06aac1458c058f20db5fca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343300Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Yuheng Huang <yuhengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796584}

This will prevent Chrome from adding 'import' lines in the future
which could cause a infinite import loop (by importing the combined
property file itself.) See crbug.com/1114279.

This makes our unit tests simpler too.

BUG=None
TEST=arc.Boot.vm, try

Change-Id: I66f58cf4fdce5e2e84de754755e9d90525eb666e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343505Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796583}

SAFE_BROWSING_STANDARD_PROTECTION_EXTENDED_REPORTING_TITLE is used as
a title of Chrome switch preference. It should not be limited to 32
char long. Such limitation makes translation hard to proceed
(b/162847586). A string of the same use case is
PASSWORDS_LEAK_DETECTION_SWITCH_TITLE, which doesn't have such
limitation.

Bug: 1097310
Change-Id: Ie566f819446e9fc1949475681c5709e90ad56893
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343873Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Auto-Submit: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796582}

https://docs.google.com/document/d/1UmT3I_bK-M5nfy--6HcgNAtnfLrG_xN5Fj2WVJgaqlk

Bug: 1112872
Change-Id: I99da26b3a553e8771de53696a24e12cfda44638a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346624
Auto-Submit: Fred Mello <fredmello@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796581}

Command to verify they are sorted:

cat chrome/common/chrome_features.h | \
gawk '{print gensub(/.*Feature[^ ]* ([0-9a-zA-Z_]*).*/,"\\1","g")}' | \
gawk '/^k/' > out/all \
&& cat out/all | LANG=C sort -u > out/sorted \
&& diff -u out/all out/sorted

chrome/common/chrome_features.cc can be checked similarly.
Fixing them was manual.

Bug: None
Change-Id: Ie5639fa4bedc41024f975ad43b8bf5a5149b322f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345944
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796580}

This adds a new bit field 'hidden_' to LocalFrame, to track when a frame
has been hidden/shown. Hidden state doesn't affect intersection
geometry, but it does affect occlusion state as understood by
IntersectionObserver V2.

Also, refactor bool members in LocalFrame into idiomatic bit fields. No
functional change in any of the existing members.

BUG=1114395

Change-Id: I2a09a2e9f5940f5f909413f0cf1c545e16aced4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337343Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796579}

https://dawn.googlesource.com/tint.git/+log/f18d737b4e93..bc80805c4b04

$ git log f18d737b4..bc80805c4 --date=short --no-merges --format='%ad %ae %s'
2020-08-09 dneto [spirv-writer] Infer and emit matrix layout
2020-08-07 sarahmashay [validation] v-0021: cannot re-assign constants
2020-08-06 sarahmashay [Validation] v-0006: variables must be defined before use
2020-08-05 dneto [spirv-reader] Remove support for NumWorkgroups builtin variable
2020-08-05 sarahmashay [validator] implement variable_stack_

Created with:
  roll-dep src/third_party/tint/src

Change-Id: I3531ae47e02d7b10f2317d40b85052eeb32ee125
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346330
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796578}

suitable for nested attribute calls

Bug: 1100991
AX-Relnotes: n/a
Change-Id: Ib0c4512242bad94abf8a0231e129951172e6b584
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274545
Commit-Queue: Alexander Surkov <asurkov@igalia.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796577}

It was to return the visual rect calculated from the cc::Layer's bounds.
It has been doing nothing since we removed DisplayItemClient::VisualRect().

Change-Id: I9104ab23fdd58b4b9362e0c6f4babeef2680e24e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346993Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796576}

Mockito is unable to mock WindowAndroid for Android L, because it uses
Display.Mode that was added in Android M.
Changing tests to use BaseRobolectricTestRunner as unit tests are good
enough for these tests and it also uses sdk 28, which solves the issue.

Bug: 1111408
Change-Id: I1635fcb0ac62372d1a364fd2f72f1fad7927f88f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346790Reviewed-by: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796575}

Bug: 1108130
Change-Id: I455ec24f639ca920d94a4018939f3c602a778c62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346966Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796574}

- Adds a Share action definition to the action factory,
- Adds a Share action to the History context menu,
- Move the Copy action to comply with UX's actions sorting,
- Adds HistoryEntry as a Sharing scenario, with metrics and all.

Bug: 1093302
Change-Id: Iebb8a36e60b823c3adc8ba609373ff27d8b3f7af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333684
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796573}

In preparation for VP9 support, consolidate the multiple paths for
creating VTDecompressionSessions. We had one that was exclusively
for sandbox startup and one for normal decoding. These can be the
same thing, with an admittedly large number of parameters.

R=sandersd

Bug: 1103432
Change-Id: Ic87d9e0e3aef69f7b7356af4d1060f4c55983943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346995Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796572}

This reverts commit 0745b831.

Reason for revert: We still have 10.10 bots on the waterfall. This breaks the Mac10.10 bot. See https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/56807 and the blink_python_tests . Sample error:

[1690/1762] blinkpy.web_tests.servers.cli_wrapper_unittest.CliWrapperTest.test_main_server_error_after_start failed unexpectedly:
  Traceback (most recent call last):
    File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/servers/cli_wrapper_unittest.py", line 54, in test_main_server_error_after_start
      argv=[])
    File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/servers/cli_wrapper.py", line 87, in main
      port_obj = host.port_factory.get(options=options)
    File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/port/factory.py", line 91, in get
      self._host, port_name, options=options, **kwargs)
    File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/port/mac.py", line 71, in __init__
      assert self._version in self.SUPPORTED_VERSIONS
  AssertionError


Original change's description:
> Remove retired mac versions from blinkpy.
> 
> This cl removes blinkpy support for Mac10.10, Mac10.11, and Mac Retina.
> blink web tests for these versions has been removed from waterfall.
> 
> Bug: 1077312, 1107003, 1114680
> Change-Id: I819d0bf7316119b2f5bc127f6eda1deaba7e0cd9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343548
> Commit-Queue: Ilia Samsonov <isamsonov@google.com>
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#796476}

TBR=wangxianzhu@chromium.org,isamsonov@google.com

Change-Id: I196b5f27ab989ea18e0ebccf2164f578826b6a68
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1077312
Bug: 1107003
Bug: 1114680
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347326Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796571}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/c626b912dc45..9f09e3fd0930

2020-08-10 rharrison@google.com Roll 5 dependencies and update expectations (#1129)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: radial-bots+chrome-roll@google.com
Change-Id: Id4aec573c21c9b7b8c82779bce352d54018b1fb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346858Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#796570}

Features.InstrumentationProcessor is already one of the default test
rules in ChromeJUnit4ClassRunner

Bug: 1114451
Change-Id: I86f7e2cdaaa48282d0791d891e326ed6fa8f9fd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344806Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796569}

This external data policy is used to handle the
DeviceExternalPrintServers policy which corresponds with the existing
ExternalPrintServers policy used to manage a list of print servers.

Bug: 1100777
Change-Id: I86028c0451212e506001bbdd8dae8010e88d8608
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290968
Commit-Queue: Matt Menard <mattme@google.com>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Nikita Podguzov <nikitapodguzov@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796568}

The latest/ash-chromium.txt contains the latest version number.

Bug: 1109287
Change-Id: I1797c00ee22720eceb4ea3b43c8d29717b0e6f92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343544
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796567}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: Id50ac4360650c9319396efaca0a27e717440b940
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347307Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#796566}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/03b15131d393..531d992f00bb

2020-08-10 saagarsanghavi@google.com Changed naming convention

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1112667
Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com
Change-Id: I3432c796d49288ab10457261d461379105173fe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347191Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#796565}

This allows us to remove the staging flag to use the image's
own context as the context for the color space conversion.

Bug: skia:104662
Change-Id: Ibe5947dd0be652de11dfbf5d8b1066183eb9ad2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341018Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Adlai Holler <adlai@google.com>
Cr-Commit-Position: refs/heads/master@{#796564}

This reverts commit 4d9f6afe.

Reason for revert: Reason for revert: We still have 10.10 bots on the waterfall. This breaks the Mac10.10 bot. See https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/56807 and the blink_python_tests . Sample error:

[1690/1762] blinkpy.web_tests.servers.cli_wrapper_unittest.CliWrapperTest.test_main_server_error_after_start failed unexpectedly:
  Traceback (most recent call last):
    File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/servers/cli_wrapper_unittest.py", line 54, in test_main_server_error_after_start
      argv=[])
    File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/servers/cli_wrapper.py", line 87, in main
      port_obj = host.port_factory.get(options=options)
    File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/port/factory.py", line 91, in get
      self._host, port_name, options=options, **kwargs)
    File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/port/mac.py", line 71, in __init__
      assert self._version in self.SUPPORTED_VERSIONS
  AssertionError

Original change's description:
> [blinkpy] Drop mac-retina detection from MacPort
> 
> Also remove Retina tags from all expectation files.
> 
> Bug: 1104846
> Change-Id: If16ec3610f4120628f834a72fe02750e70418320
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346855
> Commit-Queue: Robert Ma <robertma@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Auto-Submit: Robert Ma <robertma@chromium.org>
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#796546}

TBR=wangxianzhu@chromium.org,robertma@chromium.org

Change-Id: I62bf3d1704dd3740f16a69e3c9bdf834a379a82c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1104846
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347250Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796563}

As RFC 4517 spec, it is printable string not utf8 string.
ref : https://tools.ietf.org/html/rfc4517#section-3.3.4

Bug: 1114433
Change-Id: Ic60df7bfc3e4b1d94fb045004006fa068b34e985
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315561
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796562}

When working with downstream branches chained to upstream branches, it
helps to use `git rebase -i @{u}` twice to pull upstream changes into
the downstream branch. Expect a lot of merge conflicts when you do
this, as git is often not smart enough to figure out which change
happened more recently, and should take precedence.

Bug: None
Change-Id: Ic742439981d6d63e8d6bd1e10776fa920c88eb7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341387Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796561}

The server provided suggestion header map may come with entries
that do not correspond to any of the matches. Using that map to display
suggestion headers can result in empty headers. This CL fixes that by
using the header information in the matches themselves as the source of
truth about what headers actually exist in the server response. It also
modifies the type annotations to consistently use the "number" type for
the suggestion IDs.

Bug: 1113447
Change-Id: I5f685595cfe5a295d483447e6965cb77b7c581fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347047
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796560}

https://docs.google.com/document/d/1DcIumJ7I-gSFaB0kbrjhfxqvNxKAVvcfKavUVWkxKB0

Bug: 1112872
Change-Id: I3b512197f2969722d5a6cadad18614d5ffd4cac7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346849
Auto-Submit: Fred Mello <fredmello@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796559}

Change:
* Before - when Profile is not available when PaymentRequest is
created, Chrome crashes. After - at the same condition, the transaction
becomes off the record.
* When Profile is not accessible from the ChromeActivity when
PaymentRequest is created, the transaction is dealt with in the manner
as in off-the-record mode.

Bug: 1114138

Change-Id: Ie5b9064e695dda9939543836201523a899ac9f98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342249
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796558}