GitLab

WebRTC 8649:8651
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/b4c07a0..61b3feb

Libjingle 8639:8651
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/c9f4c13..4138f65

TBR=tommi

Review URL: https://codereview.chromium.org/987033002

Cr-Commit-Position: refs/heads/master@{#319635}

InMemoryURLIndex is not used in the history code (except for the creation)
but only by the autocomplete code, so move the code there and all its
related types.

BUG=453790

Review URL: https://codereview.chromium.org/963823003

Cr-Commit-Position: refs/heads/master@{#319634}

Revert of Re-enable Android profiling helper unittests (patchset #1 id:1 of https://codereview.chromium.org/981293002/)

Reason for revert:
Still failing on the FYI bot: http://build.chromium.org/p/chromium.fyi/builders/Android%20Tests%20%28K%20N5%2C%20user%20build%29%28dbg%29

Original issue's description:
> Re-enable Android profiling helper unittests
>
> These seem to be passing locally now.
>
> BUG=437081
>
> Committed: https://crrev.com/49fdcead2be3fb974069fe8b70651e6b26ba9455
> Cr-Commit-Position: refs/heads/master@{#319471}

TBR=primiano@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=437081

Review URL: https://codereview.chromium.org/988403002

Cr-Commit-Position: refs/heads/master@{#319633}

Reorder members for better packing in memory.  Fix indentation.  Remove
redundant private: keyword.  Remove trivial test.

This CL lands server change 87638916 by birenroy.

BUG=

Review URL: https://codereview.chromium.org/987823003

Cr-Commit-Position: refs/heads/master@{#319632}

Revert "ScopedCrashKey doesn't appear to be configured to work on Windows. Manually set the crash key."

This reverts commit af3e767a. The reverted code is a workaround. The root cause is addressed by http://crrev.com/985763004/ .

BUG=460512

Review URL: https://codereview.chromium.org/981183003

Cr-Commit-Position: refs/heads/master@{#319631}

Design: go/chrome-fallback-icons

Fallback icon "explicit flow" URL used to have '#' in hex colors, e.g.:

chrome://fallback-icon/,#01f,#123456,,/http://www.google.com

Problem: "#" denotes fragment in URLs, so we get rid of it. This causes no ambiguity
with named color (e.g., "red") because no named color consists of letters a-f only.
Also adding "ARGB" hex color since this is supported in Skia color parsing.

BUG=455063

Review URL: https://codereview.chromium.org/988863002

Cr-Commit-Position: refs/heads/master@{#319630}

This CL adds a telemetry benchmark to use gmail page and uses the
scrollbar and mouss drag action to scroll the page. The test calculates
the mid-point of scrollbar and drags it till the end of the page.

BUG=464685

Review URL: https://codereview.chromium.org/985603003

Cr-Commit-Position: refs/heads/master@{#319629}

Serializing form_data is required for server-side password generation heuristics. It was implemented on all others platforms before. Here it's implemented in gnome-keyring and libsecret backends (both of them works with Gnome keyring service).

BUG=463126

Review URL: https://codereview.chromium.org/980583002

Cr-Commit-Position: refs/heads/master@{#319628}

BUG=464277

Review URL: https://codereview.chromium.org/980373002

Cr-Commit-Position: refs/heads/master@{#319627}

Changing TabLaunchType from FROM_LINK to FROM_LONGPRESS_FOREGROUND. This should
not have any functionality impact, it's just more correct.

BUG=465329

Review URL: https://codereview.chromium.org/991823003

Cr-Commit-Position: refs/heads/master@{#319626}

Includes some related loading status changes.
BUG=443773

Review URL: https://codereview.chromium.org/981243006

Cr-Commit-Position: refs/heads/master@{#319625}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9434cdf..e08a307

TBR=jbroman@chromium.org

Review URL: https://codereview.chromium.org/991843002

Cr-Commit-Position: refs/heads/master@{#319624}

The purpose is to test CPU usage and vital WebRTC stats over a
longer, more taxing call. Also updates all pages since the GitHub
location has moved again.

BUG=436361

Review URL: https://codereview.chromium.org/962113003

Cr-Commit-Position: refs/heads/master@{#319623}

[Cronet] Make sure to only pass the application Context to InitApplicationContext to avoid DCHECK failures.

An application may have multiple Contexts but only one application Context.  InitApplicationContext DCHECKs if passed more than one Context, so make sure to always pass it only the application Context.
Also, clean up other uses of Contexts in Cronet to only use the application Context when necessary.  Unnecessarily using the application Context was hiding the bug this CL fixes.  I'm renaming variables to make it clear where an application context is needed versus where any Context is okay.  It's good practice to use the Context explicitly passed in as the wrapping it provides may add additional functionality on top of wrapped Contexts and the application Context.
Also, add a test that Cronet can be simultaneously instantiated upon a Context, a wrapped version of the Context and the application Context to verify Cronet doesn't DCHECK.

BUG=453845

Review URL: https://codereview.chromium.org/981013002

Cr-Commit-Position: refs/heads/master@{#319622}

This was causing a crash in Blink with some Chrome Android UI pages. These
pages would disable top controls by setting the height to 0 but when we
scroll the page we calculate the "shown ratio" by dividing by height. This
the divided-by-0 value made its way down to Blink.

BUG=460007

Review URL: https://codereview.chromium.org/982333003

Cr-Commit-Position: refs/heads/master@{#319621}

Revert of Add policy_templates target for GN. (patchset #3 id:40001 of https://codereview.chromium.org/957283003/)

Reason for revert:
Seems to have broken (at least) the Mac GN build:
http://build.chromium.org/p/chromium.mac/builders/Mac%20GN
http://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20(dbg)

Original issue's description:
> Add policy_templates target for GN.
>
> BUG=462362
>
> Committed: https://crrev.com/f24e2a468f0fffe65f626ba5d7c4c0089a78a65e
> Cr-Commit-Position: refs/heads/master@{#319616}

TBR=pneubeck@chromium.org,bauerb@chromium.org,knn@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=462362

Review URL: https://codereview.chromium.org/994533003

Cr-Commit-Position: refs/heads/master@{#319620}

Swap sdefresne@ instead of blundell@ and droger@ as temporary OWNERS of
chrome/browser/favicon during the componentization of the feature.

BUG=359513

Review URL: https://codereview.chromium.org/985073002

Cr-Commit-Position: refs/heads/master@{#319619}

BUG=443095

Review URL: https://codereview.chromium.org/974463002

Cr-Commit-Position: refs/heads/master@{#319618}

As pointed out in https://codereview.chromium.org/906973007/diff/80001/chrome/browser/password_manager/password_store_x.cc#newcode157, instead of overriding Get*LoginsImpl in PasswordStoreX, it is enough to rely on the PasswordStoreDefault implementation of those methods to use PasswordStoreX::Fill*Logins.

The only current difference is that in addition to what Fill*Logins do, PasswordStoreX::Get*LoginsImpl also sorted the logins by origin, to match the order of the login database. There are two ways to fix this:
(1) Move the sorting from Get*LoginsImpl to Fill*Logins.
(2) Drop the sorting.

This CL chose (1). This means that now also PasswordSyncableService::ReadFromPasswordStore, which currently gets the logins unsorted, will perform the sorting. This call should be infrequent enough for this not to be noticeable.r

While (2) would also not break the insides of the password manager, it would degrade the UI (try to find a login in an unsorted list of them). For the reference, the CL which added the sorting was https://codereview.chromium.org/6953010.

BUG=324291

Review URL: https://codereview.chromium.org/986983002

Cr-Commit-Position: refs/heads/master@{#319617}

BUG=462362

Review URL: https://codereview.chromium.org/957283003

Cr-Commit-Position: refs/heads/master@{#319616}

We don't use one on windows either, and e.g. for running V8 compile
jobs, we need a higher stack size limit than we currently have. Instead
of guessing a value, let's just use the default.

BUG=464538
R=mark@chromium.org,rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/992623002

Cr-Commit-Position: refs/heads/master@{#319615}

BUG=464837

Review URL: https://codereview.chromium.org/983283002

Cr-Commit-Position: refs/heads/master@{#319614}

BUG=451004,464993

Review URL: https://codereview.chromium.org/976313003

Cr-Commit-Position: refs/heads/master@{#319613}

Cr-Commit-Position: refs/heads/master@{#319612}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/cedc36f..1b110d6

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/989193002

Cr-Commit-Position: refs/heads/master@{#319611}

WebRTC 8646:8649
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/a2bd4b8..b4c07a0

TBR=

Review URL: https://codereview.chromium.org/994503002

Cr-Commit-Position: refs/heads/master@{#319610}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/27dc83a..9434cdf

TBR=jbroman@chromium.org

Review URL: https://codereview.chromium.org/987013002

Cr-Commit-Position: refs/heads/master@{#319609}

The tests are tagged for rebaseline in Blink now, new results trickling
in.

BUG=458898
TBR=reed@google.com,robertphillips@google.com

Review URL: https://codereview.chromium.org/990103002

Cr-Commit-Position: refs/heads/master@{#319608}

Previously, the callback would be run when a new Profile object was instantiated, even when the profile already existed on disk. This would have the effect of reopening windows for closed profiles, when we just want to preload the profile on Mac.

BUG=463898

Review URL: https://codereview.chromium.org/961863006

Cr-Commit-Position: refs/heads/master@{#319607}

Looks like nobody is using this target according to
https://code.google.com/p/chromium/codesearch#chromium/src/build/all.gyp&q=chromium_builder_perf_av&sq=package:chromium&l=645

BUG=224072
TEST=trybots
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/984363002

Cr-Commit-Position: refs/heads/master@{#319606}

BUG=464890
R=fukino@chromium.org

Review URL: https://codereview.chromium.org/980423003

Cr-Commit-Position: refs/heads/master@{#319605}

BUG=464030

Review URL: https://codereview.chromium.org/984073003

Cr-Commit-Position: refs/heads/master@{#319604}

 menuitem

The condition to check the status of "resume" was wrong. This patch fixes it by flipping the condition.

BUG=465193
TBR=asanka@chromium.org

Review URL: https://codereview.chromium.org/991753002

Cr-Commit-Position: refs/heads/master@{#319603}

This is a clean up CL and should not change any behavior.

BUG=none
TEST=browsertest passes

Review URL: https://codereview.chromium.org/984593002

Cr-Commit-Position: refs/heads/master@{#319602}

NOTRY=true
R=jkummerow@chromium.org
TBR=jkummerow@chromium.org
BUG=465187

Review URL: https://codereview.chromium.org/989183002

Cr-Commit-Position: refs/heads/master@{#319601}

Cr-Commit-Position: refs/heads/master@{#319600}

BUG=449754
R=thakis@chromium.org
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/988243002

Cr-Commit-Position: refs/heads/master@{#319599}

BUG=458898
TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/926403002

Cr-Commit-Position: refs/heads/master@{#319598}

This is dependent on https://codereview.chromium.org/965903003/

BUG=377250

Review URL: https://codereview.chromium.org/968663004

Cr-Commit-Position: refs/heads/master@{#319597}

BUG=413437

Review URL: https://codereview.chromium.org/990503002

Cr-Commit-Position: refs/heads/master@{#319596}