- 17 Mar, 2017 40 commits
-
-
rsesek authored
BUG=166704 Review-Url: https://codereview.chromium.org/2748393002 Cr-Commit-Position: refs/heads/master@{#457773}
-
Blink W3C Test Autoroller authored
Using wpt-import in Chromium 6f8c23bd. Build: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/8014 Directory owners for changes in this CL: dom-dev@chromium.org: external/wpt/html jsbell@chromium.org: external/wpt/common suzyh@chromium.org: external/wpt/web-animations TBR=qyearsley@chromium.org NOEXPORT=true Change-Id: I8294ca176bd28212fadcf0c49a42e991036b9fa7 Reviewed-on: https://chromium-review.googlesource.com/456677Reviewed-by:
Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org> Commit-Queue: Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#457772}
-
mcasas authored
This CL adds MediaStreamTrack.applyConstraints() method behind a flag (that is implied if ImageCapture is on). The method essentially derives to ImageCapture::setMediaTrackConstraints(); this one prepares a mojo::PhotoSettings and applies it via mojo interface. Only simple Constrains are supported now, i.e., {zoom : 3.14} is supported, but {zoom : { ideal : 100}} or {zoom : { exact : 27}} are not (TBD later). LayoutTests are added where appropriate. Also a cleanup: methods that return Promises are not supposed to throw exceptions; so I removed an unused ExceptionState from some ImageCapture methods. applyConstraints() when called without the optional argument |constraints|, and is supposed to do... nothing? Filed Spec bug: https://github.com/w3c/mediacapture-main/issues/438 BUG=700607 Review-Url: https://codereview.chromium.org/2757673005 Cr-Commit-Position: refs/heads/master@{#457771}
-
rsleevi authored
Absolutify the links, per https://gerrit.googlesource.com/gitiles/+/HEAD/Documentation/markdown.md documenting support, fix a mailto link (which auto-linking broke), and fix a '/` typo BUG=700973 TBR=eranm@chromium.org Review-Url: https://codereview.chromium.org/2758763002 Cr-Commit-Position: refs/heads/master@{#457770}
-
treib authored
Hidden behind a flag, so no user-visible changes yet. BUG=690467 Review-Url: https://codereview.chromium.org/2749813002 Cr-Commit-Position: refs/heads/master@{#457769}
-
Vasilii Sukhanov authored
BUG=701451 TBR=fukino@chromium.org Review-Url: https://codereview.chromium.org/2748383006 . Cr-Commit-Position: refs/heads/master@{#457768}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7b2dc0f0d467..689eddc13b0f $ git log 7b2dc0f0d..689eddc13 --date=short --no-merges --format='%ad %ae %s' 2017-03-17 nednguyen Remove oomkiller_profiler Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2749383004 Cr-Commit-Position: refs/heads/master@{#457767}
-
rsleevi authored
BUG=700973 Review-Url: https://codereview.chromium.org/2756633002 Cr-Commit-Position: refs/heads/master@{#457766}
-
eugenebut authored
Also removed PendingIndexNavigationDisabled experimental setting. BUG=692331,701717 TEST=Back forward navigation works correctly. Original Review-Url: https://codereview.chromium.org/2751793002 Review-Url: https://codereview.chromium.org/2756753002 Cr-Commit-Position: refs/heads/master@{#457765}
-
eugenebut authored
Replaced with WebStateObserver::DidSuppressDialog callback. In content dialogs suppression is implemented via a single callback: WebContentsDelegate::ShouldSuppressDialogs. This callback is called before showing a dialog. On iOS implementing the same API would require a roundtrip (JS->Native->JS). This is because WKWebView does not provide any callbacks for showing geolocation dialogs. So on iOS dialogs blocking is implemented in JS as a boolean flag which is set by WebState::SetShouldSuppressDialogs. Embedder still needs a callback to know if the dialog was suppressed which is implemented as WebStateObserver::DidSuppressDialog and require only one JS->Native message. BUG=674991 Review-Url: https://codereview.chromium.org/2755013002 Cr-Commit-Position: refs/heads/master@{#457764}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/73e21af21390..a392dbaa998e $ git log 73e21af21..a392dbaa9 --date=short --no-merges --format='%ad %ae %s' 2017-03-16 bsalomon Revert "Revert "Revert "Revert "Detect Chrome either by renderer or version strings."""" 2017-03-17 reed Revert "More SkVertices implementation work" Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=borenet@chromium.org Change-Id: I14dd58faedbdeecdfe87319012a5750fd46de375 Reviewed-on: https://chromium-review.googlesource.com/456620Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#457763}
-
rune authored
When blocks in inlines break lines, we don't create LayoutObjects for whitespace Text nodes following those blocks unless they are out-of-flow. However, we incorrectly didn't skip floats looking for such blocks which caused us to drop whitespace LayoutObjects after floats. R=mstensho@opera.com BUG=569786 Review-Url: https://codereview.chromium.org/2757563006 Cr-Commit-Position: refs/heads/master@{#457762}
-
mattm authored
BUG=none Review-Url: https://codereview.chromium.org/2756733003 Cr-Commit-Position: refs/heads/master@{#457761}
-
estade authored
Changes include: - if a window specifies a non-default shadow elevation, use that for both the active and inactive state (shadow_controller.cc) instead of just the inactive state. - make the contents of the info bubble a single, multi-line, selectable label. To be selectable, the bubble must be activatable. This is somewhat trickier because the system menu bubble wants to close itself whenever activation changes.* - Better internationalization for contents of network info bubble. - New layout for InfoBubble. *Network info bubble should close when the user mouses out, when the system bubble closes, when the user presses the back arrow, or when the user presses the (i) again. BUG=676395,341706 Review-Url: https://codereview.chromium.org/2754963002 Cr-Commit-Position: refs/heads/master@{#457760}
-
teravest authored
This migrates the variables in chromeos.gyp to BUILD.gn, making the source easier to read. This also lets us remove a use of exec_script, so chromeos/BUILD.gn no longer has to be whitelisted to use it. BUG=701617 Review-Url: https://codereview.chromium.org/2753883002 Cr-Commit-Position: refs/heads/master@{#457759}
-
blundell authored
This CL relaxes the precision of a floating-point comparison made in the zoom browsertest to avoid spurious test failures. BUG=702269 Review-Url: https://codereview.chromium.org/2761473002 Cr-Commit-Position: refs/heads/master@{#457758}
-
arthursonzogni authored
Use a NavigationThrottle to check infringement of the 'frame-src' on the browser-side. Before this patch, a redirect during the navigation could led to a child frame to be displayed inside its parent, even if it was disallowed by its parent. BUG=685074 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_site_isolation,linux_chromium_browser_side_navigation_rel Review-Url: https://codereview.chromium.org/2655463006 Cr-Commit-Position: refs/heads/master@{#457757}
-
danakj authored
Revert of Disable flaky TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer (patchset #2 id:20001 of https://codereview.chromium.org/2756853002/ ) Reason for revert: Disables half of cc unittests, this is of course not good. Original issue's description: > Disable flaky TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer > > BUG=702329 > TBR=enne@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2756853002 > Cr-Commit-Position: refs/heads/master@{#457697} > Committed: https://chromium.googlesource.com/chromium/src/+/a2ef1195d4f15d4a589110dd682baaa1174225b8 TBR=enne@chromium.org,nhiroki@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=702329 Review-Url: https://codereview.chromium.org/2761483002 Cr-Commit-Position: refs/heads/master@{#457756}
-
aberent authored
During restore save the result of the restore (success, or failure with reason) in a SharedPreference. The first time Chrome is run copy this value to a UMA histogram, or record that no restore happened. BUG=685774 Review-Url: https://codereview.chromium.org/2750323002 Cr-Commit-Position: refs/heads/master@{#457755}
-
tzik authored
Taking a method pointer to Callback::Run is problematic for upcoming refactoring of it. Review-Url: https://codereview.chromium.org/2754793003 Cr-Commit-Position: refs/heads/master@{#457754}
-
sigbjornf authored
Attempt to diagnose a crash condition by locking out main thread GCs while the audio thread propagates consumeAudio() updates. R=haraken BUG=682945 Review-Url: https://codereview.chromium.org/2761463002 Cr-Commit-Position: refs/heads/master@{#457753}
-
clamy authored
SecurityExploitBrowserTest.AttemptDuplicateRenderWidgetHost has been failing a flaky manner on Android. This CL makes it return early on Android when PlzNavigate is enabled while we investigate the root cause of the failure. BUG=702584 TBR=nasko@chromium.org Review-Url: https://codereview.chromium.org/2759653002 Cr-Commit-Position: refs/heads/master@{#457752}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/14583e11fd62..73e21af21390 $ git log 14583e11f..73e21af21 --date=short --no-merges --format='%ad %ae %s' 2017-03-17 borenet Revert "Add color spin test for SkColorSpaceXformCanvas" Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=borenet@chromium.org Change-Id: I48d3b774634d0e148a33f96b85af5df082d85c19 Reviewed-on: https://chromium-review.googlesource.com/456486Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#457751}
-
Vasilii Sukhanov authored
BUG=689662 TBR=gangwu@chromium.org Review-Url: https://codereview.chromium.org/2757833004 . Cr-Commit-Position: refs/heads/master@{#457750}
-
dgn authored
This flag will allow devs having access to the internal Chrome for Android repo to choose whether to use it in their builds. BUG=702323 Review-Url: https://codereview.chromium.org/2753273002 Cr-Commit-Position: refs/heads/master@{#457749}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bac1574d..f8189977 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2759503003 Cr-Commit-Position: refs/heads/master@{#457748}
-
Vasilii Sukhanov authored
BUG=701924 TBR=yoshiki@chromium.org Review-Url: https://codereview.chromium.org/2756593005 . Cr-Commit-Position: refs/heads/master@{#457747}
-
guidou authored
This is a step towards making getUserMedia() more spec-compliant. See https://w3c.github.io/mediacapture-main/#dom-mediadevices-getusermedia BUG=690491 Review-Url: https://codereview.chromium.org/2749893004 Cr-Commit-Position: refs/heads/master@{#457746}
-
thanhph authored
Adding visibility property will enable a window/widget/view to be shown or hidden by simply changing the value 1 (visible) to 0 (hide) in the element CSS style. BUG=697175 Review-Url: https://codereview.chromium.org/2739523002 Cr-Commit-Position: refs/heads/master@{#457745}
-
sergiyb authored
R=stgao@chromium.org, tandrii@chromium.org CC=sshruthi@chromium.org BUG=702202 Review-Url: https://codereview.chromium.org/2754063002 Cr-Commit-Position: refs/heads/master@{#457744}
-
yutak authored
A CL (https://codereview.chromium.org/2741343017) failed to compile on Windows Debug try bots because files in wtf/ lacked __declspec(dllimport) even though they need to import symbols defined in platform_wtf. Conceptually, platform_wtf and wtf are a single link unit, thus the target type of "component" was inappropriate; it should have been "source_set" instead. This change is supposed to fix the compile error mentioned above. BUG=691465 Review-Url: https://codereview.chromium.org/2760573002 Cr-Commit-Position: refs/heads/master@{#457743}
-
Vasilii Sukhanov authored
BUG=702171 TBR=nhiroki@chromium.org Review-Url: https://codereview.chromium.org/2753223003 . Cr-Commit-Position: refs/heads/master@{#457742}
-
finnur authored
This is the first step towards implementing a new Photo Picker for Chrome for Android, broken down into multiple steps for easier reviewing. First part includes simply replacing the stock Android picker with a Toast saying "Not implemented". Includes a Finch tie-in and a flag to turn this on manually ("Enable new photopicker" in chrome://flags). BUG=656015 Review-Url: https://codereview.chromium.org/2737393002 Cr-Commit-Position: refs/heads/master@{#457741}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/dea7428b96ba..14583e11fd62 $ git log dea7428b9..14583e11f --date=short --no-merges --format='%ad %ae %s' 2017-03-16 reed More SkVertices implementation work Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=borenet@chromium.org Change-Id: I9586804667a1f5cab2677afb99db39383b5050db Reviewed-on: https://chromium-review.googlesource.com/456588Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#457740}
-
nhiroki authored
This CL removes DOMWrapperWorld::fromWorldId() that looks like a simple getter but actually has a side effect like this: 1) When a given id is for the main world, ensures the main world and returns it. 2) When a given id is for an isolated world, ensures the isolated world and returns it. 3) Otherwise, looks up a given id in the world map and then returns the finding. If the world doesn't exist, returns nullptr. After this CL, mainWorld() is used for 1) and ensureIsolatedWorld() is used for 2). fromWorldId() hasn't been used for 3), so this CL does not introduce an alternative for the case. Also, this CL pushes the main world into the world map for cleanup. Before this CL, the main world is managed separately from other worlds. Managing all worlds in the single map would be simpler. BUG=697622, 697629 Review-Url: https://codereview.chromium.org/2753013003 Cr-Commit-Position: refs/heads/master@{#457739}
-
gambard authored
This CL adds headers for the Content Suggestions sections. BUG=702236 Review-Url: https://codereview.chromium.org/2751653008 Cr-Commit-Position: refs/heads/master@{#457738}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4e3e3842..bac1574d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2756123002 Cr-Commit-Position: refs/heads/master@{#457737}
-
horo authored
This CL blocks responding to requests which redirect mode is not 'follow' with redirected responses. BUG=669363,658249 Review-Url: https://codereview.chromium.org/2755643004 Cr-Commit-Position: refs/heads/master@{#457736}
-
pfeldman authored
BUG=702498 Review-Url: https://codereview.chromium.org/2753063003 Cr-Commit-Position: refs/heads/master@{#457735}
-
ehmaldonado authored
BUG=chromium:702201 R=sullivan@chromium.org, nednguyen@google.com Review-Url: https://codereview.chromium.org/2744243007 Cr-Commit-Position: refs/heads/master@{#457734}
-