GitLab

../../chrome/installer/mac/app/NetworkCommunication.m:48:17: error: 'dataTaskWithRequest:completionHandler:' is partial: introduced in macOS 10.9 [-Werror,-Wpartial-availability]
      [session_ dataTaskWithRequest:request_
                ^
/Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:203:1: note: 'dataTaskWithRequest:completionHandler:' has been explicitly marked partial here
- (NSURLSessionDataTask *)dataTaskWithRequest:(NSURLRequest *)request completionHandler:(void (^)(NSData *data, NSURLResponse *response, NSError *error))completionHandler NS_CLASS_AVAILABLE(NSURLSESSION_AVAILABLE, 7_0);
^
../../chrome/installer/mac/app/NetworkCommunication.m:48:17: note: explicitly redeclare 'dataTaskWithRequest:completionHandler:' to silence this warning
      [session_ dataTaskWithRequest:request_
                ^
../../chrome/installer/mac/app/NetworkCommunication.m:57:30: error: 'downloadTaskWithRequest:completionHandler:' is partial: introduced in macOS 10.9 [-Werror,-Wpartial-availability]
    downloadTask = [session_ downloadTaskWithRequest:request_
                             ^
/Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:218:1: note: 'downloadTaskWithRequest:completionHandler:' has been explicitly marked partial here
- (NSURLSessionDownloadTask *)downloadTaskWithRequest:(NSURLRequest *)request completionHandler:(void (^)(NSURL *location, NSURLResponse *response, NSError *error))completionHandler NS_CLASS_AVAILABLE(NSURLSESSION_AVAILABLE, 7_0);
^
../../chrome/installer/mac/app/NetworkCommunication.m:57:30: note: explicitly redeclare 'downloadTaskWithRequest:completionHandler:' to silence this warning
    downloadTask = [session_ downloadTaskWithRequest:request_
                             ^

R=dpranke@chromium.org, mark@chromium.org
BUG=627890

Review URL: https://codereview.chromium.org/2144033002 .

Cr-Commit-Position: refs/heads/master@{#405219}

git cl try now schedules CQ dry run by default.

BUG=577224
R=sergiyb@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2151543002
Cr-Commit-Position: refs/heads/master@{#405218}

This creates a copy of the downstream web_js_test.h upstream in
ios/web/public/test and puts it into the ios_web_test_support build target
(+equivalent in GN).

The upstream web_js_test.h is an almost-identical copy of the downstream version, with 2 differences:
  (1) git cl format is required upstream, which changed indenting in a single location.
  (2) namespace web was introduced to match the style of the target directory.

BUG=627775

Review-Url: https://codereview.chromium.org/2150513002
Cr-Commit-Position: refs/heads/master@{#405217}

DevTools: Move Spectrum from elements/ to components/ so that it can be used in both Sources and Elements.

Review-Url: https://codereview.chromium.org/2142133002
Cr-Commit-Position: refs/heads/master@{#405216}

DevTools: Added styling to checkboxes so that a focus state is displayed when tabbing through the checkboxes (for keyboard accessibility).

BUG=580199

Review-Url: https://codereview.chromium.org/2096183002
Cr-Commit-Position: refs/heads/master@{#405215}

BUG=626740

Review-Url: https://codereview.chromium.org/2142283002
Cr-Commit-Position: refs/heads/master@{#405214}

media/audio/audio_device_description.h.  The renderer needs a way to specify which audio device the sound should be play out.

Bug=b/28193093

Review-Url: https://codereview.chromium.org/2016053003
Cr-Commit-Position: refs/heads/master@{#405213}

Each story in the benchmark does the following:
1. Load the main page.
2. Open and scroll the first news item.
3. Go back to the main page and scroll it.
4. Open and scroll the second news item.
5. Go back to the main page and scroll it.
6. etc.

This workflow is interesting because it is close to real world
and generates a lot of garbage by creating and discarding pages.

A couple of websites crash with OOM on svelte device, so by
tracking and optimizing for this benchmark we can improve
user experience on low-memory devices.

*** NOTE TO SHERRIF ***
Regressions are expected in system_health.memory_mobile and
system_health.memory_desktop for the following stories:
- load:news:cnn
- load:social:facebook
- load:news:qq
- load:news:reddit
- load:social:twitter

If there are failing tests in form of benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.*
please do not revert this CL but instead disabling failing
test by adding them into the _DISABLE_TESTS list in
tools/perf/benchmarks/system_health_smoke_test.py

BUG=589726
CQ_INCLUDE_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2118293002
Cr-Commit-Position: refs/heads/master@{#405212}

Make gfx::ColorSpace have an internal pointer to a globally-unique
structure for the color space, where its ICC profile can be stored.

BUG=622133

Review-Url: https://codereview.chromium.org/2140803002
Cr-Commit-Position: refs/heads/master@{#405211}

Eliminates races between IPCChannelPosixTest instances
which were all using the same named pipe path to establish
an IPC channel.

BUG=627730
R=amistry@chromium.org

Review-Url: https://codereview.chromium.org/2141403002
Cr-Commit-Position: refs/heads/master@{#405210}

BUG=627668

Review-Url: https://codereview.chromium.org/2140413002
Cr-Commit-Position: refs/heads/master@{#405209}

BUG=624452

Review-Url: https://codereview.chromium.org/2104393002
Cr-Commit-Position: refs/heads/master@{#405208}

TBR=zmo@chromium.org
TBR=kbr@chromium.org

BUG=598902
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2146003002
Cr-Commit-Position: refs/heads/master@{#405207}

Specifically:

- chromium.chromiumos
  - Linux ChromiumOS Ozone Builder
- tryserver.chromium.linux
  - linux_chromium_chromeos_ozone_rel_ng

These are the last main CrOS builders on GYP. There are still
three memory-related builders on GYP, waiting for the "v8_target_cpu"
fixes to land ...

R=stevenjb@chromium.org
BUG=605732

Review-Url: https://codereview.chromium.org/2143453002
Cr-Commit-Position: refs/heads/master@{#405206}

results.

When you re-open the find bar and it's prepopulated with a previous
search, we don't execute a search until you press enter or
next/previous. Before this patch, next/previous was disabled when you
have prepopulated search text but no actual search.

BUG=627356

Review-Url: https://codereview.chromium.org/2143703002
Cr-Commit-Position: refs/heads/master@{#405205}

BUG=627306

Review-Url: https://codereview.chromium.org/2138123003
Cr-Commit-Position: refs/heads/master@{#405204}

It's a one-liner, too.

R=esprehn

Review-Url: https://codereview.chromium.org/2141093004
Cr-Commit-Position: refs/heads/master@{#405203}

This is part of a refactor to split WebView/WebWidget.

BUG=419087

Review-Url: https://codereview.chromium.org/2043903002
Cr-Commit-Position: refs/heads/master@{#405202}

Removed the hard coded drawings for the Omnibox vector icons.
Replace them with a call to CreateVectorIcon()

BUG=621302

Review-Url: https://codereview.chromium.org/2129723003
Cr-Commit-Position: refs/heads/master@{#405201}

BUG=588956

Review-Url: https://codereview.chromium.org/2145893003
Cr-Commit-Position: refs/heads/master@{#405200}

There already are versions of these split by tile source, but the accumulated totals weren't there.

BUG=611341

Review-Url: https://codereview.chromium.org/2131133003
Cr-Commit-Position: refs/heads/master@{#405199}

Doing this causes any open controls including autofill to be closed.

BUG=622603

Review-Url: https://codereview.chromium.org/2146743002
Cr-Commit-Position: refs/heads/master@{#405198}

Revert of Forward password-store switch to OSCrypt component (patchset #15 id:310001 of https://codereview.chromium.org/2118443002/ )

Reason for revert:
mahmadi@ reported reaching the DCHECK in components/os_crypt/os_crypt_linux.cc

Original issue's description:
> Forward password-store switch to OSCrypt component
>
> Password manager uses a switch to allow the user to override the
> auto-detection of the appropriate password store. OSCrypt should
> respect this switch as well.
>
> The switch value is read and passed to OSCrypt at a very early
> point in Chrome's start, before any of OSCrypt's dependents
> use it.
>
> I also reworked OSCrypt's build to make it simpler for chrome to
> deduce whether the linux implementation of OSCrypt will be used.
>  - Previously, os_crypt_linux was used only if we also decided to
>    link at least one linux backend. Otherwise we used os_crypt_posix.
>  + Now, we always use the linux implementation for linux. If no
>    KeyStorage is linked, the linux implementation defaults to the
>    same behavior as for posix.
>
> BUG=602624
>
> Committed: https://crrev.com/92699e345c15243c4023a8739101333ed2658e37
> Cr-Commit-Position: refs/heads/master@{#405114}

TBR=thestig@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=602624

Review-Url: https://codereview.chromium.org/2152493002
Cr-Commit-Position: refs/heads/master@{#405197}

- Update chrome_device_settings.proto to include report setting
  for os_update_status and running_kiosk_app;
- Update device_management_backend.proto to include os_update_status
  and running_kiosk_app in DeviceStatusReportRequest;

BUG=577800
TEST=browser_tests --gtest_filter=DeviceStatusCollectorTest.*OsUpdateStatus*:
    DeviceStatusCollectorTest.*RunningKioskApp*

Review-Url: https://codereview.chromium.org/2132663002
Cr-Commit-Position: refs/heads/master@{#405196}

pointer lock.

This CL fixes two separate issues. One is that when a
CrossProcessFrameConnector is being destroyed, if the
RenderWidgetHostViewChildFrame holds the mouse lock it must
unlock the mouse.

The second issue is that when flash holds a fullscreen
pointer lock and releases it, the WebContents is notified
of the lost mouse lock, even though it was never notified
that the mouse lock was acquired (because flash has extra
privileges to acquire the lock).

BUG=619571
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2112923002
Cr-Commit-Position: refs/heads/master@{#405195}

This check is now made at presubmit time, preventing hard to debug failure on
the infrastructure.

The failure mode is not obvious, the recipe throw an exception at trigger time
and this is hard to diagnose.

This fixes the problem before this is even sent to run as a try job.

Tested manually.

R=thakis@chromium.org
BUG=626766

Review-Url: https://codereview.chromium.org/2151503003
Cr-Commit-Position: refs/heads/master@{#405194}

BUG=none

Review-Url: https://codereview.chromium.org/2131863002
Cr-Commit-Position: refs/heads/master@{#405193}

|EVP_PKEY_up_ref| was a BoringSSL addition to OpenSSL The next major,
public OpenSSL release will include it, but it'll return 0/1 rather than
the object being referenced.

This change updates Chromium to expect that function signature (in a
backwards compatible way). Once all callers have been updated likewise,
BoringSSL will align this function with upstream OpenSSL.

BUG=none

Review-Url: https://codereview.chromium.org/2113143004
Cr-Commit-Position: refs/heads/master@{#405192}

"Bookmark added!" => "Bookmark added"

ainslie@ says it doesn't belong.

BUG=none

Review-Url: https://codereview.chromium.org/2142103002
Cr-Commit-Position: refs/heads/master@{#405191}

The CL 2129543002 introduced an option to override variation parameters
using a feature in chrome://flags. The list of options for the given
feature always includes "Default", "Enabled", and "Disabled". Even
though the semantics of "Enabled" was meant as 'enabled with the default
parameter values', the API forced to specify the variation for "Enabled"
as well.

This is unnecessarily cumbersome and confusing. This CL makes the
"Enabled" option completely automatic - no need to specify its variation
any more.

BUG=609059

Review-Url: https://codereview.chromium.org/2146903002
Cr-Commit-Position: refs/heads/master@{#405190}

The bug was introduced in the last patch set of
https://codereview.chromium.org/2129213003/.
1. Open an app window with insets (hidden header) and a few other windows.
2. Enter overview
3. While in overview close a few windows so that all windows grow.
4. Close overview by clicking the window with active shape (app frame).

The first active window has its header and some client area content
masked.

BUG=624431
TBR=tdanderson@chromium.org

Review-Url: https://codereview.chromium.org/2148703002
Cr-Commit-Position: refs/heads/master@{#405189}

More sprinkling of artisanal const &s.

BUG=None

Review-Url: https://codereview.chromium.org/2141753002
Cr-Commit-Position: refs/heads/master@{#405188}

Mark ref test affected by same change as Pass Failure

BUG=627844

Review-Url: https://codereview.chromium.org/2143983003
Cr-Commit-Position: refs/heads/master@{#405187}

This CLs adds an entry in mb_config.pyl for a new Cronet Release Asan bot.

BUG=567323

Review-Url: https://codereview.chromium.org/2143363003
Cr-Commit-Position: refs/heads/master@{#405186}

The issues w/ the remoting targets have been addressed, so let's
give this another try.

TBR=rsesek@chromium.org
BUG=618468

Review-Url: https://codereview.chromium.org/2143863002
Cr-Commit-Position: refs/heads/master@{#405185}

Update the ordering of polymer properties passed to Polymer() to match
https://www.chromium.org/developers/web-development-style-guide.

BUG=529395
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2140513003
Cr-Commit-Position: refs/heads/master@{#405184}

BUG=612205
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2076213002
Cr-Commit-Position: refs/heads/master@{#405183}

The test is exceedingly simple. It uses requestAnimationFrame and WebGL APIs
to animate the background color of the page.

BUG=616811

Review-Url: https://codereview.chromium.org/2143523002
Cr-Commit-Position: refs/heads/master@{#405182}

"Toasts" are ARC++ notifications coming from the Android side. These need
to migrate to WmWindow/WmShell so we can use them in mus.

Also make sure the toast bounds are computed based on the "target" root window
where they will appear. The existing code placed the toasts on the target root
window (which could be the secondary display), but used the primary display's
bounds for positioning.

TODO - Convert the unit test, which relies on DisplayManager for unified
desktop mode.

BUG=619636
TEST=ash_unittests, manually spawn toasts with Ctrl-Alt-Shift-O

Review-Url: https://codereview.chromium.org/2139183003
Cr-Commit-Position: refs/heads/master@{#405181}

BUG=566163
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2138183002
Cr-Commit-Position: refs/heads/master@{#405180}