- 19 Sep, 2019 21 commits
-
-
Antonio Gomes authored
It is an empty folder now. BUG=787254 R=haraken@chromium.org Change-Id: Ie970a5fc4c92d02a8379df5dd5db7dfd4e6ea992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806848 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#697854}
-
Henrique Ferreiro authored
Convert the implementation and all users of the feed_internals::mojom::PageHandler interface. Bug: 955171 Change-Id: I9d85ac453e31e111596adf469b4cba9cb2867253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807828Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#697853}
-
Julie Jeongeun Kim authored
This CL converts NaClRendererHost and NaClExitControl to new Mojo types. It also updates ProvideExitControl from nacl.mojom and methods and members which implement it. Bug: 955171 Change-Id: Ie6b875e07796b08818825474e8493e5f48072c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810509Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#697852}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8b95eac85df9..f314a97e3bde Created with: gclient setdep -r src-internal@f314a97e3bde If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1000513 Change-Id: Ia26f67ed2744f826667db3292755c426a8f22e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812240Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697851}
-
chrome://media-appchrome://media-app-guestTrent Apted authored
Installs these routes as webui with basic structure and no permissions. Code added as a component in //chromeos/components/media_app_ui so that any chrome dependencies are clearly documented. --enable-features=MediaApp is required to enable the app at runtime on ChromeOS. The app is loaded as a guest (currently in an <iframe>) hosted in another chrome:// WebUI host that may be granted privileges in future. Currently the WebUI loaded in the <iframe> uses a chrome:// scheme, but this is not the long-term plan. A js2gtest is added with a test fixture that enables these flags and does integration testing. A build-time flag, enable_cros_media_app determines the bulk of what is served inside the sandboxed guest. When false, it provides a mock that facilitates integration testing even when is_chrome_branded is false. An internal change - https://crrev.com/i/1646974 - provides the content when is_chrome_branded is true (enable_cros_media_app must be set manually in args.gn until that lands). Bug: 996088 Change-Id: Ied7a41795409bdc8c028e63155f37452be84532e Test: MediaAppUIBrowserTest.WebviewHasAppElement Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767457 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#697850}
-
Sarthak Shah authored
This CL adds a flag parameter named "Enable experiment fling animation". This flag will be consumed by Gerrit CL https://crrev.com/c/1773872. Change-Id: I931b6034f76957d868c3e4f95f1cd1d5f7bfd26a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804460Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Sarthak Shah <sarsha@microsoft.com> Cr-Commit-Position: refs/heads/master@{#697849}
-
Patrick Monette authored
Bug: 993029 Change-Id: I340a39e49f1ca80f874c879f28368a1c76084b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787888 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#697848}
-
Eric Willigers authored
Split WebAppControllerBrowserTestBase out from WebAppControllerBrowserTest, so more tests can be parameterized on BMO flags. BookmarkAppTest now uses WebAppControllerBrowserTestBase. Bug: 966290 Change-Id: I01cc42152ddb5348c65271b4158daa48a9c016b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809129Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#697847}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/db09eb68b9de..2f2ea8b465ed git log db09eb68b9de..2f2ea8b465ed --date=short --no-merges --format='%ad %ae %s' 2019-09-18 geofflang@chromium.org Fix depth pitch calculations for compressed textures. 2019-09-18 tobine@google.com Vulkan: Pass ContextVk to various helpers Created with: gclient setdep -r src/third_party/angle@2f2ea8b465ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: None Change-Id: I372e121e22c171163618a82603f32060f6b85f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811833Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697846}
-
Richard Knoll authored
We now support devices in the intent picker and want to log UMA metrics for when a user selects a device from the list. TBR=dominickn@chromium.org Bug: 993309 Change-Id: I151017a02e0debc249ce39250247d1d7157d5a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787643 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697845}
-
Melissa Zhang authored
This CL adds unit_tests for ReplacePinnedItem, PinAppAtIndex, PinnedItemIndexByAppID and a browser_test for the shelf pin update when an Android app updates to PWA or vice-versa. BUG=986132 Change-Id: I9b709fc1f9865854873a3f800dab56ba778fd3db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810167 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
-
Erik Jensen authored
It seems invoking killall with a full path does not work if the executable has been replaced since it was launched (as happens during an upgrade). pkill allows matching against the command line used to invoke the process, rather than just the (truncated) process name or exact executable. Change-Id: I0b727aae6fbfc3b8bec72faa335ced4013d8d5d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812124Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#697843}
-
Eric Roman authored
This reverts commit 987d1fa4. Reason for revert: Broke internal targets depending on cronet, that treat proguard warnings as errors Original change's description: > Removing unnecessary dontwarns from cronet proguard configs > > Bug: 887942 > Change-Id: I120d6aa7681d7d86ce3ee9d2b8add7bd5dc0e0da > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804075 > Auto-Submit: Sam Maier <smaier@chromium.org> > Commit-Queue: Ryan Hamilton <rch@chromium.org> > Reviewed-by: Ryan Hamilton <rch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696870} TBR=rch@chromium.org,smaier@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 887942 Change-Id: I58746c8ad28176c6115b5b2ec205bd372f3a7513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812133Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#697842}
-
Findit authored
This reverts commit 52d70a63. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 697833 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzUyZDcwYTYzYmY1ODhkOTMzYmZkMDZhZDk3NTIxNzZjYzJjYzdhZTcM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/Linux%20ChromiumOS%20Full/143702 Sample Failed Step: compile Original change's description: > Remove *.mojom-shared.h from web_url_response.h > > This CL reduce the estimated pre-processed size of web_url_response.h > from 2.42MB to 0.91MB. > > Bug: 242216 > Change-Id: Ia95b04b7ef33e9a961a69522fb566c0649a4b7a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810119 > Reviewed-by: John Rummell <jrummell@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697833} Change-Id: I9d7870133551921392733f765bf7370da8a0de9a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 242216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812093 Cr-Commit-Position: refs/heads/master@{#697841}
-
Chris Lu authored
This reverts commit 9384d0a2. Reason for revert: <INSERT REASONING HERE> Original change's description: > [ios] Remove Unused FullScreen Feature Flags > > There is no need for ViewportAdjustmentExperiment since the only experiment > remaining is just the kSmoothScrollingDefault feature flag. > GetActiveViewportExperiment() can just be a function that returns > whether or not smooth scrolling is turned on. GetActiveViewportExperiment() > and ViewportAdjustmentExperiment are still needed for downstream compatibility, > and will be removed in a subsequent CL. > > Bug: 914042 > Change-Id: I57bcd13dafaafb3b3a05ec65f23dacf2936e81e9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799663 > Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> > Commit-Queue: Chris Lu <thegreenfrog@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697673} TBR=kkhorimoto@chromium.org,thegreenfrog@chromium.org Change-Id: Id1e0df1c06297d0249717102d5dc87e6343b6b63 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 914042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812091Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#697840}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d91e95a64c1b..58f19530fefa git log d91e95a64c1b..58f19530fefa --date=short --no-merges --format='%ad %ae %s' 2019-09-18 bhthompson@google.com chromeos_config: test veyron_mighty instead of veyron_jerry for N PFQ Created with: gclient setdep -r src/third_party/chromite@58f19530fefa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I99058c0fc1efca3dc8d99718db9ab8425bd73753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811981Reviewed-by:
-
Jinsuk Kim authored
A bug in the math getting BottomSheet full height ratio prevented the content from scrolling properly in when the sheet is of max height. This CL sets it right. Bug: 1005371 Change-Id: I4e59898c14ffaaa3fb9635e25769936d199cd907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809023Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#697838}
-
Joel Hockey authored
Check policy before starting an export or import. Bug: 1003944 Change-Id: I2f87ab7f1995fbb47ed4e4da13e0cff7c5852041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809123 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#697837}
-
Taylor Bergquist authored
This allows tabstrip animations to be disabled during tests and with various operating system settings. Bug: 8944 Change-Id: I56d7edb7fd3c05f98e2ada0b3e14efaef5cf9ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812131Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#697836}
-
Kenneth Russell authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/abaae12..f4ddbaf Bug: 691951, 891861 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64 Change-Id: Ice20033bf05e05376bcd33210bdae2fb2009e0c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810002 Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#697835}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/17a3a0bda946..e2a903e18b59 git log 17a3a0bda946..e2a903e18b59 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 csmartdalton@google.com Reland "Reorder msaa and mipmap resolves to happen all at once" 2019-09-18 bsalomon@google.com Handle F16Norm clamping in SkPaint->GrPaint conversion. 2019-09-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-18 mtklein@google.com move skvm debug tools back to core 2019-09-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-18 herb@google.com Reland "SkZip - synchronized indexing of several pointers" 2019-09-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@e2a903e18b59 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: I70e3704c9eedcda905998e98d267ab01b398ff72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811977Reviewed-by:
-
- 18 Sep, 2019 19 commits
-
-
Kent Tamura authored
This CL reduce the estimated pre-processed size of web_url_response.h from 2.42MB to 0.91MB. Bug: 242216 Change-Id: Ia95b04b7ef33e9a961a69522fb566c0649a4b7a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810119Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#697833}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/017dfff534a5..e9b6f28fdd71 git log 017dfff534a5..e9b6f28fdd71 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 jmadill@chromium.org GN: Build libVulkan to root_out_dir. Created with: gclient setdep -r src/third_party/swiftshader@e9b6f28fdd71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:1000668 Change-Id: I67c94b1425f1576fcb46b33ab7e47ff64e5e39e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811982Reviewed-by:
-
Sadrul Habib Chowdhury authored
We have not been using FrameMetrics or SkippedFrameTracker to report any metrics so far. So stop using them from cc. Follow up CLs will remove the code and associated tests. BUG=1005377 Change-Id: Idb779df9210b1b075bb2d76fd499ec43b3822898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811201Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#697831}
-
Robbie McElrath authored
This makes the class names used in android_webview constants so they can be used without android_webview having to depend on services. This also includes a test to validate that the class constants are correct. Test: ninja -C out/aw android_webview/test:webview_instrumentation_test_apk Bug: 934152 Change-Id: Ifa2ee5da43748c41d1e0ff2d8320ceb45e5a4e4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794262 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#697830}
-
Moe Ahmadi authored
Bug: 996516 Change-Id: Ib536df9fc6c9f645f6932cdc399259fc2be01de2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809966 Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#697829}
-
Stefan Zager authored
This already gets called from PerformPostLayoutTasks. That's a better place for it, because it means the call happens before we recurse into child frames and run layout in them, since the geometry update call invalidate layout in the child frames. Change-Id: I145f054b7516e95545d68402fae38519c6706557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800922Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#697828}
-
Toni Barzic authored
For new spec, the search results top margin is different between half and fullscreen state. This cl makes the app list ContentsView gradually update the top margin for search results app list page during dragging. This updates AppListView::GetAppListTransitionProgress to support getting progress for search results page (where baseline position is different from peeking), so it can be used to update the search box position while dragging in search results state. Also updates ContentsView::GetSearchBoxBounds to consider app list transition progress while in drag. Without this, ContentsView layout during app list drag does not correctly position search box, and consequently app list pages' content (it uses the search box padding associated with the current app list view state, instead of padding proportional to the current app list transition progress). Has small cleanup: * Passes progress and "should_restore_opacity" flag from ContentsView to children's UpdateYPositionAndOpacity(). * In AppListView, removes calls to ContentsView::SetActiveState that follow AppListView::SetState - these are not needed, as the contents view active state is set during AppListView::SetState (in SetChildViewsForStateTransition()). BUG=999273 Change-Id: I17db7701bd7c3dfa39824c95b0eea94ddc9269c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808389 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#697827}
-
Ahmed Fakhry authored
This CL fixes a bug in which a forced-visible window that is a descendant of a hidden window used to be considered occluded along with its descendants. This causes problems with virtual desks, since a browser window may be forced visible (while projecting), but the desk it resides on is switched, hence its container is hidden. In this case, the browser window, as well as its descendants should be considered visible from an occlusion stand point. BUG=998214 TEST=Added a new test Change-Id: I7031f16f4fbfd6e86228670f5d58ef1ac135eab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810104Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#697826}
-
Eric Stevenson authored
This CL was generated by //base/android/jni_generator/jni_refactorer.py. Bug: 929661 Change-Id: Ia3a1f45ce0255362c44b51dded3abd640ad1d966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809335Reviewed-by:
-
Aaron Gable authored
This reverts commit ec810bac. Reason for revert: causing eslint failures on Linux Tests: /b/s/w/ir/third_party/blink/renderer/devtools/front_end/dom_extension/DOMExtension.js 817:10 error 'onInvokeElement' is defined but never used no-unused-vars https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/81950 Original change's description: > Reland "Convert ui/ARIAUtils.js to an ES module" > > This is a reland of b3373919 > > Original change's description: > > Convert ui/ARIAUtils.js to an ES module > > > > ES modules allow files to explicitly import and export symbols [1]. > > This patch migrates ARIAUtils.js to an ES module, while maintaining > > backwards compatibility with existing usages of `window.UI.ARIAUtils`. > > > > The build system is updated to copy these modules verbatim, as it no > > longer require pre-processing to be loaded. The `module.json` no longer > > includes this file as a script, to make sure it is not double-bundled > > into `shell.js`. Instead, it is added to the new field `modules`, which > > contains all modules. By doing so, it becomes clear which files are > > converted to modules already and which require the legacy references > > to the global scope. > > > > This module and future modules will be imported from `root.js`, which is > > added to all existing HTML application files. > > > > Design Doc: https://docs.google.com/document/d/1h9dOy3nNPNfZ2AtZXzB-DwJqG4Oo37WWvKLCuzCcPzo/edit?usp=sharing > > > > [1]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import > > > > TBR=jochen@chromium.org > > > > Change-Id: Ie79c8f2fce3aff96fa28af0b575eae39bfe8e1a5 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748949 > > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > > Reviewed-by: Yang Guo <yangguo@chromium.org> > > Commit-Queue: Tim van der Lippe <tvanderlippe@google.com> > > Cr-Commit-Position: refs/heads/master@{#697238} > > Change-Id: I7544cbf4364d0b1a3c2f137a4d17a1afdb1d4aed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810534 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697626} TBR=yangguo@chromium.org,aerotwist@chromium.org,tvanderlippe@chromium.org Change-Id: I445fd35f135450cd9e8ed4c69bf913662f461ce6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811989Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#697824}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1070231232ce..8b95eac85df9 Created with: gclient setdep -r src-internal@8b95eac85df9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1004563,chromium:None Change-Id: Ibdf37cc28faf28323dbe43520702c7016938d080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811980Reviewed-by:
-
Tommy Li authored
This experiment is over. Bug: 956102 Change-Id: Ib571044bc10cced1d3853fd5b7623e072e40bedd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804034Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#697822}
-
Min Qin authored
DownloadManagerImpl creation will load all history downloads, and that will cost a lot of memory space. This CL allows DownloadManager creation to be deferred once UseInProgressDownloadManagerForDownloadService feature is enabled. New UMAs are added to capture the duration of the delay and the approximate memory usage of history downloads. BUG=1003904 Change-Id: I55d3079685b8169cb1090230829bfca2d4ac2605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804076 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
James Cook authored
By default, clicking on the People > Profile row will open the Chrome OS account manager in a new window. Change the row to use the "link out" arrow icon. Screenshot: http://screen/UBHW5acnie0 If ChromeOSAccountManager is disabled, it does nothing on click, like before. If SplitSettings is disabled, it opens the profile picture picker, like before. Bug: 1004446 Test: added to browser_tests Change-Id: Ia537bdc4fa841ec1995496b87c4650e0b1e761a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811862Reviewed-by:
-
Charlene Yan authored
Bug: 1003765 Change-Id: If6e35db7a420a77ee2f532e3545ab1c1626cf54e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807575 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#697819}
-
Giovanni Ortuño Urquidi authored
Enums were initialized before the interface's namespace which caused an error when trying to add the enum to the namespace. This CL fixes the issue by moving enum initialization after the interface's namespace is initialized. Bug: 1004822 Change-Id: I6e8328ebc7cccee744388bb32939dfe1bdfcbd42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810170Reviewed-by:
-
Rakib M. Hasan authored
TBR=crouleau@chromium.org Bug: chromium:999335 Change-Id: I2030d0d319ef1c091b29a725198c4f99cc4b66c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811997Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#697817}
-
Xianzhu Wang authored
After crrev.com/c/1799701, non-backdrop-filter mask layers become normal layers with DstIn blend mode, thus they can be tiled normally to avoid the problems caused by single tile before (e.g. too much memory usage for huge masks, no benefits of tile management). Bug: 1003414 Change-Id: Ic0c5d318bc3e657de861f6c7246c417399900209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805468Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697816}
-
Andrew Xu authored
ShelfWidget's bounds are offset to leave space for the navigation widget even when the login shelf shows. It leads to the wrong layout of the login shelf. This CL fixes such an issue. Bug: 994424 Change-Id: I2f422e2a53e7d40f76ebbbb53204e1619ccc95e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811642Reviewed-by:
-
