- 23 Jun, 2017 9 commits
-
-
liberato@chromium.org authored
During GPU process teardown, the GpuCommandBufferStub clears the current surface. ScopedMakeCurrent doesn't handle this case well. Since the process is going away, we just skip GL cleanup. Bug: 718117 Change-Id: I04dce5d60fbe9d3f6c060c161029d7ec724ecdb0 Reviewed-on: https://chromium-review.googlesource.com/544381Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Chris Watkins <watk@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#481739}
-
domlaskowski authored
On low-DPI displays, the pointer surface was being scaled up using bilinear filtering, resulting in a slightly blurry cursor. This CL sets the capture scale to the largest DSF instead of a constant. BUG=730843 TEST=minnie,caroline: Cursor is sharp on all displays. Review-Url: https://codereview.chromium.org/2933133002 Cr-Commit-Position: refs/heads/master@{#481738}
-
thakis authored
The __isnanf only exists on android 21+, so provide a fallback for the fallback for versions 16-20. BUG=735003 Review-Url: https://codereview.chromium.org/2945293002 Cr-Commit-Position: refs/heads/master@{#481737}
-
Matt Wolenetz authored
As part of PTS/DTS compliance, SourceBufferRange will need to understand its presentation interval and understand whether or not a subsequent keyframe is "continuous" with the end of that interval. This CL adds tracking of the range's frame with highest PTS, adds a method (for test usage only at the moment) to query whether or not a frame is continuous in PTS with the end of the range, relocates IsNextInDecodeSequence to private scope, and adds some better comments. It also adds some unit tests exercising the new behavior. This change does not switch over to using PTS for actually managing buffered ranges, but significantly prepares for that to happen in later CL(s). BUG=718641 Change-Id: Iabd19071032d4508abbb9c62a5f7c897d334670b Reviewed-on: https://chromium-review.googlesource.com/541586 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#481736}
-
Kevin Marshall authored
Fix thread safety issues with safe browsing DB. The Safe Browsing DB has some sequence consistency issues, which is caught by the stricter WeakPtr semantics detailed on CL 2908073007. * Delete SafeBrowsingDatabaseManager on IO thread. * Remove illegal dereferencing of IO-thread WeakPtr from DB thread in V4Database::VerifyChecksumOnTaskRunner * Remove non-threadsafe accesses of |io_thread_| resident members from the DB thread in V4LocalDatabaseManager. * Add IO-thread runloops to unit tests to handle database teardown. R=nparker@chromium.org CC=wez@chromium.org Bug: 729716 Change-Id: I1bc620d42aca2f1cc99e482b7776a628d783d390 Reviewed-on: https://chromium-review.googlesource.com/523983 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#481735}
-
Steven Holte authored
This reverts commit a4d28004. Reason for revert: Test is flaky failing due to UKM not getting enabled consistently. Original change's description: > Disable UKM in incognito mode. > > Add explicit checks to make sure UKM is disabled in incognito mode, > and add browser tests to check that behavior. > > Bug: 734091 > Change-Id: Ib772d5bd5231b9ce50b3468eef213fff2f9393e5 > Reviewed-on: https://chromium-review.googlesource.com/537774 > Commit-Queue: Steven Holte <holte@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Martin Šrámek <msramek@chromium.org> > Reviewed-by: Louis Romero <lpromero@chromium.org> > Cr-Commit-Position: refs/heads/master@{#481321} TBR=rkaplow@chromium.org,msramek@chromium.org,holte@chromium.org,lpromero@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 734091 Change-Id: I88d012477473581ce72280e859995f898ffb5087 Reviewed-on: https://chromium-review.googlesource.com/545175Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#481734}
-
erikchen authored
Revert of mac: Roll hermetic toolchain to Xcode 8.3.2. (patchset #2 id:20001 of https://codereview.chromium.org/2950933003/ ) Reason for revert: Reverting. Failed to update all perf Mac Builder slaves to 10.12. Original issue's description: > mac: Roll hermetic toolchain to Xcode 8.3.2. > > Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the > 10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK. > > To support machines running macOS versions < 10.12, but don't require building > targets, this CL also: > * Does not download the hermetic toolchain if the macOS version does not > support the toolchain version. > * Does not allow building targets with the default hermetic toolchain if the > macOS version does not support the toolchain version. > > BUG=624049 > > Review-Url: https://codereview.chromium.org/2950933003 > Cr-Original-Commit-Position: refs/heads/master@{#481225} > Committed: https://chromium.googlesource.com/chromium/src/+/2f19b143e444c920e643feda583e9ceb72d29c8e > Review-Url: https://codereview.chromium.org/2950933003 > Cr-Commit-Position: refs/heads/master@{#481692} > Committed: https://chromium.googlesource.com/chromium/src/+/350127923178be13e901e047ea5719890e7af365 TBR=dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624049 Review-Url: https://codereview.chromium.org/2957483002 Cr-Commit-Position: refs/heads/master@{#481733}
-
reillyg authored
This test moves all the tests from third_party/WebKit/LayoutTests/usb to third_party/WebKit/LayoutTests/external/wpt/webusb. The WebUSB Test API polyfill is included in a new resources/chromium directory and loaded automatically when the tests are run in a Chromium-based browser with the --enable-blink-features=MojoJS,MojoJSTest flag set. BUG=705734 Review-Url: https://codereview.chromium.org/2789723003 Cr-Commit-Position: refs/heads/master@{#481732}
-
lukasza authored
BUG=416660 Review-Url: https://codereview.chromium.org/2928033002 Cr-Commit-Position: refs/heads/master@{#481731}
-
- 22 Jun, 2017 31 commits
-
-
updowndota authored
Adjust the dialog size, padding and buttons for the voice interaction value prop and wait for conainer ready screen, in order to be consistent with other part of voice interaction OOBE flow. BUG=b/62843626 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2952943002 Cr-Commit-Position: refs/heads/master@{#481730}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6b73d036d392..326eb241976e $ git log 6b73d036d..326eb2419 --date=short --no-merges --format='%ad %ae %s' 2017-06-22 ehmaldonado Update the WebRTC rendering metric. 2017-06-22 dtu [pinpoint] ChartJSON support. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ic03bd2967a1a381522f368b27437957791d27f1f Reviewed-on: https://chromium-review.googlesource.com/544803 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#481729}
-
yusufo authored
We should avoid showing search suggest until we have gone through the necessary checks for search engine promo and either has shown it or know that we wont be showing it this session. BUG=729132 Review-Url: https://codereview.chromium.org/2957443002 Cr-Commit-Position: refs/heads/master@{#481728}
-
Theresa Wellington authored
- setPendingTabAdd(false) on other model when opening the new tab UI. - Make sure correct tab stack shows when opening the new tab UI. - Update IncognitoTabModel #index() to account for pending tab add and to notify observers (inadvertently removed in a rebase in previous CL). - Select the previous tab when closing the NTP UI if necessary. - Update/add tests to BottomSheetNewTabControllerTest. BUG=734529,734975,726612,695973 Change-Id: Ie96756b10c9f6752ace1eedec09b013dd3060811 Reviewed-on: https://chromium-review.googlesource.com/541611Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#481727}
-
dgozman authored
BUG=734762 Review-Url: https://codereview.chromium.org/2953663003 Cr-Commit-Position: refs/heads/master@{#481726}
-
Marijn Kruisselbrink authored
Rather than erasing the LevelDBWrapperImpl as soon as the last mojo connection to it is closed, keep around unused wrappers, and only delete them when new connections are opened, if too many wrappers are around. This more closely resembles the behavior of the old localstorage implementation, and should have a performance improvement in certain situations. It does come with a slight memory penalty, but not worse than the old implementation. Bug: 730475 Change-Id: I258dc4218f88167a19fc103cd581bf3e9567f901 Reviewed-on: https://chromium-review.googlesource.com/541815 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#481725}
-
Scott Graham authored
Links but 25/80 tests crash. Bug: 734791 Change-Id: I0e53a60c33ec016bb051b661eaa398d246b6d5eb Reviewed-on: https://chromium-review.googlesource.com/540288Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#481724}
-
Renjie Liu authored
I'm exposing a RecordLanguageDetection API in translate_client so different platforms can handle record language detection uniformly. Bug: 722679 Change-Id: I6df293b7d7d6ef81ffd5f46cb0885a28bf4bef19 Reviewed-on: https://chromium-review.googlesource.com/523882Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Renjie Liu <renjieliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#481723}
-
Darren Shen authored
This patch removes direct references to: - StyleRareNonInheritedData - StyleWillChangeData - StyleGridItemData - StyleFlexibleBoxData and replaces them with internal accessors. Bug: 710938 Change-Id: I757411ece02c28a3e3fb8bad0f29537594db4ebb Reviewed-on: https://chromium-review.googlesource.com/544635Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#481722}
-
Matt Falkenhagen authored
Help debugging for PlzNavigate regression. We want to see if SW-controlled loads make an outsized contribution to the PlzNavigate FowardBack regression. See bug, comment 64. Bug: 705318 Change-Id: I28136ee2a1e220a6d9584b168fe13308434cc55f Reviewed-on: https://chromium-review.googlesource.com/541257 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#481721}
-
warx authored
Changes: (1) app list item view, which is used for all apps grid view, has the same tile layout (icon, title, and their paddings) requirement as start page recommended apps tile. (2) fix recommended apps tile title width issue: it has 80px width requirement, we just need to set left and right 8px insets for it. R=xiyuan@chromium.org CC=newcomer@chromium.org, weidongg@chromium.org BUG=735702 TEST=tested with and without --enable-features=EnableFullscreenAppList flag Review-Url: https://codereview.chromium.org/2945343003 Cr-Commit-Position: refs/heads/master@{#481720}
-
avi authored
BUG=689520 Review-Url: https://codereview.chromium.org/2953633002 Cr-Commit-Position: refs/heads/master@{#481719}
-
dgozman authored
BUG=734762 Review-Url: https://codereview.chromium.org/2952023003 Cr-Commit-Position: refs/heads/master@{#481718}
-
Darren Shen authored
Currently, column-rule related properties are being stored as a single BorderValue called ColumnRule. However, it is possible to split ColumnRule into its constituent fields and generate each of them individually. There should be no performance impact from this patch. Diff: https://gist.github.com/955fa418e240be79c0521d7d53e26ca7/revisions Bug: 628043 Change-Id: I31db806f2fc427eb996ba78ef56dce17e5bc83d5 Reviewed-on: https://chromium-review.googlesource.com/544479Reviewed-by:
-
varkha authored
Store kPreferredSize property in an aura::Window when Chrome browser frame is updated upon BrowserView::Layout(). Retrieve it in CustomFrameViewAsh::GetMinimumSize() to ensure that in Mus the browser window frame honors window size constraints. This only affects chrome browser frame when running with --mash. BUG=728455 TEST=BrowserNonClientFrameViewAshTest.FrameMinSizeIsUpdated CustomFrameViewAshTest.HonorsMinimumSizeProperty Review-Url: https://codereview.chromium.org/2914793005 Cr-Commit-Position: refs/heads/master@{#481716} -
Luna Lu authored
Added two entries to separately count: http header and iframe allow attribute. Also fix bug for including type attribute in <enum> in enums.xml Change-Id: I065ba516445c065c1d11cafc55591299f5c01d64 Reviewed-on: https://chromium-review.googlesource.com/535995 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#481715}
-
Robert Hogan authored
"For the ellipsis value implementations must hide characters and atomic inline-level elements at the end edge of the line as necessary to fit the ellipsis, and place the ellipsis immediately adjacent to then end edge of the remaining inline content." - https://drafts.csswg.org/css-ui/#text-overflow Bug: 534798 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I39e39e17bcb8fbafd862822f9633faa8adb33d88 Reviewed-on: https://chromium-review.googlesource.com/539460 Commit-Queue: Robert Hogan <robhogan@gmail.com> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#481714}
-
kristipark authored
Bug: 729772 Change-Id: I34b16707b790f65faba01bdcc44bbd98c911b93b Reviewed-on: https://chromium-review.googlesource.com/541981 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#481713}
-
Alok Priyadarshi authored
This reverts commit c461e58e. Reason for revert: JsToCpp.mojom.js should now be available on android devices when running webkit_unit_tests: https://chromium-review.googlesource.com/c/540085/ Original change's description: > Revert "Reland of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2939663002/ )" > > Reason for revert: > WebKit Android (Nexus4) are still broken with four failing tests: > JsToCppTest.BackPointer > JsToCppTest.BitFlip > JsToCppTest.Ping > JsToCppTest.Echo > > TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,jwd@chromium.org,alokp@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=699569 > > Change-Id: I925840dbe50bd21e6c87b03f23d6b4007d27df63 > Reviewed-on: https://chromium-review.googlesource.com/538520 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#480282} TBR=dcheng@chromium.org,jwd@chromium.org,jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,agrieve@chromium.org,alokp@chromium.org Bug: 699569 Change-Id: I59bcce1f0a4f650eedaea7cce999b650041e7506 Reviewed-on: https://chromium-review.googlesource.com/540664 Commit-Queue: Alok Priyadarshi <alokp@chromium.org> Reviewed-by:
Alok Priyadarshi <alokp@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#481712}
-
eroman authored
These existed to support ProxyConfigServiceLinux, which used to require a SingleThreadTaskRunner for FILE (but was recently removed). TBR=sky@chromium.org,mkwst@chromium.org BUG=689520 Review-Url: https://codereview.chromium.org/2946343003 Cr-Commit-Position: refs/heads/master@{#481711}
-
Tom Anderson authored
The eu-strip that ships with Ubuntu Trusty segfaults when stripping a chrome binary that statically links libc++. The issue was fixed upstream at some point because the crash does not occur on Ubuntu Xenial. This CL bundles a patched eu-strip for x86_64 (and removes the x86 one that used to be in Google Cloud Storage). The issue was due to a double-free in libelf.so. The patched version simply removes the offending call to free and statically links libelf into eu-strip. This probably results in a memory leak, but this is ok for now since the utility is a very short-lived process. BUG=593874 R=dpranke@chromium.org,thestig@chromium.org TBR=thakis@chromium.org Change-Id: I2085c4f6278cffbaeae972545280ebb437a8bdc0 Reviewed-on: https://chromium-review.googlesource.com/544798 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Shakti Sahu authored
Bug: Change-Id: Icc4c9740a70c95d8137692638438b1506eda4979 Reviewed-on: https://chromium-review.googlesource.com/542936 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#481709}
-
Nick Ward authored
This code is an unused duplicate of third_party/catapult/common/py_trace_event. The only code that used this copy of the py_trace_event library was removed here: https://codereview.chromium.org/1290113003 Bug: Change-Id: Iac39091c22f38cea92724b8adc77e03be2e0c1ea Reviewed-on: https://chromium-review.googlesource.com/543566Reviewed-by:
David Tu <dtu@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Michael Case <mikecase@chromium.org> Commit-Queue: Nick Ward <npward@google.com> Cr-Commit-Position: refs/heads/master@{#481708}
-
Charles Harrison authored
Bug: 689992 Change-Id: Idcc8123a17c44ff3bac30237a60d70532254d7f7 Reviewed-on: https://chromium-review.googlesource.com/541642Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#481707}
-
Stephen Martinis authored
The bots are imbalanced, and a referenc build is expiring. This CL shuffles around some benchmarks. Specifically, the following benchmarks will probably shift: * v8.runtime_stats.top_25 * page_cycler_v2.basic_oopif TBR=nednguyen Bug: 736089 Change-Id: Icf50165a37a437f59492e61d5ee0aec0ab892542 Reviewed-on: https://chromium-review.googlesource.com/545157Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
-
Marijn Kruisselbrink authored
No implementation for BytesProvider so no data is actually being transported, but this does contain the bulk of the logic of converting BlobDataItems to mojo DataElement, combining byte elements, and optionally embedding data in the byte elements. Bug: 611935 Change-Id: Iccd789c03130c03549d1a00866af05d7c958434b Reviewed-on: https://chromium-review.googlesource.com/517254 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
It seems there was an intention of merging lexer/parser for PPAPI IDL and WebIDL but no one has been working on it recently. PPAPI has its own lexer/parser in ppapi/generators. Blink is the only user of tools/idl_parser in the code base with some custom extensions (See third_party/WebKit/Source/bindings/scripts/blink_idl_parser.py). The grammar of WebIDL has been actively changing and maintaining both idl_parser.py and blink_idl_parser.py is troublesome. Let's remove PPAPI support from tools/idl_parser so that we can easily keep the parser up-to-date. BUG=617899 Change-Id: Ia4b8c7918245cce57c7a14326e5fc5c48ba42127 Reviewed-on: https://chromium-review.googlesource.com/544401Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#481704}
-
warx authored
BUG=none TBR=xdai@chromium.org TEST=chrome doesn't crash Review-Url: https://codereview.chromium.org/2954563002 Cr-Commit-Position: refs/heads/master@{#481703}
-
dgozman authored
BUG=734762 Review-Url: https://codereview.chromium.org/2950193003 Cr-Commit-Position: refs/heads/master@{#481702}
-
Andrew Moylan authored
This is just some typos and other small fixups I noticed while reading these docs. Only substantial thing is probably this rename which I think is appropriate but please confirm: s/InterfaceRegistry/BinderRegistry Change-Id: I2c9f712b87a45d9d1f66f5e8cc053fa4e9751e2e Reviewed-on: https://chromium-review.googlesource.com/544639Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#481701}
-
Danyao Wang authored
NavigationManagerImpl::GetPreviousItemIndex is a wrapper around |CRWSessionController previousItemIndex|. This can actually be -1, so the return type should be int not size_t. This mistake was introduced in https://codereview.chromium.org/2944093002. Added a unit test to verify this edge case. Moved the method to public section to allow access in test. Bug: 734150 Change-Id: I3f70635ccb62ae205fcef6dc2d9b8813ed872a99 Reviewed-on: https://chromium-review.googlesource.com/544626 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
-
